Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

ABataev updated this revision to Diff 45149. ABataev added a comment. Simplified handling of private copies in C/C++. Now all outpup parameters of UDR must be passed by pointer, not by reference (better compatibility with C) http://reviews.llvm.org/D11182 Files: include/clang/AST/DeclBase.h

Re: [PATCH] D16280: [OpenMP] Detect implicit map type to report unspecified map type for target enter/exit data directives.

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:8587 @@ -8583,4 +8586,3 @@ Diag(StartLoc, diag::err_omp_invalid_map_type_for_directive) << - // TODO: Need to determine if map type is implicitly determined - (0) << + static_cast(

Re: [PATCH] D15989: [OpenMP] Parsing + sema for "target enter data" and "target exit data" directives.

ABataev added inline comments. Comment at: include/clang/Sema/Sema.h:7767-7768 @@ -7766,2 +7766,4 @@ bool StrictlyPositive = true); + /// \brief Check for existence of a map clause + bool HasMapClause(ArrayRef Clauses);

Re: [PATCH] D16259: Add clang-tidy readability-redundant-return check

LegalizeAdulthood added a comment. I'm starting with stuff that I see in code bases where I work; chances are that other people see them too. In the future, I'll look in the bug database for stuff that is similar or identical to what I'm doing. http://reviews.llvm.org/D16259 __

Re: [PATCH] D16259: Add clang-tidy readability-redundant-return check

Eugene.Zelenko added a comment. In http://reviews.llvm.org/D16259#328834, @LegalizeAdulthood wrote: > I didn't know about the bug reports. I created this check because I have > encountered such redundant control flow in real code bases. Bug report was reflection on my code base, but I also sp

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste updated this revision to Diff 45129. Alexander_Droste added a comment. - removed files not being part of this patch anymore http://reviews.llvm.org/D12761 Files: tools/clang/lib/StaticAnalyzer/Checkers/CMakeLists.txt tools/clang/lib/StaticAnalyzer/Checkers/Checkers.td too

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste updated this revision to Diff 45126. Alexander_Droste added a comment. - removed AST related functionality from patch, as AST-based checks will be integrated into clang tidy - fix `checkMissingWaits()` - moved `getVariableName()` from patch (currently under review here: http://r

[PATCH] D16280: [OpenMP] Detect implicit map type to report unspecified map type for target enter/exit data directives.

arpith-jacob created this revision. arpith-jacob added reviewers: kkwli0, ABataev, sfantao, hfinkel, carlo.bertolli. arpith-jacob added subscribers: cfe-commits, caomhin, fraggamuffin. Support for the following OpenMP 4.5 restriction on 'target enter data' and 'target exit data': - A map-type mus

[PATCH] D16279: [OpenMP] Parsing + sema for "target exit data" directive.

arpith-jacob created this revision. arpith-jacob added reviewers: kkwli0, sfantao, hfinkel, carlo.bertolli, ABataev. arpith-jacob added subscribers: cfe-commits, caomhin, fraggamuffin. Created a distinct patch for the 'target exit data' directive. http://reviews.llvm.org/D16279 Files: include/

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste added inline comments. Comment at: tools/clang/lib/StaticAnalyzer/Checkers/MPI-Checker/MPICheckerPathSensitive.cpp:107 @@ +106,3 @@ + State = State->remove(Req.first); +} + } zaks.anna wrote: > Alexander_Droste wrote: > > I need `addTra

Re: [PATCH] D16044: getVariableName() for MemRegion

Alexander_Droste marked an inline comment as done. Comment at: tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:653 @@ +652,3 @@ +llvm::SmallString<2> intValAsString; +IndexInArray.toString(intValAsString); +std::string idx{intValAsString.begin(), intValAsString.end()

Re: [PATCH] D15305: [CUDA] Do not allow dynamic initialization of global device side variables.

jlebar added a comment. tra asked me to check for coverage. Looks pretty good in that respect. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6419 @@ +6418,3 @@ +"dynamic initialization is not supported for " +"__device__, __constant__ and __shared__ variables."

Re: [PATCH] D16259: Add clang-tidy readability-redundant-return check

LegalizeAdulthood added a comment. I didn't know about the bug reports. I created this check because I have encountered such redundant control flow in real code bases. This would close 21984 , but not 22416

Re: [PATCH] D16259: Add clang-tidy readability-redundant-return check

LegalizeAdulthood updated this revision to Diff 45110. LegalizeAdulthood added a comment. Extend this check to handle redundant `continue` statements in loop bodies. With this extension, I'm wondering if the check should be renamed redundant-control-flow instead of redundant-return. Comments?