Re: [PATCH] D14980: PR18513: make gcc compatible layout for bit-fields with explicit aligned attribute

DmitryPolukhin added a comment. John and Richard, I think this patch fixes important ABI compatibility issue with GCC and if there are no more comments, I think it makes sense to commit it. Could you please approve this CL? Thanks, Dmitry http://reviews.llvm.org/D14980 ___

[PATCH] D15486: [RFC] Emit note pointing to a discarded qualifier [-Wincompatible-pointer-types-discards-qualifiers]

adek05 created this revision. adek05 added a reviewer: jroelofs. adek05 added a subscriber: cfe-commits. Finding original declaration which is suffering from discarding a qualifier is somewhat tricky and it doesn't always make sense in all of the contexts that DiagnoseAssignmentResult is called.

Re: [PATCH] D14877: Fix ICE on lowering of constexpr vector splats

george.burgess.iv updated this revision to Diff 42686. george.burgess.iv added a comment. TIL you can use OpenCL vectors in C++ files. Fixed a bug related to not knowing this + added tests for the constexpr cases. Also, is there a better way to do the `bool` -> `APFloat` conversion in ExprConst

Re: [PATCH] D14877: Fix ICE on lowering of constexpr vector splats

george.burgess.iv added inline comments. Comment at: lib/Sema/SemaExpr.cpp:5576 @@ +5575,3 @@ +return ExprError(); + return ImpCastExprToType(CastExprRes.get(), DestElemTy, CK); +} rsmith wrote: > Looking at `ScalarExprEmitter::VisitCastExpr`, it seems like w

Re: [PATCH] D14877: Fix ICE on lowering of constexpr vector splats

george.burgess.iv updated this revision to Diff 42683. george.burgess.iv marked an inline comment as done. george.burgess.iv added a comment. > Changes to ExprConstant and CGExprConstant appear to be pure cleanups; please > check those in as a separate change r255314, thanks. > When this is do

[PATCH] D15485: [clang-format] BraceWrapping.BeforeElse is incorrect for BS_Linux

ksuther created this revision. ksuther added reviewers: cfe-commits, djasper. Herald added a subscriber: klimek. The BraceWrapping of the Linux style is incorrect. This appeared in r248802 when the custom BraceWrapping options were added. This is what r248801 looked like: clang-format -style="{

Re: r255447 - Revert r255445: adding a new test case

On Sat, Dec 12, 2015 at 8:45 PM, Xinliang David Li via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: davidxl > Date: Sat Dec 12 22:45:49 2015 > New Revision: 255447 > > URL: http://llvm.org/viewvc/llvm-project?rev=255447&view=rev > Log: > Revert r255445: adding a new test case > > Rem

Re: [patch] Let -Wdelete-non-virtual-dtor mention that making the class final is a good fix too

(attachment missing) Cursory review based on description: Sounds reasonable to me. Would want to check the C++98 behavior to ensure it is actually relevant/correct to imply the possibility of 'final' being used to fix the issue. On Sun, Dec 13, 2015 at 1:37 AM, Nico Weber via cfe-commits < cfe-co

Re: r255281 - Do not generate DW_TAG_imported_module for anonymous namespaces (even nested) for all the platforms except PS4.

On Thu, Dec 10, 2015 at 10:52 AM, Ekaterina Romanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: kromanova > Date: Thu Dec 10 12:52:50 2015 > New Revision: 255281 > > URL: http://llvm.org/viewvc/llvm-project?rev=255281&view=rev > Log: > Do not generate DW_TAG_imported_module for

[clang-tools-extra] r255475 - clang-tools-extra/test/clang-tidy/cppcoreguidelines-pro-bounds-constant-array-index*.cpp: Don't assume size_t were unsigned int.

Author: chapuni Date: Sun Dec 13 16:49:37 2015 New Revision: 255475 URL: http://llvm.org/viewvc/llvm-project?rev=255475&view=rev Log: clang-tools-extra/test/clang-tidy/cppcoreguidelines-pro-bounds-constant-array-index*.cpp: Don't assume size_t were unsigned int. Modified: clang-tools-extra/

Re: [PATCH] D15030: [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index

This revision was automatically updated to reflect the committed changes. Closed by commit rL255470: [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index (authored by mgehre). Changed prior to commit: http://reviews.llvm.org/D15030?vs=42338&id=42671#toc Repository: rL LLV

[clang-tools-extra] r255470 - [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index

Author: mgehre Date: Sun Dec 13 16:08:26 2015 New Revision: 255470 URL: http://llvm.org/viewvc/llvm-project?rev=255470&view=rev Log: [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index Summary: This is http://reviews.llvm.org/D13746 but instead of including , a stub is provid

[PATCH]: Allow the use of i386/darwin with ELF

Hello, I'm the developer of Darling, a translation layer for running OS X binaries on Linux. I'm facing many difficulties due to the following differences in i386 ABI between Darwin and Linux: * size_t on Darwin/i386 is 'unsigned long', but Linux/i386 uses 'unsigned int' (=> different mangled na

Re: [PATCH] D14329: Show inclusions from a preamble in clang_getInclusions.

skalinichev added a subscriber: skalinichev. skalinichev added a comment. I've seen this bug too. Generally this patch looks good to me. Could you also add a test for includes half-way through a file case? Comment at: tools/c-index-test/c-index-test.c:1567 @@ -1564,1 +1566,3 @@

Re: [PATCH] D13001: [libclang] Handle AutoType in clang_getTypeDeclaration

skalinichev updated the summary for this revision. skalinichev updated this revision to Diff 42654. skalinichev added a comment. Added tests http://reviews.llvm.org/D13001 Files: test/Index/print-type-declaration.cpp tools/c-index-test/c-index-test.c tools/libclang/CXType.cpp Index: tool

Re: [PATCH] D9600: Add scan-build python implementation

kimgr added a subscriber: kimgr. kimgr added a comment. > > Comment at: tools/scan-build-py/bin/analyze-cc:14 > @@ +13,2 @@ > +from libscanbuild.analyze import wrapper > +sys.exit(wrapper(False)) > > > > It is hard to figure out/search which functio