Per discussion at
http://lists.llvm.org/pipermail/cfe-dev/2015-December/046321.html allow
tools to work in the absence of a compilation database, but warn the user
about the absence.
Index: lib/Tooling/CommonOptionsParser.cpp
===
--- l
majnemer updated this revision to Diff 41716.
majnemer added a comment.
- Updated for the latest EH changes
http://reviews.llvm.org/D15140
Files:
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGCleanup.cpp
lib/CodeGen/CGCleanup.h
lib/CodeGen/CGException.cpp
lib/CodeGen/CodeGenFunction.h
lib/Co
ABataev created this revision.
ABataev added reviewers: rnk, rjmccall.
ABataev added a subscriber: cfe-commits.
All problems described in http://llvm.org/PR25636 are implemented except for
return value of the 'put' property. This patch fixes this problem with the
indexed properties
http://revie
bruno created this revision.
bruno added reviewers: doug.gregor, akyrtzi.
bruno added subscribers: cfe-commits, dexonsmith.
Consider the following ObjC++ snippet:
@protocol PA;
@protocol PB;
@class NSArray;
typedef int some_t;
id FA(NSArray> *h, some_t group);
This would hit an asser
Author: nico
Date: Wed Dec 2 20:25:26 2015
New Revision: 254579
URL: http://llvm.org/viewvc/llvm-project?rev=254579&view=rev
Log:
Fix a comment typo from r251874.
Modified:
cfe/trunk/lib/Sema/SemaObjCProperty.cpp
Modified: cfe/trunk/lib/Sema/SemaObjCProperty.cpp
URL:
http://llvm.org/viewvc
On Thu, Dec 03, 2015 at 12:15:25AM +, Dimitry Andric wrote:
> This patch updates the Clang driver to use libstdc++ from GCC 5.2
What about the abi tag mess? Or do you actually mean GCC 5.0?
Joerg
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
Author: spatel
Date: Wed Dec 2 19:51:39 2015
New Revision: 254576
URL: http://llvm.org/viewvc/llvm-project?rev=254576&view=rev
Log:
generalize CHECK lines to make buildbot happy
Modified:
cfe/trunk/test/CodeGen/fp-contract-pragma.cpp
Modified: cfe/trunk/test/CodeGen/fp-contract-pragma.cpp
U
mjacob added inline comments.
Comment at: lib/Sema/SemaCast.cpp:1081-1083
@@ -1080,3 +1080,5 @@
}
- Kind = CK_BitCast;
+ unsigned SrcAS = SrcPointee.getAddressSpace();
+ unsigned DestAS = DestPointee.getAddressSpace();
+ Kind = SrcAS
Author: rsmith
Date: Wed Dec 2 19:36:22 2015
New Revision: 254574
URL: http://llvm.org/viewvc/llvm-project?rev=254574&view=rev
Log:
PR17381: Treat undefined behavior during expression evaluation as an unmodeled
side-effect, so that we don't allow speculative evaluation of such expressions
during
rsmith added inline comments.
Comment at: lib/Sema/SemaCast.cpp:1081-1083
@@ -1080,3 +1080,5 @@
}
- Kind = CK_BitCast;
+ unsigned SrcAS = SrcPointee.getAddressSpace();
+ unsigned DestAS = DestPointee.getAddressSpace();
+ Kind = SrcAS
Author: spatel
Date: Wed Dec 2 19:25:12 2015
New Revision: 254573
URL: http://llvm.org/viewvc/llvm-project?rev=254573&view=rev
Log:
change an assert when generating fmuladd to an ordinary 'if' check (PR25719)
We don't want to generate fmuladd if there's a use of the fmul expression, but
this sh
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254573: change an assert when generating fmuladd to an
ordinary 'if' check (PR25719) (authored by spatel).
Changed prior to commit:
http://reviews.llvm.org/D15165?vs=41699&id=41702#toc
Repository:
rL
rsmith added a subscriber: rsmith.
Comment at: lib/CodeGen/CGDecl.cpp:933
@@ +932,3 @@
+ ASTContext &Ctx = getContext();
+ auto &OffsetsInfo = InvariantOffsets.FindAndConstruct(Record).second;
+ OffsetsType &Args = OffsetsInfo.Offsets;
Instead of tracking a sep
scanon added a comment.
LGTM.
http://reviews.llvm.org/D15165
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
scanon abandoned this revision.
scanon added a comment.
Abandoned for http://reviews.llvm.org/D15165.
http://reviews.llvm.org/D14891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spatel updated this revision to Diff 41699.
spatel added a comment.
Patch updated with suggestions from http://reviews.llvm.org/D14891:
1. Changed 'else if' to plain 'if' for RHS check.
2. Used 'auto*' for dyn_casted vars.
3. Replaced 'getNUses() == 0' with 'use_empty()'.
http://reviews.llvm.or
spatel added a comment.
In http://reviews.llvm.org/D15165#300999, @scanon wrote:
> This is mostly http://reviews.llvm.org/D14891 with a test case added, but
> http://reviews.llvm.org/D14891 also fixed a second very minor issue: that the
> "else if" should just be "if". Also, majnemer made a fe
rsmith added a subscriber: rsmith.
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
This looks fine (subject to the observation in http://reviews.llvm.org/D13603
that `MarkWriteOnceWrittenRAII` can just be a f
rsmith added a subscriber: rsmith.
rsmith added a comment.
Your http://reviews.llvm.org/D14419 removes a lot of the code added here. Can
you update this patch to not add that code? I'd prefer not to review the
portion of this code that you're about to delete.
Comment at: lib/C
dim created this revision.
dim added reviewers: joerg, rsmith.
dim added a subscriber: cfe-commits.
[ Copied from https://llvm.org/bugs/show_bug.cgi?id=25597 ]
Clang support for DragonFly BSD is lagging a bit, resulting in poor
support for c++.
DragonFlyBSD is unique in that it has two base comp
scanon added a comment.
This is mostly http://reviews.llvm.org/D14891 with a test case added, but
http://reviews.llvm.org/D14891 also fixed a second very minor issue: that the
"else if" should just be "if". Also, majnemer made a few style suggestions
there that it would be nice to adopt. Eith
spatel created this revision.
spatel added reviewers: lhames, scanon, hfinkel, klimek.
spatel added a subscriber: cfe-commits.
We don't want to generate fmuladd if there's a use of the fmul expression, but
this shouldn't be an assert.
The test case is derived from the commit message for r253337:
davidxl added a comment.
Should also add a test case as a followup. Example:
./projects/compiler-rt/test/profile/instrprof-basic.c
David
Repository:
rL LLVM
http://reviews.llvm.org/D15163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Serge Pavlov writes:
> sepavloff created this revision.
> sepavloff added a reviewer: bogner.
> sepavloff added subscribers: cfe-commits, silvas.
>
> Constructors and destructors may be represented by several functions
> in IR. Only the base structors correspond to source code, others
> are small
Author: spatel
Date: Wed Dec 2 17:06:17 2015
New Revision: 254561
URL: http://llvm.org/viewvc/llvm-project?rev=254561&view=rev
Log:
fix typos; NFC
Modified:
cfe/trunk/test/CodeGen/fp-contract-pragma.cpp
Modified: cfe/trunk/test/CodeGen/fp-contract-pragma.cpp
URL:
http://llvm.org/viewvc/llv
sfantao added a comment.
Any more comments on this patch?
Thanks!
Samuel
http://reviews.llvm.org/D7606
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao updated this revision to Diff 41676.
sfantao added a comment.
- Rebase.
http://reviews.llvm.org/D7606
Files:
lib/Sema/Sema.cpp
lib/Sema/SemaCast.cpp
test/CodeGen/address-space-explicit-cast.c
Index: test/CodeGen/address-space-explicit-cast.c
==
(tangential: Should we just have a utility function llvm::adl_swap that we
could use everywhere rather than having to write two lines for every
caller? (& have a variant of this check that knows to suggest that in
LLVM?))
On Wed, Dec 2, 2015 at 1:35 PM, Marshall Clow via cfe-commits <
cfe-commits@
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254554: Add the `pass_object_size` attribute to clang.
(authored by gbiv).
Changed prior to commit:
http://reviews.llvm.org/D13263?vs=41651&id=41675#toc
Repository:
rL LLVM
http://reviews.llvm.org/D
george.burgess.iv marked 2 inline comments as done.
Comment at: lib/AST/ExprConstant.cpp:6507-6509
@@ -6506,5 +6544,1 @@
-// handle all cases where the expression has side-effects.
-// Likewise, if Type is 3, we must handle this because CodeGen cannot give
a
-// conse
Author: gbiv
Date: Wed Dec 2 15:58:08 2015
New Revision: 254554
URL: http://llvm.org/viewvc/llvm-project?rev=254554&view=rev
Log:
Add the `pass_object_size` attribute to clang.
`pass_object_size` is our way of enabling `__builtin_object_size` to
produce high quality results without requiring inl
sfantao added a comment.
Are there any more comments for this patch?
Thanks!
Samuel
http://reviews.llvm.org/D12614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
beanz updated this revision to Diff 41668.
beanz added a comment.
My patch dropped one of the gating checks. This fixes that. It only needs to
apply to Darwin when installing to /usr.
http://reviews.llvm.org/D15161
Files:
CMakeLists.txt
Index: CMakeLists.txt
mclow.lists marked 5 inline comments as done.
mclow.lists added a comment.
http://reviews.llvm.org/D15121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists updated this revision to Diff 41667.
mclow.lists added a comment.
Richard clued me in to the cool method `isStdNamespace()`, which made the code
simpler.
http://reviews.llvm.org/D15121
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/St
beanz created this revision.
beanz added reviewers: mclow.lists, EricWF.
beanz added a subscriber: cfe-commits.
The current implementation doesn't work as intended because of CMake's caching
behavior. The CMake set command doesn't globally override cached options.
This change removes LIBCXX_OVER
rafael abandoned this revision.
rafael added a comment.
In the end we changed only SetVector.
http://reviews.llvm.org/D14691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added a comment.
lgtm
http://reviews.llvm.org/D14639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists updated this revision to Diff 41662.
mclow.lists added a comment.
More tests; incorporated some of the suggestions for making sure we don't step
on other people's namespaces named `std`.
http://reviews.llvm.org/D15121
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTi
srhines marked 3 inline comments as done.
srhines added a comment.
I uploaded a fixed version to use isPowerOf2_32() and more comments. Thanks for
the reviews.
http://reviews.llvm.org/D14639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
chandlerc added inline comments.
Comment at: include/clang/Lex/HeaderSearchOptions.h:145
@@ -143,2 +144,3 @@
/// of computing the module hash.
- llvm::SetVector ModulesIgnoreMacros;
+ llvm::SetVector, std::set>
+ ModulesIgnoreMacros;
There is clearly a u
srhines updated this revision to Diff 41654.
srhines added a comment.
Switched to isPowerOf2_32() and added more details about Android's ABI.
http://reviews.llvm.org/D14639
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGen/arm-abi-vector.c
Index: test/CodeGen/arm-abi-vector.c
george.burgess.iv added a comment.
Oops -- I didn't see Richard's comments before I pressed "save". Will address
that feedback too. Sorry! :)
http://reviews.llvm.org/D13263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
On Wed, Dec 2, 2015 at 1:00 PM, David Blaikie wrote:
> Oh, this type has a user-defined dtor, so it's deprecated to use the
> implicit copy ctor/assignment operator anyway - and I have the -Wdeprecated
> flag on in my build (& keep the LLVM build clean of any warnings it shows).
>
> At some point
sepavloff created this revision.
sepavloff added a reviewer: bogner.
sepavloff added subscribers: cfe-commits, silvas.
Constructors and destructors may be represented by several functions
in IR. Only the base structors correspond to source code, others
are small pieces of code and eventually call
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.
Ouch, that 2012 vector passing ABI break is a bummer. :(
Comment at: lib/CodeGen/TargetInfo.cpp:5236
@@ +5235,3 @@
+ if (const VectorType *VT = Ty->getAs
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254535: Fix the clang driver when "-nostdlib" is present
(authored by sgundapa).
Changed prior to commit:
http://reviews.llvm.org/D15130?vs=41582&id=41650#toc
Repository:
rL LLVM
http://reviews.llvm
Author: sgundapa
Date: Wed Dec 2 13:12:41 2015
New Revision: 254535
URL: http://llvm.org/viewvc/llvm-project?rev=254535&view=rev
Log:
Fix the clang driver when "-nostdlib" is present
This patch is a fix to r252901 which changed the behavior of
clang driver. In the presence of "-nostdlib" none o
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM! Thank you!
http://reviews.llvm.org/D14872
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
rjmccall added a comment.
LGTM, thanks!
http://reviews.llvm.org/D14872
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DmitryPolukhin updated this revision to Diff 41648.
DmitryPolukhin marked 2 inline comments as done.
DmitryPolukhin added a comment.
Fixed warning and comment.
http://reviews.llvm.org/D14872
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclAttr.cpp
test/Sema/struct-packe
Author: probinson
Date: Wed Dec 2 12:41:52 2015
New Revision: 254528
URL: http://llvm.org/viewvc/llvm-project?rev=254528&view=rev
Log:
Move _mm256_cvtps_ph and _mm256_cvtph_ps to immintrin.h.
This more closely matches their locations as described by Intel
documentation, and lets us remove a pair
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254528: Move _mm256_cvtps_ph and _mm256_cvtph_ps to
immintrin.h. (authored by probinson).
Changed prior to commit:
http://reviews.llvm.org/D15127?vs=41555&id=41647#toc
Repository:
rL LLVM
http://rev
tstellarAMD resigned from this revision.
tstellarAMD removed a reviewer: tstellarAMD.
tstellarAMD added a comment.
Hans already commented on the release script changes, and I agrre they look
good.
http://reviews.llvm.org/D13802
___
cfe-commits mail
tstellarAMD accepted this revision.
tstellarAMD added a comment.
This revision is now accepted and ready to land.
AMDGPU changes LGTM.
http://reviews.llvm.org/D14691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
mclow.lists added inline comments.
Comment at: clang-tidy/misc/StdSwapCheck.cpp:68
@@ +67,3 @@
+
callee(expr(ignoringParenImpCasts(declRefExpr(has(nestedNameSpecifierLoc().bind("namespace"))).bind("swap"),
+this);
+}
I believe that if you do that, you
Oh, this type has a user-defined dtor, so it's deprecated to use the
implicit copy ctor/assignment operator anyway - and I have the -Wdeprecated
flag on in my build (& keep the LLVM build clean of any warnings it shows).
At some point (would love help) we should just turn that on for everyone,
the
On Wed, Dec 2, 2015 at 7:05 AM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: aaronballman
> Date: Wed Dec 2 09:05:47 2015
> New Revision: 254515
>
> URL: http://llvm.org/viewvc/llvm-project?rev=254515&view=rev
> Log:
> Amending r254423 by deleting the copy construc
rjmccall added inline comments.
Comment at: lib/AST/RecordLayoutBuilder.cpp:1606
@@ -1605,1 +1605,3 @@
+} else if (ExplicitFieldAlign)
+ FieldOffset = llvm::RoundUpToAlignment(FieldOffset, ExplicitFieldAlign);
Be sure to test specifically with an APCS A
Author: aaronballman
Date: Wed Dec 2 11:07:30 2015
New Revision: 254520
URL: http://llvm.org/viewvc/llvm-project?rev=254520&view=rev
Log:
Making the deleted copy constructor parameter const; NFC.
Modified:
cfe/trunk/include/clang/Sema/AttributeList.h
Modified: cfe/trunk/include/clang/Sema/A
On Thu, Nov 26, 2015 at 09:34:31AM -, Alexander Musman via cfe-commits
wrote:
> Author: amusman
> Date: Thu Nov 26 03:34:30 2015
> New Revision: 254143
>
> URL: http://llvm.org/viewvc/llvm-project?rev=254143&view=rev
> Log:
> Fix for merging decls in pragma weak
> Calling CheckFunctionDeclara
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/StdSwapCheck.cpp:86
@@ +85,3 @@
+ SourceLocation semiLoc =
findSemiAfterLocation(swapSourceRange.getEnd(), *Result.Context, false);
+ assert(semiLoc != SourceLocation() && "Can't find the terminating
klimek added a reviewer: bkramer.
Comment at: clang-tidy/misc/StdSwapCheck.cpp:25
@@ +24,3 @@
+static SourceLocation findSemiAfterLocation(SourceLocation loc,
+ASTContext &Ctx,
+bool IsDecl) {
mclow.lists added inline comments.
Comment at: clang-tidy/misc/StdSwapCheck.cpp:24
@@ +23,3 @@
+/// source location will be invalid.
+static SourceLocation findSemiAfterLocation(SourceLocation loc,
+ASTContext &Ctx,
aaro
mclow.lists updated the summary for this revision.
mclow.lists updated this revision to Diff 41626.
mclow.lists marked 7 inline comments as done.
mclow.lists added a comment.
Fixed all the simple things that people commented on.
http://reviews.llvm.org/D15121
Files:
clang-tidy/misc/CMakeLists
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2788
@@ +2787,3 @@
+def warn_attribute_packed_for_bitfield : Warning<
+ "'packed' attribute was ignored on bit-fields with alignment 1 "
+ "in older versions of GCC and Clang">,
-
Author: aaronballman
Date: Wed Dec 2 09:24:47 2015
New Revision: 254517
URL: http://llvm.org/viewvc/llvm-project?rev=254517&view=rev
Log:
Replace the custom AST matcher for nothrow functions with the canonical AST
matcher from r254516.
Modified:
clang-tools-extra/trunk/clang-tidy/cert/Stati
On Tue, Dec 1, 2015 at 8:12 PM, Matthias Braun via cfe-commits
wrote:
> Author: matze
> Date: Tue Dec 1 19:12:06 2015
> New Revision: 254477
>
> URL: http://llvm.org/viewvc/llvm-project?rev=254477&view=rev
> Log:
> Force test to a target that supports thread_local
>
> This should fix darwin bots.
Author: aaronballman
Date: Wed Dec 2 09:23:59 2015
New Revision: 254516
URL: http://llvm.org/viewvc/llvm-project?rev=254516&view=rev
Log:
Add a narrowing AST matcher that matches on a FunctionDecl with a non-throwing
exception specification.
Modified:
cfe/trunk/docs/LibASTMatchersReference.
aaron.ballman added a comment.
In http://reviews.llvm.org/D14731#300074, @jamesr wrote:
> It looks like Aaron Ballman was involved with adding parsing for these
> attributes in clang - perhaps he has an idea of a better way to detect these
> than __has_attribute(acquire_capability).
__has_att
Author: aaronballman
Date: Wed Dec 2 09:05:47 2015
New Revision: 254515
URL: http://llvm.org/viewvc/llvm-project?rev=254515&view=rev
Log:
Amending r254423 by deleting the copy constructor and adding a move constructor
instead; NFC as neither of these constructors are currently called, but this i
On Tue, Dec 1, 2015 at 6:47 PM, Richard Smith wrote:
> On Tue, Dec 1, 2015 at 3:42 PM, Duncan P. N. Exon Smith via cfe-commits
> wrote:
>>
>>
>> > On 2015-Dec-01, at 09:15, Aaron Ballman via cfe-commits
>> > wrote:
>> >
>> > Author: aaronballman
>> > Date: Tue Dec 1 11:15:13 2015
>> > New Revis
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/StdSwapCheck.cpp:24
@@ +23,3 @@
+/// source location will be invalid.
+static SourceLocation findSemiAfterLocation(SourceLocation loc,
+ASTContext &Ctx,
rs
ABataev added inline comments.
Comment at: include/clang/AST/OpenMPClause.h:667
@@ -666,3 +666,3 @@
OpenMPScheduleClauseKind Kind;
- /// \brief Start location of the schedule ind in source code.
+ /// \brief Start location of the schedule kind in source code.
SourceLocatio
djasper closed this revision.
djasper added a comment.
Submitted as r254510.
http://reviews.llvm.org/D15149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: djasper
Date: Wed Dec 2 07:57:46 2015
New Revision: 254510
URL: http://llvm.org/viewvc/llvm-project?rev=254510&view=rev
Log:
Traverse the NestedNameSpecifier(Loc) of NamespaceAliasDecls.
Review: http://reviews.llvm.org/D15149
Modified:
cfe/trunk/include/clang/AST/RecursiveASTVisitor
spetrovic updated this revision to Diff 41613.
spetrovic marked an inline comment as done.
http://reviews.llvm.org/D14871
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGen/ppc-varargs-struct.c
test/CodeGen/x86_64-arguments.c
Index: test/CodeGen/x86_64-arguments.c
=
kkwli0 added inline comments.
Comment at: include/clang/AST/OpenMPClause.h:708
@@ -707,3 +707,3 @@
public:
- /// \brief Build 'schedule' clause with schedule kind \a Kind and chunk size
- /// expression \a ChunkSize.
+ /// \brief Build 'dist_schedule' clause with schedule kind
djasper created this revision.
djasper added a reviewer: klimek.
djasper added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
http://reviews.llvm.org/D15149
Files:
include/clang/AST/RecursiveASTVisitor.h
unittests/ASTMatchers/ASTMatchersTest.cpp
Index: unittests/ASTMatchers/AS
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D15149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
DmitryPolukhin added a comment.
This CL doesn't changes anything for ms_struct cases and ms_struct seems to be
broken for bit-fields even for very simple cases so filed separate bug
https://llvm.org/bugs/show_bug.cgi?id=25707
PTAL
Comment at: lib/AST/RecordLayoutBuilder.cpp:1
DmitryPolukhin updated this revision to Diff 41611.
DmitryPolukhin marked an inline comment as done.
DmitryPolukhin added a comment.
Fixed logic for warning calculation and added even more test-cases.
http://reviews.llvm.org/D14980
Files:
lib/AST/RecordLayoutBuilder.cpp
test/Sema/bitfield-l
klimek added inline comments.
Comment at: lib/Format/BreakableToken.cpp:443
@@ -439,2 +442,3 @@
}
+ const StringRef Line = Lines[LineIndex];
For posterity, from in-person chat:
Currently, this does the same as before when we're in DryRun mode, and only
wrap
bkramer created this revision.
bkramer added reviewers: djasper, klimek.
bkramer added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
/* a
* a*/
Now becomes
/*
* a a*/
instead of
/*
* a
* a*/
This is implemented by glueing the next line on while f
Author: christof
Date: Wed Dec 2 06:03:42 2015
New Revision: 254505
URL: http://llvm.org/viewvc/llvm-project?rev=254505&view=rev
Log:
Teaches clang about Cortex-A35.
Adds support for the new Cortex-A35 ARMv8-A core.
Differential Revision: http://reviews.llvm.org/D15142
Modified:
cfe/trunk/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254505: Teaches clang about Cortex-A35. (authored by
christof).
Changed prior to commit:
http://reviews.llvm.org/D15142?vs=41600&id=41609#toc
Repository:
rL LLVM
http://reviews.llvm.org/D15142
File
vkalintiris created this revision.
vkalintiris added a subscriber: cfe-commits.
http://reviews.llvm.org/D15145
Files:
.gitignore
Index: .gitignore
===
--- .gitignore
+++ .gitignore
@@ -52,3 +52,7 @@
# PyBuilder
target/
+
+# vi
rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.
Isn't it time we move AArch64 to the target parser, too?
Anyway, as it is, LGTM, for the time being. Thanks!
Repository:
rL LLVM
http://reviews.llv
vkalintiris accepted this revision.
vkalintiris added a comment.
This revision is now accepted and ready to land.
LGTM. Thank you for working on this.
http://reviews.llvm.org/D15130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
DmitryPolukhin updated this revision to Diff 41597.
DmitryPolukhin marked an inline comment as done.
DmitryPolukhin added a comment.
Warning text updated, PTAL.
http://reviews.llvm.org/D14872
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclAttr.cpp
test/Sema/struct-pack
90 matches
Mail list logo
