ABataev added reviewers: hans, tstellarAMD.
ABataev updated this revision to Diff 38374.
ABataev marked an inline comment as done.
http://reviews.llvm.org/D13802
Files:
autoconf/configure.ac
configure
docs/GettingStarted.rst
docs/ReleaseProcess.rst
utils/release/test-release.sh
Index:
ABataev marked an inline comment as done.
ABataev added a comment.
Hi Chandler, thanks for the review.
In http://reviews.llvm.org/D13802#272053, @chandlerc wrote:
> Some minor issues below. Also, Hans and Tom should have a glance at the
> release bits of this, I don't know any of that stuff.
>
djasper added a comment.
I'll take a look. I agree that there should be a better approach.
Also, you seem to have created the inverse patch :-).
http://reviews.llvm.org/D14052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
LG. Thanks, totally missed this.
On Sun, Oct 25, 2015, 7:46 PM Matthias Gehre via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> mgehre created this revision.
> mgehre added reviewers: alexfh, sbenza, bkramer, aaron.ballman.
> mgehre added a subscriber: cfe-commits.
>
> Adapt clang-tidy/add_n
Ah, I see Benjamin got to this in 251265
On Oct 25, 2015 9:54 PM, "David Blaikie" wrote:
>
> On Oct 25, 2015 2:47 PM, "Daniel Jasper via cfe-commits" <
> cfe-commits@lists.llvm.org> wrote:
> >
> > Author: djasper
> > Date: Sun Oct 25 16:44:55 2015
> > New Revision: 251262
> >
> > URL: http://llvm
On Oct 25, 2015 3:05 PM, "Benjamin Kramer via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
>
> Author: d0k
> Date: Sun Oct 25 17:03:00 2015
> New Revision: 251265
>
> URL: http://llvm.org/viewvc/llvm-project?rev=251265&view=rev
> Log:
> assert(false) -> llvm_unreachable.
>
> Modified:
>
clang-
On Oct 25, 2015 2:47 PM, "Daniel Jasper via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
>
> Author: djasper
> Date: Sun Oct 25 16:44:55 2015
> New Revision: 251262
>
> URL: http://llvm.org/viewvc/llvm-project?rev=251262&view=rev
> Log:
> [clang-tidy] Add return value for non-assert builds.
>
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Looks good to me. I will commit.
http://reviews.llvm.org/D13800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
jeanphilippeD created this revision.
jeanphilippeD added a reviewer: djasper.
jeanphilippeD added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
The function type declared in an std::function template parameter is confused
for a cast:
Currently:
Pass: "std::function< void(int, int
Author: d0k
Date: Sun Oct 25 17:03:00 2015
New Revision: 251265
URL: http://llvm.org/viewvc/llvm-project?rev=251265&view=rev
Log:
assert(false) -> llvm_unreachable.
Modified:
clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp
Modified:
clang-tools-extra/trunk/clang-tid
Author: djasper
Date: Sun Oct 25 16:44:55 2015
New Revision: 251262
URL: http://llvm.org/viewvc/llvm-project?rev=251262&view=rev
Log:
[clang-tidy] Add return value for non-assert builds.
Modified:
clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp
Modified:
clang-tools
mgehre updated this revision to Diff 38359.
mgehre added a comment.
Update for review comments
http://reviews.llvm.org/D13973
Files:
lib/Analysis/CFG.cpp
test/Analysis/no-unreachable-dtors.cpp
Index: test/Analysis/no-unreachable-dtors.cpp
===
klimek added inline comments.
Comment at: lib/Analysis/CFG.cpp:1949-1952
@@ +1948,6 @@
+ }
+ if(!C->body_empty() && !dyn_cast(*C->body_rbegin())) {
+// If the body ends with a ReturnStmt, the dtors will be added in
VisitReturnStmt
+addAutomaticObjDtors(ScopePos, scopeBe
Author: marshall
Date: Sun Oct 25 15:12:58 2015
New Revision: 251258
URL: http://llvm.org/viewvc/llvm-project?rev=251258&view=rev
Log:
Mark LWG#2495 as complete. No code changes needed
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm
Author: marshall
Date: Sun Oct 25 15:12:16 2015
New Revision: 251257
URL: http://llvm.org/viewvc/llvm-project?rev=251257&view=rev
Log:
Fix LWG#2489: mem_fn() should be noexcept
Modified:
libcxx/trunk/include/functional
libcxx/trunk/test/std/utilities/function.objects/func.memfn/member_fu
Author: marshall
Date: Sun Oct 25 14:53:29 2015
New Revision: 251254
URL: http://llvm.org/viewvc/llvm-project?rev=251254&view=rev
Log:
Add the tests for the last commit
Added:
libcxx/trunk/test/std/utilities/allocator.adaptor/scoped.adaptor.operators/copy_assign.pass.cpp
libcxx/trunk/te
Author: marshall
Date: Sun Oct 25 14:52:47 2015
New Revision: 251253
URL: http://llvm.org/viewvc/llvm-project?rev=251253&view=rev
Log:
Fix LWG#2476: scoped_allocator_adaptor is not assignable
Modified:
libcxx/trunk/include/scoped_allocator
Modified: libcxx/trunk/include/scoped_allocator
URL:
Author: marshall
Date: Sun Oct 25 14:34:04 2015
New Revision: 251252
URL: http://llvm.org/viewvc/llvm-project?rev=251252&view=rev
Log:
Add a test for LWG#2466: allocator_traits::max_size() default behavior is
incorrect
Modified:
libcxx/trunk/include/memory
libcxx/trunk/test/std/utilitie
krememek added a subscriber: krememek.
krememek accepted this revision.
krememek added a reviewer: krememek.
krememek added a comment.
This revision is now accepted and ready to land.
These all look good to me.
http://reviews.llvm.org/D10021
___
cfe
Author: marshall
Date: Sun Oct 25 14:20:14 2015
New Revision: 251250
URL: http://llvm.org/viewvc/llvm-project?rev=251250&view=rev
Log:
Add a test for LWG#2462: std::ios_base::failure is overspecified
Modified:
libcxx/trunk/test/std/input.output/iostreams.base/ios.base/ios.types/ios_failure/c
Author: marshall
Date: Sun Oct 25 13:58:07 2015
New Revision: 251247
URL: http://llvm.org/viewvc/llvm-project?rev=251247&view=rev
Log:
Fix LWG#2127: Move-construction with raw_storage_iterator.
Modified:
libcxx/trunk/include/memory
libcxx/trunk/test/std/utilities/memory/storage.iterator/
majnemer added a subscriber: majnemer.
Comment at: lib/Analysis/CFG.cpp:1949
@@ +1948,3 @@
+ }
+ if(!C->body_empty() && !dyn_cast(*C->body_rbegin())) {
+// If the body ends with a ReturnStmt, the dtors will be added in
VisitReturnStmt
mgehre wrote:
> klimek
mgehre created this revision.
mgehre added reviewers: alexfh, sbenza, bkramer, aaron.ballman.
mgehre added a subscriber: cfe-commits.
Adapt clang-tidy/add_new_check.py according to commit r251010 "Add
%check_clang_tidy and %clang_tidy_diff"
http://reviews.llvm.org/D14049
Files:
clang-tidy/add
mgehre added inline comments.
Comment at: lib/Analysis/CFG.cpp:1949-1952
@@ +1948,6 @@
+ }
+ if(!C->body_empty() && !dyn_cast(*C->body_rbegin())) {
+// If the body ends with a ReturnStmt, the dtors will be added in
VisitReturnStmt
+addAutomaticObjDtors(ScopePos, scopeBe
mgehre updated this revision to Diff 38353.
mgehre marked an inline comment as done.
mgehre added a comment.
Do not flag explicit casts
http://reviews.llvm.org/D13640
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy
Author: marshall
Date: Sun Oct 25 13:31:51 2015
New Revision: 251246
URL: http://llvm.org/viewvc/llvm-project?rev=251246&view=rev
Log:
Fix LWG#2244: basic_istream::seekg
Modified:
libcxx/trunk/include/istream
libcxx/trunk/test/std/input.output/iostream.format/input.streams/istream.unform
Author: piotrdz
Date: Sun Oct 25 12:11:13 2015
New Revision: 251244
URL: http://llvm.org/viewvc/llvm-project?rev=251244&view=rev
Log:
[clang-tidy] Another fix for failing buildbots regarding signedness of char
I totally forgot that char can be defined as unsigned on some platforms.
Now I made exp
petpav01 added a comment.
Thank you for having a look at this patch. I should get to updating it as
requested soon. Apologies for the delay.
http://reviews.llvm.org/D13289
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
Author: piotrdz
Date: Sun Oct 25 10:47:21 2015
New Revision: 251239
URL: http://llvm.org/viewvc/llvm-project?rev=251239&view=rev
Log:
[clang-tidy] Fix for build bots not liking #include
Modified:
clang-tools-extra/trunk/test/clang-tidy/readability-implicit-bool-cast-cxx98.cpp
clang-tool
Author: piotrdz
Date: Sun Oct 25 10:31:25 2015
New Revision: 251235
URL: http://llvm.org/viewvc/llvm-project?rev=251235&view=rev
Log:
[clang-tidy] Add check readability-implicit-bool-cast
Summary:
This is another check that I ported to clang-tidy from colobot-lint tool.
As previously discussed o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251224: [X86] Mark inregs correctly for MCU psABI (authored
by mkuper).
Changed prior to commit:
http://reviews.llvm.org/D13978?vs=38107&id=38341#toc
Repository:
rL LLVM
http://reviews.llvm.org/D139
Author: mkuper
Date: Sun Oct 25 03:18:20 2015
New Revision: 251224
URL: http://llvm.org/viewvc/llvm-project?rev=251224&view=rev
Log:
[X86] Mark inregs correctly for MCU psABI
The MCU psABI calling convention is somewhat, but not quite, like -mregparm 3.
In particular, the rules involving structs
mkuper added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:857
@@ -854,3 +856,3 @@
IsWin32StructABI(Win32StructABI),
- IsSoftFloatABI(SoftFloatABI),
+ IsSoftFloatABI(SoftFloatABI), IsMCUABI(MCUABI),
DefaultNumRegisterParameters(NumRegisterParamete
33 matches
Mail list logo
