thakis added a subscriber: thakis.
Comment at: test/SemaCXX/auto-type-from-cxx.cpp:14
@@ +13,3 @@
+ auto _ = [](__auto_type f) {}; // expected-error {{'__auto_type' not allowed
in lambda parameter}}
+ __auto_type g = 2;
+ struct BitField { int field:2; };
Shou
Author: ctopper
Date: Tue Oct 13 00:15:17 2015
New Revision: 250149
URL: http://llvm.org/viewvc/llvm-project?rev=250149&view=rev
Log:
[X86] LLVM now prints XOP immediates as unsigned after r250147. Fix expected
check string accordingly.
Modified:
cfe/trunk/test/CodeGen/xop-builtins.c
Modifi
comex updated this revision to Diff 37215.
comex added a comment.
Okay.
http://reviews.llvm.org/D12686
Files:
include/clang/AST/ASTContext.h
include/clang/AST/Type.h
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticParseKinds.td
include/clang/Basic/DiagnosticSemaK
Author: rsmith
Date: Mon Oct 12 20:26:26 2015
New Revision: 250140
URL: http://llvm.org/viewvc/llvm-project?rev=250140&view=rev
Log:
[modules] Improve error message on failed module load due to a missing file to
say which module file referenced the missing file.
Modified:
cfe/trunk/lib/Serial
rsmith added a comment.
Thanks, this essentially looks good to me. I can't think of any other cases
where C++ allows `auto` that you've not covered.
Comment at: lib/Sema/SemaExprCXX.cpp:1172-1173
@@ -1171,1 +1171,4 @@
+ if (D.getDeclSpec().getTypeSpecType() == DeclSpec::TST_
comex updated the summary for this revision.
comex updated this revision to Diff 37202.
comex marked 3 inline comments as done.
comex added a comment.
Fixed raised issues.
(I don't have commit rights.)
http://reviews.llvm.org/D12686
Files:
include/clang/AST/ASTContext.h
include/clang/AST/T
Author: rsmith
Date: Mon Oct 12 19:39:40 2015
New Revision: 250137
URL: http://llvm.org/viewvc/llvm-project?rev=250137&view=rev
Log:
[modules] Allow the error on importing a C++ module within an extern "C"
context (but otherwise at the top level) to be disabled, to support use of C++
standard libr
Author: chapuni
Date: Mon Oct 12 19:38:06 2015
New Revision: 250136
URL: http://llvm.org/viewvc/llvm-project?rev=250136&view=rev
Log:
Tweak clang/test/CodeGen/debug-prefix-map.c to appease win32 hosts.
!1 = !DIFile(filename: "/var/empty\5C", directory:
"E:\5Cllvm\5Cbuild\5Ccmake-ninja\5Ctools\
comex marked 5 inline comments as done.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1726
@@ -1720,1 +1725,3 @@
+def err_auto_bitfield : Error<
+ "cannot pass bit-field as __auto_type initializer in C">;
rsmith wrote:
> pass -> use
>
> Also, why not?
Author: eugenis
Date: Mon Oct 12 18:50:19 2015
New Revision: 250128
URL: http://llvm.org/viewvc/llvm-project?rev=250128&view=rev
Log:
[safestack] Driver link test for safestack on android.
Safestack runtime should never be linked on Android targets because
it is implemented directly in libc. This
mgehre added inline comments.
Comment at:
clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:29
@@ +28,3 @@
+ implicitCastExpr(unless(hasParent(arraySubscriptExpr())),
+
unless(hasSourceExpression(declRefExpr(to(varDecl(hasName("__range
Hello everyone,
LLVM buildmaster will be updated and restarted after 6 PM Pacific time
today.
I know it makes some noise, I am working on reducing it.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
zaks.anna added a comment.
> so it'd take more time for me to conduct a deeper audit of the reaping code
> to answer this question
That would be great, thanks!
> And i guess it should be large and varied enough(?)
Yes.
http://reviews.llvm.org/D12726
_
ahatanak updated this revision to Diff 37172.
ahatanak added a comment.
I've made some changes following the discussion I had and the feedback I got on
the llvm-side patch.
This is the link to the discussion thread:
http://thread.gmane.org/gmane.comp.compilers.llvm.cvs/271105/
The difference be
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250116: [clang-tidy] new check
cppcoreguidelines-pro-bounds-pointer-arithmetic (authored by mgehre).
Changed prior to commit:
http://reviews.llvm.org/D13311?vs=36564&id=37183#toc
Repository:
rL LLVM
Author: mgehre
Date: Mon Oct 12 16:53:19 2015
New Revision: 250116
URL: http://llvm.org/viewvc/llvm-project?rev=250116&view=rev
Log:
[clang-tidy] new check cppcoreguidelines-pro-bounds-pointer-arithmetic
Summary:
This check flags all usage of pointer arithmetic, because it could lead
to an
invali
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250114: Add decayedType and hasDecayedType AST matchers
(authored by mgehre).
Changed prior to commit:
http://reviews.llvm.org/D13639?vs=37066&id=37178#toc
Repository:
rL LLVM
http://reviews.llvm.or
Author: mgehre
Date: Mon Oct 12 16:46:07 2015
New Revision: 250114
URL: http://llvm.org/viewvc/llvm-project?rev=250114&view=rev
Log:
Add decayedType and hasDecayedType AST matchers
Summary: Add decayedType and hasDecayedType AST matchers
Reviewers: klimek
Subscribers: klimek, cfe-commits
Diffe
sbenza added inline comments.
Comment at:
clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:29
@@ +28,3 @@
+ implicitCastExpr(unless(hasParent(arraySubscriptExpr())),
+
unless(hasSourceExpression(declRefExpr(to(varDecl(hasName("__range
Author: compnerd
Date: Mon Oct 12 16:19:27 2015
New Revision: 250111
URL: http://llvm.org/viewvc/llvm-project?rev=250111&view=rev
Log:
test: relax path matching for windows
The test failed on Windows due to use of \ as a path separator rather than /.
Modified:
cfe/trunk/test/CodeGen/debug-pr
Author: compnerd
Date: Mon Oct 12 16:19:30 2015
New Revision: 250112
URL: http://llvm.org/viewvc/llvm-project?rev=250112&view=rev
Log:
test: change argument
This failed on AArch64 due to the type mismatch using int instead of
__builtin_va_list.
Modified:
cfe/trunk/test/CodeGen/Inputs/stdio.h
jroelofs added a comment.
LGTM, with one small nit (and once http://reviews.llvm.org/D13407 lands):
Comment at: src/locale.cpp:1176
@@ -1171,3 +1175,3 @@
}
-#endif // __GLIBC__ || __EMSCRIPTEN__ || __NETBSD__
+#endif // __GLIBC__ || __NETBSD__ || || __EMSCRIPTEN__ ||
defined(_
rsmith added a comment.
I think this is a good direction. I used to link libc++abi into libc++, and
switched to using a hand-rolled linker script a while back. It's been working
great for me.
http://reviews.llvm.org/D12508
___
cfe-commits mailing
vkalintiris created this revision.
vkalintiris added reviewers: mclow.lists, jroelofs, EricWF.
vkalintiris added a subscriber: cfe-commits.
vkalintiris added a dependency: D13407: [libcxx] Capture configuration
information when installing the libc++ headers.
Herald added subscribers: srhines, dana
Author: rsmith
Date: Mon Oct 12 16:05:54 2015
New Revision: 250105
URL: http://llvm.org/viewvc/llvm-project?rev=250105&view=rev
Log:
Add warning flags for #include_next and some nearby warnings.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticGroups.td
cfe/trunk/include/clang/Basic/Diag
mclow.lists closed this revision.
mclow.lists added a comment.
landed as revision 249649
http://reviews.llvm.org/D13192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hans
Date: Mon Oct 12 15:47:58 2015
New Revision: 250099
URL: http://llvm.org/viewvc/llvm-project?rev=250099&view=rev
Log:
Parse and ignore #pragma runtime_checks in MS extensions mode (PR25138)
We already silently ignore the /RTC, which controls the same functionality.
Modified:
cfe
Author: mgehre
Date: Mon Oct 12 15:46:53 2015
New Revision: 250098
URL: http://llvm.org/viewvc/llvm-project?rev=250098&view=rev
Log:
[clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast
Summary:
This check flags all usages of static_cast, where a base class is casted
to a derive
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250098: [clang-tidy] add check
cppcoreguidelines-pro-type-static-cast-downcast (authored by mgehre).
Changed prior to commit:
http://reviews.llvm.org/D13368?vs=37155&id=37164#toc
Repository:
rL LLVM
Author: marshall
Date: Mon Oct 12 15:45:05 2015
New Revision: 250097
URL: http://llvm.org/viewvc/llvm-project?rev=250097&view=rev
Log:
Fix Bug 25103 - _cxa_demangle improperly demangles virtual thunks. Thanks to
Jason King for the report and suggested fix
Modified:
libcxxabi/trunk/src/cxa_de
Author: compnerd
Date: Mon Oct 12 15:21:08 2015
New Revision: 250094
URL: http://llvm.org/viewvc/llvm-project?rev=250094&view=rev
Log:
Support Debug Info path remapping
Add support for the `-fdebug-prefix-map=` option as in GCC. The syntax is
`-fdebug-prefix-map=OLD=NEW`. When compiling files f
> On Oct 12, 2015, at 10:50 AM, David Blaikie wrote:
> +John, author of the original patch - in case it's an obvious mistake. I
> haven't looked at John's change yet & compared it to the intended behavior,
> etc. Will do so soon and/or if John doesn't see something at a glance.
The functionalit
mgehre updated this revision to Diff 37155.
mgehre marked an inline comment as done.
mgehre added a comment.
Add test for static_cast with const
http://reviews.llvm.org/D13368
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250090: [Sema] Make `&function_with_enable_if_attrs` an
error (authored by gbiv).
Changed prior to commit:
http://reviews.llvm.org/D13607?vs=37075&id=37152#toc
Repository:
rL LLVM
http://reviews.llv
Author: gbiv
Date: Mon Oct 12 14:57:04 2015
New Revision: 250090
URL: http://llvm.org/viewvc/llvm-project?rev=250090&view=rev
Log:
[Sema] Make `&function_with_enable_if_attrs` an error
This fixes a bug where one can take the address of a conditionally
enabled function to drop its enable_if guards
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1726
@@ -1720,1 +1725,3 @@
+def err_auto_bitfield : Error<
+ "cannot pass bit-field as __auto_type initializer in C">;
pass -> use
Also, why not? Just because GCC messes this
vsk added a comment.
This lgtm. If you don't have commit rights, I can land this for you if you'd
like.
http://reviews.llvm.org/D12686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250078: [Sema] Don't emit multiple diags for one error
(authored by gbiv).
Changed prior to commit:
http://reviews.llvm.org/D13664?vs=37137&id=37138#toc
Repository:
rL LLVM
http://reviews.llvm.org/D
Author: gbiv
Date: Mon Oct 12 13:40:58 2015
New Revision: 250078
URL: http://llvm.org/viewvc/llvm-project?rev=250078&view=rev
Log:
[Sema] Don't emit multiple diags for one error
Fixed a bug where we'd emit multiple diagnostics if there was a problem
taking the address of an overloaded template fu
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D13607
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
http://reviews.llvm.org/D13664
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
On Mon, Oct 12, 2015 at 9:41 AM, Steven Wu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi Richard
>
> Your splitting seems causing problem when using extern "C". Here is a test
> case:
>
> $ cat test.cpp
> #ifdef __cplusplus
> extern "C" {
> #endif
> #include
> #ifdef __cplusplus
> }
>
george.burgess.iv updated this revision to Diff 37137.
george.burgess.iv added a comment.
Un-nested an if statement.
http://reviews.llvm.org/D13664
Files:
lib/Sema/SemaOverload.cpp
test/SemaCXX/addr-of-overloaded-function.cpp
Index: test/SemaCXX/addr-of-overloaded-function.cpp
george.burgess.iv created this revision.
george.burgess.iv added a reviewer: rsmith.
george.burgess.iv added a subscriber: cfe-commits.
Given code like the following (stolen from tests):
```
template int f(T1 *, const T2 *);
template int f(const T1 *, T2 *);
int (*p)(const int *, const int *) =
+John, author of the original patch - in case it's an obvious mistake. I
haven't looked at John's change yet & compared it to the intended behavior,
etc. Will do so soon and/or if John doesn't see something at a glance.
On Sun, Oct 11, 2015 at 11:09 PM, Bataev, Alexey
wrote:
> Yes, revision 2469
Hi Richard
Your splitting seems causing problem when using extern "C". Here is a test case:
$ cat test.cpp
#ifdef __cplusplus
extern "C" {
#endif
#include
#ifdef __cplusplus
}
#endif
Error:
clang -fsyntax-only test.cpp
In file included from test.cpp:4:
In file included from /usr/bin/../includ
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250064: [CMake] Bug 14109 - CMake build for compiler-rt
should use just-built clang (authored by cbieneman).
Changed prior to commit:
http://reviews.llvm.org/D13399?vs=36897&id=37127#toc
Repository:
Author: cbieneman
Date: Mon Oct 12 11:34:23 2015
New Revision: 250064
URL: http://llvm.org/viewvc/llvm-project?rev=250064&view=rev
Log:
[CMake] Bug 14109 - CMake build for compiler-rt should use just-built clang
Summary:
Many small improvements to LLVM_BUILD_EXTERNAL_COMPILER_RT.
* Works correct
Author: marshall
Date: Mon Oct 12 11:25:21 2015
New Revision: 250061
URL: http://llvm.org/viewvc/llvm-project?rev=250061&view=rev
Log:
Mark 2447 and 2466 as completed.
Modified:
libcxx/trunk/www/kona.html
Modified: libcxx/trunk/www/kona.html
URL:
http://llvm.org/viewvc/llvm-project/libcxx/t
On Fri, Oct 9, 2015 at 9:10 PM, Douglas Gregor wrote:
>
>
> Sent from my iPhone
>
>> On Oct 9, 2015, at 2:17 PM, Hans Wennborg wrote:
>>
>>> On Fri, Oct 9, 2015 at 1:46 PM, Douglas Gregor wrote:
>>>
On Oct 7, 2015, at 11:55 AM, Hans Wennborg wrote:
Hi Doug,
On Wed, Sep
Author: d0k
Date: Mon Oct 12 11:16:39 2015
New Revision: 250060
URL: http://llvm.org/viewvc/llvm-project?rev=250060&view=rev
Log:
[VFS] Let the user decide if they want path normalization.
This is a more principled version of what I did earlier. Path
normalization is generally a good thing, but m
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250060: [VFS] Let the user decide if they want path
normalization. (authored by d0k).
Changed prior to commit:
http://reviews.llvm.org/D13658?vs=37124&id=37125#toc
Repository:
rL LLVM
http://reviews
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
Comment at: include/clang/Basic/VirtualFileSystem.h:282
@@ -280,2 +281,3 @@
/// Add a buffer to the VFS with a path. The VFS owns the buffer.
- void addFile(const Twine
bkramer updated this revision to Diff 37124.
bkramer added a comment.
Addressed review comments.
http://reviews.llvm.org/D13658
Files:
include/clang/Basic/VirtualFileSystem.h
lib/Basic/VirtualFileSystem.cpp
unittests/Basic/VirtualFileSystemTest.cpp
Index: unittests/Basic/VirtualFileSyste
klimek added inline comments.
Comment at: include/clang/Basic/VirtualFileSystem.h:276
@@ -275,2 +275,3 @@
std::string WorkingDirectory;
+ bool UseNormalizedPaths;
I'd use an in class initializer.
Comment at: include/clang/Basic/VirtualFileS
junbuml added a comment.
Just want to hear if there is any opinion about moving this implementation back
to PrunceEH.cpp like http://reviews.llvm.org/D12979 and adding the minimum
callee size check to avoid marking noinlines on trivial constrictor calls.
Please let me know any objection or sugg
bkramer created this revision.
bkramer added a reviewer: klimek.
bkramer added a subscriber: cfe-commits.
This is a more principled version of what I did earlier. Path
normalization is generally a good thing, but may break users in strange
environments, e. g. using lots of symlinks. Let the user c
curdeius updated this revision to Diff 37115.
curdeius added a comment.
Add option converters for filenames (prohibiting quotes) and styles (giving a
list of predefined styles).
http://reviews.llvm.org/D13549
Files:
tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs
tools/clang-format
curdeius marked 5 inline comments as done.
curdeius added a comment.
Assume-Filename option will now give an error when there are quotes in the
filename.
http://reviews.llvm.org/D13549
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
I have just made one minor update in the CodeGen test
(test/CodeGen/atomic-ops.c) that is now checking the IR output rather than only
making sure frontend doesn't crash.
The final patch is attached here!
Thanks,
Anastasia
-Original Message-
From: Pekka Jääskeläinen [mailto:pekka.jaas
Author: atanasyan
Date: Mon Oct 12 09:32:57 2015
New Revision: 250043
URL: http://llvm.org/viewvc/llvm-project?rev=250043&view=rev
Log:
[Driver] Remove `else` after `return`
Modified:
cfe/trunk/lib/Driver/Multilib.cpp
Modified: cfe/trunk/lib/Driver/Multilib.cpp
URL:
http://llvm.org/viewvc/l
aaboud updated this revision to Diff 37108.
aaboud added a comment.
Added two LIT tests to check the xsave intrinsic instructions.
Repository:
rL LLVM
http://reviews.llvm.org/D13014
Files:
include/clang/Basic/BuiltinsX86.def
lib/CodeGen/CGBuiltin.cpp
lib/Headers/CMakeLists.txt
lib/He
I believe we need a more principled approach here :)
1. The first thing we need is to actually produce nice errors when we hit
an addFile() with the same path (normalized or non-normalized)
I'd propose the following approach: we compare the buffers; if the buffer
contents are equal, we declare suc
Author: d0k
Date: Mon Oct 12 08:39:33 2015
New Revision: 250037
URL: http://llvm.org/viewvc/llvm-project?rev=250037&view=rev
Log:
[VFS] Unbreak test.
Modified:
cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp
Modified: cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp
URL:
http://llvm.
nwilson marked 2 inline comments as done.
Comment at: lib/Sema/SemaDecl.cpp:7886
@@ -7863,1 +7885,3 @@
+
+ if (NewFD->isInvalidDecl() && !NewFD->isConcept()) {
HasExplicitTemplateArgs = false;
Maybe there could be a problem further down if we think t
Author: d0k
Date: Mon Oct 12 08:30:38 2015
New Revision: 250036
URL: http://llvm.org/viewvc/llvm-project?rev=250036&view=rev
Log:
[VFS] Don't try to be heroic with '.' in paths.
Actually the only special path we have to handle is ./foo, the rest is
tricky to get right so do the same thing as the
nwilson updated this revision to Diff 37099.
nwilson added a comment.
Moving tests to the correct file.
Modifying the diagnostic id and message so it's more applicable to the checks
in this Patch. Update the quoted sections of the standard as well.
Use ternary operator for Partial Specialization
aaron.ballman closed this revision.
aaron.ballman added a comment.
I have commit in r250034. I noticed that there was a missing reference to the
new documentation in list.rst, so I went ahead and added that as part of your
patch during the commit.
http://reviews.llvm.org/D13620
Author: aaronballman
Date: Mon Oct 12 07:57:55 2015
New Revision: 250034
URL: http://llvm.org/viewvc/llvm-project?rev=250034&view=rev
Log:
Added documentation for misc-throw-by-value-catch-by-reference.
Patch by Tobias Langner.
Added:
clang-tools-extra/trunk/docs/clang-tidy/checks/misc-thro
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for doing this!
http://reviews.llvm.org/D13620
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
NoQ updated this revision to Diff 37094.
NoQ marked an inline comment as done.
NoQ added a comment.
> What are the implications in each case?
Uhm, sorry, right, I guess i have to admit i don't quite understand what
exactly is going on, so it'd take more time for me to conduct a deeper audit of
klimek added inline comments.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:186
@@ -145,1 +185,3 @@
+if (!string.IsNullOrEmpty(assumeFilename))
+ process.StartInfo.Arguments += " -assume-filename \"" +
assumeFilename + "\"";
curdeius added inline comments.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:186
@@ -145,1 +185,3 @@
+if (!string.IsNullOrEmpty(assumeFilename))
+ process.StartInfo.Arguments += " -assume-filename \"" +
assumeFilename + "\"";
klimek added inline comments.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:186
@@ -145,1 +185,3 @@
+if (!string.IsNullOrEmpty(assumeFilename))
+ process.StartInfo.Arguments += " -assume-filename \"" +
assumeFilename + "\"";
curdeius added inline comments.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:186
@@ -145,1 +185,3 @@
+if (!string.IsNullOrEmpty(assumeFilename))
+ process.StartInfo.Arguments += " -assume-filename \"" +
assumeFilename + "\"";
klimek added inline comments.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:186
@@ -145,1 +185,3 @@
+if (!string.IsNullOrEmpty(assumeFilename))
+ process.StartInfo.Arguments += " -assume-filename \"" +
assumeFilename + "\"";
curdeius marked 3 inline comments as done.
curdeius added a comment.
Applied suggestions from comments.
http://reviews.llvm.org/D13549
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: d0k
Date: Mon Oct 12 04:22:07 2015
New Revision: 250021
URL: http://llvm.org/viewvc/llvm-project?rev=250021&view=rev
Log:
[VFS] remove handling of '..' for now.
This can fail badly if we're overlaying a real file system and there are
symlinks there. Just keep the path as-is for now.
This
curdeius updated this revision to Diff 37087.
curdeius marked 2 inline comments as done.
curdeius added a comment.
Add FIXME comment.
http://reviews.llvm.org/D13549
Files:
tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs
tools/clang-format-vs/ClangFormat/Properties/AssemblyInfo.cs
curdeius updated this revision to Diff 37086.
curdeius added a comment.
Escape only '<' and '&'.
Remove unrelated changes from the revision.
http://reviews.llvm.org/D13549
Files:
tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs
tools/clang-format-vs/ClangFormat/Properties/AssemblyInf
seaneveson updated this revision to Diff 37084.
seaneveson added a comment.
Updated to latest trunk
Replaced some code with an existing method: ignoreParenBaseCasts()
Could someone commit this for me as I don't have SVN access?
Thank you.
http://reviews.llvm.org/D13099
Files:
include/clang/S
klimek added inline comments.
Comment at: tools/clang-format/ClangFormat.cpp:227
@@ -213,1 +226,3 @@
+ llvm::outs() << """;
+ break;
default:
curdeius wrote:
> klimek wrote:
> > For XML, we should only need "<" and "&". Everything else is just impor
curdeius added inline comments.
Comment at: lib/Driver/Tools.cpp:2356
@@ -2355,3 +2355,3 @@
CmdArgs.push_back(
-Args.MakeArgString("-dwarf-version=" + llvm::itostr(DwarfVersion)));
+Args.MakeArgString("-dwarf-version=" + Twine(DwarfVersion)));
}
-
klimek added inline comments.
Comment at: lib/Driver/Tools.cpp:2356
@@ -2355,3 +2355,3 @@
CmdArgs.push_back(
-Args.MakeArgString("-dwarf-version=" + llvm::itostr(DwarfVersion)));
+Args.MakeArgString("-dwarf-version=" + Twine(DwarfVersion)));
}
---
comex added a comment.
Ping again.
http://reviews.llvm.org/D12686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
curdeius updated this revision to Diff 37081.
curdeius added a comment.
Fix description formatting.
http://reviews.llvm.org/D13549
Files:
lib/Driver/Tools.cpp
tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs
tools/clang-format-vs/ClangFormat/Properties/AssemblyInfo.cs
tools/clang
aaboud added a comment.
In http://reviews.llvm.org/D13014#264638, @delena wrote:
> Do you need to add some tests for clang?
I thought I did (see "builtins-x86.c").
This is how other intrinsic instructions are tested by clang, am I missing
something?
Repository:
rL LLVM
http://reviews.llvm
Author: abataev
Date: Mon Oct 12 01:59:48 2015
New Revision: 250017
URL: http://llvm.org/viewvc/llvm-project?rev=250017&view=rev
Log:
[ATTR] Automatic line feed after pragma-like attribute.
Automatically insert line feed after pretty printing of all pragma-like
attributes + fix printing of pragma
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250017: [ATTR] Automatic line feed after pragma-like
attribute. (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D13546?vs=36924&id=37080#toc
Repository:
rL LLVM
http://review
89 matches
Mail list logo
