Re: [PATCH] D13639: Add decayedType and hasDecayedType AST matchers

klimek added a comment. Oh, please also run the docs update script cd docs/tools python ./dump_ast_matchers.py http://reviews.llvm.org/D13639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [PATCH] D13014: [X86] Add XSAVE intrinsics (Clang part)

delena added a comment. Do you need to add some tests for clang? Repository: rL LLVM http://reviews.llvm.org/D13014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13639: Add decayedType and hasDecayedType AST matchers

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D13639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D13643: [Sema] Warn on ternary comparison

mgrabovsky created this revision. mgrabovsky added a subscriber: cfe-commits. This change adds a Sema diagnostic for comparisons like `a < b < c`, which usually do not behave as intended by the author. Fixes bug 20082. http://reviews.llvm.org/D13643 Files: include/clang/Basic/DiagnosticSemaKi

Re: [PATCH] D13582: [DEBUG INFO] Emit debug info for type used in explicit cast only.

Yes, revision 246985 broke th debug info for types in explicit casts. Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 09.10.2015 18:26, David Blaikie

Re: [PATCH] D10834: Added functions to retrieve information about variable storage in libclang and its python bindings.

RedX2501 added inline comments. Comment at: include/clang-c/Index.h:3815-3823 @@ -3814,2 +3814,11 @@ /** + * \brief Returns true if a variable with function scope is a non-static local variable. + */ +CINDEX_LINKAGE bool clang_Cursor_hasLocalStorage(CXCursor C); + +/* + * \bri

Re: [PATCH] D12501: [clang-format] Obj-C dictionary literals: Fixed typecast getting put on a separate line from the key

djasper closed this revision. djasper added a comment. Submitted as r250010. http://reviews.llvm.org/D12501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r250010 - clang-format: Fixed typecast getting put on a separate line from the

Author: djasper Date: Sun Oct 11 22:19:07 2015 New Revision: 250010 URL: http://llvm.org/viewvc/llvm-project?rev=250010&view=rev Log: clang-format: Fixed typecast getting put on a separate line from the key in Obj-C dictionary literals This fixes: https://llvm.org/PR22647 Patch by Kent Sutherlan

Re: [PATCH] D13641: clang-format: [JS] handle character classes in regexes.

djasper closed this revision. djasper added a comment. Submitted as r250009. http://reviews.llvm.org/D13641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13641: clang-format: [JS] handle character classes in regexes.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. looks good Comment at: lib/Format/Format.cpp:879 @@ -878,2 +878,3 @@ unsigned TokenCount = 0; +auto InCharacterClass = false; for (auto I = Tokens.rbegin() + 1

r250009 - clang-format: [JS] handle character classes in regexes.

Author: djasper Date: Sun Oct 11 22:13:48 2015 New Revision: 250009 URL: http://llvm.org/viewvc/llvm-project?rev=250009&view=rev Log: clang-format: [JS] handle character classes in regexes. Slashes in regular expressions do not need to be escaped and do not terminate the regular expression even w

r250008 - bindings: add new C++ function attribute accessors

Author: compnerd Date: Sun Oct 11 22:10:20 2015 New Revision: 250008 URL: http://llvm.org/viewvc/llvm-project?rev=250008&view=rev Log: bindings: add new C++ function attribute accessors Add methods to index Cursor to see if a cxx method is pure_virtual, virtual or const methods. Patch by Jonatha

Re: [libcxx] r250003 - [Darwin] Need to add -isysroot on OS X otherwise the tests will fail if you don't have the command line tools package installed.

Updated in r250007. -Chris > On Oct 11, 2015, at 7:49 PM, Chris Bieneman via cfe-commits > wrote: > > CMake handles doing it while building. I will update to use lit.util.* > > -Chris > >> On Oct 11, 2015, at 6:04 PM, Eric Fiselier > > wrote: >> >> Do we need to do with

[libcxx] r250007 - [Darwin] Reworking r250003 to use lit.util.capture instead of subprocess.

Author: cbieneman Date: Sun Oct 11 21:54:30 2015 New Revision: 250007 URL: http://llvm.org/viewvc/llvm-project?rev=250007&view=rev Log: [Darwin] Reworking r250003 to use lit.util.capture instead of subprocess. Modified: libcxx/trunk/test/libcxx/test/config.py Modified: libcxx/trunk/test/libc

Re: [libcxx] r250003 - [Darwin] Need to add -isysroot on OS X otherwise the tests will fail if you don't have the command line tools package installed.

CMake handles doing it while building. I will update to use lit.util.* -Chris > On Oct 11, 2015, at 6:04 PM, Eric Fiselier wrote: > > Do we need to do with while building libc++ as well? Also please reuse > lit.util.capture or lit.util.executeCommand instead of subprocess. > > /Eric > > On S

Re: [libcxx] r250003 - [Darwin] Need to add -isysroot on OS X otherwise the tests will fail if you don't have the command line tools package installed.

Do we need to do with while building libc++ as well? Also please reuse lit.util.capture or lit.util.executeCommand instead of subprocess. /Eric On Sun, Oct 11, 2015 at 6:49 PM, Chris Bieneman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: cbieneman > Date: Sun Oct 11 19:49:56 201

[libcxx] r250003 - [Darwin] Need to add -isysroot on OS X otherwise the tests will fail if you don't have the command line tools package installed.

Author: cbieneman Date: Sun Oct 11 19:49:56 2015 New Revision: 250003 URL: http://llvm.org/viewvc/llvm-project?rev=250003&view=rev Log: [Darwin] Need to add -isysroot on OS X otherwise the tests will fail if you don't have the command line tools package installed. This mirrors how other LLVM sui

Re: [PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

EricWF added a comment. Whats preventing this from landing? @joerg @danalbert Do we want to use "posix_memalign" on Android or not? http://reviews.llvm.org/D12512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

Re: [PATCH] D11740: ABI versioning macros for libc++

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM but this is still blocked by http://reviews.llvm.org/D13407. Ill let you know once that has landed. Comment at: include/__config:251 @@ +250,3 @@ + !defined(__arm__)

Re: [PATCH] D13607: [Fix] Make it an error to take the address of (most) enable_if functions.

george.burgess.iv added inline comments. Comment at: lib/Sema/SemaInit.cpp:4978-4990 @@ -4977,1 +4977,15 @@ +// As an extension, C can have overloaded functions. We need to add the +// address resolution step. +if (Initializer->getType() == Context.OverloadTy) { +

Re: [PATCH] D13607: [Fix] Make it an error to take the address of (most) enable_if functions.

george.burgess.iv updated this revision to Diff 37075. george.burgess.iv marked 2 inline comments as done. george.burgess.iv added a comment. Addressed all feedback by rolling two of our overloading checks into one. http://reviews.llvm.org/D13607 Files: include/clang/Basic/DiagnosticSemaKinds

[PATCH] D13641: clang-format: [JS] handle character classes in regexes.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added subscribers: cfe-commits, klimek. Slashes in regular expressions do not need to be escaped and do not terminate the regular expression even without a preceding backslash. http://reviews.llvm.org/D13641 Files: lib/F

[PATCH] D13640: [clang-tidy] Add new check cppcoreguidelines-pro-bounds-array-to-pointer-decay

mgehre created this revision. mgehre added reviewers: alexfh, sbenza, bkramer, aaron.ballman. mgehre added a subscriber: cfe-commits. This check flags all array to pointer decays. Pointers should not be used as arrays. array_view is a bounds-checked, safe alternative to using pointers to access a

[clang-tools-extra] r250002 - Test commit

Author: mgehre Date: Sun Oct 11 17:55:29 2015 New Revision: 250002 URL: http://llvm.org/viewvc/llvm-project?rev=250002&view=rev Log: Test commit Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp Modified: clang-tools-extra/trunk/clang-tidy/cppco

Re: [PATCH] D13639: Add decayedType and hasDecayedType AST matchers

mgehre updated this revision to Diff 37066. mgehre added a comment. Add test http://reviews.llvm.org/D13639 Files: include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/ASTMatchersTest.cpp Index: unittests/ASTMatchers/ASTMatchersTest.cpp =

[PATCH] D13639: Add decayedType and hasDecayedType AST matchers

mgehre created this revision. mgehre added a reviewer: klimek. mgehre added a subscriber: cfe-commits. Herald added a subscriber: klimek. Add decayedType and hasDecayedType AST matchers http://reviews.llvm.org/D13639 Files: include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Regi

r249997 - Fix warning caused by r249995

Author: gbiv Date: Sun Oct 11 15:37:14 2015 New Revision: 249997 URL: http://llvm.org/viewvc/llvm-project?rev=249997&view=rev Log: Fix warning caused by r249995 Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp URL: http://llvm.org/viewvc/llvm-projec

Re: [PATCH] D13604: Fix to allow C conversions on arguments passed to functions with __attribute__((overloadable)) in C

This revision was automatically updated to reflect the committed changes. Closed by commit rL249995: [Sema] Allow C conversions in C overload logic (authored by gbiv). Changed prior to commit: http://reviews.llvm.org/D13604?vs=36986&id=37062#toc Repository: rL LLVM http://reviews.llvm.org/D

r249995 - [Sema] Allow C conversions in C overload logic

Author: gbiv Date: Sun Oct 11 15:13:20 2015 New Revision: 249995 URL: http://llvm.org/viewvc/llvm-project?rev=249995&view=rev Log: [Sema] Allow C conversions in C overload logic C allows for some implicit conversions that C++ does not, e.g. void* -> char*. This patch teaches clang that these conv

Re: [PATCH] D13344: Keep the IfStmt node even if the condition is invalid

ogoffart abandoned this revision. ogoffart marked an inline comment as done. ogoffart added a comment. commited as r249982. (I forgot to add the link to reviews.llvm.org in the commit message. I'll do it next time) http://reviews.llvm.org/D13344 __

r249982 - Keep the IfStmt node even if the condition is invalid

Author: ogoffart Date: Sun Oct 11 12:27:29 2015 New Revision: 249982 URL: http://llvm.org/viewvc/llvm-project?rev=249982&view=rev Log: Keep the IfStmt node even if the condition is invalid This is important to keep the information in IDE or other tools even if the code contains a few errors Modi

[clang-tools-extra] r249970 - [clang-tidy] Python script for easy check rename

Author: clockman Date: Sun Oct 11 02:58:34 2015 New Revision: 249970 URL: http://llvm.org/viewvc/llvm-project?rev=249970&view=rev Log: [clang-tidy] Python script for easy check rename Summary: Script can rename check that is in same module - I found it useful. Diff generated in root directory of