loladiro removed rL LLVM as the repository for this revision.
loladiro updated this revision to Diff 36459.
loladiro added a comment.
Rebased, added support for unique_instantiation on explicit function templates
and fix the case where one record is embedded in another and the outer is
explicitl
EricWF updated this revision to Diff 36457.
EricWF added a comment.
I removed all non-essential changes in order to make this easy and fast to
review. This patch is blocking a number of people so I would like to have this
reviewed soon.
http://reviews.llvm.org/D13407
Files:
CMakeLists.txt
EricWF created this revision.
EricWF added reviewers: majnemer, rsmith.
EricWF added a subscriber: cfe-commits.
__atomic_load's allows it's first argument to be a pointer to a const type.
However the second argument is an output parameter and must be a pointer to
non-const.
This patch fixes the
Author: ctopper
Date: Sun Oct 4 00:09:13 2015
New Revision: 249260
URL: http://llvm.org/viewvc/llvm-project?rev=249260&view=rev
Log:
Pass SourceRange by value in a test I missed in r249259.
Modified:
cfe/trunk/unittests/ASTMatchers/Dynamic/ParserTest.cpp
Modified: cfe/trunk/unittests/ASTMat
Author: ctopper
Date: Sat Oct 3 23:53:55 2015
New Revision: 249259
URL: http://llvm.org/viewvc/llvm-project?rev=249259&view=rev
Log:
SourceRanges are small and trivially copyable, don't them by reference.
Modified:
cfe/trunk/include/clang/ASTMatchers/Dynamic/Diagnostics.h
cfe/trunk/inclu
Author: ctopper
Date: Sat Oct 3 23:53:37 2015
New Revision: 249258
URL: http://llvm.org/viewvc/llvm-project?rev=249258&view=rev
Log:
SourceRanges are small and trivially copyable, don't them by reference. NFC
Modified:
clang-tools-extra/trunk/clang-modernize/LoopConvert/LoopActions.cpp
c
loladiro created this revision.
loladiro added reviewers: aaron.ballman, rsmith, rnk.
loladiro added a subscriber: cfe-commits.
loladiro set the repository for this revision to rL LLVM.
When we were looking at a template instantiation, that itself was a template
instantiation
(say a templated mem
tejohnson updated this revision to Diff 36453.
tejohnson added a comment.
- Rename code gen option to EmitFunctionSummary as per review for
http://reviews.llvm.org/D13107.
- Clang format the latest changes.
Let me know if it looks good now.
http://reviews.llvm.org/D11908
Files:
include/cl
EricWF abandoned this revision.
EricWF added a comment.
Abandoning. I bit off more that I could chew.
I committed the part @rsmith approved separably as r249252.
http://reviews.llvm.org/D10407
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: ericwf
Date: Sat Oct 3 19:11:02 2015
New Revision: 249252
URL: http://llvm.org/viewvc/llvm-project?rev=249252&view=rev
Log:
Diagnose const atomics in __atomic builtins.
Diagnose when a pointer to const T is used as the first argument in at atomic
builtin unless that builtin is a load ope
Hi Adrian,
So the goal of this patch was to increase the coverage of the test
suite by default.
Previously we used C++11 as the default but this meant that new C++14
and C++1z tests
were never run. The failures you are seeing are all C++14 tests.
We should work on actually fixing the failing tes
Hello Eric,
it looks like this patch broke the lab.llvm.org buildbots (darwin+cmake):
http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA_check/7544/consoleFull#2729576478254eaf0-7326-4999-85b0-388101f2d404
could you please investigate and/or revert the change?
thanks,
Adrian
> On Oct 2,
loladiro added a comment.
Thoughts on allowing this attribute to be specified on the templated class
itself, with the intention of never allowing any implicit instantiation? As an
example, consider SymbolTableListTraits in LLVM. It can only ever be used as an
explicit instantiation (because the
flx updated this revision to Diff 36433.
flx added a comment.
Updated patch to new cxx* matcher variants.
http://reviews.llvm.org/D12839
Files:
clang-tidy/misc/MoveConstructorInitCheck.cpp
clang-tidy/misc/MoveConstructorInitCheck.h
clang-tidy/modernize/PassByValueCheck.cpp
clang-tidy/mo
franchiotta updated the summary for this revision.
franchiotta updated this revision to Diff 36431.
franchiotta added a comment.
Some changes made based on the received suggestions.
http://reviews.llvm.org/D11700
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h
lib/Stat
franchiotta added inline comments.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:444-448
@@ +443,7 @@
+
+ SymbolRef
+ getSymbolFromStmt(const Stmt *S, const LocationContext *LCtx) const;
+
+ const MemRegion*
+ getRegionFromStmt(const Stmt *S, cons
rengolin added inline comments.
Comment at: lib/Basic/Targets.cpp:4456
@@ -4455,3 +4455,1 @@
-if (ArchVersion < 6 ||
- (ArchVersion == 6 && ArchProfile == llvm::ARM::PK_M))
labrinea wrote:
> rengolin wrote:
> > Why is this not necessary any more?
> T
petpav01 added a comment.
It would be probably better if the patch changed the original templates to take
only `__val_expr` as there is now no need for them to match valarray too. This
should be a simple change but requires additional tests so I will wait for
initial feedback that this approach
Author: yrnkrn
Date: Sat Oct 3 05:46:20 2015
New Revision: 249235
URL: http://llvm.org/viewvc/llvm-project?rev=249235&view=rev
Log:
Replace double negation of !FileID.isInvalid() with FileID.isValid().
+couple more of double-negated !SourceLocation.isInvalid() unfixed in r249228.
Modified:
Author: yrnkrn
Date: Sat Oct 3 05:46:20 2015
New Revision: 249235
URL: http://llvm.org/viewvc/llvm-project?rev=249235&view=rev
Log:
Replace double negation of !FileID.isInvalid() with FileID.isValid().
+couple more of double-negated !SourceLocation.isInvalid() unfixed in r249228.
Modified:
EricWF created this revision.
EricWF added reviewers: rsmith, majnemer.
EricWF added subscribers: cfe-commits, mclow.lists.
Currently when a function annotated with __attribute__((nonnull)) is called in
an unevaluated context with a null argument a -Wnonnull warning is emitted.
This warning seem
Author: compnerd
Date: Sat Oct 3 02:15:28 2015
New Revision: 249232
URL: http://llvm.org/viewvc/llvm-project?rev=249232&view=rev
Log:
fix previous commit
Forgot to add the '='. In cl mode, --target must have an '='.
Modified:
cfe/trunk/test/Driver/cl-options.c
Modified: cfe/trunk/test/Dri
22 matches
Mail list logo
