On Sat, Sep 12, 2015, 9:25 PM Aaron Ballman wrote:
> On Sat, Sep 12, 2015 at 8:22 AM, Manuel Klimek wrote:
> >
> >
> > On Fri, Sep 11, 2015 at 10:39 PM Aaron Ballman
> > wrote:
> >>
> >> On Fri, Sep 11, 2015 at 4:30 PM, Richard Smith
> >> wrote:
> >> > I don't think CXXRecordDecl is an anachro
Alexander_Droste updated this revision to Diff 34633.
Alexander_Droste added a comment.
- changed header file extension to .h
- fixed variable naming
- adapted llvm include guard style
- fixed function comments
- included parameter names in function declarations
- fixed namespacing (mpi is now ins
Alexander_Droste marked 14 inline comments as done.
Comment at:
tools/clang/lib/StaticAnalyzer/Checkers/MPI-Checker/Container.hpp:10-11
@@ +9,4 @@
+///
+/// \file
+/// This file defines convenience templates for C++ container class usage.
+///
Alexander_Droste wr
Alexander_Droste updated this revision to Diff 34640.
Alexander_Droste added a comment.
- fixed include guard for MPIBugReporter.h
- capitalized two variable names
http://reviews.llvm.org/D12761
Files:
tools/clang/lib/StaticAnalyzer/Checkers/CMakeLists.txt
tools/clang/lib/StaticAnalyzer/Che
honggyu.kim added a comment.
In http://reviews.llvm.org/D12827#244906, @ayartsev wrote:
> Thanks, Honggyu!
You're welcome, Антон!
http://reviews.llvm.org/D12827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
ayartsev added a comment.
Thanks, Honggyu!
http://reviews.llvm.org/D12827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Would you mind sticking abi-tag.patch in phabricator:
http://llvm.org/docs/Phabricator.html ?
Your patch is big enough that it would make it a little easier for me to
review.
On Sat, Sep 12, 2015 at 7:12 AM, Stefan Bühler via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi all,
>
> I've bee
On Sat, Sep 12, 2015 at 8:22 AM, Manuel Klimek wrote:
>
>
> On Fri, Sep 11, 2015 at 10:39 PM Aaron Ballman
> wrote:
>>
>> On Fri, Sep 11, 2015 at 4:30 PM, Richard Smith
>> wrote:
>> > I don't think CXXRecordDecl is an anachronism, so much as an
>> > implementation
>> > detail; it makes sense to
dcoughlin added a comment.
I looked at the behavior of invalidateRegions() under the patch. It looks like
MemSpaceRegions //are// being added to the worklist but these regions don't
have clusters associated with them so invalidating the regions themselves
doesn't remove any bindings.
Ted: What
Alexander_Droste added inline comments.
Comment at: tools/clang/lib/StaticAnalyzer/Checkers/Checkers.td:524
@@ +523,3 @@
+def MPIChecker : Checker<"MPI-Checker">,
+ HelpText<"Checks MPI code written in C">,
+ DescFile<"MPIChecker.cpp">;
gribozavr wrote:
> Does i
Alexander_Droste added inline comments.
Comment at:
tools/clang/lib/StaticAnalyzer/Checkers/MPI-Checker/Container.hpp:10-11
@@ +9,4 @@
+///
+/// \file
+/// This file defines convenience templates for C++ container class usage.
+///
gribozavr wrote:
> This file re
Hi all,
I've been working on #23529.
The abi tag mangling implemented by gcc is horrible, but I think my
patch covers most of the incompatibilities with gcc5.
There might be some bugs with substitutions, although I have to come up
with a test case for that to see what gcc does...
Test cases com
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Please, commit after the comments are addressed!
Thank you,
Anna.
Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:39
@@ -26,1 +38,3 @@
+// ProgramS
rnk added inline comments.
Comment at: lib/Sema/SemaType.cpp:5876
@@ +5875,3 @@
+
+if (!IsCtorOrDtor) {
+ if (CurCC != DefaultCC || DefaultCC == ToCC)
andreybokhanko wrote:
> rnk wrote:
> > This looks like the !IsCtorOrDtor check that affects Itanium. Isn
andreybokhanko added inline comments.
Comment at: lib/Sema/SemaType.cpp:5876
@@ +5875,3 @@
+
+if (!IsCtorOrDtor) {
+ if (CurCC != DefaultCC || DefaultCC == ToCC)
rnk wrote:
> This looks like the !IsCtorOrDtor check that affects Itanium. Isn't it
> alread
krememek accepted this revision.
krememek added a comment.
This revision is now accepted and ready to land.
Applied in r247510.
http://reviews.llvm.org/D12827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
Author: kremenek
Date: Sat Sep 12 11:01:34 2015
New Revision: 247510
URL: http://llvm.org/viewvc/llvm-project?rev=247510&view=rev
Log:
Use -f instead of -d flag for testing existing of clang executable
(http://reviews.llvm.org/D12827).
Modified:
cfe/trunk/tools/scan-build/scan-build
Modifie
Author: kli
Date: Sat Sep 12 08:35:31 2015
New Revision: 247503
URL: http://llvm.org/viewvc/llvm-project?rev=247503&view=rev
Log:
Test commit.
Modified:
cfe/trunk/lib/Sema/SemaOpenMP.cpp
Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/
On Fri, Sep 11, 2015 at 10:39 PM Aaron Ballman
wrote:
> On Fri, Sep 11, 2015 at 4:30 PM, Richard Smith
> wrote:
> > I don't think CXXRecordDecl is an anachronism, so much as an
> implementation
> > detail; it makes sense to use a smaller class when in C mode, as we don't
> > need most of the fea
Test would be awesome :) Thx!
On Fri, Sep 11, 2015 at 10:44 PM Argyrios Kyrtzidis
wrote:
> In r247468, thanks for reviewing!
>
> On Sep 11, 2015, at 10:24 AM, Manuel Klimek via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> Ok, looked at the original patch again, and if we're fixing the
honggyu.kim updated the summary for this revision.
honggyu.kim updated this revision to Diff 34624.
http://reviews.llvm.org/D12827
Files:
tools/scan-build/scan-build
Index: tools/scan-build/scan-build
===
--- tools/scan-build/scan
honggyu.kim added a comment.
After applying http://reviews.llvm.org/rL247466, I got the following error
which was not shown before.
scan-build: error: Cannot find an executable 'clang' relative to scan-build.
Consider using --use-analyzer to pick a version of 'clang' to use for static
analy
honggyu.kim created this revision.
honggyu.kim added reviewers: ayartsev, zaks.anna, krememek.
honggyu.kim added subscribers: jordan_rose, dcoughlin, cfe-commits.
This patch fixes an error made by rL247466.
It mistakenly wrote "-d" check in if statement with the file name itself not a
directory.
Ping...
Il 29/08/2015 10:01, Abramo Bagnara ha scritto:
> Il 28/08/2015 23:27, Richard Smith ha scritto:
>> On Tue, Aug 25, 2015 at 10:27 AM, Abramo Bagnara
>> mailto:abramo.bagn...@bugseng.com>> wrote:
>>
>> Comparing the result of InitListExpr::getSyntacticForm between r224986
>> and r24
24 matches
Mail list logo
