r247500 - [CodeGen] Remove wrapper-free always_inline functions from COMDATs

Author: majnemer Date: Sat Sep 12 01:37:42 2015 New Revision: 247500 URL: http://llvm.org/viewvc/llvm-project?rev=247500&view=rev Log: [CodeGen] Remove wrapper-free always_inline functions from COMDATs always_inline functions without a wrapper don't need to be in a COMDAT. Modified: cfe/trun

r247498 - Clean up trailing whitespace in the builtin headers

Author: silvas Date: Fri Sep 11 21:55:19 2015 New Revision: 247498 URL: http://llvm.org/viewvc/llvm-project?rev=247498&view=rev Log: Clean up trailing whitespace in the builtin headers Modified: cfe/trunk/lib/Headers/altivec.h cfe/trunk/lib/Headers/ammintrin.h cfe/trunk/lib/Headers/av

Re: [PATCH] D12712: Implementation and testing for poisoning vtable ptr in dtor.

nmusgrave updated this revision to Diff 34617. nmusgrave added a comment. - Poison vtable in either complete or base dtor. http://reviews.llvm.org/D12712 Files: lib/CodeGen/CGClass.cpp test/CodeGenCXX/sanitize-dtor-derived-class.cpp test/CodeGenCXX/sanitize-dtor-vtable.cpp Index: test/Co

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

rsmith added a subscriber: rsmith. Comment at: include/clang/AST/Type.h:1210 @@ +1209,3 @@ +/// Which keyword(s) were used to create an AutoType. +enum struct AutoTypeKeyword : unsigned char { + /// \brief auto Please use `enum class` here; we don't use `enum str

r247496 - clang/test/Driver/stackrealign.c REQUIRES clang-driver.

Author: chapuni Date: Fri Sep 11 20:29:35 2015 New Revision: 247496 URL: http://llvm.org/viewvc/llvm-project?rev=247496&view=rev Log: clang/test/Driver/stackrealign.c REQUIRES clang-driver. GCC driver, for example cygwin, both "-mstackrealign" "-mno-stackrealign" are passed. Modified: cfe/t

Re: [PATCH] D12712: Implementation and testing for poisoning vtable ptr in dtor.

nmusgrave updated this revision to Diff 34614. nmusgrave marked 2 inline comments as done. nmusgrave added a comment. - Fixed testing callback emission order to account for vptr. http://reviews.llvm.org/D12712 Files: lib/CodeGen/CGClass.cpp test/CodeGenCXX/sanitize-dtor-derived-class.cpp

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

vsk added a subscriber: vsk. vsk added a comment. First off, welcome! And thanks for patch. This basically LGTM, but I have one small change I'd like to see (inline comment). Hm, the spec says "The sizeof operator shall not be applied to... an lvalue that designates a bit-field". Sounds like a

Re: [PATCH] D12087: always_inline codegen rewrite

eugenis added a comment. second attempt in r247494 Repository: rL LLVM http://reviews.llvm.org/D12087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r247494 - Always_inline codegen rewrite.

Author: eugenis Date: Fri Sep 11 20:07:37 2015 New Revision: 247494 URL: http://llvm.org/viewvc/llvm-project?rev=247494&view=rev Log: Always_inline codegen rewrite. Current implementation may end up emitting an undefined reference for an "inline __attribute__((always_inline))" function by generat

Re: [PATCH] D12087: always_inline codegen rewrite

Thanks. I just reproduced it on release w/o asserts build and fixed locally. The other problem is fixed as well, I'll try re-landing now. I'll keep an eye on the bot later today and will revert again if necessary. On Fri, Sep 11, 2015 at 6:02 PM, H.J. Lu wrote: > On Fri, Sep 11, 2015 at 4:45 PM,

Re: [PATCH] D12087: always_inline codegen rewrite

On Fri, Sep 11, 2015 at 4:45 PM, Evgenii Stepanov wrote: > Does it say that there is no entry basic block? I.e. the output > apparently looks like > > define void @h() #1 { > store void ()* @f1, void ()** @p, align 8 > > Could you confirm it? Never seen this behavior. > > I'm going to revert the

Re: [PATCH] D12684: [INSTALL.txt] Fix formatting - 80 character line

vsk added a subscriber: vsk. vsk accepted this revision. vsk added a reviewer: vsk. vsk added a comment. This revision is now accepted and ready to land. Thanks, LGTM. http://reviews.llvm.org/D12684 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: [PATCH] D12087: always_inline codegen rewrite

eugenis added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:543 @@ +542,3 @@ + if (Fn->isUsedByMetadata()) +llvm::ValueAsMetadata::handleRAUW(Fn, StubFn); +} As the comment says. W/o this, the debug info for .alwaysinline instructions is attached

Re: [PATCH] D12087: always_inline codegen rewrite

eugenis updated this revision to Diff 34610. eugenis added a comment. Fixed the debug info problem. Repository: rL LLVM http://reviews.llvm.org/D12087 Files: lib/CodeGen/CGCXX.cpp lib/CodeGen/CGClass.cpp lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CodeGenModule.cpp lib/CodeGen/Code

Re: [PATCH] D12251: Analyzer: Calculate field offset correctly

ismailp added a comment. Ping! http://reviews.llvm.org/D12251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12381: [Static Analyzer] Merge the Objective-C Generics Checker into Dynamic Type Propagation checker.

xazax.hun updated this revision to Diff 34606. xazax.hun added a comment. - Rebased on the top of latest trunk (which contains patch #1 and patch #2 from my previous comments) http://reviews.llvm.org/D12381 Files: lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/Check

r247491 - Revert "Specify target triple in alwaysinline tests."

Author: eugenis Date: Fri Sep 11 18:48:37 2015 New Revision: 247491 URL: http://llvm.org/viewvc/llvm-project?rev=247491&view=rev Log: Revert "Specify target triple in alwaysinline tests." Revert "Always_inline codegen rewrite." Breaks gdb & lldb tests. Breaks on Fedora 22 x86_64. Removed: cf

Re: [PATCH] D12821: Allow for C's "writing off the end" idiom in __builtin_object_size

rsmith added inline comments. Comment at: lib/AST/ExprConstant.cpp:165 @@ -159,1 +164,3 @@ +/// Indicator of whether the most-derived object is an array. +bool MostDerivedIsArrayElement : 1; array -> array element. Comment at: lib/AST/E

Re: [PATCH] D12087: always_inline codegen rewrite

Does it say that there is no entry basic block? I.e. the output apparently looks like define void @h() #1 { store void ()* @f1, void ()** @p, align 8 Could you confirm it? Never seen this behavior. I'm going to revert the change due to this and also one broken gdb test (something wrong with de

Re: r246877 - Increase accuracy of __builtin_object_size.

Proposed fix: http://reviews.llvm.org/D12821 On Fri, Sep 11, 2015 at 1:44 PM, George Burgess IV < george.burgess...@gmail.com> wrote: > > It might be reasonable for __builtin_object_size(..., 2) to give up if > [...] > > That sounds like the best overall solution to me, as well. Working on a > fi

[PATCH] D12821: Allow for C's "writing off the end" idiom in __builtin_object_size

george.burgess.iv created this revision. george.burgess.iv added a reviewer: rsmith. george.burgess.iv added subscribers: cfe-commits, mzolotukhin. In C, a common idiom is: ``` struct Foo { int a; char cs[1] }; struct Foo *F = (struct Foo *)malloc(sizeof(Foo) + strlen(SomeString)); strcpy(F->cs,

Re: [PATCH] D12087: always_inline codegen rewrite

On Fri, Sep 11, 2015 at 1:31 PM, Evgeniy Stepanov via cfe-commits wrote: > eugenis closed this revision. > eugenis added a comment. > > r247465, thanks for the review! > On Fedora 22/x86-64, I got FAIL: Clang :: CodeGen/always_inline.c (3049 of 26132) TEST 'Clang :: CodeGen/

Re: [PATCH] D12780: [analyzer] Add generateErrorNode() APIs to CheckerContext

zaks.anna added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:321 @@ +320,3 @@ +// sink, we assume that a client requesting a transition to a state that is +// the same as the predecessor state has made a mistake. We return t

Re: [PATCH] D12780: [analyzer] Add generateErrorNode() APIs to CheckerContext

dcoughlin marked 3 inline comments as done. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:229 @@ -228,2 +228,3 @@ + /// checkers should use generateErrorNode() instead. ExplodedNode *generateSink(ProgramStateRef State = nullptr,

[clang-tools-extra] r247489 - [clang-tidy] misc-sizeof-container: whitelist std::bitset<>.

Author: alexfh Date: Fri Sep 11 17:54:44 2015 New Revision: 247489 URL: http://llvm.org/viewvc/llvm-project?rev=247489&view=rev Log: [clang-tidy] misc-sizeof-container: whitelist std::bitset<>. It's fine to use sizeof on std::bitset<>, since it doesn't have any external storage, everything's insi

r247488 - Add new test file missing from r247486.

Author: rsmith Date: Fri Sep 11 17:54:01 2015 New Revision: 247488 URL: http://llvm.org/viewvc/llvm-project?rev=247488&view=rev Log: Add new test file missing from r247486. Added: cfe/trunk/test/Modules/Inputs/template-default-args/d.h Added: cfe/trunk/test/Modules/Inputs/template-default-ar

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

gribozavr added inline comments. Comment at: tools/clang/lib/StaticAnalyzer/Checkers/Checkers.td:524 @@ +523,3 @@ +def MPIChecker : Checker<"MPI-Checker">, + HelpText<"Checks MPI code written in C">, + DescFile<"MPIChecker.cpp">; Does it only works with C code,

r247486 - [modules] When picking one of two template declarations as a lookup result,

Author: rsmith Date: Fri Sep 11 17:39:35 2015 New Revision: 247486 URL: http://llvm.org/viewvc/llvm-project?rev=247486&view=rev Log: [modules] When picking one of two template declarations as a lookup result, it's not sufficient to prefer the declaration with more default arguments, or the one tha

[clang-tools-extra] r247485 - [clang-tidy] Fix minor issues in the testing script.

Author: alexfh Date: Fri Sep 11 17:38:26 2015 New Revision: 247485 URL: http://llvm.org/viewvc/llvm-project?rev=247485&view=rev Log: [clang-tidy] Fix minor issues in the testing script. Modified: clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy.py Modified: clang-tools-extra/trunk/te

Re: [PATCH] D12759: [clang-tidy] Add misc-sizeof-container check to find sizeof() uses on stlcontainers.

Indeed. But this has been fixed before I could get to it. On Thu, Sep 10, 2015 at 10:47 PM, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > aaron.ballman added a comment. > > This appears to have broken one of the bots: > > http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/

r247482 - When comparing two block captures for layout, don't crash

Author: rjmccall Date: Fri Sep 11 17:00:51 2015 New Revision: 247482 URL: http://llvm.org/viewvc/llvm-project?rev=247482&view=rev Log: When comparing two block captures for layout, don't crash if they have the same alignment and one was 'this'. Fixes PR24780. Modified: cfe/trunk/lib/CodeGen/

r247477 - Let selector-expr-lvalue.mm actually test something.

Author: nico Date: Fri Sep 11 16:24:40 2015 New Revision: 247477 URL: http://llvm.org/viewvc/llvm-project?rev=247477&view=rev Log: Let selector-expr-lvalue.mm actually test something. I accidentally introduced a bug locally, and noticed that none of the tests caught it. No longer! Modified:

r247476 - [Static Analyzer] Properly cash the configuration option for lambda support.

Author: xazax Date: Fri Sep 11 16:19:39 2015 New Revision: 247476 URL: http://llvm.org/viewvc/llvm-project?rev=247476&view=rev Log: [Static Analyzer] Properly cash the configuration option for lambda support. Modified: cfe/trunk/lib/StaticAnalyzer/Core/AnalyzerOptions.cpp Modified: cfe/trun

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

zhengkai updated the summary for this revision. zhengkai updated this revision to Diff 34588. http://reviews.llvm.org/D12379 Files: include/clang/Basic/SourceManager.h lib/Basic/SourceManager.cpp lib/Frontend/DiagnosticRenderer.cpp test/Index/fix-its.m test/Misc/caret-diags-macros.c t

r247474 - [Shave]: pass -isystem dirs and "-Wa," args to moviAsm

Author: dougk Date: Fri Sep 11 16:13:46 2015 New Revision: 247474 URL: http://llvm.org/viewvc/llvm-project?rev=247474&view=rev Log: [Shave]: pass -isystem dirs and "-Wa," args to moviAsm Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/shave-toolchain.c Modified: cfe/trunk/

r247473 - Specify target triple in alwaysinline tests.

Author: eugenis Date: Fri Sep 11 16:10:12 2015 New Revision: 247473 URL: http://llvm.org/viewvc/llvm-project?rev=247473&view=rev Log: Specify target triple in alwaysinline tests. This should fix the tests on Windows (failing due to mangling differencies). Modified: cfe/trunk/test/CodeGen/alw

Re: r247464 - [MS ABI] Select an inheritance model in template arguments

On Fri, Sep 11, 2015 at 1:23 PM, Richard Smith wrote: > On Fri, Sep 11, 2015 at 1:18 PM, David Majnemer via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: majnemer >> Date: Fri Sep 11 15:18:09 2015 >> New Revision: 247464 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=247464&

r247472 - Simplify logic introduced in r247464.

Author: majnemer Date: Fri Sep 11 15:55:29 2015 New Revision: 247472 URL: http://llvm.org/viewvc/llvm-project?rev=247472&view=rev Log: Simplify logic introduced in r247464. Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp URL: http://llvm.org/viewv

[PATCH] D12818: [Static Analyzer] Relaxing a caching out related assert.

xazax.hun created this revision. xazax.hun added reviewers: zaks.anna, dcoughlin, jordan_rose, krememek. xazax.hun added a subscriber: cfe-commits. During the development of the nullability checkers I hit this assert several times. However it is very hard to reproduce it with a minimal example, a

[PATCH] D12817: [CMake] Add cache scripts for Apple-style clang builds.

beanz created this revision. beanz added reviewers: chandlerc, echristo. beanz added a subscriber: cfe-commits. These CMake cache scripts are my first pass at replicating Apple's packaging logic from autoconf. They can be used on any Darwin machine to approximate an Apple Clang build. The inclu

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

ayartsev updated this revision to Diff 34583. ayartsev added a comment. Updated the patch after r246978. Please review! http://reviews.llvm.org/D9040 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/malloc.c Index: test/Analysis/malloc.c ==

Re: r246877 - Increase accuracy of __builtin_object_size.

> It might be reasonable for __builtin_object_size(..., 2) to give up if [...] That sounds like the best overall solution to me, as well. Working on a fix now. On Fri, Sep 11, 2015 at 1:22 PM, Richard Smith wrote: > On Fri, Sep 11, 2015 at 12:15 PM, Mikhail Zolotukhin via cfe-commits < > cfe-co

Re: PATCH: Expose the 'file' that is associated with a compile database command

In r247468, thanks for reviewing! > On Sep 11, 2015, at 10:24 AM, Manuel Klimek via cfe-commits > wrote: > > Ok, looked at the original patch again, and if we're fixing the > FixedCompilationDatabase to only insert the file when it actually produces a > CompileCommand it seems to be fine. >

r247468 - [tooling] In CompileCommand, Expose the 'file' that was associated with the command.

Author: akirtzidis Date: Fri Sep 11 15:43:05 2015 New Revision: 247468 URL: http://llvm.org/viewvc/llvm-project?rev=247468&view=rev Log: [tooling] In CompileCommand, Expose the 'file' that was associated with the command. Modified: cfe/trunk/include/clang-c/CXCompilationDatabase.h cfe/tr

r247467 - [CMake] [Darwin] Add support for building bootstrap builds with -flto

Author: cbieneman Date: Fri Sep 11 15:42:57 2015 New Revision: 247467 URL: http://llvm.org/viewvc/llvm-project?rev=247467&view=rev Log: [CMake] [Darwin] Add support for building bootstrap builds with -flto When building with LTO the bootstrap builds need to depend on libLTO, llvm-ar, and llvm-ra

r247466 - [analyzer] Improve behavior if Clang not found.

Author: ayartsev Date: Fri Sep 11 15:41:09 2015 New Revision: 247466 URL: http://llvm.org/viewvc/llvm-project?rev=247466&view=rev Log: [analyzer] Improve behavior if Clang not found. - Eliminate 'No such file or directory at scan-build line ...' error if '$RealBin/bin/clang' or '$RealBin/clang'

Re: recordDecl() AST matcher

On Fri, Sep 11, 2015 at 4:30 PM, Richard Smith wrote: > I don't think CXXRecordDecl is an anachronism, so much as an implementation > detail; it makes sense to use a smaller class when in C mode, as we don't > need most of the features and complexity that CXXRecordDecl brings with it. > But... as

Re: [PATCH] D12406: [Analyzer] Add -analyzer-config option for function size the inliner considers as large

krememek added a comment. LGTM as well. Thanks Sean. Repository: rL LLVM http://reviews.llvm.org/D12406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12780: [analyzer] Add generateErrorNode() APIs to CheckerContext

zaks.anna added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:244 @@ +243,3 @@ + const ProgramPointTag *Tag = nullptr) { +return generateSink(State, /*Pred=*/nullptr, + (Tag

Re: [PATCH] D12087: always_inline codegen rewrite

eugenis closed this revision. eugenis added a comment. r247465, thanks for the review! Repository: rL LLVM http://reviews.llvm.org/D12087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: recordDecl() AST matcher

I don't think CXXRecordDecl is an anachronism, so much as an implementation detail; it makes sense to use a smaller class when in C mode, as we don't need most of the features and complexity that CXXRecordDecl brings with it. But... as a user of clang matchers, I don't think I'd want to care about

r247465 - Always_inline codegen rewrite.

Author: eugenis Date: Fri Sep 11 15:29:07 2015 New Revision: 247465 URL: http://llvm.org/viewvc/llvm-project?rev=247465&view=rev Log: Always_inline codegen rewrite. Current implementation may end up emitting an undefined reference for an "inline __attribute__((always_inline))" function by generat

Re: [PATCH] D12087: always_inline codegen rewrite

eugenis updated this revision to Diff 34578. eugenis added a comment. rebase, fix a merge conflict Repository: rL LLVM http://reviews.llvm.org/D12087 Files: lib/CodeGen/CGCXX.cpp lib/CodeGen/CGClass.cpp lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeG

Re: r247346 - [MS ABI] Make member pointers return true for isIncompleteType

On Fri, Sep 11, 2015 at 1:16 PM, Richard Smith wrote: > On Fri, Sep 11, 2015 at 12:46 PM, David Majnemer via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Reduced it a bit: >> template >> void JSMethod(); >> class A { >> int printd(int); >> void printd(); >> }; >> void A::printd()

Re: r247464 - [MS ABI] Select an inheritance model in template arguments

On Fri, Sep 11, 2015 at 1:18 PM, David Majnemer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: majnemer > Date: Fri Sep 11 15:18:09 2015 > New Revision: 247464 > > URL: http://llvm.org/viewvc/llvm-project?rev=247464&view=rev > Log: > [MS ABI] Select an inheritance model in template

Re: r246877 - Increase accuracy of __builtin_object_size.

On Fri, Sep 11, 2015 at 12:15 PM, Mikhail Zolotukhin via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi George, > > After this commit we started to trap on the following case: > > #include > typedef struct { > int n; > char key[1]; > } obj_t; > > char *str = "hello"; > > int main() { >

r247464 - [MS ABI] Select an inheritance model in template arguments

Author: majnemer Date: Fri Sep 11 15:18:09 2015 New Revision: 247464 URL: http://llvm.org/viewvc/llvm-project?rev=247464&view=rev Log: [MS ABI] Select an inheritance model in template arguments We used to only select an inheritance model if the pointer to member was nullptr. Instead, select a mo

Re: r247346 - [MS ABI] Make member pointers return true for isIncompleteType

On Fri, Sep 11, 2015 at 12:46 PM, David Majnemer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Reduced it a bit: > template > void JSMethod(); > class A { > int printd(int); > void printd(); > }; > void A::printd() { JSMethod(); } > > This test case will crash clang at the revision b

Re: [PATCH] D12406: [Analyzer] Add -analyzer-config option for function size the inliner considers as large

This revision was automatically updated to reflect the committed changes. Closed by commit rL247463: [analyzer] Add -analyzer-config option for function size the inliner… (authored by dcoughlin). Changed prior to commit: http://reviews.llvm.org/D12406?vs=34196&id=34574#toc Repository: rL LLV

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

rjmccall added a comment. In http://reviews.llvm.org/D12743#244375, @vsk wrote: > Ah, ok. We have some objective-c++ code which calls into a boost routine > which throws an exception. That results in an undefined reference to > ___objc_personality_v0, because the boost library we linked against

r247463 - [analyzer] Add -analyzer-config option for function size the inliner considers as large

Author: dcoughlin Date: Fri Sep 11 15:14:05 2015 New Revision: 247463 URL: http://llvm.org/viewvc/llvm-project?rev=247463&view=rev Log: [analyzer] Add -analyzer-config option for function size the inliner considers as large Add an option (-analyzer-config min-blocks-for-inline-large=14) to contr

Re: [PATCH] D10018: C11 _Bool bitfield diagnostic

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks great, please go ahead. Sorry it's taken so long to get this reviewed. http://reviews.llvm.org/D10018 ___ cfe-commits mailing list cfe-comm

r247462 - [Edit] Fix issue with tracking what macro argument inputs have been edited.

Author: akirtzidis Date: Fri Sep 11 15:09:11 2015 New Revision: 247462 URL: http://llvm.org/viewvc/llvm-project?rev=247462&view=rev Log: [Edit] Fix issue with tracking what macro argument inputs have been edited. This was not working correctly, leading to erroneously rejecting valid edits. Modif

Re: [PATCH] D10018: C11 _Bool bitfield diagnostic

rcraik marked 3 inline comments as done. rcraik added a comment. http://reviews.llvm.org/D10018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10018: C11 _Bool bitfield diagnostic

rcraik updated the summary for this revision. rcraik updated this revision to Diff 34571. rcraik added a comment. switched to using getIntWidth instead of getTypeSize and updated the error and warning messages accordingly, as have the necessary test cases. The separate check for _Bool bitfields

Re: r247447 - Remove a redundant check from CGDebugInfo::shouldOmitDefinition() (NFC).

On Fri, Sep 11, 2015 at 11:54 AM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Fri Sep 11 13:54:28 2015 > New Revision: 247447 > > URL: http://llvm.org/viewvc/llvm-project?rev=247447&view=rev > Log: > Remove a redundant check from CGDebugInfo::shouldO

Re: r247432 - Module Debugging: Emit forward declarations for types that are defined in

On Fri, Sep 11, 2015 at 11:55 AM, Adrian Prantl wrote: > > On Sep 11, 2015, at 11:21 AM, David Blaikie wrote: > > > > On Fri, Sep 11, 2015 at 10:23 AM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: adrian >> Date: Fri Sep 11 12:23:08 2015 >> New Revision: 2474

Re: r247346 - [MS ABI] Make member pointers return true for isIncompleteType

Reduced it a bit: template void JSMethod(); class A { int printd(int); void printd(); }; void A::printd() { JSMethod(); } This test case will crash clang at the revision before this commit which means that something more mysterious/horrific is going on... On Fri, Sep 11, 2015 at 11:10 AM, Da

Re: [PATCH] D12780: [analyzer] Add generateErrorNode() APIs to CheckerContext

jordan_rose added inline comments. Comment at: lib/StaticAnalyzer/Checkers/FixedAddressChecker.cpp:53 @@ -52,3 +52,3 @@ - if (ExplodedNode *N = C.addTransition()) { + if (ExplodedNode *N = C.generateNonFatalErrorNode()) { if (!BT) zaks.anna wrote: > Can t

Re: r246877 - Increase accuracy of __builtin_object_size.

Hi George, After this commit we started to trap on the following case: #include typedef struct { int n; char key[1]; } obj_t; char *str = "hello"; int main() { obj_t* p = (obj_t*)malloc(strlen(str) + 1 + sizeof(int)); strcpy(p->key, str); free(p); return 0; } As far as I understan

Re: [PATCH] D12780: [analyzer] Add generateErrorNode() APIs to CheckerContext

xazax.hun added a comment. In general I like this change, the node handling of the checkers are more readable and reflects the intent in a clearer way. I have some comments inline. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:244 @@ +243,3 @@ +

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

This revision was automatically updated to reflect the committed changes. Closed by commit rL247451: Record function attribute "stackrealign" instead of using backend option (authored by ahatanak). Changed prior to commit: http://reviews.llvm.org/D11815?vs=33456&id=34569#toc Repository: rL L

r247451 - Record function attribute "stackrealign" instead of using backend option

Author: ahatanak Date: Fri Sep 11 13:55:09 2015 New Revision: 247451 URL: http://llvm.org/viewvc/llvm-project?rev=247451&view=rev Log: Record function attribute "stackrealign" instead of using backend option -force-align-stack. Also, make changes to the driver so that -mno-stack-realign is no lon

r247449 - Fix a typo and make this test stricter.

Author: adrian Date: Fri Sep 11 13:54:34 2015 New Revision: 247449 URL: http://llvm.org/viewvc/llvm-project?rev=247449&view=rev Log: Fix a typo and make this test stricter. Modified: cfe/trunk/test/Modules/ExtDebugInfo.m Modified: cfe/trunk/test/Modules/ExtDebugInfo.m URL: http://llvm.org/v

r247448 - Remove an unnecessary check. NFC

Author: adrian Date: Fri Sep 11 13:54:31 2015 New Revision: 247448 URL: http://llvm.org/viewvc/llvm-project?rev=247448&view=rev Log: Remove an unnecessary check. NFC Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL: http://llvm.org/viewvc/l

Re: r247432 - Module Debugging: Emit forward declarations for types that are defined in

> On Sep 11, 2015, at 11:21 AM, David Blaikie wrote: > > > > On Fri, Sep 11, 2015 at 10:23 AM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: adrian > Date: Fri Sep 11 12:23:08 2015 > New Revision: 247432 > > URL: http://llvm.org/viewvc/llvm-project?rev=

r247447 - Remove a redundant check from CGDebugInfo::shouldOmitDefinition() (NFC).

Author: adrian Date: Fri Sep 11 13:54:28 2015 New Revision: 247447 URL: http://llvm.org/viewvc/llvm-project?rev=247447&view=rev Log: Remove a redundant check from CGDebugInfo::shouldOmitDefinition() (NFC). Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebu

r247445 - Cleanup: Get rid of a bunch of unnecessary invocations of internString()

Author: adrian Date: Fri Sep 11 13:45:02 2015 New Revision: 247445 URL: http://llvm.org/viewvc/llvm-project?rev=247445&view=rev Log: Cleanup: Get rid of a bunch of unnecessary invocations of internString() in CGDebugInfo.cpp: MDString::get() copies its arguments. Modified: cfe/trunk/lib/CodeG

r247444 - [Static Analyzer] Fixed a typo in a diagnostic message.

Author: xazax Date: Fri Sep 11 13:41:50 2015 New Revision: 247444 URL: http://llvm.org/viewvc/llvm-project?rev=247444&view=rev Log: [Static Analyzer] Fixed a typo in a diagnostic message. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp Modified: cfe/trunk/lib/StaticAna

Re: [PATCH] D12807: Display name of identifier tokens in Visual Studio native visualizer

mspertus added a comment. Thanks, Aaron! Hal mentioned that I might need to ask you to commit on my behalf as I don't have commit access as of now. http://reviews.llvm.org/D12807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

Re: [PATCH] D12807: Display name of identifier tokens in Visual Studio native visualizer

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in r247442, thank you for the patch! http://reviews.llvm.org/D12807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

r247442 - Extend the Token visualizer used by MSVC to display the identifier text for tok::identifier tokens.

Author: aaronballman Date: Fri Sep 11 13:35:18 2015 New Revision: 247442 URL: http://llvm.org/viewvc/llvm-project?rev=247442&view=rev Log: Extend the Token visualizer used by MSVC to display the identifier text for tok::identifier tokens. Patch by Mike Spertus. Modified: cfe/trunk/utils/cla

Re: r247432 - Module Debugging: Emit forward declarations for types that are defined in

On Fri, Sep 11, 2015 at 10:23 AM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Fri Sep 11 12:23:08 2015 > New Revision: 247432 > > URL: http://llvm.org/viewvc/llvm-project?rev=247432&view=rev > Log: > Module Debugging: Emit forward declarations for ty

Re: [PATCH] D12807: Display name of identifier tokens in Visual Studio native visualizer

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank for you this (I think it's going to help me out quite a bit)! http://r

[PATCH] D12807: Display name of identifier tokens in Visual Studio native visualizer

mspertus created this revision. mspertus added a subscriber: cfe-commits. The Token visualizer in clang.natvis makes debugging Clang in Visual Studio much easier for keywords (because a given keyword is always the same), but it doesn't work very well for identifiers (because they are all differe

Re: r247346 - [MS ABI] Make member pointers return true for isIncompleteType

Taking a look, would appreciate it if we didn't revert this until I give it a fair shot. Shouldn't take too long. On Fri, Sep 11, 2015 at 10:58 AM, Hans Wennborg wrote: > This made the Chromium build sad. For example: > > http://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/3092

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

vsk added a comment. Ah, ok. We have some objective-c++ code which calls into a boost routine which throws an exception. That results in an undefined reference to ___objc_personality_v0, because the boost library we linked against doesn't have ___objc_personality_v0. Should the compiler have f

Re: r247346 - [MS ABI] Make member pointers return true for isIncompleteType

This made the Chromium build sad. For example: http://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/3092/steps/compile/logs/stdio Reduction: $ clang -cc1 -triple i686-pc-windows-msvc18.0.0 -w -fms-extensions -fms-compatibility -fms-compatibility-version=18.0 -std=c++11 -fdelayed-t

r247438 - Use Itanium C++ ABI triple for new modules+debug test

Author: rnk Date: Fri Sep 11 12:50:14 2015 New Revision: 247438 URL: http://llvm.org/viewvc/llvm-project?rev=247438&view=rev Log: Use Itanium C++ ABI triple for new modules+debug test Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp URL: ht

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

rnk added a comment. Right, I understand the behavior change, I'm just wondering why it results in link failures. There isn't a ton of public info about how ObjC++ EH interacts with C++ EH. Repository: rL LLVM http://reviews.llvm.org/D12743 ___

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

vsk marked an inline comment as done. vsk added a comment. Addressed Reid's comment w.r.t exception object type. Repository: rL LLVM http://reviews.llvm.org/D12743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

This revision was automatically updated to reflect the committed changes. Closed by commit rL247437: [test] Specify exception object type in two tests (authored by vedantk). Changed prior to commit: http://reviews.llvm.org/D12743?vs=34408&id=34560#toc Repository: rL LLVM http://reviews.llvm

r247437 - [test] Specify exception object type in two tests

Author: vedantk Date: Fri Sep 11 12:39:34 2015 New Revision: 247437 URL: http://llvm.org/viewvc/llvm-project?rev=247437&view=rev Log: [test] Specify exception object type in two tests Replace: 'try { throw 0; } catch (...)' with 'try { throw 0; } catch (int e)' in two test cases. Differ

r247436 - [CMake] Making the bootstrap-clear target always delete the boostrap build directories.

Author: cbieneman Date: Fri Sep 11 12:38:38 2015 New Revision: 247436 URL: http://llvm.org/viewvc/llvm-project?rev=247436&view=rev Log: [CMake] Making the bootstrap-clear target always delete the boostrap build directories. Modified: cfe/trunk/CMakeLists.txt Modified: cfe/trunk/CMakeLists.t

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

vsk added a comment. I think 'optimization' is a bit of a misnomer. There's a comment in this code that reads: "Can't do the optimization if it has non-C++ uses", so that's why I picked up the word. Without SimplifyPersonality(), some objective c++ code can no longer link against c++ libraries.

r247434 - Update test expectations for LLVM asm printing change

Author: rnk Date: Fri Sep 11 12:27:53 2015 New Revision: 247434 URL: http://llvm.org/viewvc/llvm-project?rev=247434&view=rev Log: Update test expectations for LLVM asm printing change Modified: cfe/trunk/test/CodeGen/exceptions-seh-new.c Modified: cfe/trunk/test/CodeGen/exceptions-seh-new.c

Re: r247369 - Module Debugging: Emit forward declarations for types that are defined in

> On Sep 11, 2015, at 8:27 AM, David Blaikie wrote: > > > > On Fri, Sep 11, 2015 at 8:18 AM, Adrian Prantl > wrote: > >> On Sep 10, 2015, at 6:56 PM, David Blaikie > > wrote: >> >> >> >> On Thu, Sep 10, 2015 at 6:40 PM, David Blaikie >

r247431 - Revert "Module Debugging: Emit forward declarations for types that are defined in"

Author: adrian Date: Fri Sep 11 12:23:03 2015 New Revision: 247431 URL: http://llvm.org/viewvc/llvm-project?rev=247431&view=rev Log: Revert "Module Debugging: Emit forward declarations for types that are defined in" This reverts commit r247369 to facilitate reviewing of the following patch. Rem

Re: PATCH: Expose the 'file' that is associated with a compile database command

Ok, looked at the original patch again, and if we're fixing the FixedCompilationDatabase to only insert the file when it actually produces a CompileCommand it seems to be fine. On Fri, Sep 11, 2015 at 6:32 PM Argyrios Kyrtzidis wrote: > On Sep 11, 2015, at 12:21 AM, Manuel Klimek wrote: > > On

r247432 - Module Debugging: Emit forward declarations for types that are defined in

Author: adrian Date: Fri Sep 11 12:23:08 2015 New Revision: 247432 URL: http://llvm.org/viewvc/llvm-project?rev=247432&view=rev Log: Module Debugging: Emit forward declarations for types that are defined in clang modules, if -dwarf-ext-refs (DebugTypesExtRefs) is specified. This reimplements r247

  1   2   >