EricWF created this revision.
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: cfe-commits.
This patch optimizes basic_string::compare to use strcmp when the default
char_traits has been given.
See PR19900 for more information. https://llvm.org/bugs/show_bug.cgi?id=19900
http://r
ABataev updated this revision to Diff 33181.
ABataev marked 7 inline comments as done.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D10599
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticParseKinds.td
include/clang
ABataev marked 7 inline comments as done.
ABataev added a comment.
Richard, thanks for the review!
Comment at: include/clang/Basic/Attr.td:2074-2078
@@ +2073,7 @@
+ let Documentation = [OMPDeclareSimdDocs];
+ let AdditionalMembers = [{
+ void printPrettyPragma(raw_ostream &OS
EricWF updated this revision to Diff 33180.
EricWF added a comment.
Cleanup the diff and remove extra changes.
http://reviews.llvm.org/D12354
Files:
include/__debug
include/algorithm
test/libcxx/algorithms/debug_less.pass.cpp
test/support/debug_mode.h
Index: test/support/debug_mode.h
=
EricWF updated this revision to Diff 33179.
EricWF added a comment.
Remove all functions in the dylib and make them inline.
http://reviews.llvm.org/D12354
Files:
include/__debug
include/algorithm
include/regex
src/debug.cpp
test/libcxx/algorithms/debug_less.pass.cpp
test/support/deb
Author: majnemer
Date: Wed Aug 26 00:13:19 2015
New Revision: 246014
URL: http://llvm.org/viewvc/llvm-project?rev=246014&view=rev
Log:
[Sema] Don't assume CallExpr::getDirectCallee will succeed
We tried to provide a very nice diagnostic when diagnosing an assignment
to a const int & produced by a
EricWF created this revision.
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: cfe-commits.
This patch adds a global assertion handler that is called when _LIBCPP_ASSERT
fails. This allows us to test debug mode features without _LIBCPP_ASSERT always
calling `abort()`.
This patch
Author: echristo
Date: Tue Aug 25 23:23:11 2015
New Revision: 246006
URL: http://llvm.org/viewvc/llvm-project?rev=246006&view=rev
Log:
Update file comment to more accurately describe what's implemented.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
URL:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246005: Modify DeclaratorChuck::getFunction to be passed an
Exception Specification… (authored by nwilson).
Changed prior to commit:
http://reviews.llvm.org/D11789?vs=33093&id=33177#toc
Repository:
r
Author: nwilson
Date: Tue Aug 25 23:19:36 2015
New Revision: 246005
URL: http://llvm.org/viewvc/llvm-project?rev=246005&view=rev
Log:
Modify DeclaratorChuck::getFunction to be passed an Exception Specification
SourceRange
Summary:
- Store the exception specification range's begin and end SourceL
pcc updated this revision to Diff 33175.
pcc added a comment.
- Add apology for lack of documentation
http://reviews.llvm.org/D11857
Files:
docs/ControlFlowIntegrity.rst
docs/ControlFlowIntegrityDesign.rst
include/clang/AST/Mangle.h
include/clang/Basic/Sanitizers.def
lib/AST/ItaniumMa
Author: kremenek
Date: Tue Aug 25 22:11:31 2015
New Revision: 246003
URL: http://llvm.org/viewvc/llvm-project?rev=246003&view=rev
Log:
Add missing newline.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp
Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/LocalizationChec
EricWF added a comment.
Ping @mclow.lists. This is one of the first patches I submitted but I abandoned
it due to ABI concerns. However I now believe that this patch does not break
the ABI.
http://reviews.llvm.org/D4447
___
cfe-commits mailing lis
george.burgess.iv created this revision.
george.burgess.iv added a reviewer: rsmith.
george.burgess.iv added a subscriber: cfe-commits.
Modify clang to emit `@llvm.objectsize(i8*, i8)` instead of
`@llvm.objectsize(i8*, i1)`
Accompanying LLVM patch: http://reviews.llvm.org/D12351
http://reviews.
rsmith added inline comments.
Comment at: include/clang/Basic/Attr.td:2074-2078
@@ +2073,7 @@
+ let Documentation = [OMPDeclareSimdDocs];
+ let AdditionalMembers = [{
+ void printPrettyPragma(raw_ostream &OS, const PrintingPolicy &Policy) const {
+OS << "\n";
+ }
+ }];
+}
dcoughlin added a comment.
Thanks for adding handling of the symbolic cases! Some more comments inline.
Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:825
@@ -816,1 +824,3 @@
+ProgramStateRef CStringChecker::IsFirstBufInBound(CheckerContext &C,
+
vsk added a comment.
Yep, this looks fine. Out of curiosity, what happens if we permit the MachO +
!useAAPCS + FloatABI=hard case?
http://reviews.llvm.org/D12344
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Author: ab
Date: Tue Aug 25 18:42:55 2015
New Revision: 245992
URL: http://llvm.org/viewvc/llvm-project?rev=245992&view=rev
Log:
[Headers] Require x86-registered for r245987 codegen tests.
Modified:
cfe/trunk/test/CodeGen/avx2-builtins.c
Modified: cfe/trunk/test/CodeGen/avx2-builtins.c
URL:
xazax.hun updated this revision to Diff 33151.
xazax.hun marked 30 inline comments as done.
xazax.hun added a comment.
Addressed the comments.
Added some more tests.
Added a design document.
http://reviews.llvm.org/D11468
Files:
docs/analyzer/nullability.rst
lib/StaticAnalyzer/Checkers/CMak
ab added a comment.
Thanks Simon! Replaced the FIXMEs with proper tests and committed.
Whenever I have time I'll have a look at the others, filed PR24580.
Repository:
rL LLVM
http://reviews.llvm.org/D12212
___
cfe-commits mailing list
cfe-commi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245987: [Headers][X86] Add -O0 assembly tests for avx2
intrinsics. (authored by ab).
Changed prior to commit:
http://reviews.llvm.org/D12212?vs=32732&id=33147#toc
Repository:
rL LLVM
http://reviews.
Author: ab
Date: Tue Aug 25 18:09:05 2015
New Revision: 245987
URL: http://llvm.org/viewvc/llvm-project?rev=245987&view=rev
Log:
[Headers][X86] Add -O0 assembly tests for avx2 intrinsics.
We agreed for r245605 that, as long as we don't affect -O0 codegen
too much, it's OK to use native constructs
ahatanak created this revision.
ahatanak added a reviewer: vsk.
ahatanak added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
This patch corrects http://reviews.llvm.org/D12155, which didn't take into
account the fact that aapcs ABI can be selected on darwin platforms. T
- Original Message -
> From: "Eric Christopher"
> To: "Hal Finkel"
> Cc: cfe-commits@lists.llvm.org
> Sent: Tuesday, August 25, 2015 5:51:50 PM
> Subject: Re: r245914 - Reimplement the PPC explicit option checking to be a
> bit more obvious
>
> On Tue, Aug 25, 2015 at 3:51 PM Hal Finkel
On Tue, Aug 25, 2015 at 3:51 PM Hal Finkel wrote:
> Hi Eric,
>
> Can you please update the test case for this change?
>
>
Hmm? The testcases are pretty exhaustive and should be checking exactly
what's here. (i.e. I don't expect a functional change).
-eric
> Thanks again,
> Hal
>
> - Origin
Hi Eric,
Can you please update the test case for this change?
Thanks again,
Hal
- Original Message -
> From: "Eric Christopher via cfe-commits"
> To: cfe-commits@lists.llvm.org
> Sent: Monday, August 24, 2015 7:59:11 PM
> Subject: r245914 - Reimplement the PPC explicit option checking t
Author: nicholas
Date: Tue Aug 25 17:33:16 2015
New Revision: 245985
URL: http://llvm.org/viewvc/llvm-project?rev=245985&view=rev
Log:
Make sure that we evaluate __attribute__((enable_if)) on a method with no
overloads. Patch by Ettore Speziale!
Modified:
cfe/trunk/lib/Sema/SemaOverload.cpp
Author: nicholas
Date: Tue Aug 25 17:18:46 2015
New Revision: 245979
URL: http://llvm.org/viewvc/llvm-project?rev=245979&view=rev
Log:
Clarify the error message when the reason the conversion is not viable is
because the returned value does not match the function return type.
Modified:
cfe/t
ayartsev added a comment.
Please review!
Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:158
@@ +157,3 @@
+/// zero-allocated memory returned by 'realloc(ptr, 0)'.
+struct ReallocSizeZero {
+ void Profile(llvm::FoldingSetNodeID &ID) const {
zaks.anna
ayartsev updated this revision to Diff 33134.
http://reviews.llvm.org/D9040
Files:
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
test/Analysis/malloc.c
Index: test/Analysis/malloc.c
===
--- test/Analysis/malloc.c
+++ test/Analys
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, sorry for the delay.
http://reviews.llvm.org/D11789
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
On Tue, Aug 25, 2015 at 1:39 PM, Filipe Cabecinhas <
filcab+llvm.phabrica...@gmail.com> wrote:
> Hi Richard,
>
> On Tue, Aug 25, 2015 at 11:01 AM, Richard Smith
> wrote:
>
>> On Aug 25, 2015 10:26 AM, "Filipe Cabecinhas" <
>> filcab+llvm.phabrica...@gmail.com> wrote:
>> >
>> > Hi Richard,
>> >
>>
RKSimon created this revision.
RKSimon added reviewers: echristo, mkuper, silvas, craig.topper.
RKSimon added a subscriber: cfe-commits.
RKSimon set the repository for this revision to rL LLVM.
Follow up to D12272
This adds the missing 3dnow intrinsics _m_to_float / _m_from_float and removes
the
Author: rksimon
Date: Tue Aug 25 16:27:46 2015
New Revision: 245975
URL: http://llvm.org/viewvc/llvm-project?rev=245975&view=rev
Log:
[X86] Remove unnecessary MMX declarations from Intrin.h
As discussed in PR23648 - the intrinsics _m_from_int, _m_to_int and _m_prefetch
are defined in mmintrin.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245975: [X86] Remove unnecessary MMX declarations from
Intrin.h (authored by RKSimon).
Changed prior to commit:
http://reviews.llvm.org/D12272?vs=32926&id=33124#toc
Repository:
rL LLVM
http://review
ayartsev closed this revision.
ayartsev added a comment.
Merged with http://reviews.llvm.org/D8774.
http://reviews.llvm.org/D9357
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ayartsev closed this revision.
ayartsev added a comment.
Committed as r241201
http://reviews.llvm.org/D8774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nmusgrave updated this revision to Diff 33115.
nmusgrave added a comment.
- Simplify parameters, rename function, for examining fields of class to
destroy.
http://reviews.llvm.org/D12022
Files:
lib/CodeGen/CGCXX.cpp
lib/CodeGen/CGClass.cpp
lib/CodeGen/CodeGenModule.h
test/CodeGenCXX/sa
Hi Richard,
On Tue, Aug 25, 2015 at 11:01 AM, Richard Smith
wrote:
> On Aug 25, 2015 10:26 AM, "Filipe Cabecinhas" <
> filcab+llvm.phabrica...@gmail.com> wrote:
> >
> > Hi Richard,
> >
> > We wouldn't be able to link with libs matching
> "libinker=*.{dylib,so,...}", I guess. If that is a big pro
sfantao added a comment.
Thanks for the review!
In http://reviews.llvm.org/D11361#232045, @ABataev wrote:
> Samuel, Yes, I thought about different files and different classes. Runtime
> for offloading codegen is not a part of libomp and it would be good to have
> separate runtime handler class
eugenis added inline comments.
Comment at: lib/CodeGen/CGCXX.cpp:31
@@ -30,1 +30,3 @@
+static bool HasTrivialField(CodeGenModule &CGM, const CXXDestructorDecl *D) {
+ for (const auto *Field : D->getParent()->fields())
I think this should be called "HasFieldWith
sfantao updated this revision to Diff 33111.
sfantao added a comment.
Move map type and device id enums from CGOpenMPRuntime.h to CGOpenMPRuntime.cpp.
http://reviews.llvm.org/D11361
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/Op
george.burgess.iv updated this revision to Diff 33104.
george.burgess.iv added a comment.
Talked with Richard, and we both agree that adding 4 EvaluationModes is too
much for the use case. So, we decided to add a flag to LValue to denote that
the LValueBase is invalid. This allows us to get by w
rjmccall added a comment.
You should add a test that actually checks that your feature works.
Comment at: lib/CodeGen/CGClass.cpp:1279
@@ +1278,3 @@
+ if (CGM.getCodeGenOpts().StrictVPtrs && BaseVPtrsInitialized)
+CXXThisValue = Builder.CreateInvariantGroupBarrier(LoadCXXTh
nmusgrave updated this revision to Diff 33100.
nmusgrave marked an inline comment as done.
nmusgrave added a comment.
- Check flags before dtor sanitizing
http://reviews.llvm.org/D12022
Files:
lib/CodeGen/CGCXX.cpp
lib/CodeGen/CGClass.cpp
lib/CodeGen/CodeGenModule.h
test/CodeGenCXX/sani
jroelofs added a comment.
Ah, I only tested it by editing the CMakeCache.txt manually... ship it!
http://reviews.llvm.org/D12209
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added inline comments.
Comment at: CMakeLists.txt:105
@@ +104,3 @@
+if (${CMAKE_SYSTEM_NAME} MATCHES "Darwin" AND NOT
LIBCXX_OVERRIDE_DARWIN_INSTALL)
+ if ("${CMAKE_INSTALL_PREFIX}" STREQUAL "/usr")
+message(WARNING "Disabling libc++ install rules because installation
rjmccall added a comment.
This looks generally like what I'm looking for, thanks! Some comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:1129
@@ +1128,3 @@
+if (GV && GV != GetGlobalValue(getMangledName(D)))
+ continue;
+
This is a pretty expensive e
jroelofs accepted this revision.
This revision is now accepted and ready to land.
Comment at: CMakeLists.txt:105
@@ +104,3 @@
+if (${CMAKE_SYSTEM_NAME} MATCHES "Darwin" AND NOT
LIBCXX_OVERRIDE_DARWIN_INSTALL)
+ if ("${CMAKE_INSTALL_PREFIX}" STREQUAL "/usr")
+message(WARNING
Author: nico
Date: Tue Aug 25 13:43:32 2015
New Revision: 245965
URL: http://llvm.org/viewvc/llvm-project?rev=245965&view=rev
Log:
Revert r245879. Speculative, might have caused crbug.com/524604
Modified:
cfe/trunk/lib/CodeGen/CGCall.cpp
cfe/trunk/lib/CodeGen/CGCall.h
cfe/trunk/test/C
awi added a subscriber: awi.
awi added a comment.
Hello,
I like your patch very much. I looks similar to my patch from January, so I am
confident it solves my problem, but it does so a little more elegantly at some
places.
I tried it with my two sources files main.cpp and main2.cpp. While main.c
sepavloff created this revision.
sepavloff added a subscriber: cfe-commits.
Instantiation of static class members can be not obvious in some cases. Using
modules can cause problems even more difficult to diagnose. PR24425 describes
one of such cases. As a way to assist a user, compiler could issue
nwilson updated this revision to Diff 33093.
http://reviews.llvm.org/D11789
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/DeclSpec.h
lib/Parse/ParseDecl.cpp
lib/Parse/ParseExpr.cpp
lib/Parse/ParseExprCXX.cpp
lib/Sema/DeclSpec.cpp
lib/Sema/SemaDecl.cpp
lib/Se
nwilson added a comment.
Ping
http://reviews.llvm.org/D11789
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Aug 25, 2015 10:26 AM, "Filipe Cabecinhas" <
filcab+llvm.phabrica...@gmail.com> wrote:
>
> Hi Richard,
>
> We wouldn't be able to link with libs matching
"libinker=*.{dylib,so,...}", I guess. If that is a big problem and you'd
prefer that we keep this as a private patch, let me know.
I don't th
Guys, talking about implicitly captured variables we have to deal with 2
locations: 1) point of real capturing (it is the point of '=' or '&'
symbols in lambda capture-list); 2) a point of first use of variable
inside lambda's body.
When we're talking about diagnostic for implicitly captured var
Comparing the result of InitListExpr::getSyntacticForm between r224986
and r245836 I've discovered that integer to char implicit cast for
integer literal 3 is no longer added to AST for C++ (while it is present
in C).
This is the source used to test:
char v[10] = { 3 };
Taken in account that:
-
Hi Richard,
We wouldn't be able to link with libs matching "libinker=*.{dylib,so,...}",
I guess. If that is a big problem and you'd prefer that we keep this as a
private patch, let me know.
Thank you,
Filipe
On Mon, Aug 24, 2015 at 6:45 PM, Richard Smith
wrote:
> On Mon, Aug 24, 2015 at 5:5
filcab updated this revision to Diff 33085.
filcab marked 3 inline comments as done.
filcab added a comment.
Addressed comments.
http://reviews.llvm.org/D11737
Files:
include/clang/Driver/Options.td
test/Driver/fuse-ld.c
Index: test/Driver/fuse-ld.c
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
Looks good to me.
http://reviews.llvm.org/D12123
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
Author: majnemer
Date: Tue Aug 25 11:44:38 2015
New Revision: 245953
URL: http://llvm.org/viewvc/llvm-project?rev=245953&view=rev
Log:
[Sema] Handle leading and trailing __ for GNU attributes
GNU attributes can have a leading and trailing __ appended/prepended to
the attribute name. While the pa
Author: xazax
Date: Tue Aug 25 11:38:05 2015
New Revision: 245951
URL: http://llvm.org/viewvc/llvm-project?rev=245951&view=rev
Log:
[Static Analyzer] Fix tests to reflect the change in the diagnostic message.
Modified:
cfe/trunk/test/Analysis/generics.m
Modified: cfe/trunk/test/Analysis/gene
Author: xazax
Date: Tue Aug 25 11:27:03 2015
New Revision: 245949
URL: http://llvm.org/viewvc/llvm-project?rev=245949&view=rev
Log:
[Static Analyzer] Fixed a typo in a diagnostic message.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/ObjCGenericsChecker.cpp
Modified: cfe/trunk/lib/StaticAn
rnk closed this revision.
rnk added a comment.
Looks like this landed as r245817.
http://reviews.llvm.org/D12137
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
andreybokhanko updated this revision to Diff 33083.
andreybokhanko added a comment.
John,
I implemented precisely what you described (or so I believe :-))
Patch is updated; please re-review.
This patch implements support for functions, but not variables yet -- the patch
is big enough already,
Yeah. I can't see a difference here being useful, and more likely harmful.
On Tue, Aug 25, 2015, 8:48 AM David Blaikie wrote:
> On Tue, Aug 25, 2015 at 8:44 AM, Bataev, Alexey
> wrote:
>
>> Debug info points to the real place where it is captured, while
>> diagnostics points to the first use of
Debug info points to the real place where it is captured, while
diagnostics points to the first use of implicitly captured variable.
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
25.08.2015 18:22, David Blaikie пишет:
On Tue, Aug 25, 2015 at 8:18 AM, Bataev,
On Tue, Aug 25, 2015 at 8:44 AM, Bataev, Alexey
wrote:
> Debug info points to the real place where it is captured, while
> diagnostics points to the first use of implicitly captured variable.
Right, but I'm trying to understand the justification for why that's the
right thing to do. Why the deb
Author: angelgarcia
Date: Tue Aug 25 10:44:00 2015
New Revision: 245942
URL: http://llvm.org/viewvc/llvm-project?rev=245942&view=rev
Log:
Avoid LoopConvertCheck replacements in template instantiations.
Summary: Prevent LoopConvertCheck from doing replacements in template
instantiations, and add
alexfh added a comment.
Thanks! Still looks good.
http://reviews.llvm.org/D12321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dnovillo
Date: Tue Aug 25 10:25:13 2015
New Revision: 245941
URL: http://llvm.org/viewvc/llvm-project?rev=245941&view=rev
Log:
Convert SampleProfile pass into a Module pass.
Eventually, we will need sample profiles to be incorporated into the
inliner's cost models. To do this, we need th
On Tue, Aug 25, 2015 at 8:18 AM, Bataev, Alexey
wrote:
> I though about this. I think it will be more convenient for user to see
> the diagnostic on the first use of the variable rather than on '=' or '&'
> symbol.
>
Why the difference between the diagnostic & the debug info, then?
>
> Best re
I though about this. I think it will be more convenient for user to see
the diagnostic on the first use of the variable rather than on '=' or
'&' symbol.
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
25.08.2015 18:07, David Blaikie пишет:
On Tue, Aug 18, 20
angelgarcia updated this revision to Diff 33081.
angelgarcia added a comment.
Add test.
http://reviews.llvm.org/D12321
Files:
clang-tidy/modernize/LoopConvertCheck.cpp
test/clang-tidy/modernize-loop-convert-extra.cpp
Index: test/clang-tidy/modernize-loop-convert-extra.cpp
=
Author: abataev
Date: Tue Aug 25 10:15:12 2015
New Revision: 245939
URL: http://llvm.org/viewvc/llvm-project?rev=245939&view=rev
Log:
Fix possible crash on null base or type for array elements.
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
cfe/trunk/test/OpenMP/task_depend_messages.cpp
Modi
On Tue, Aug 18, 2015 at 9:05 PM, Alexey Bataev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> ABataev created this revision.
> ABataev added reviewers: echristo, rjmccall, rsmith.
> ABataev added a subscriber: cfe-commits.
>
> When variables are implicitly captured in lambdas, debug info g
Hmm, my mistake, it did - my mail client's just not threaded it together
for some reason. :/
On Tue, Aug 25, 2015 at 8:06 AM, David Blaikie wrote:
> Looks like the initial mail didn't hit the mailing list? Does someone want
> to restart this review and/or forward that initial mail with the
> pat
Looks like the initial mail didn't hit the mailing list? Does someone want
to restart this review and/or forward that initial mail with the
patch/description/etc?
On Mon, Aug 24, 2015 at 11:00 PM, Eric Christopher via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> echristo added a comment.
>
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with a comment.
Comment at: test/clang-tidy/modernize-loop-convert-extra.cpp:636
@@ +635,3 @@
+ SE = container.end(); SI != SE; ++SI) {
+ }
+}
--
angelgarcia created this revision.
angelgarcia added a reviewer: alexfh.
angelgarcia added subscribers: cfe-commits, klimek.
Prevent LoopConvertCheck from doing replacements in template instantiations,
and add a test.
http://reviews.llvm.org/D12321
Files:
clang-tidy/modernize/LoopConvertCheck
aaron.ballman updated this revision to Diff 33078.
aaron.ballman added a comment.
This patch completely reworks the way the warning is implemented by moving it
into the frontend instead of clang-tidy.
http://reviews.llvm.org/D12301
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/
This revision was automatically updated to reflect the committed changes.
ABataev marked an inline comment as done.
Closed by commit rL245937: [OPENMP 4.0] Initial support for array sections.
(authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D10732?vs=32974&id=33077#toc
R
Author: abataev
Date: Tue Aug 25 09:24:04 2015
New Revision: 245937
URL: http://llvm.org/viewvc/llvm-project?rev=245937&view=rev
Log:
[OPENMP 4.0] Initial support for array sections.
Adds parsing/sema analysis/serialization/deserialization for array sections in
OpenMP constructs (introduced in O
Changed in r245934.
On Mon, Aug 24, 2015 at 5:48 PM, Daniel Jasper wrote:
>
>
> On Mon, Aug 24, 2015 at 5:46 PM, David Blaikie wrote:
>
>>
>>
>> On Mon, Aug 24, 2015 at 7:28 AM, Daniel Jasper via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Author: djasper
>>> Date: Mon Aug 24 09:
Author: echristo
Date: Tue Aug 25 08:45:28 2015
New Revision: 245936
URL: http://llvm.org/viewvc/llvm-project?rev=245936&view=rev
Log:
Rewrite the PPC target feature handling to more resemble other targets.
This involved specializing handleUserFeatures so that we could perform
diagnostics on -onl
Author: echristo
Date: Tue Aug 25 08:45:24 2015
New Revision: 245935
URL: http://llvm.org/viewvc/llvm-project?rev=245935&view=rev
Log:
Extract handling of user defined features into a function so we can
specialize it on the targets.
Modified:
cfe/trunk/include/clang/Basic/TargetInfo.h
cfe
Author: djasper
Date: Tue Aug 25 08:40:51 2015
New Revision: 245934
URL: http://llvm.org/viewvc/llvm-project?rev=245934&view=rev
Log:
clang-format: Add space before member function reference qualifiers.
Before:
SomeType MemberFunction(const Deleted &)&;
After:
SomeType MemberFunction(const D
On Tue, Aug 25, 2015 at 8:05 AM, Aaron Ballman wrote:
> On Mon, Aug 24, 2015 at 7:42 PM, Richard Smith wrote:
>> On Mon, Aug 24, 2015 at 3:36 PM, Aaron Ballman
>> wrote:
>>>
>>> On Mon, Aug 24, 2015 at 6:29 PM, Richard Smith
>>> wrote:
>>> > On Mon, Aug 24, 2015 at 3:23 PM, Aaron Ballman
>>> >
ABataev added a comment.
Samuel, Yes, I thought about different files and different classes. Runtime for
offloading codegen is not a part of libomp and it would be good to have
separate runtime handler class for target codegen also. We need to think about
it in future.
Commen
Author: angelgarcia
Date: Tue Aug 25 08:03:43 2015
New Revision: 245933
URL: http://llvm.org/viewvc/llvm-project?rev=245933&view=rev
Log:
Add replace-auto_ptr check.
Summary: Migrate replace-auto_ptr check from clang-modernize to modernize
module in clang-tidy.
Reviewers: alexfh
Subscribers: k
angelgarcia updated this revision to Diff 33066.
angelgarcia added a comment.
Use the full message once in the test, and truncate all the other patterns.
http://reviews.llvm.org/D12287
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/moder
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with one nit.
Thank you!
Comment at: test/clang-tidy/modernize-replace-auto-ptr.cpp:12
@@ +11,3 @@
+std::auto_ptr create_derived_ptr();
+// CHECK-MESSAGES: :[[@LIN
On Mon, Aug 24, 2015 at 7:42 PM, Richard Smith wrote:
> On Mon, Aug 24, 2015 at 3:36 PM, Aaron Ballman
> wrote:
>>
>> On Mon, Aug 24, 2015 at 6:29 PM, Richard Smith
>> wrote:
>> > On Mon, Aug 24, 2015 at 3:23 PM, Aaron Ballman
>> > wrote:
>> >>
>> >> aaron.ballman created this revision.
>> >> a
Author: mkuper
Date: Tue Aug 25 06:42:31 2015
New Revision: 245929
URL: http://llvm.org/viewvc/llvm-project?rev=245929&view=rev
Log:
Revert r245923 since it breaks mingw.
Removed:
cfe/trunk/test/CodeGen/x86-rot-intrinsics.c
Modified:
cfe/trunk/lib/Headers/Intrin.h
cfe/trunk/lib/Header
ABataev added a subscriber: ABataev.
ABataev added a comment.
Yes, you're right, and it will be 13, 14, 15. It is implemented already
and this patch does not break this.
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
25.08.2015 9:00, Eric Christopher пишет:
>
Yes, you're right, and it will be 13, 14, 15. It is implemented already
and this patch does not break this.
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
25.08.2015 9:00, Eric Christopher пишет:
echristo added a comment.
How about:
13. [apple,
14. banana,
15
Argh.
I'll revert, and figure out what to do with it later.
Sorry about the breakage.
Michael
-Original Message-
From: İsmail Dönmez [mailto:ism...@i10z.com]
Sent: Tuesday, August 25, 2015 14:17
To: Kuperstein, Michael M
Cc: cfe-commits@lists.llvm.org
Subject: Re: r245923 - [X86] Expose
Hi,
On Tue, Aug 25, 2015 at 10:21 AM, Michael Kuperstein via cfe-commits
wrote:
> Author: mkuper
> Date: Tue Aug 25 02:21:33 2015
> New Revision: 245923
>
> URL: http://llvm.org/viewvc/llvm-project?rev=245923&view=rev
> Log:
> [X86] Expose the various _rot intrinsics on non-MS platforms
>
> _rotl
angelgarcia updated this revision to Diff 33055.
angelgarcia added a comment.
Add check description.
http://reviews.llvm.org/D12287
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/ReplaceAutoPtrCheck.cpp
clang-tidy/modernize/R
labrinea updated this revision to Diff 33054.
labrinea added a comment.
_ARM_FP16_FORMAT_IEEE and _ARM_FP16_ARGS should be defined unconditionally.
When hardware does not support them library calls are emitted.
http://reviews.llvm.org/D12244
Files:
lib/Basic/Targets.cpp
test/Preprocessor/a
1 - 100 of 103 matches
Mail list logo
