Re: r245041 - [OPENMP] Fix for http://llvm.org/PR24371: Assert failure compiling blender 2.75.

Yes, please, forget to tell you. :) Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 14.08.2015 19:03, Hans Wennborg пишет: On Fri, Aug 14, 2015 at 5:25 AM, Alexey Bataev via cfe-commits wrote: Author: abataev Date: Fri Aug 14 07:25:37 2015 New Revision: 245041

Re: [PATCH] D11361: [OpenMP] Target directive host codegen

ABataev added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:1969 @@ -1945,3 +1968,3 @@ else - return EmitCapturedFieldLValue(*this, CapturedStmtInfo->lookup(VD), - CapturedStmtInfo->getContextValue()); + retu

Re: [PATCH] D10732: [OPENMP 4.0] Initial support for array sections.

ABataev added a comment. Richard, any comments? http://reviews.llvm.org/D10732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

ABataev added a comment. Richard? http://reviews.llvm.org/D10599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11859: Generating vptr assume loads

Prazek updated this revision to Diff 32263. http://reviews.llvm.org/D11859 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGClass.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/ItaniumCXXABI.cpp lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGen/available-externally-hidden.cpp test/CodeGenCXX/c

Re: [PATCH] D11859: Generating vptr assume loads

Prazek updated this revision to Diff 32262. http://reviews.llvm.org/D11859 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGClass.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/ItaniumCXXABI.cpp lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGen/available-externally-hidden.cpp test/CodeGenCXX/c

Re: [PATCH] D11859: Generating vptr assume loads

Prazek marked an inline comment as done. Prazek added a comment. In http://reviews.llvm.org/D11859#225404, @rjmccall wrote: > In http://reviews.llvm.org/D11859#225384, @Prazek wrote: > > > In http://reviews.llvm.org/D11859#225025, @rjmccall wrote: > > > > > Mostly LGTM. Are you going to emit ass

Re: [PATCH] D11859: Generating vptr assume loads

Prazek marked an inline comment as done. Comment at: lib/CodeGen/CGCXXABI.h:352 @@ +351,3 @@ + isVirtualOffsetNeededForVTableField(CodeGenFunction &CGF, + const CXXRecordDecl *NearestVBase) = 0; + rjmccall wrote: > This method

Re: [PATCH] D11859: Generating vptr assume loads

rjmccall added a comment. In http://reviews.llvm.org/D11859#225384, @Prazek wrote: > In http://reviews.llvm.org/D11859#225025, @rjmccall wrote: > > > Mostly LGTM. Are you going to emit assumptions for vbptrs in a separate > > patch? > > > I wasn't planning to. I am focusing now on upgrading GVN

Re: [PATCH] D11859: Generating vptr assume loads

Prazek added a comment. In http://reviews.llvm.org/D11859#225025, @rjmccall wrote: > Mostly LGTM. Are you going to emit assumptions for vbptrs in a separate > patch? I wasn't planning to. I am focusing now on upgrading GVN for using new invariant.barrier metadata. http://reviews.llvm.org/D

Re: [PATCH] D11851: clang-format: Add "AllowShortNamespacesOnASingleLine" option

cbeck88 removed rL LLVM as the repository for this revision. cbeck88 updated this revision to Diff 32249. cbeck88 added a comment. - Fixed formatting in header - Fixed handling of nested namespaces - Added unit tests djasper: I thought about it, I guess I don't have a particularly good reason th

r245184 - Enable passing test on Windows + MSYS.

Author: yrnkrn Date: Sun Aug 16 14:02:49 2015 New Revision: 245184 URL: http://llvm.org/viewvc/llvm-project?rev=245184&view=rev Log: Enable passing test on Windows + MSYS. Modified: cfe/trunk/test/Preprocessor/macro-multiline.c Modified: cfe/trunk/test/Preprocessor/macro-multiline.c URL: h

Re: [PATCH] D5102: [analyzer][Bugfix/improvement] Fix for PR16833

a.sidorin added inline comments. Comment at: lib/StaticAnalyzer/Core/SimpleConstraintManager.cpp:215-220 @@ +214,8 @@ + return assumeSymWithinInclusiveRange(State, Sym, From, To, InRange); +return State; + } // end switch + + case nonloc::ConcreteIntKind: { +const l

Re: [PATCH] D5102: [analyzer][Bugfix/improvement] Fix for PR16833

a.sidorin added a comment. Thank you for reply, Jordan. > I guess the regular pings didn't work, so it was worth trying the gentle one? > Sorry! And it worked :) I'll fix the issues you pointed. http://reviews.llvm.org/D5102 ___ cfe-commits mai

Re: [PATCH] D12052: [X86][SSE] Add _mm_undefined_* intrinsics

RKSimon added a comment. Yes using that uninitialized value has worried me as well. I originally set it to zero (and considered using __ LINE __ or __ COUNTER __) but both introduce defined behaviour that I could see causing all sorts of problems further down the line in debug vs release builds

Re: [PATCH] D12052: [X86][SSE] Add _mm_undefined_* intrinsics

majnemer added a subscriber: majnemer. majnemer added a comment. In http://reviews.llvm.org/D12052#225194, @mkuper wrote: > Thanks, Simon! > I've wanted to add the _undefined intrinsics for a while now, but never got > to it. > > Anyway, this sort of implementation somewhat worries me. > Yes,

Re: [PATCH] D12052: [X86][SSE] Add _mm_undefined_* intrinsics

mkuper added a comment. Thanks, Simon! I've wanted to add the _undefined intrinsics for a while now, but never got to it. Anyway, this sort of implementation somewhat worries me. Yes, I know that the gcc intrinsics do something very similar. And I also know that in practice we'll get an undef