Re: [ceph-users] O_DIRECT on deep-scrub read

2015-10-09 Thread Milosz Tanski
On Thu, Oct 8, 2015 at 4:11 AM, Paweł Sadowski wrote: > > On 10/07/2015 10:52 PM, Sage Weil wrote: > > On Wed, 7 Oct 2015, David Zafman wrote: > >> There would be a benefit to doing fadvise POSIX_FADV_DONTNEED after > >> deep-scrub reads for objects not recently accessed by clients. > > Yeah, it's

Re: [ceph-users] O_DIRECT on deep-scrub read

2015-10-08 Thread Lionel Bouton
Le 07/10/2015 13:44, Paweł Sadowski a écrit : > Hi, > > Can anyone tell if deep scrub is done using O_DIRECT flag or not? I'm > not able to verify that in source code. > > If not would it be possible to add such feature (maybe config option) to > help keeping Linux page cache in better shape? Note

Re: [ceph-users] O_DIRECT on deep-scrub read

2015-10-08 Thread Paweł Sadowski
On 10/07/2015 10:52 PM, Sage Weil wrote: > On Wed, 7 Oct 2015, David Zafman wrote: >> There would be a benefit to doing fadvise POSIX_FADV_DONTNEED after >> deep-scrub reads for objects not recently accessed by clients. > Yeah, it's the 'except for stuff already in cache' part that we don't do >

Re: [ceph-users] O_DIRECT on deep-scrub read

2015-10-07 Thread Sage Weil
On Wed, 7 Oct 2015, David Zafman wrote: > > There would be a benefit to doing fadvise POSIX_FADV_DONTNEED after > deep-scrub reads for objects not recently accessed by clients. Yeah, it's the 'except for stuff already in cache' part that we don't do (and the kernel doesn't give us a good interf

Re: [ceph-users] O_DIRECT on deep-scrub read

2015-10-07 Thread David Zafman
There would be a benefit to doing fadvise POSIX_FADV_DONTNEED after deep-scrub reads for objects not recently accessed by clients. I see the NewStore objectstore sometimes using the O_DIRECT flag for writes. This concerns me because the open(2) man pages says: "Applications should avoid m

Re: [ceph-users] O_DIRECT on deep-scrub read

2015-10-07 Thread Milosz Tanski
On Wed, Oct 7, 2015 at 10:50 AM, Sage Weil wrote: > It's not, but it would not be ahrd to do this. There are fadvise-style > hints being passed down that could trigger O_DIRECT reads in this case. > That may not be the best choice, though--it won't use data that happens > to be in cache and it'll

Re: [ceph-users] O_DIRECT on deep-scrub read

2015-10-07 Thread Sage Weil
It's not, but it would not be ahrd to do this. There are fadvise-style hints being passed down that could trigger O_DIRECT reads in this case. That may not be the best choice, though--it won't use data that happens to be in cache and it'll also throw it out.. On Wed, 7 Oct 2015, Pawe? Sadowsk

[ceph-users] O_DIRECT on deep-scrub read

2015-10-07 Thread Paweł Sadowski
Hi, Can anyone tell if deep scrub is done using O_DIRECT flag or not? I'm not able to verify that in source code. If not would it be possible to add such feature (maybe config option) to help keeping Linux page cache in better shape? Thanks, -- PS _