open another action later on. That
shouldn't keep it from being useful in general though. There's lots of
sprintf junk in there for someone to fix either way. any way I hope
someone finds this patch useful.
>From 9c6bf2153b18514d66b949e6c4d092a04db27c4c Mon Sep 17 00:00:00 2001
Fr
On 08/11/2012 03:18 AM, Marc Balmer wrote:
> A few comments:
>
> Since sizeof(char) is 1, it is not needed to write
>
> malloc(... + 5 * sizeof(char))
>
> but just
>
> malloc(... + 5)
>
> And actually, only 4 extra characters are needed, so don't waste that
> byte ;)
>
> And never use a multiplicat
On 08/11/2012 03:56 AM, William Schaub wrote:
On 08/11/2012 03:18 AM, Marc Balmer wrote:
A few comments:
Since sizeof(char) is 1, it is not needed to write
malloc(... + 5 * sizeof(char))
but just
malloc(... + 5)
And actually, only 4 extra characters are needed, so don't waste that
On 08/11/2012 04:25 AM, Pascal Stumpf wrote:
On Sat, 11 Aug 2012 04:16:49 -0400, William Schaub wrote:
On 08/11/2012 03:56 AM, William Schaub wrote:
On 08/11/2012 03:18 AM, Marc Balmer wrote:
A few comments:
Since sizeof(char) is 1, it is not needed to write
malloc(... + 5 * sizeof(char
I also found a double free error in parser.c that caused me some grief.
Attached are both the original patch and the parser.c patch for dtcreate.
>From 7f64a9c4e8f8108021f5f65e9210bdc994232e40 Mon Sep 17 00:00:00 2001
From: William Schaub
Date: Sat, 11 Aug 2012 04:02:17 -0400
Subject: [PATCH
.
>From c05c883cdb4a8e7cf2362a1c1fd67db6d0df93e0 Mon Sep 17 00:00:00 2001
From: William Schaub
Date: Sun, 12 Aug 2012 16:24:36 -0400
Subject: [PATCH] dtcreate: check for TT_ERR_PTYPE the correct way
---
cde/programs/dtcreate/main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/cde/programs/dtcreate
On 08/12/2012 07:48 PM, Jon Trulson wrote:
> Seems dtbuilder isn't working well - I get:
>
> Warning: Color name "(nil)" is not defined
> Warning: Cannot convert string "False" to type Widget
> dtbuilder: WARNING: Object 'project'
> Could not allocate Background color "(nil)".
> Object's Background
On 08/13/2012 11:42 AM, Pascal Stumpf wrote:
> Please test this patch on 32bit, it should fix the dtbuilder crashes
> people were seeing. Also note that dtbuilder still crashes on 64bit ...
>
Seems to work for me on 32bit ARM.
-
17 00:00:00 2001
From: William Schaub
Date: Mon, 13 Aug 2012 16:44:42 -0400
Subject: [PATCH] dtwm: add RestartWorkSpaceManager action and DtWorkspace_Restart TT op
to allow the workspace manager to be restarted by a simple call to dtaction
---
cde/programs/dtwm/WmIPC.c| 10 ++
On 08/13/2012 04:11 PM, Pascal Stumpf wrote:
> On Mon, 13 Aug 2012 15:10:51 -0400, William Schaub wrote:
>> On 08/13/2012 11:42 AM, Pascal Stumpf wrote:
>>> Please test this patch on 32bit, it should fix the dtbuilder crashes
>>> people were seeing. Also note that dtbui
seems they all use 32 bit userland and maybe a select few 64 bit
binaries.
dtdocbook fails to build but I will look into that later.
>From 3bc9eba2d57400193aea8e719003709bfb4e39cb Mon Sep 17 00:00:00 2001
From: William Schaub
Date: Wed, 15 Aug 2012 22:35:49 -0400
Subject: [PATCH] Add sup
rom 60ee53957d5103c6a48e02af1e3f620a317c997f Mon Sep 17 00:00:00 2001
From: William Schaub
Date: Thu, 16 Aug 2012 13:55:41 -0400
Subject: [PATCH 2/2] dtdocbook: on some systems SIGLOST = SIGPWR and they
should not be in the same case statement.
---
cde/programs/dtdocbook/tcl/tclPosixStr.c |4 ++--
1 file changed, 2 insertions(+)
On 08/16/2012 09:21 PM, Frederic Koehler wrote:
> It's impressive this code ever worked at all. Dtcreate is still not
> really working yet.
>
I totally agree, I seriously doubt this code ever worked in the state it
is in currently. I suspect that vendors made a lot of the same patches I
made and
13 matches
Mail list logo