Re: [cdesktopenv-devel] Small dthelp-related fixes

2012-09-29 Thread Marc Balmer
Am 29.09.12 03:29, schrieb Jon Trulson: > On Fri, 28 Sep 2012, Marc Balmer wrote: > >> for patch 1: don't roll your own strfunctions, use strlcpy or so > > I'm inclined to apply this - strlcpy isn't available on all systems > (on linux, requires bsd lib I think). In addition, strlcpy also does

Re: [cdesktopenv-devel] C++: warning: -Wno-write-strings

2012-09-29 Thread Marcin Cieslak
On Mon, 24 Sep 2012, Jon Trulson wrote: > On Mon, 24 Sep 2012, Marcin Cieslak wrote: > > > Hello, > > > > When building dtmail with gcc 4.2 I get the following warning: > > > > Hmmm. Yes we could ignore the warning, but I'd suggest we don't if it > has the potential to create grief in the fut

Re: [cdesktopenv-devel] Small dthelp-related fixes

2012-09-29 Thread Frederic Koehler
On Sat, Sep 29, 2012 at 3:40 AM, Marc Balmer wrote: > Am 29.09.12 03:29, schrieb Jon Trulson: >> On Fri, 28 Sep 2012, Marc Balmer wrote: >> >>> for patch 1: don't roll your own strfunctions, use strlcpy or so >> >> I'm inclined to apply this - strlcpy isn't available on all systems >> (on linux,

Re: [cdesktopenv-devel] dtcreate problems

2012-09-29 Thread Marcin Cieslak
On Sat, 29 Sep 2012, Frederic Koehler wrote: > This is on a 64-bit machine. Opening the help window works fine the > first time [and > their are no valgrind messages], but after closing it and opening it > again the program > segfaults, and there are a lot of valgrind messages about using freed >

Re: [cdesktopenv-devel] dtcreate problems

2012-09-29 Thread Frederic Koehler
That's weird. On my machine _UxUxParent is also NULL but the program runs fine [no segfaults, I can even browse icons and create new entries for my deskbar now]. On Sat, Sep 29, 2012 at 1:27 PM, Marcin Cieslak wrote: > On Sat, 29 Sep 2012, Frederic Koehler wrote: > >> This is on a 64-bit machine.

Re: [cdesktopenv-devel] Small dthelp-related fixes

2012-09-29 Thread Robert Tomsick
On Sat, 29 Sep 2012, Marc Balmer wrote: > Am 29.09.12 03:29, schrieb Jon Trulson: >> On Fri, 28 Sep 2012, Marc Balmer wrote: >> >>> for patch 1: don't roll your own strfunctions, use strlcpy or so >> >> I'm inclined to apply this - strlcpy isn't available on all systems >> (on linux, requires b

Re: [cdesktopenv-devel] dtcreate problems

2012-09-29 Thread Marcin Cieslak
> On Sat, Sep 29, 2012 at 1:27 PM, Marcin Cieslak wrote: > > On Sat, 29 Sep 2012, Frederic Koehler wrote: > >> This is on a 64-bit machine. Opening the help window works fine the > >> first time [and On Sat, 29 Sep 2012, Frederic Koehler wrote: > That's weird. On my machine _UxUxParent is also N

Re: [cdesktopenv-devel] Regeneration of with XmPrivate.h

2012-09-29 Thread Marcin Cieslak
On Wed, 19 Sep 2012, Marcin Cieslak wrote: > make should never regenerate XmPrivate.h unless: > - it is missing > - extractprototype.awk is *newer* than XmPrivate.h Hello, I have another change to cde/include/Xm/extractprototype.awk pending. What shall I do? XmPrivate.h needs to be re-created. C

[cdesktopenv-devel] [PATCH] XmPrivate.h: Avoid whitespace problems

2012-09-29 Thread Marcin Cieslak
When applying a patch, "git am" strips trailing whitespace, although they are present in the git formatted-patch. This way the committed file will be slightly different than the file re-generated by extractprototype.h It shouldn't hurt, but next run of extractprototype.h will add trailing spaces

[cdesktopenv-devel] [PATCH] XmPrivate.h: Avoid whitespace problems (IMPROVED)

2012-09-29 Thread Marcin Cieslak
When applying a patch, "git am" strips trailing whitespace, although they are present in the git formatted-patch. This way the committed file will be slightly different than the file re-generated by extractprototype.h It shouldn't hurt, but next run of extractprototype.h will add trailing spaces

Re: [cdesktopenv-devel] dtcreate 'mainHelpDialog' fix

2012-09-29 Thread Marcin Cieslak
On Fri, 28 Sep 2012, Jon Trulson wrote: > > for patch 2: hunk 1 and 3 are not needed > > > > > > Yeah, not sure about this one either... Confused. > > Marc says 1 and 3 are not needed, but if you omit them, then 2 cannot > work otherwise. I wonder if this is the real problem? Is this on a > 64

[cdesktopenv-devel] [PATCH 66/67] dtcreate: Avoid trying to reuse closed help window

2012-09-29 Thread Marcin Cieslak
From: Frederic Koehler This fixes a segfault when trying to go to help a second time, after closing the first window. --- cde/programs/dtcreate/cmncbs.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cde/programs/dtcreate/cmncbs.c b/cde/programs/dtcreate/cmncbs.c index 0

[cdesktopenv-devel] [PATCH 67/67] dtcreate: Don't crash when clicking "Find Set..."

2012-09-29 Thread Marcin Cieslak
dtcreate crashed on 64-bit system when clicking "Find Set.." button. Crash happens in libXm: new_w=0x805db4300, args=0x7fffb430, num_args=0x7fffb3dc) at Form.c:1955 $1 = {att = {{type = 4 '\004', w = 0x805db3700, percent = 0, offset = 0, value = 0, tempValue = 0}, {type = 1

[cdesktopenv-devel] [PATCH 65/67] dtcreate: Add missing prototypes and more (64-bit)

2012-09-29 Thread Marcin Cieslak
- Fix missing prototypes - Fix some 64-bit related problems (XtVaGetValues) - Fix crash on dtcreate startup in create_applicationShell1() - Add XmeFlushIconFileCache() prototype from --- cde/include/Xm/XmPrivate.h| 2 ++ cde/include/Xm/extractprototype.awk | 1 + c

Re: [cdesktopenv-devel] Small dthelp-related fixes

2012-09-29 Thread Marcin Cieslak
> Technically strcpy's ranges cannot overlap at all, > although in practice this is usually not an issue. > Does quiet a valgrind warning, however. > -strcpy (string, &string[*idx+1]); > *strmove (string, &string[*idx+1]); Interesting, although I agree with others that introduci

Re: [cdesktopenv-devel] Small dthelp-related fixes

2012-09-29 Thread Jon Trulson
On Sat, 29 Sep 2012, Frederic Koehler wrote: > On Sat, Sep 29, 2012 at 3:40 AM, Marc Balmer wrote: >> Am 29.09.12 03:29, schrieb Jon Trulson: >>> On Fri, 28 Sep 2012, Marc Balmer wrote: >>> for patch 1: don't roll your own strfunctions, use strlcpy or so >>> >>> I'm inclined to apply this -

Re: [cdesktopenv-devel] dtcreate problems

2012-09-29 Thread Jon Trulson
On Sat, 29 Sep 2012, Marcin Cieslak wrote: > On Sat, 29 Sep 2012, Frederic Koehler wrote: > >> This is on a 64-bit machine. Opening the help window works fine the >> first time [and >> their are no valgrind messages], but after closing it and opening it >> again the program >> segfaults, and there

Re: [cdesktopenv-devel] dtcreate problems

2012-09-29 Thread Jon Trulson
On Sat, 29 Sep 2012, Marcin Cieslak wrote: >> On Sat, Sep 29, 2012 at 1:27 PM, Marcin Cieslak wrote: >>> On Sat, 29 Sep 2012, Frederic Koehler wrote: This is on a 64-bit machine. Opening the help window works fine the first time [and > > On Sat, 29 Sep 2012, Frederic Koehler wrote: > >>

Re: [cdesktopenv-devel] Small dthelp-related fixes

2012-09-29 Thread Jon Trulson
On Sun, 30 Sep 2012, Marcin Cieslak wrote: > >> Technically strcpy's ranges cannot overlap at all, >> although in practice this is usually not an issue. >> Does quiet a valgrind warning, however. > >> -strcpy (string, &string[*idx+1]); >> *strmove (string, &string[*idx+1]); > > > I

Re: [cdesktopenv-devel] session manager cannot be contacted

2012-09-29 Thread Marcin Cieslak
On Sat, 29 Sep 2012, Jon Trulson wrote: > On Sun, 30 Sep 2012, Marcin Cieslak wrote: > > When I login, everything comes up, but a dialog appears saying that > the session manager (I'm paraphrasing) could not be contacted. It has > an Ok buton, which if you hit, ends the session. I'm guessing it

Re: [cdesktopenv-devel] Regeneration of with XmPrivate.h

2012-09-29 Thread Jon Trulson
On Sat, 29 Sep 2012, Marcin Cieslak wrote: > On Wed, 19 Sep 2012, Marcin Cieslak wrote: >> make should never regenerate XmPrivate.h unless: >> - it is missing >> - extractprototype.awk is *newer* than XmPrivate.h > > Hello, > > I have another change to cde/include/Xm/extractprototype.awk > pending

Re: [cdesktopenv-devel] session manager cannot be contacted

2012-09-29 Thread Marcin Cieslak
On Sun, 30 Sep 2012, Marcin Cieslak wrote: > Watch ~/.dt/errlog, since you might not be getting all error $HOME/.dt/errorlog of course -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics

Re: [cdesktopenv-devel] Regeneration of with XmPrivate.h

2012-09-29 Thread Marcin Cieslak
On Sat, 29 Sep 2012, Jon Trulson wrote: > On Sat, 29 Sep 2012, Marcin Cieslak wrote: > > > On Wed, 19 Sep 2012, Marcin Cieslak wrote: > > > make should never regenerate XmPrivate.h unless: > > > - it is missing > > > - extractprototype.awk is *newer* than XmPrivate.h > > > > Hello, > > > > I ha

Re: [cdesktopenv-devel] session manager cannot be contacted

2012-09-29 Thread Jon Trulson
On Sun, 30 Sep 2012, Marcin Cieslak wrote: > On Sat, 29 Sep 2012, Jon Trulson wrote: > >> On Sun, 30 Sep 2012, Marcin Cieslak wrote: >> >> When I login, everything comes up, but a dialog appears saying that >> the session manager (I'm paraphrasing) could not be contacted. It has >> an Ok buton, w

Re: [cdesktopenv-devel] Regeneration of with XmPrivate.h

2012-09-29 Thread Jon Trulson
On Sun, 30 Sep 2012, Marcin Cieslak wrote: > On Sat, 29 Sep 2012, Jon Trulson wrote: > >> On Sat, 29 Sep 2012, Marcin Cieslak wrote: >> >>> On Wed, 19 Sep 2012, Marcin Cieslak wrote: make should never regenerate XmPrivate.h unless: - it is missing - extractprototype.awk is *newer* t

Re: [cdesktopenv-devel] [PATCH 66/67] dtcreate: Avoid trying to reuse closed help window

2012-09-29 Thread Jon Trulson
On Sun, 30 Sep 2012, Marcin Cieslak wrote: > From: Frederic Koehler > > This fixes a segfault when trying to go to help a second > time, after closing the first window. I've already applied Frederic's patch, no need to resubmit it... -- Jon Trulson The Higgs Field is what make atoms matter.

Re: [cdesktopenv-devel] [PATCH 67/67] dtcreate: Don't crash when clicking "Find Set..."

2012-09-29 Thread Jon Trulson
On Sun, 30 Sep 2012, Marcin Cieslak wrote: > dtcreate crashed on 64-bit system when clicking > "Find Set.." button. > I'm not going to apply this one, at least not without a better understanding of what the real problem is... > Crash happens in libXm: > [...] > >{ type = 3 '\003', /* XmATTAC

Re: [cdesktopenv-devel] Regeneration of with XmPrivate.h

2012-09-29 Thread Jon Trulson
On Sat, 29 Sep 2012, Jon Trulson wrote: > On Sun, 30 Sep 2012, Marcin Cieslak wrote: > >> On Sat, 29 Sep 2012, Jon Trulson wrote: >> >>> On Sat, 29 Sep 2012, Marcin Cieslak wrote: >>> On Wed, 19 Sep 2012, Marcin Cieslak wrote: > make should never regenerate XmPrivate.h unless: > - it

Re: [cdesktopenv-devel] [PATCH] XmPrivate.h: Avoid whitespace problems (IMPROVED)

2012-09-29 Thread Jon Trulson
On Sat, 29 Sep 2012, Marcin Cieslak wrote: Applied. -- Jon Trulson The Higgs Field is what make atoms matter. -- Tom L. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDyna

Re: [cdesktopenv-devel] [PATCH 65/67] dtcreate: Add missing prototypes and more (64-bit)

2012-09-29 Thread Jon Trulson
On Sun, 30 Sep 2012, Marcin Cieslak wrote: Applied. -- Jon Trulson The Higgs Field is what make atoms matter. -- Tom L. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDyn