Re: [cdesktopenv-devel] [PATCH] Fix dtfile crash on 64 bit - how to cast XtPointer?

2012-09-22 Thread Marcin Cieslak
On Fri, 21 Sep 2012, Marcin Cieslak wrote: > + union { > + XtPointer ptr; > + Dimension dim; > + } wide; > + XtVaGetValues(dir_label, XmNwidth, &wide.ptr, NULL); > + d_width = wide.dim; > + XtVaGetValues(file_label, XmNwidth, &wide.ptr, NULL); > + f_width = wide.dim; Sorry, t

[cdesktopenv-devel] [PATCH] Fix dtfile crash on 64 bit

2012-09-22 Thread Marcin Cieslak
When asking for data using XtVaGetValue() make sure that there is enough place for the return value (which is sometimes XtPointer). Providing pointer to (int) is not enough. Cast XtPointer into requested int types directly, which unfortunately introduces compilation warning: cast from pointer to

[cdesktopenv-devel] NetBSD/DragonFlyBSD progress

2012-09-22 Thread Jelle Hermsen
Hiya everybody, This is a quick status update so that you all know I'm still working on this . The pkgsrc freeze for 2012Q3 started last Sunday and I had to get some stuff fixed before that, so with that out of the way I'm focusing more on porting CDE to NetBSD (and when I'm done with that Drago

Re: [cdesktopenv-devel] NetBSD/DragonFlyBSD progress

2012-09-22 Thread Marcin Cieslak
On Sat, 22 Sep 2012, Jelle Hermsen wrote: > The pkgsrc freeze for 2012Q3 started last Sunday and I had to get some > stuff fixed before that, so with that out of the way I'm focusing more > on porting CDE to NetBSD (and when I'm done with that Dragonfly). CDE on FreeBSD works pretty nice now (o

Re: [cdesktopenv-devel] [PATCH] Fix dtfile crash on 64 bit

2012-09-22 Thread Jon Trulson
On Sat, 22 Sep 2012, Marcin Cieslak wrote: > When asking for data using XtVaGetValue() > make sure that there is enough place for > the return value (which is sometimes XtPointer). > Providing pointer to (int) is not enough. > > Cast XtPointer into requested int types > directly, which unfortunate

Re: [cdesktopenv-devel] [PATCH] dttypes should not crash on 64-bit system

2012-09-22 Thread Jon Trulson
On Fri, 21 Sep 2012, Marcin Cieslak wrote: > Casting (int) to (char **) will not > prevent crash on a 64-bit system. > > A proper ANSI prototype has been added. Applied. -- Jon Trulson The Higgs Field is what make atoms matter. -- Tom L.

Re: [cdesktopenv-devel] NetBSD/DragonFlyBSD progress

2012-09-22 Thread Jon Trulson
On Sat, 22 Sep 2012, Marcin Cieslak wrote: > On Sat, 22 Sep 2012, Jelle Hermsen wrote: > >> The pkgsrc freeze for 2012Q3 started last Sunday and I had to get some [...] > I am not the gatekeeper but I don't mind partial patches as long > as they don't break other builds. Feel free to experiment on

Re: [cdesktopenv-devel] NetBSD/DragonFlyBSD progress

2012-09-22 Thread Jelle Hermsen
Hiya, Thanks Marcin for the elaborate update on the FreeBSD side of things. I'm definitely a proponent of using CSRG_BASED and have_something macros. It would be great if you would only need to teach one configuration header about an OS, defining a bunch of have_something macros in there. Howeve