Re: [cdesktopenv-devel] [PATCH] post_install: Fix shellcheck warnings

2018-11-04 Thread Jon Trulson
Applied to master, thanks! -jon On 10/30/18 8:05 AM, Matthew R. Trower wrote: I'm sorry to report that with this commit, installCDE.src:CleanDaemons() is utterly broken. It doesn't work at all on any platform, and breaks installation on non AIX/freebsd/openbsd/netbsd/linux platforms (eg: sun).

Re: [cdesktopenv-devel] [PATCH] post_install: Fix shellcheck warnings

2018-10-30 Thread Matthew R. Trower
Ah, the actual commit in question was ff17b57585af5c3ce9555b42daf848a89e10effd whereas this thread refers to e8e03641214e472288d52a12caa5f1e0bf9f69cd ... so many 'shellcheck' commits. I'm not sure where the thread that Chase introduced the patch in question is. Hopefully I've given plenty of i

Re: [cdesktopenv-devel] [PATCH] post_install: Fix shellcheck warnings

2018-10-30 Thread Matthew R. Trower
... my apologies; in the interest of precision, I mispoke here: it doesn't actually *break* installation per-say; it spits out alarming amounts of 'kill' spam while sleeping for 6 seconds. I did the sane thing at this point and mashed Ctrl-C. =) The rest stands. -mrt d...@blackshard.net (Matt

Re: [cdesktopenv-devel] [PATCH] post_install: Fix shellcheck warnings

2018-10-30 Thread Matthew R. Trower
I'm sorry to report that with this commit, installCDE.src:CleanDaemons() is utterly broken. It doesn't work at all on any platform, and breaks installation on non AIX/freebsd/openbsd/netbsd/linux platforms (eg: sun). On those platforms it tries to kill *all* running processes (!!). Fortunately, t

Re: [cdesktopenv-devel] [PATCH] post_install: Fix shellcheck warnings

2018-08-25 Thread Jon Trulson
Merged to master, thanks! Sorry for the delay in reviewing these - this week was very busy at $JOB. -jon On 08/19/2018 03:02 PM, Chase via cdesktopenv-devel wrote: 1st of four incoming patches Thank you for your time, -Chase

[cdesktopenv-devel] [PATCH] post_install: Fix shellcheck warnings

2018-08-19 Thread Chase via cdesktopenv-devel
1st of four incoming patches Thank you for your time, -ChaseFrom 0cb151787253c724203814135f6527a0685863cc Mon Sep 17 00:00:00 2001 From: chase Date: Sat, 18 Aug 2018 13:33:35 -0500 Subject: [PATCH 1/4] post_install: fix shellcheck warnings --- .../IntegTools/post_install/build_udb_list| 2