[cdesktopenv-devel] [PATCH] [AUTOTOOLS-CONVERSION] replace ast hash with dt hash

2020-01-26 Thread Chase via cdesktopenv-devel
So this patch will be necessary for the autotooling of ksh (or at least the updating of it then the subsequent autotooling), as ksh no longer provides its hashing library this will be necessary if we want to update it (which would also end it's dependency on ksh, and in the future we could even

Re: [cdesktopenv-devel] [PATCH][AUTOTOOLS-CONVERSION] add generated manpages

2020-01-26 Thread Jon Trulson
On 1/26/20 12:39 PM, Matthew R. Trower wrote: > Chase mentioned build times.  I understand that it would be desirable > to update and clean up the toolchain. > Well, actually generating them is pretty quick.  But all the crap we can delete by pre-generating them is not to be ignored either.  At an

Re: [cdesktopenv-devel] [PATCH][AUTOTOOLS-CONVERSION] add generated manpages

2020-01-26 Thread Matthew R. Trower
Chase mentioned build times.  I understand that it would be desirable to update and clean up the toolchain. -mrt

Re: [cdesktopenv-devel] [PATCH][AUTOTOOLS-CONVERSION] add generated manpages

2020-01-26 Thread Jon Trulson
On 1/26/20 12:34 PM, Matthew R. Trower wrote: > Well, if building manpages is truly a considerable slowdown, I guess I > wouldn't be opposed to optionally forgoing compilation in favor of > pre-generated files.  But the idea of only having pre-generated pages, > and losing the ability to build from

Re: [cdesktopenv-devel] [PATCH][AUTOTOOLS-CONVERSION] add generated manpages

2020-01-26 Thread Matthew R. Trower
Well, if building manpages is truly a considerable slowdown, I guess I wouldn't be opposed to optionally forgoing compilation in favor of pre-generated files.  But the idea of only having pre-generated pages, and losing the ability to build from source, does not sit well with me.

Re: [cdesktopenv-devel] [PATCH][AUTOTOOLS-CONVERSION] add generated manpages

2020-01-26 Thread Jon Trulson
Ok, looking at these in more detail - there is no way you could have tested these... doc/ isn't even being built yet.  So, while I am ok with pregenerating the manpages *as long as they can be verified to work on all the platforms we support*, there is no way I am going to apply patches of this ma

Re: [cdesktopenv-devel] [PATCH][AUTOTOOLS-CONVERSION] add generated manpages

2020-01-26 Thread Jon Trulson
Well, a couple of things... 1) how did you test them?  They should also perhaps be checked in a UTF locale - or converted to UTF-8... 2) While I proposed pre-generating manpages, and the help text previously, I got pushback from people. TBH, I am fine with pre-generating the man pages.  They only

Re: [cdesktopenv-devel] [PATCH][AUTOTOOLS-CONVERSION] add generated manpages

2020-01-26 Thread Jon Trulson
I went ahead and applied this to autotools-conversion, but I do want the priority on getting those other modules working first. Thanks for the clean up though. -jon On 1/20/20 11:39 AM, Chase via cdesktopenv-devel wrote: > these patches will make installing the manpages much easier via > autotoo

Re: [cdesktopenv-devel] [PATCH][AUTOTOOLS-CONVERSION] add generated manpages

2020-01-26 Thread Chase via cdesktopenv-devel
Yes, trying to get these to generate under autotools is a mess, we are going to throw out the docbook sgm files, docbooktoman and the rest and just add the post generation manpages so we can just install them via dist_man1_MANS = something.1, it will speed up build times and make life easier Th

Re: [cdesktopenv-devel] [PATCH][AUTOTOOLS-CONVERSION] add generated manpages

2020-01-26 Thread Jon Trulson
Ah, and one more thing - WRT the autotools branch, I'd prefer: 1. Do not remove any of the imake stuff.  I will do all of that myself when that branch is ready for merging into master.  It is handy having around while the conversion is still in progress. 2. I would prefer to concentrate on gettin

Re: [cdesktopenv-devel] [PATCH][AUTOTOOLS-CONVERSION] add generated manpages

2020-01-26 Thread Jon Trulson
On 1/20/20 11:39 AM, Chase via cdesktopenv-devel wrote: > these patches will make installing the manpages much easier via > autotools, as we can just use man1= manpage.1 rather than the whole > generated script mess I was working on earlier > Hi, Can you explain this in more detail?  These patch