I merged this, let's keep an eye on our jenkins jobs :) I doubt there will be
any issues
--
https://code.launchpad.net/~canonical-platform-qa/qa-jenkins-jobs/+git/qa-jenkins-jobs/+merge/471372
Your team Canonical Platform QA Team is requested to review the proposed merge
of qa-jenkins-jobs:pre-
Couple of inline comments, also CI failed unit test so unfortunately ya gotta
fix them :D
Diff comments:
> diff --git a/charms/focal/autopkgtest-web/webcontrol/request/app.py
> b/charms/focal/autopkgtest-web/webcontrol/request/app.py
> index 1f33218..caa7e4c 100644
> --- a/charms/focal/autopkgt
Tim Andersson has proposed merging
~andersson123/qa-jenkins-jobs:britney-check-no-emails into
qa-jenkins-jobs:master.
Requested reviews:
Canonical Platform QA Team (canonical-platform-qa)
For more details, see:
https://code.launchpad.net/~andersson123/qa-jenkins-jobs/+git/qa-jenkins-jobs
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:cloud-charm-fixes into autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+
The proposal to merge ~andersson123/autopkgtest-cloud:charm-fixes into
autopkgtest-cloud:master has been updated.
Description changed to:
web charm bugfixes to ease the re-deployability of the juju units
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/auto
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:three-cloud-workers into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+
I have added a fix here:
https://code.launchpad.net/~andersson123/ubuntu/+source/ubuntu-manual-tests/+git/ubuntu-manual-tests/+ref/fix/bug%232012346
--
You received this bug notification because you are a member of
Canonical's Ubuntu QA, which is subscribed to Ubuntu Manual Tests.
https://bugs.la
https://code.launchpad.net/~andersson123/ubuntu/+source/ubuntu-manual-tests/+git/ubuntu-manual-tests/+ref/fix/bug%232015464
I've amended this here, it seems the two terms 'Log in automatically' and
'Require my password to log in' are synonymous, so I've clarified in the
instructions
--
You rece
Tim Andersson has proposed merging ubuntu-manual-tests:fix/bug#2012346 into
ubuntu-manual-tests:main.
Commit message:
Fix bug #2012346
Requested reviews:
Brian Murray (brian-murray)
For more details, see:
https://code.launchpad.net/~ubuntu-testcase/ubuntu-manual-tests/+git/ubuntu-manual
Tim Andersson has proposed merging ubuntu-manual-tests:fix/bug#2015464 into
ubuntu-manual-tests:main.
Commit message:
Fix bug #2015464
Requested reviews:
Paride Legovini (paride)
For more details, see:
https://code.launchpad.net/~ubuntu-testcase/ubuntu-manual-tests/+git/ubuntu-manual-tests
Diff comments:
> diff --git a/definitions/basic_installation.xml
> b/definitions/basic_installation.xml
> index 6e1951a..40310f6 100644
> --- a/definitions/basic_installation.xml
> +++ b/definitions/basic_installation.xml
> @@ -134,7 +134,7 @@
> Select your timezone, and click on the Cont
Diff comments:
> diff --git a/definitions/basic_installation.xml
> b/definitions/basic_installation.xml
> index 6e1951a..40310f6 100644
> --- a/definitions/basic_installation.xml
> +++ b/definitions/basic_installation.xml
> @@ -134,7 +134,7 @@
> Select your timezone, and click on the Cont
The wording for this should be better. Perhaps the /home partition
should be formatted? I just tested removing the home partition and
putting it back when 'erasing' and it retains the data if not formatted.
Perhaps the instruction should say to format the /home partition, or
maybe in the second ste
I tested on my Lunar machine today. The 'no argument --architecture' error did
not occur, however when using --apt-pocket=proposed, more tests failed than
without. I guess this is to be expected but I've attached some details here
just in case:
Without
```
vlc-all FAIL badpkg
blame:
Ran these tests on my lunar machine today. No errors for 'argument not
found --architecture' occurred. Test results differed between using and
not using '--apt-pocket=proposed'.
Without proposed:
autopkgtest [10:28:21]: test vlc-all: ---]
autopkgtest [10:28:22]: test vlc-all:
On my jammy machine I ran these steps to confirm the --apt-
pocket=proposed option was working
lxc launch ubuntu:jammy sru-lp2008026-j
lxc exec sru-lp2008026-j bash
add "deb http://archive.ubuntu.com/ubuntu jammy-proposed main restricted" to
/etc/apt/sources.list
sudo apt-get -t jammy-proposed in
For testing the add-architecture I did this:
lxc launch ubuntu:kinetic sru-lp2008026-j
lxc exec sru-lp2008026-j bash
add "deb http://archive.ubuntu.com/ubuntu kinetic-proposed main restricted" to
/etc/apt/sources.list
sudo apt update
sudo apt-get -t kinetic-proposed install autopkgtest
exit
# on
Just as an addendum comment, I tested the --add-architecture arg in a
kinetic container and vlc-all did not fail, so I think there may be an
issue
--
You received this bug notification because you are a member of
Canonical's Ubuntu QA, which is subscribed to autopkgtest in Ubuntu.
https://bugs.la
Testing on jammy with version 5.25:
root@timscontainer:/home/ubuntu# apt list --installed | grep autopkgtest
WARNING: apt does not have a stable CLI interface. Use with caution in
scripts.
autopkgtest/kinetic,now 5.25ubuntu1 all [installed]
root@timscontainer:/home/ubuntu# sudo autopkgtest --arc
Testing the apt-pocket proposed
lxc launch ubuntu:kinetic timscontainer
lxc exec timscontainer bash
# Testing the wrong version
sudo apt install -t kinetic autopkgtest
exit
# Back to my machine
sudo autopkgtest-buildvm-ubuntu-cloud -a amd64 -r mantic -s 15G
lxc file push autopkgtest-mantic-amd64.i
Testing the --add-architecture argument in the same container (testing
with mawk instead of vlc as it has a shorter test duration and VLC has
some issues at the moment):
check failure with incorrect version:
root@timscontainer:/home/ubuntu# apt list --installed | grep autopkgtest
WARNING: apt doe
Retesting the --add-architecture arg with mawk as vlc has issues with
the autopkgtest tests failing, plus mawk is a lot faster
lxc launch ubuntu:jammy timscontainer
lxc exec timscontainer bash
sudo apt install autopkgtest
root@timscontainer:/home/ubuntu# apt list --installed | grep autopkgtest
WA
** Tags removed: verification-needed verification-needed-kinetic
** Tags added: verification-done-kinetic
** Tags added: verification-needed
** Tags removed: verification-needed
--
You received this bug notification because you are a member of
Canonical's Ubuntu QA, which is subscribed to autop
** Tags removed: verification-needed-jammy
** Tags added: verification-done-jammy
** Tags removed: verification-needed
--
You received this bug notification because you are a member of
Canonical's Ubuntu QA, which is subscribed to autopkgtest in Ubuntu.
https://bugs.launchpad.net/bugs/2008026
T
Public bug reported:
This happens for me with version 5.28ubuntu1 of autopkgtest on my Lunar system.
The failure happens as follows:
The script downloads the file, reaches 100% download capacity and then exits
with the message "Download failed!", shown below:
```
andersson123@duckstation7:~/cano
Comments from another test, from this bug, regarding the architecture flag:
https://bugs.launchpad.net/ubuntu/+source/autopkgtest/+bug/2008026
"""
lxc launch ubuntu:jammy timscontainer
lxc exec timscontainer bash
sudo apt install autopkgtest
root@timscontainer:/home/ubuntu# apt list --installed |
(testing on Mantic)
--
You received this bug notification because you are a member of
Canonical's Ubuntu QA, which is subscribed to autopkgtest in Ubuntu.
https://bugs.launchpad.net/bugs/2008026
Title:
[SRU Exception] Backport 5.28 to Jammy
Status in autopkgtest package in Ubuntu:
New
Statu
I addressed your comments and rebased. I think this is good to go now.
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/442546
Your team Canonical's Ubuntu QA is subscribed to branch
autopkgtest-cloud:master.
--
Mailing list: https://launchpad.net/~ca
charms/focal/autopkgtest-cloud-worker/config.yaml:default: "m1.small"
charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/worker/worker.conf:package_size_default
= m1.small
The string also occurs in the above files, do we need to change that too or
will that happen later?
--
https://cod
Review: Approve
--
https://code.launchpad.net/~ubuntu-release/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/443515
Your team Canonical's Ubuntu QA is subscribed to branch
autopkgtest-cloud:master.
--
Mailing list: https://launchpad.net/~canonical-ubuntu-qa
Post to : canonical-ubuntu-qa
I haven't tested the changed scripts yet, no. Let's create a test plan. I
imagine it'd start with deploying this branch in staging. And then manually
running any related scripts.
Honestly the disabling of some of the shellcheck tests was because I was scared
to break things. My aim is after mer
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:move_create_test_instances into
autopkgtest-cloud:master.
Commit message:
Move create-test-instances into tools directory
Requested reviews:
Paride Legovini (paride)
For more details, see:
https://code.launchpad.net
Review: Approve
--
https://code.launchpad.net/~ubuntu-release/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/443513
Your team Canonical's Ubuntu QA is subscribed to branch
autopkgtest-cloud:master.
--
Mailing list: https://launchpad.net/~canonical-ubuntu-qa
Post to : canonical-ubuntu-qa
The proposal to merge autopkgtest-cloud:cninr-autopkgtest into
autopkgtest-cloud:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~ubuntu-release/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/443513
--
Your team Canonical's Ubuntu
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:modify_seed_new_release into
autopkgtest-cloud:master.
Commit message:
Modify seed-new-release to use retries
Requested reviews:
Brian Murray (brian-murray)
For more details, see:
https://code.launchpad.net/~andersson123
The proposal to merge
~andersson123/auto-upgrade-testing-specifications:add_lunar_mantic_profiles
into auto-upgrade-testing-specifications:main has been updated.
Description changed to:
Add profiles for all relevant flavours for lunar->mantic. Pass/fail details
below:
- `ubuntu-lunar-mantic-b
Tim Andersson has proposed merging
~andersson123/auto-upgrade-testing-specifications:add_lunar_mantic_profiles
into auto-upgrade-testing-specifications:main.
Commit message:
Add lunar->mantic profiles
Requested reviews:
Canonical Platform QA Team (canonical-platform-qa)
For more deta
Review: Approve
--
https://code.launchpad.net/~ubuntu-release/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/443693
Your team Canonical's Ubuntu QA is subscribed to branch
autopkgtest-cloud:master.
--
Mailing list: https://launchpad.net/~canonical-ubuntu-qa
Post to : canonical-ubuntu-qa
Yes there is another commit but that is also in all my other MP's as to avoid
merge conflicts. I just wanted it to pass pipeline. I can remove it though,
it's no problem!
I will address shellcheck and your comments :)
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgt
If we're okay to leave the lpci changes in, this is good to go, let's discuss
in standup
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/442546
Your team Canonical's Ubuntu QA is subscribed to branch
autopkgtest-cloud:master.
--
Mailing list: https:
Restored the lpci changes
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/442546
Your team Canonical's Ubuntu QA is subscribed to branch
autopkgtest-cloud:master.
--
Mailing list: https://launchpad.net/~canonical-ubuntu-qa
Post to : canonical-ubu
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud-2:update_pipeline into
autopkgtest-cloud:master.
Commit message:
remove readthedocs build from pipeline, update lint dependency
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For
Ready for re-review
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/443597
Your team Canonical's Ubuntu QA is subscribed to branch
autopkgtest-cloud:master.
--
Mailing list: https://launchpad.net/~canonical-ubuntu-qa
Post to : canonical-ubuntu-qa
ready for re-review and testing
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/443597
Your team Canonical's Ubuntu QA is subscribed to branch
autopkgtest-cloud:master.
--
Mailing list: https://launchpad.net/~canonical-ubuntu-qa
Post to : canonic
Amended, no idea how that happened, the two files were identical as far as I
could tell, no newlines or anything I believe
Diff comments:
> diff --git a/tests/check-ubuntu-unity-desktop
> b/tests/check-ubuntu-unity-desktop
> index 8168a16..0ffc5c0 100755
> --- a/tests/check-ubuntu-unity-deskto
The merge conflict didn't take affect I don't think (at least not locally). I
think this needs re-review
--
https://code.launchpad.net/~andersson123/auto-upgrade-testing-specifications/+git/auto-upgrade-testing-specifications/+merge/443687
Your team Canonical Platform QA Team is subscribed to bra
I'm going to work on the auto-generation of the dates now.
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/442546
Your team Canonical's Ubuntu QA is subscribed to branch
autopkgtest-cloud:master.
--
Mailing list: https://launchpad.net/~canonical-ubun
Ready for re-review
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/442546
Your team Canonical's Ubuntu QA is subscribed to branch
autopkgtest-cloud:master.
--
Mailing list: https://launchpad.net/~canonical-ubuntu-qa
Post to : canonical-ubuntu-qa
Tim Andersson has proposed merging
~andersson123/auto-upgrade-testing-specifications:add-ubuntu-unity-profile into
auto-upgrade-testing-specifications:main.
Commit message:
Search for ubuntu-unity package and not task when installing for kinetic->lunar
ubuntu-unity upgrade test
Reques
The proposal to merge
~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud-2:update_pipeline into
autopkgtest-cloud:master has been updated.
Commit message changed to:
remove readthedocs build from pipeline, update lint dependency, add charmcraft
pack into pipeline
For more details, see:
ht
The proposal to merge
~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud-2:update_pipeline into
autopkgtest-cloud:master has been updated.
Description changed to:
remove readthedocs build from pipeline, update lint dependency, add charmcraft
pack into pipeline
For more details, see:
https
(needs testing)
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/442546
Your team Canonical's Ubuntu QA is subscribed to branch
autopkgtest-cloud:master.
--
Mailing list: https://launchpad.net/~canonical-ubuntu-qa
Post to : canonical-ubuntu-qa@lis
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:fake_release_seed_new_release into
autopkgtest-cloud:master.
Commit message:
add fake release flag for testing script
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
H, with regards to the retry code, if we get to the bottom of the issue, we
might not actually want to wrap the code in retries right? I won't make an MP
for that.
With regards to the print to logging, I'll amend this once these various MP's
go through.
The code is still in a separate fun
Tim Andersson has proposed merging
~andersson123/auto-upgrade-testing-specifications:add_lunar_mantic_profiles
into auto-upgrade-testing-specifications:main.
Commit message:
Remove task package for ubuntu-unity lunar->mantic
Requested reviews:
Canonical Platform QA Team (canonical-platf
Looks like this has a merge conflict in too? Really weird
--
https://code.launchpad.net/~andersson123/auto-upgrade-testing-specifications/+git/auto-upgrade-testing-specifications/+merge/443984
Your team Canonical Platform QA Team is requested to review the proposed merge
of ~andersson123/auto-up
I JUST rebased and it happened AGAIN
--
https://code.launchpad.net/~andersson123/auto-upgrade-testing-specifications/+git/auto-upgrade-testing-specifications/+merge/443984
Your team Canonical Platform QA Team is subscribed to branch
auto-upgrade-testing-specifications:main.
--
Mailing list: ht
Okay. I think ready to go now
--
https://code.launchpad.net/~andersson123/auto-upgrade-testing-specifications/+git/auto-upgrade-testing-specifications/+merge/443984
Your team Canonical Platform QA Team is subscribed to branch
auto-upgrade-testing-specifications:main.
--
Mailing list: https://l
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud-2:add_charms_to_pipeline
into autopkgtest-cloud:master.
Commit message:
update .launchpad.yaml to pack the charms before linting
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For
> Actually not yet, sorry! :-)
>
> What the change does is *installing* the ubuntu-unity-desktop package and not
> task. Please amend the commit message:
>
> git commit --amend
> git push --force
Amended, thanks :)
--
https://code.launchpad.net/~andersson123/auto-upgrade-testing-specifications
Tim Andersson has proposed merging
~andersson123/qa-jenkins-jobs:daily_charmcraft_build into
qa-jenkins-jobs:master.
Commit message:
add daily charmcraft pack
Requested reviews:
Canonical Platform QA Team (canonical-platform-qa)
For more details, see:
https://code.launchpad.net
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:seed_new_release_add_dry_run into
autopkgtest-cloud:master.
Commit message:
Add dry run option to seed new release script
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
Just updated the script after testing in Venonat. Had to sort out the lxd/lxc
installation but works fine now. Will address comments
--
https://code.launchpad.net/~andersson123/qa-jenkins-jobs/+git/qa-jenkins-jobs/+merge/444059
Your team Canonical Platform QA Team is subscribed to branch
qa-jen
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud-2:add_yamllint_to_pipeline
into autopkgtest-cloud:master.
Commit message:
add yamllint to pipeline
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
The proposal to merge ~andersson123/qa-jenkins-jobs:daily_charmcraft_build into
qa-jenkins-jobs:master has been updated.
Description changed to:
add daily charmcraft pack.
Not sure this will work. I think we need a 20.04 host to run this on or need
help resolving lxd as dependency
For more de
Done and ready for re-review / merge :)
--
https://code.launchpad.net/~andersson123/qa-jenkins-jobs/+git/qa-jenkins-jobs/+merge/444059
Your team Canonical Platform QA Team is subscribed to branch
qa-jenkins-jobs:master.
--
Mailing list: https://launchpad.net/~canonical-ubuntu-qa
Post to :
The proposal to merge autopkgtest-cloud:lxd-creds into autopkgtest-cloud:master
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~ubuntu-release/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/444126
--
Your team Canonical's Ubuntu QA is req
The proposal to merge autopkgtest-cloud:lxd-creds into autopkgtest-cloud:master
has been updated.
Status: Merged => Approved
For more details, see:
https://code.launchpad.net/~ubuntu-release/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/444126
--
Your team Canonical's Ubuntu QA is request
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:lint_tools_and_scripts into
autopkgtest-cloud:master.
Commit message:
Lint tools and scripts of autopkgtest-cloud, compartmentalise linting changes
for easier testing.
Requested reviews:
Canonical's Ubuntu QA (cano
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:lint_autopkgtest-web into
autopkgtest-cloud:master.
Commit message:
Lint only autopkgtest-web directory for easier testing
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:lint_autopkgtest-cloud-worker into
autopkgtest-cloud:master.
Commit message:
Lint only autopkgtest-cloud-worker for easier testing
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
Yes, your commit message change suggestion makes a lot of sense. I've amended
the commit message :)
--
https://code.launchpad.net/~andersson123/qa-jenkins-jobs/+git/qa-jenkins-jobs/+merge/444059
Your team Canonical Platform QA Team is subscribed to branch
qa-jenkins-jobs:master.
--
Mailing l
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:lpci_add_black into autopkgtest-cloud:master.
Commit message:
lpci: add black check to ci
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~anderss
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:add_isort_to_lpci into autopkgtest-cloud:master.
Commit message:
lpci: add isort check to ci
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~anderss
Tim Andersson has proposed merging
~andersson123/auto-upgrade-testing-specifications:check_conf_file_prompt into
auto-upgrade-testing-specifications:main.
Commit message:
add check for conf file prompt in upgrade log
Requested reviews:
Canonical Platform QA Team (canonical-platform-qa)
For
Could you add some more details on how you produced this error? What
qemu vm were you using when running autopkgtest on this package? And
what was the system the VM was running on?
--
You received this bug notification because you are a member of
Canonical's Ubuntu QA, which is subscribed to auto
Tim Andersson has proposed merging
~andersson123/qa-jenkins-jobs:add_unstable_exit_code into
qa-jenkins-jobs:master.
Commit message:
Add unstable exit code for auto-upgrade-tests
Requested reviews:
Paride Legovini (paride)
For more details, see:
https://code.launchpad.net/~andersson123/qa
> OK your other MP [1] answered my question on "What is actually going to exit
> 75". It is better the way you did it, having a "real" separate check in auto-
> upgrade-testing.
>
> Indentation still needs to be fixed I believe.
>
> [1] https://code.launchpad.net/~andersson123/auto-upgrade-testin
Are we amending the review status since we cannot, at this point in time, use
junit?
--
https://code.launchpad.net/~andersson123/qa-jenkins-jobs/+git/qa-jenkins-jobs/+merge/444727
Your team Canonical Platform QA Team is subscribed to branch
qa-jenkins-jobs:master.
--
Mailing list: https://lau
yep, you're right, i'll close this
--
https://code.launchpad.net/~andersson123/qa-jenkins-jobs/+git/qa-jenkins-jobs/+merge/444727
Your team Canonical Platform QA Team is subscribed to branch
qa-jenkins-jobs:master.
--
Mailing list: https://launchpad.net/~canonical-ubuntu-qa
Post to : canon
The proposal to merge autopkgtest-cloud:get-and-put into
autopkgtest-cloud:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~ubuntu-release/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/445296
--
Your team Canonical's Ubuntu QA is
Tim Andersson has proposed merging ~andersson123/autopkgtest-cloud:codespell
into autopkgtest-cloud:master.
Commit message:
lpci: add codespell to ci
The idea was floated a little while ago in standup. codespell checks for
spelling errors in all files in autopkgtest-cloud. If there are
The proposal to merge ~paride/autopkgtest-cloud:lint-shellscripts into
autopkgtest-cloud:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~paride/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/445422
--
Your team Canonical's Ubuntu
The proposal to merge ~paride/autopkgtest-cloud:lint-shellscripts into
autopkgtest-cloud:master has been updated.
Status: Approved => Work in progress
For more details, see:
https://code.launchpad.net/~paride/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/445422
--
Your team Canonical's Ub
The proposal to merge ~paride/autopkgtest-cloud:lint-shellscripts into
autopkgtest-cloud:master has been updated.
Status: Work in progress => Approved
For more details, see:
https://code.launchpad.net/~paride/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/445422
--
Your team Canonical's Ub
Diff comments:
> diff --git a/.launchpad.yaml b/.launchpad.yaml
> index a744b71..bec3a7d 100755
> --- a/.launchpad.yaml
> +++ b/.launchpad.yaml
> @@ -18,8 +41,3 @@ jobs:
>- name: charmcraft
> classic: true
> run: ./ci/build_charms
> - lint_test:
> -series: focal
> -
Diff comments:
> diff --git a/.launchpad.yaml b/.launchpad.yaml
> index a744b71..bec3a7d 100755
> --- a/.launchpad.yaml
> +++ b/.launchpad.yaml
> @@ -1,16 +1,39 @@
> pipeline:
>- pre_commit
>- build_charms
> - - lint_test
>
> jobs:
>pre_commit:
> -series: jammy
> +serie
Diff comments:
> diff --git a/.launchpad.yaml b/.launchpad.yaml
> index a744b71..bec3a7d 100755
> --- a/.launchpad.yaml
> +++ b/.launchpad.yaml
> @@ -1,16 +1,39 @@
> pipeline:
>- pre_commit
>- build_charms
> - - lint_test
>
> jobs:
>pre_commit:
> -series: jammy
> +serie
Diff comments:
> diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
> index 0735120..d3bc39f 100644
> --- a/.pre-commit-config.yaml
> +++ b/.pre-commit-config.yaml
> @@ -22,3 +22,28 @@ repos:
> rev: 5.12.0
> hooks:
>- id: isort
> + - repo: local
> +hooks:
> +
Looks like this MP also contains a bunch of linting changes that aren't
mentioned in the commits? Presumably from running pre-commit/pylint locally. Is
there a way to remove this and put it on a separate commit so we can verify the
linting changes are only made by a specific linting program?
--
I think we should also move the ppa to canonical-ubuntu-qa
There is no better way to install python deps.
I like the two pylint hooks as long as the one without import errors doesn't
run in CI
--
https://code.launchpad.net/~paride/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/445630
Your team C
It still looks to me like the linting changes are in the diff or am I wrong? I
think this is good to go when we have the new ppa and the linting changes are
out
--
https://code.launchpad.net/~paride/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/445630
Your team Canonical's Ubuntu QA is request
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:seed-new-release-refactor into
autopkgtest-cloud:master.
Commit message:
seed-new-release: refactor duplicate for loops
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
The diff will be a bit simpler once the other MP for creating instances and
testing mirrors has been merged.
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/445759
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson1
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:create-instances-refactor into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-
I understand the MP now, sorry for my previous confusion. LGTM.
Diff comments:
> diff --git a/.pylintrc b/.pylintrc
> index a831f0a..b6b77fa 100644
> --- a/.pylintrc
> +++ b/.pylintrc
> @@ -2,4 +2,48 @@
>
> jobs=0
>
> -disable=invalid-name, import-error, no-name-in-module
> +[MESSAGES CONTR
re-reviewed, LGTM! Just one question about docstring disables in pylint
--
https://code.launchpad.net/~paride/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/445630
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~paride/autopkgtest-cloud:pre-commit-pylint into autopk
*untested as of yet*
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/445950
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:fix_seed_new_release into
autopkgtest-cloud:master.
--
Mailing l
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:fix_seed_new_release into
autopkgtest-cloud:master.
Commit message:
fix: seed new release retries in more appropriate manner
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
Okay this is tested in staging now and ready for testing in production
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/445950
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:fix_seed_new_relea
701 - 800 of 1209 matches
Mail list logo
