Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:ugj-proxy-fix into autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/4
amended, please re-review
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/459644
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:ugj-proxy-fix into autopkgtest-cloud:master.
--
Mailing list
THIS NEEDS ANOTHER CHANGE DONT MERGE !
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/459644
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:ugj-proxy-fix into autopkgtest-cloud:master.
--
Amended, please re-review
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/459644
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:ugj-proxy-fix into autopkgtest-cloud:master.
--
Mailing list
Needs testing in staging.
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/459627
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:all-proposed-patch into
autopkgtest-cloud:master.
--
Mailin
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:filter-amqp-no-need-rerun into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-
Known issue, the db is currently incomplete and it's being repopulated
right now. Everything will be back to normal in a couple days I imagine.
--
You received this bug notification because you are a member of
Canonical's Ubuntu QA, which is subscribed to Auto Package Testing.
https://bugs.launch
Thanks for reporting!
** Changed in: auto-package-testing
Status: New => In Progress
--
You received this bug notification because you are a member of
Canonical's Ubuntu QA, which is subscribed to Auto Package Testing.
https://bugs.launchpad.net/bugs/2051851
Title:
Error: package does
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:another-github-jobs-fix into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-
Diff comments:
> diff --git
> a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/worker/worker
> b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/worker/worker
> index 3744f06..ef2ca83 100755
> --- a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/worker/worker
> +++ b
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:uuid-integration into autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:lxd-armhf-update-02022024 into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-
testing in staging now
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/459942
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:another-all-proposed-patch into
autopkgtest-cloud:master.
--
M
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:another-all-proposed-patch into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:sqlite-db-backup into autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+
The proposal to merge ~andersson123/autopkgtest-cloud:sqlite-db-backup into
autopkgtest-cloud:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460043
--
Your team
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:sqlite-db-backup into autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+
CI is unrelated tempfail, I'm going to merge this
--
https://code.launchpad.net/~ubuntu-release/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460053
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
autopkgtest-cloud:no-haproxy-lxd into autopkgtest-cloud:master.
--
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:lxd-update-after-fire into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-
rebased off of master and tested in staging just now.
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/458950
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:uuid-integration into autopkgtest-c
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:add-test-name-feat into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:quick-ugj-amendment into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+
The proposal to merge ~andersson123/autopkgtest-cloud:add-test-name-feat into
autopkgtest-cloud:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460092
--
Your te
ah, damn, I forgot to incorporate leader check in this script. I'll add that
now
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460043
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:sqlite
Public bug reported:
When the specified queue is too large (not sure what the cutoff is) you
get a traceback after deleting x number of items in the queue. I closed
the terminal so I no longer have the traceback, but it's non-specific
and unhelpful.
** Affects: auto-package-testing
Importanc
Tested in staging and fully functional.
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460043
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:sqlite-db-backup into autopkgtest-cloud:master.
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:replace-swirlix-lxc-remotes into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopk
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:create-security-group-amendment-for-bos03 into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud
CI is unrelated tempfail - I also routinely modify the script to reduce the
number of instances being created
--
https://code.launchpad.net/~ubuntu-release/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460129
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
autopkgt
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:lxd-metrics-fix into autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+
The proposal to merge ~andersson123/autopkgtest-cloud:lxd-metrics-fix into
autopkgtest-cloud:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460176
--
Your team
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:lxd-armhf6-update into autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:lxd-metrics-update into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+
I realised there's a better way to do the whole lxd remotes file thing
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460195
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:lxd-metrics-updat
This is tested now and is ready for review.
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460195
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:lxd-metrics-update into
autopkgtest-cloud:ma
I think it's better to have all-proposed=0 rather than all-proposed=null. Best
they're the same type since multiple snippets of code interact with it
--
https://code.launchpad.net/~hyask/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460240
Your team Canonical's Ubuntu QA is requested to review
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:another-lxd-update into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+
let's discuss in standup tomorrow maybe
--
https://code.launchpad.net/~hyask/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460240
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~hyask/autopkgtest-cloud:skia/always_dump_additional_params into
autopkgtest-cloud:mast
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:lxd-armhf12-replacement into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:service-bundle-bos03-arm64 into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:rabbitmq-revision-update into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:decrease-bos03-workers into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-
Approved once the commit messages have been amended as we just discussed in a
call
--
https://code.launchpad.net/~hyask/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460240
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~hyask/autopkgtest-cloud:skia/always_dump_ad
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:d-r-d-a-r-handle-simultaneous-write into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud
Needs one amendment
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460498
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:d-r-d-a-r-handle-simultaneous-write into
autopkgtest-cloud:master.
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:fix-helpers-utils-ci into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-
Tim Andersson has proposed merging ~andersson123/autopkgtest-cloud:test-name
into autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/4
Tim Andersson has proposed merging
~andersson123/qa-jenkins-jobs:fix-jammy-point-release-download-job into
qa-jenkins-jobs:master.
Requested reviews:
Canonical Platform QA Team (canonical-platform-qa)
For more details, see:
https://code.launchpad.net/~andersson123/qa-jenkins-jobs/+git/qa
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:check-test-running-amendment into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopk
The proposal to merge ~andersson123/autopkgtest-cloud:fix-dodgy-ci into
autopkgtest-cloud:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460607
--
Your team Can
Tim Andersson has proposed merging ~andersson123/autopkgtest-cloud:fix-dodgy-ci
into autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/4
Just gna try a bunch of things and see if I can get CI to reliably pass
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460607
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:fix-dodgy-ci into
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:fix-install-section-web-systemd-units into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:cloud-worker-tmp-cleanup into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-
The proposal to merge
~andersson123/autopkgtest-cloud:fix-install-section-web-systemd-units into
autopkgtest-cloud:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merg
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:dont-check-huge-tests-for-duplicate-queued-items
into autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-
I don't think we need a minimally sized backup, given that we clear up old
backups in this script as well. SO I think not locking and not vacuuming is the
better option here.
Thanks so much for the review Dave. Your help on this has been really handy and
awesome.
--
https://code.launchpad.net/
object_path = "%s/%s" % (now, DB_PATH.rsplit("/", maxsplit=1)[-1] + ".gz")
AttributeError: 'PosixPath' object has no attribute 'rsplit'
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460043
Your team Canonical's Ubuntu QA is requested to review the
Amended and ready for re-review.
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460043
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:sqlite-db-backup into autopkgtest-cloud:master.
--
Ma
well, worked as expected, but not as we want it to right? Or you're saying the
oldfile u made got deleted?
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460680
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123
I'm going to amend all your smaller comments now and address your larger
pathlib comment after :)
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460043
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgt
Diff comments:
> diff --git a/charms/focal/autopkgtest-web/webcontrol/db-backup
> b/charms/focal/autopkgtest-web/webcontrol/db-backup
> new file mode 100755
> index 000..273e153
> --- /dev/null
> +++ b/charms/focal/autopkgtest-web/webcontrol/db-backup
> @@ -0,0 +1,201 @@
> +#!/usr/bin/pyth
Hey, this got amended a little while ago, if you're in one of these
teams [1] you can trigger tests for a new package
[1] https://git.launchpad.net/autopkgtest-
cloud/tree/charms/focal/autopkgtest-web/webcontrol/request/submit.py#n39
** Changed in: autopkgtest (Ubuntu)
Status: Confirmed =>
Decided not to amend it to completely use pathlib like u say, but I use it in
more places now.
This is ready for another review round now :)
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460043
Your team Canonical's Ubuntu QA is requested to review t
I didn't think we still got emails for work in progress MP's, mb
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460607
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:fix-dodgy-ci into autopk
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:d-r-d-a-r-merging into autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+
This is tested in staging btw.
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460847
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:d-r-d-a-r-merging into autopkgtest-cloud:master.
--
Mai
Look at that. I completely forgot to do this. testing now.
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/456773
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:lxd-cleanup-srv-files into
au
Tested and fully functional. Noice
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/456773
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:lxd-cleanup-srv-files into
autopkgtest-cloud:master.
Diff comments:
> diff --git a/charms/focal/autopkgtest-web/webcontrol/download-results
> b/charms/focal/autopkgtest-web/webcontrol/download-results
> index e71d4a0..4b9b11e 100755
> --- a/charms/focal/autopkgtest-web/webcontrol/download-results
> +++ b/charms/focal/autopkgtest-web/webcontrol/d
Diff comments:
> diff --git a/charms/focal/autopkgtest-web/webcontrol/sqlite-writer
> b/charms/focal/autopkgtest-web/webcontrol/sqlite-writer
> new file mode 100755
> index 000..3939bde
> --- /dev/null
> +++ b/charms/focal/autopkgtest-web/webcontrol/sqlite-writer
> @@ -0,0 +1,136 @@
> +#!/
LGTM. I'll test this in staging and check all is okay, then merge it.
--
https://code.launchpad.net/~ubuntu-release/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460979
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
autopkgtest-cloud:adt-region into autopkgtest-clo
Tested in staging, all good, merging it
--
https://code.launchpad.net/~ubuntu-release/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460979
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
autopkgtest-cloud:adt-region into autopkgtest-cloud:master.
--
Mailing list:
Looks like I accidentally merged this :)
--
https://code.launchpad.net/~hyask/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/461022
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~hyask/autopkgtest-cloud:skia/improve_browsing into autopkgtest-cloud:master.
--
Mai
still going to review though
--
https://code.launchpad.net/~hyask/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/461022
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~hyask/autopkgtest-cloud:skia/improve_browsing into autopkgtest-cloud:master.
--
Mailing list:
lbjsbootstrap changes to be tested in staging before deployment
--
https://code.launchpad.net/~hyask/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/461022
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~hyask/autopkgtest-cloud:skia/improve_browsing into autopkgtest-
Skia to implement new Exceptions in helpers/exceptions.py for the new
get_running_jobs function.
Also implement all exception handler in browse.cgi for extendability.
--
https://code.launchpad.net/~hyask/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/461022
Your team Canonical's Ubuntu QA is re
Skia to remove header/hyperlink (h2) from running macro, move into
browse-running and browse-admin.
--
https://code.launchpad.net/~hyask/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/461027
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~hyask/autopkgtest-cloud:sk
Skia to
- both commit messages more verbose
--
https://code.launchpad.net/~hyask/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/461027
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~hyask/autopkgtest-cloud:skia/ease_browse_dev into autopkgtest-cloud:master.
--
LGTM once CI passes :)
--
https://code.launchpad.net/~hyask/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/461027
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~hyask/autopkgtest-cloud:skia/ease_browse_dev into autopkgtest-cloud:master.
--
Mailing list: https://
Rebased off of master for CI, thanks so much for your review Dave.
I think Brian will take a look at this and then we'll merge it.
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460043
Your team Canonical's Ubuntu QA is requested to review the proposed
Diff comments:
> diff --git a/charms/focal/autopkgtest-web/webcontrol/sqlite-writer
> b/charms/focal/autopkgtest-web/webcontrol/sqlite-writer
> new file mode 100755
> index 000..3939bde
> --- /dev/null
> +++ b/charms/focal/autopkgtest-web/webcontrol/sqlite-writer
> @@ -0,0 +1,136 @@
> +#!/
amended, please re-review :) The configparser.read problem is prevalent
throughout the whole repository, so I've made a card to remind myself to go
back and do that refactoring :)
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460847
Your team Canoni
I'm going to test this again in staging now.
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460847
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:d-r-d-a-r-merging into autopkgtest-cloud:mas
There was one small bug but it's fixed now :P
This is ready for another review.
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460847
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:d-r-d-a-
Preserving Dave's comment here:
I'm not convinced the problematic ones will stay in the queue. Having failed
the INSERT, and logged the error, we just continue onto basic_ack() the
message, which should remove the message from queue storage and reply to the
client that we've successfully dealt
Makes total sense btw. Tryna think of what the best possible approach is...
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460847
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:d-r-d-a-r-mer
I think logspamming and ack'ing the message is actually the best approach ...
if everything is borked (r.e. the db), we'll likely know anyway. And I'd
rather, in the weird case some succeed and some fail, that it doesn't traceback
- although that situation I really don't see happening at all :/
Changed my mind. Better to have the service failing to see something is wrong
rather than having to check journalctl. I'll amend
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460847
Your team Canonical's Ubuntu QA is requested to review the proposed m
amended and ready for re-review. I removed the try except block - it's best if
the service just fails, as it shouldn't ever fail under normal circumstances.
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460847
Your team Canonical's Ubuntu QA is reques
also just FYI - not ack'ing a message in the queue listener callback WILL cause
the queue item to stay in the queue, so it is an option in callback functions
to leave the message in the queue if you choose not to do something with it :)
--
https://code.launchpad.net/~andersson123/autopkgtest-clo
I need to test this in staging again as I've detailed in the jira card as well.
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460847
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:d-r-d-a-r
LGTM! But failed CI, fix that and I'll approve :)
--
https://code.launchpad.net/~hyask/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/461059
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~hyask/autopkgtest-cloud:skia/browse_exception_handler into
autopkgtest-cloud
Sorry, just realised I do have a qualm with this:
Please amend the commit message to accurately reflect the changes. This commit
doesn't just add a generic exception handler ;)
--
https://code.launchpad.net/~hyask/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/461059
Your team Canonical's Ubunt
The proposal to merge
~andersson123/autopkgtest-cloud:create-test-instances-refactor into
autopkgtest-cloud:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/46112
needs testing and the commit messages need more detail :)
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/461125
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:create-test-instances-refactor
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:create-test-instances-refactor into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopk
amended and ready for review :)
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/461125
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:create-test-instances-refactor into
autopkgtest-cloud:m
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:create-test-instances-refactor into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopk
This is tested in staging as Brian and I discussed yesterday in our 121
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/460847
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:d-r-d-a-r-mergin
201 - 300 of 1209 matches
Mail list logo
