Re: Re: [PATCH] hexdump: add test to verify -n4 -e '"%u"'

2024-10-25 Thread Clayton Craft
On Thur, 24 Oct 2024 08:32:58 UTC David Laight wrote: > On Wed, 23 Oct 2024 15:11:20 +0200 Natanael Copa > wrote: > > - byte_count_str = "\010\004\002\001"; > > + byte_count_str = "\004\002\001"; > > Without actually checking is that a

RE: [PATCH] hexdump: add test to verify -n4 -e '"%u"'

2024-10-24 Thread David Laight
From: Clayton Craft > Sent: 23 October 2024 19:04 > > On Wed, 23 Oct 2024 15:11:20 +0200 Natanael Copa > wrote: > > I git bisected the bug to: > > commit e2287f99fe6f21fd6435ad04340170ad4ba5f6b3 > > I found that if this one byte is reverted from the patch you blamed, then > your test passes: >

Re: [PATCH] hexdump: add test to verify -n4 -e '"%u"'

2024-10-23 Thread Steffen Nurpmeso
Steffen Nurpmeso wrote in <20241023213552.tNfZc0Ju@steffen%sdaoden.eu>: |Natanael Copa wrote in | <20241023152936.658a4fdd@ncopa-desktop>: ||On Wed, 23 Oct 2024 15:11:20 +0200 ||Natanael Copa wrote: || ||> Add test that uncovers bug introduced in busybox 1.37.0 ... ||I git bisected the bu

Re: [PATCH] hexdump: add test to verify -n4 -e '"%u"'

2024-10-23 Thread Steffen Nurpmeso
Natanael Copa wrote in <20241023152936.658a4fdd@ncopa-desktop>: |On Wed, 23 Oct 2024 15:11:20 +0200 |Natanael Copa wrote: | |> Add test that uncovers bug introduced in busybox 1.37.0 |> --- |> testsuite/hexdump.tests | 7 +++ |> 1 file changed, 7 insertions(+) |> |> diff --git a/te

Re: [PATCH] hexdump: add test to verify -n4 -e '"%u"'

2024-10-23 Thread Natanael Copa
I can confirm this. The tests for od passes as well. Denys, maybe this can be applied? Natanael Copa ons. 23. okt. 2024 kl. 20:12 skrev Clayton Craft : > On Wed, 23 Oct 2024 15:11:20 +0200 Natanael Copa > wrote: > > I git bisected the bug to: > > commit e2287f99fe6f21fd6435ad04340170ad4ba5f6b

Re: [PATCH] hexdump: add test to verify -n4 -e '"%u"'

2024-10-23 Thread Clayton Craft
On Wed, 23 Oct 2024 15:11:20 +0200 Natanael Copa wrote: > I git bisected the bug to: > commit e2287f99fe6f21fd6435ad04340170ad4ba5f6b3 I found that if this one byte is reverted from the patch you blamed, then your test passes: diff --git a/libbb/dump.c b/libbb/dump.c index b406a2428..92b0d762c

Re: [PATCH] hexdump: add test to verify -n4 -e '"%u"'

2024-10-23 Thread Natanael Copa
On Wed, 23 Oct 2024 15:11:20 +0200 Natanael Copa wrote: > Add test that uncovers bug introduced in busybox 1.37.0 > --- > testsuite/hexdump.tests | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/testsuite/hexdump.tests b/testsuite/hexdump.tests > index be0379cfc..b933cd1a8 100755