Re: Failure with Github Actions from outside of the organization (out of a sudden!)

2021-01-07 Thread Jarek Potiuk
Vladimir, You did not convince me at all, that hand-crafted approach is almost the same security as submodule. I simply don't agree with that statement and I think it simply best to agree that we disagree and saying it's less secure is completely unfounded (again this is my opinion, with which yo

Re: Failure with Github Actions from outside of the organization (out of a sudden!)

2021-01-07 Thread Vladimir Sitnikov
Jarek> I am proposing here is just the way Jarek>how we've done that at Airflow Jarek, sharing the experience is awesome. No kidding. I did review Airflow actions, there are nice bits, however, I believe I do not need those. The workflows of my projects are way simpler. However, you suggested mak

Re: Failure with Github Actions from outside of the organization (out of a sudden!)

2021-01-07 Thread Jarek Potiuk
On Thu, Jan 7, 2021 at 7:29 PM Matt Sicker wrote: > GitHub supports SVN to an extent, but it's more of an SVN view of a > Git repo. Try it out: > > svn info https://github.com/apache/whimsy/ > > Path: whimsy > URL: https://github.com/apache/whimsy > Relative URL: ^/ > Repository Root: https://git

Re: Failure with Github Actions from outside of the organization (out of a sudden!)

2021-01-07 Thread Matt Sicker
GitHub supports SVN to an extent, but it's more of an SVN view of a Git repo. Try it out: svn info https://github.com/apache/whimsy/ Path: whimsy URL: https://github.com/apache/whimsy Relative URL: ^/ Repository Root: https://github.com/apache/whimsy Repository UUID: 54ef964a-1539-08b0-68b0-ce57b

Re: Failure with Github Actions from outside of the organization (out of a sudden!)

2021-01-07 Thread Jarek Potiuk
On Thu, Jan 7, 2021 at 6:56 PM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > What I mean is that there's a trivial workaround which does not require > significant changes to the repository layout. On top of that, it does not > change developer's workflows (they do not need to learn sub

Re: Failure with Github Actions from outside of the organization (out of a sudden!)

2021-01-07 Thread Vladimir Sitnikov
What I mean is that there's a trivial workaround which does not require significant changes to the repository layout. On top of that, it does not change developer's workflows (they do not need to learn submodules) On top of that, git submodules are NOT available for SVN repositories. >GitHub supp

Re: Failure with Github Actions from outside of the organization (out of a sudden!)

2021-01-07 Thread Jarek Potiuk
Very simple. Submodule are a standard git feature and provide automated compliance with https://docs.github.com/en/free-pro-team@latest/actions/learn-github-actions/security-hardening-for-github-actions#using-third-party-actions * submodules allow you to perform code review before the merge. You g

Re: Failure with Github Actions from outside of the organization (out of a sudden!)

2021-01-07 Thread Vladimir Sitnikov
Jarek>What we propose: Jarek>.gitmodules What is the purpose of git submodules here? However, that suggests there's a way easier workaround (see PR https://github.com/apache/calcite/pull/2318 ). Action repository can be cloned right before the action is used. No submodules needed, and the workarou