On Thu, 6 Mar 2025 12:46:25 GMT, David Holmes wrote:
> Abstracting this out seems reasonable to me, though I should say I thought we
> already used `-pthread` rather than `-lpthread`.
I noticed there were a few places that used `-pthread` by default. I left these
alone in this PR.
---
On Mon, 17 Mar 2025 06:41:31 GMT, David Holmes wrote:
>> @magicus why can't we just use `-pthread` everywhere? My recollection is
>> that `-pthread` both sets compiler directives needed for pthread programming
>> and links to libpthread, so it seems to be what we should be using. ??
>
>> Anothe
On Thu, 27 Mar 2025 02:57:23 GMT, SendaoYan wrote:
> Hi all,
>
> Apologize for the inconvenience, fix of
> [JDK-8352481](https://bugs.openjdk.org/browse/JDK-8352481) make AIX build
> broekn.
>
> According to the implementation of makefile function
> `FLAGS_SETUP_LDFLAGS_HELPER` which locate
On Thu, 27 Mar 2025 09:09:52 GMT, Matthias Baesken wrote:
> I wonder what to do with BSD , afaik they also use clang and probably have
> the flag that is missing on AIX ?
I'll have a look at it, but lld is the default linker, at least on FreeBSD, so
I don't think we need the flag to begin with
On Thu, 3 Apr 2025 07:59:26 GMT, snake66 wrote:
> The autoconf scrips fail to find libjpeg on systems where it's not installed
> in the default system include and library directories. It should check for
> the pkgconfig in these cases.
>
> This work is sponsored by Th
On Thu, 3 Apr 2025 08:04:50 GMT, snake66 wrote:
> The configure script is not able to pick up the giflib installed via system
> packages if it's not located in the system include and lib directories. Since
> giflib does not provide a pkgconfig, arguments to specify the l
On Thu, 3 Apr 2025 07:59:26 GMT, snake66 wrote:
> The autoconf scrips fail to find libjpeg on systems where it's not installed
> in the default system include and library directories. It should check for
> the pkgconfig in these cases.
>
> This work is sponsored by Th
On Thu, 3 Apr 2025 08:04:50 GMT, snake66 wrote:
> The configure script is not able to pick up the giflib installed via system
> packages if it's not located in the system include and lib directories. Since
> giflib does not provide a pkgconfig, arguments to specify the l
d for the full JDK, and set at the configure stage.
>
> Sponsored by: The FreeBSD Foundation
> Co-authored-by: Greg Lewis
>
> [1]:
> https://github.com/battleblow/jdk23u/commit/dbd90aa8ab0b7f5e4865864a7c63d975daacabf4
snake66 has updated the pull request incrementally with
Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's
possible to parameterize this for platforms that use different flags for
enabling posix threads.
This work is a continuation of the work done by Greg Lewis in [1], but
generalized for the full JDK, and set at the conf
On Thu, 6 Mar 2025 15:56:43 GMT, Magnus Ihse Bursie wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done
On Thu, 6 Mar 2025 14:15:38 GMT, Erik Joelsson wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done by Gr
On Thu, 6 Mar 2025 10:39:27 GMT, snake66 wrote:
> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's
> possible to parameterize this for platforms that use different flags for
> enabling posix threads.
>
> This work is a continuation of the wor
On Thu, 6 Mar 2025 13:53:31 GMT, Antonio Vieiro wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done by G
Allows for future support for platforms that require different flags for
libiconv support.
Sponsored-by: The FreeBSD Foundation
-
Commit messages:
- 8351323: Parameterize libiconv compiler and linker flags
Changes: https://git.openjdk.org/jdk/pull/23995/files
Webrev: https://web
On Thu, 13 Mar 2025 13:28:32 GMT, Magnus Ihse Bursie wrote:
>> snake66 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Unbreak libjdwp build
>
> Then I think the current solution is fine. Even if OpenBSD
> Allows for future support for platforms that require different flags for
> libiconv support.
>
> Sponsored-by: The FreeBSD Foundation
snake66 has updated the pull request incrementally with one additional commit
since the last revision:
Unbreak libjdwp build
--
> Allows for future support for platforms that require different flags for
> libiconv support.
>
> Sponsored-by: The FreeBSD Foundation
snake66 has updated the pull request incrementally with one additional commit
since the last revision:
Set ICONV_* flags for aix and
On Tue, 11 Mar 2025 19:22:34 GMT, snake66 wrote:
> Allows for future support for platforms that require different flags for
> libiconv support.
>
> Sponsored-by: The FreeBSD Foundation
This pull request has now been integrated.
Changeset: 771e160d
Author:Harald Ei
On Wed, 12 Mar 2025 12:15:18 GMT, Magnus Ihse Bursie wrote:
> > Another way to phrase this is perhaps: "why don't we need iconv on linux?"
>
> I googled this and can answer it myself: because `iconv()` is built into
> glibc.
Yes, that's what I came to as well. Sorry I didn't include that info
On Tue, 11 Mar 2025 19:35:45 GMT, Erik Joelsson wrote:
>> Allows for future support for platforms that require different flags for
>> libiconv support.
>>
>> Sponsored-by: The FreeBSD Foundation
>
> I think this looks ok, but please wait for Magnus to have a look too.
@erikj79 Thanks for the r
On Wed, 12 Mar 2025 16:56:32 GMT, Magnus Ihse Bursie wrote:
> Also, to double check, are the new variables `ICONV_CFLAGS` and
> `ICONV_LDFLAGS` going to be non-empty on BSD?
Yes, the current BSD port has the following in `libraries.m4`:
if test "x$OPENJDK_TARGET_OS" = "xbsd"; then
if te
The configure script is not able to pick up the giflib installed via system
packages if it's not located in the system include and lib directories. Since
giflib does not provide a pkgconfig, arguments to specify the location of the
include and library files needs to be added to the configure scr
The autoconf scrips fail to find libjpeg on systems where it's not installed in
the default system include and library directories. It should check for the
pkgconfig in these cases.
This work is sponsored by The FreeBSD Foundation
-
Commit messages:
- JDK-8353580: libjpeg is not f
24 matches
Mail list logo
