The DLL should be built no matter what `BUILD_CRYPTO` is.
-
Commit messages:
- the fix
Changes: https://git.openjdk.org/jdk/pull/9647/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9647&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8290920
Stats: 25 lines in 1 fil
> The DLL should be built no matter what `BUILD_CRYPTO` is.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
indentation change
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9647/files
- new: ht
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote:
> After the "this-escape" lint warning was added to javac (JDK-8015831), the
> base module was not updated to be able to compile with this warning enabled.
> This PR makes the necessary changes to allow the base module to build with
> the warni
On Mon, 13 May 2024 11:47:38 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
On Tue, 26 Jul 2022 18:12:33 GMT, Weijun Wang wrote:
> The DLL should be built no matter what `BUILD_CRYPTO` is.
This pull request has now been integrated.
Changeset: 5e1e449c
Author: Weijun Wang
URL:
https://git.openjdk.org/jdk/commit/5e1e449c116d44fb77a21ce4cd5187cfc55263f2
St
On Fri, 30 Sep 2022 04:05:51 GMT, Iris Clark wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> http -> https
>
> src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.h line
> 34:
>
>> 32: * the follo
On Fri, 30 Sep 2022 17:38:54 GMT, Phil Race wrote:
>> Why do we need to link to a URL? Why not `../../bridge/AccessBridgeCalls.c`?
>
> This is correct.
> AccessBridge.h is published with the include/header files of the JDK and
> anyone reading it there can't exactly make use of "../"
Thanks @pr
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Fri, 17 Mar 2023 20:28:13 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is adjusted to support reading in t
On Fri, 17 Mar 2023 21:49:33 GMT, Weijun Wang wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adjust CF test to read in with UTF-8 to fix failing test
>
> make/jdk/src/classes
On Tue, 13 Jun 2023 20:36:28 GMT, Anthony Scarpino
wrote:
> Hi,
>
> I need a code review for moving the contents of the jdk.crypto.ec module into
> java.base. This moves the SunEC JCE Provider (Elliptic Curve) into
> java.base. EC has always been separate from the base module/pkg because of
On Mon, 14 Oct 2024 13:52:24 GMT, Sean Mullan wrote:
> This is the implementation of JEP 486: Permanently Disable the Security
> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
> main change
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Fri, 18 Oct 2024 19:52:35 GMT, Sean Mullan wrote:
>> I assume for the second one above you mean
>> `javax.security.auth.kerberos.ServicePermission`. These classes still have a
>> lot of words like "grant" and "trust". I will make some changes to the
>> class descriptions of those classes,
On Wed, 16 Oct 2024 20:51:49 GMT, Sean Mullan wrote:
>> src/jdk.security.jgss/share/classes/com/sun/security/jgss/InquireSecContextPermission.java
>> line 31:
>>
>>> 29:
>>> 30: /**
>>> 31: * This class is for GSS security context permissions.
>>
>> Why is the content of _this_ class modifie
On Mon, 28 Oct 2024 21:02:00 GMT, Sean Mullan wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 175 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Specify that params
On Mon, 21 Oct 2024 14:34:30 GMT, Julian Waters wrote:
> After 8339120, gcc began catching many different instances of unused code in
> the Windows specific codebase. Some of these seem to be bugs. I've taken the
> effort to mark out all the relevant globals and locals that trigger the
> unuse
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Fri, 25 Oct 2024 21:14:25 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/java/security/SecureClassLoader.java line 1:
>>
>>> 1: /*
>>
>> The class spec still mentions "permissions which are retrieved by the system
>> policy by default". Shall we remove it? Also, `getPermissions` alw
On Fri, 25 Oct 2024 20:53:23 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/java/security/AccessControlContext.java line 141:
>>
>>> 139: throws AccessControlException
>>> 140: {
>>> 141: throw new AccessControlException("");
>>
>> No message for this exception?
>
>
On Fri, 8 Nov 2024 13:49:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main cha
On Fri, 14 Feb 2025 18:22:26 GMT, Leonid Mesnik wrote:
>> The fix add remaining classes to the testlibrary jar and fix some warnings
>> in security-related classes.
>
> Leonid Mesnik has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - added
On Fri, 14 Feb 2025 18:19:17 GMT, Leonid Mesnik wrote:
>> test/lib/jdk/test/lib/security/XMLUtils.java line 557:
>>
>>> 555: }
>>> 556:
>>> 557: // MISC
>>
>> This is a section break for various groups of methods in this utility class.
>> Before this there have been
>>
>> ///
On Fri, 14 Feb 2025 19:23:54 GMT, Weijun Wang wrote:
>> sure, since such comments are cause warning, i just suppress them.
>
> Oh, they were recognized as Markdown javadoc? I didn't think of that.
>
> It's strange that the other 4 show no warning, and then I no
On Tue, 11 Feb 2025 17:10:37 GMT, Leonid Mesnik wrote:
>> The fix add remaining classes to the testlibrary jar and fix some warnings
>> in security-related classes.
>
> Leonid Mesnik has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Merge
26 matches
Mail list logo
