RFR: 8268719: Force execution (and source) code page used when compiling on Windows

2023-09-06 Thread Saint Wesonga
Set MSVC source and execution character sets to UTF-8 to enable Visual C++ to compile all source files regardless of the active code page on Windows. This avoids build errors due to "warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the

Integrated: 8268719: Force execution (and source) code page used when compiling on Windows

2023-09-06 Thread Saint Wesonga
On Tue, 5 Sep 2023 15:51:58 GMT, Saint Wesonga wrote: > Set MSVC source and execution character sets to UTF-8 to enable Visual C++ to > compile all source files regardless of the active code page on Windows. This > avoids build errors due to "warning C4819: The file contains a

Re: RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v33]

2024-11-08 Thread Saint Wesonga
On Fri, 8 Nov 2024 11:31:40 GMT, Magnus Ihse Bursie wrote: >> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86 >> Port_](https://openjdk.org/jeps/479). >> >> This is the summary of JEP 479: >>> Remove the source code and build support for the Windows 32-bit x86 port. >>>

Re: RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v13]

2024-11-08 Thread Saint Wesonga
On Wed, 30 Oct 2024 11:05:17 GMT, Magnus Ihse Bursie wrote: >> make/scripts/compare.sh line 1457: >> >>> 1455: THIS_SEC_BIN="$THIS_SEC_DIR/sec-bin.zip" >>> 1456: if [ "$OPENJDK_TARGET_OS" = "windows" ]; then >>> 1457: JGSS_WINDOWS_BIN="jgss-windows-x64-bin.zip" >> >>

Re: RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v33]

2024-11-08 Thread Saint Wesonga
On Fri, 8 Nov 2024 11:31:40 GMT, Magnus Ihse Bursie wrote: >> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86 >> Port_](https://openjdk.org/jeps/479). >> >> This is the summary of JEP 479: >>> Remove the source code and build support for the Windows 32-bit x86 port. >>>

RFR: 8353009: Document target selection flag for Windows AArch64 builds

2025-03-26 Thread Saint Wesonga
The target selection configuration flag for Windows AArch64 should be added to the build documentation for improved discoverability and completeness. - Commit messages: - Document how to build for Windows AArch64 Changes: https://git.openjdk.org/jdk/pull/24267/files Webrev: https

Re: RFR: 8353009: Document target selection flag for Windows AArch64 builds

2025-03-27 Thread Saint Wesonga
On Thu, 27 Mar 2025 11:37:29 GMT, Matthias Baesken wrote: > Thanks for documenting it ! My colleague used instead > '--build=aarch64-pc-cygwin' , is this equivalent ? I don't think `--build=aarch64-pc-cygwin` is equivalent to `--openjdk-target=aarch64-unknown-cygwin`. The build experts can cla

Re: RFR: 8353009: Document target selection flag for Windows AArch64 builds [v3]

2025-04-10 Thread Saint Wesonga
On Fri, 4 Apr 2025 14:28:00 GMT, Magnus Ihse Bursie wrote: > It might still make sense to document that to cross-compile to aarch64, the > flag `--openjdk-target=aarch64-unknown-cygwin` should be used -- that is in > no way obvious or trivial to figure out. ok, I'll leave the cross-compilation

Integrated: 8353009: Improve documentation for Windows AArch64 builds

2025-04-17 Thread Saint Wesonga
On Wed, 26 Mar 2025 22:38:40 GMT, Saint Wesonga wrote: > The target selection configuration flag for Windows AArch64 should be added > to the build documentation for improved discoverability and completeness. This pull request has now been integrated. Changeset: 86f3eafa Author:

Re: RFR: 8353009: Improve documentation for Windows AArch64 builds [v6]

2025-04-16 Thread Saint Wesonga
> The target selection configuration flag for Windows AArch64 should be added > to the build documentation for improved discoverability and completeness. Saint Wesonga has updated the pull request incrementally with two additional commits since the last revision: - Remove trailing whit

Re: RFR: 8353009: Document target selection flag for Windows AArch64 builds [v5]

2025-04-16 Thread Saint Wesonga
> The target selection configuration flag for Windows AArch64 should be added > to the build documentation for improved discoverability and completeness. Saint Wesonga has updated the pull request incrementally with one additional commit since the last revision: Simplify documen

Re: RFR: 8353009: Document target selection flag for Windows AArch64 builds [v4]

2025-04-15 Thread Saint Wesonga
> The target selection configuration flag for Windows AArch64 should be added > to the build documentation for improved discoverability and completeness. Saint Wesonga has updated the pull request incrementally with two additional commits since the last revision: - Add Visual Studio

Re: RFR: 8353009: Document target selection flag for Windows AArch64 builds

2025-03-31 Thread Saint Wesonga
On Mon, 31 Mar 2025 14:27:19 GMT, Erik Joelsson wrote: > > But is the problem that we just fails to detect the _build_ platform, and > > thus generates build tools for x64, instead of aarch64, which makes the > > build fail? (Also, why doesn't the rosetta-equivalent kick in in that case?) > > O

Re: RFR: 8353009: Document target selection flag for Windows AArch64 builds

2025-03-31 Thread Saint Wesonga
On Mon, 31 Mar 2025 10:14:54 GMT, Magnus Ihse Bursie wrote: > > Wait, are you saying you can get a native build to work by setting > > --build=aarch64-pc-cygwin? If so, then that's a better instruction IMO. > > No, it's not. If we could block the `--build` flag, we would. This is the > built-i

Re: RFR: 8353009: Document target selection flag for Windows AArch64 builds [v3]

2025-03-31 Thread Saint Wesonga
> The target selection configuration flag for Windows AArch64 should be added > to the build documentation for improved discoverability and completeness. Saint Wesonga has updated the pull request incrementally with one additional commit since the last revision: Add instructions for a

Re: RFR: 8353009: Document target selection flag for Windows AArch64 builds

2025-03-31 Thread Saint Wesonga
On Mon, 31 Mar 2025 13:16:34 GMT, Erik Joelsson wrote: > > Wait a minute. I re-read the discussion a bit more carefully, and let my > > brain re-process what I said above... > > Is the goal here to document how you properly do cross-compilation for > > windows/aarch64 on windows/x64? If so, I t

Re: RFR: 8353066: Properly detect Windows/aarch64 as build platform

2025-04-02 Thread Saint Wesonga
On Wed, 2 Apr 2025 23:28:55 GMT, Magnus Ihse Bursie wrote: > @swesonga @MBaesken Can you please verify that this works for you too? This works for me. The build type is native, the C++ compiler is an ARM64 binary, and the resulting build has ARM64 binaries. Thanks. - PR Comment: h

Re: RFR: 8353009: Document target selection flag for Windows AArch64 builds [v2]

2025-04-04 Thread Saint Wesonga
> The target selection configuration flag for Windows AArch64 should be added > to the build documentation for improved discoverability and completeness. Saint Wesonga has updated the pull request incrementally with one additional commit since the last revision: Clarify that instructio