On Fri, 20 Oct 2023 15:45:50 GMT, Doug Simon wrote:
>> The Graal code base has
>> [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33)
>> its module to `jdk.compiler.graal` as part of preparations for Project
>> Galahad. Due to the way Java modules work, t
Please review an update to the way that `javadoc` handles the default legal
notices when generating docs.
Previously, the default notices were taken from the module's `legal` directory
(`$JAVA_HOME/legal/jdk.javadoc`), but in some contexts, these files were either
symbolic links, or "descriptiv
On Wed, 25 Oct 2023 23:38:38 GMT, Erik Joelsson wrote:
>> Please review an update to the way that `javadoc` handles the default legal
>> notices when generating docs.
>>
>> Previously, the default notices were taken from the module's `legal`
>> directory (`$JAVA_HOME/legal/jdk.javadoc`), but i
On Thu, 26 Oct 2023 13:29:04 GMT, Magnus Ihse Bursie wrote:
>> Please review an update to the way that `javadoc` handles the default legal
>> notices when generating docs.
>>
>> Previously, the default notices were taken from the module's `legal`
>> directory (`$JAVA_HOME/legal/jdk.javadoc`),
, because they provided their own minimal file
> manager for use with `javadoc`, which relied on default methods in the file
> manager API. These default methods are not sufficiently for handling paths in
> non-default file systems, such as the `jrt:` file system used to access the
&
On Thu, 26 Oct 2023 19:04:16 GMT, Joe Darcy wrote:
> Clarify the intention of tier 1 tests. I'll reflow the paragraph and
> regenerate the HTML file once the wording is agreed upon.
doc/testing.md line 138:
> 136: A brief description of the tiered test groups:
> 137:
> 138: - `tier1`: This is
On 10/29/23 11:21 AM, Alan Bateman wrote:
On Sat, 28 Oct 2023 21:03:50 GMT, Joe Darcy wrote:
So in terms of a sentence or two of guidance, I think "aim for 10 seconds or less
almost all of the time for a tier 1 test" is reasonable in this context.
Yes, I think making it an aspiration would
On Mon, 30 Oct 2023 21:43:11 GMT, Mandy Chung wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review feedback
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclet
, because they provided their own minimal file
> manager for use with `javadoc`, which relied on default methods in the file
> manager API. These default methods are not sufficiently for handling paths in
> non-default file systems, such as the `jrt:` file system used to access the
&
On Wed, 25 Oct 2023 23:06:59 GMT, Jonathan Gibbons wrote:
> Please review an update to the way that `javadoc` handles the default legal
> notices when generating docs.
>
> Previously, the default notices were taken from the module's `legal`
> directory (`$JAVA_HOME/legal/j
Please review a patch to add support for Markdown syntax in documentation
comments, as described in the associated JEP.
Notable features:
* support for `///` documentation comments in `JavaTokenizer`
* new module `jdk.internal.md` -- a private copy of the `commonmark-java`
library
* updates to
the `commonmark-java`
> library
> * updates to `DocCommentParser` to treat `///` comments as Markdown
> * updates to the standard doclet to render Markdown comments in HTML
Jonathan Gibbons has updated the pull request incrementally with one additional
commit since the last revision:
the `commonmark-java`
> library
> * updates to `DocCommentParser` to treat `///` comments as Markdown
> * updates to the standard doclet to render Markdown comments in HTML
Jonathan Gibbons has updated the pull request incrementally with one additional
commit since the last revision:
Impro
the `commonmark-java`
> library
> * updates to `DocCommentParser` to treat `///` comments as Markdown
> * updates to the standard doclet to render Markdown comments in HTML
Jonathan Gibbons has updated the pull request incrementally with one additional
commit since the last revision:
Fix whit
On Wed, 8 Nov 2023 10:31:14 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix whitespace
>
> test/langtools/tools/javac/doctree/MDPrinter.java line 67:
>
On Wed, 8 Nov 2023 10:59:58 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix whitespace
>
> test/langtools/tools/javac/doctree/FirstSentenceTest.java l
On Wed, 8 Nov 2023 17:24:46 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix whitespace
>
> test/langtools/jdk/javadoc/tool/testTransformer/TestTransformer.
On Wed, 15 Nov 2023 00:09:17 GMT, Jonathan Gibbons wrote:
>> test/langtools/tools/javac/doctree/FirstSentenceTest.java line 423:
>>
>>> 421: DocComment[DOC_COMMENT, pos:0
>>> 422: firstSentence: 1
>>> 423: RawText[MARKDOWN, pos:0, abc.|def.]
>
On Wed, 8 Nov 2023 17:28:10 GMT, Pavel Rappo wrote:
>> test/langtools/jdk/javadoc/tool/testTransformer/TestTransformer.java line 64:
>>
>>> 62:
>>> 63: @Test
>>> 64: public void testFindStandardTransformer_raw() throws Exception {
>>
>> Checked exceptions are not thrown:
>> Suggestion:
On Wed, 8 Nov 2023 17:28:48 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix whitespace
>
> test/langtools/jdk/javadoc/tool/testTransformer/TestTransformer.
On Wed, 8 Nov 2023 17:37:25 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix whitespace
>
> test/langtools/jdk/javadoc/tool/testTransformer/TestTran
On Thu, 9 Nov 2023 16:39:58 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Customize support for Markdown headings
>
> test/langtools/jdk/javadoc/doclet/testM
the `commonmark-java`
> library
> * updates to `DocCommentParser` to treat `///` comments as Markdown
> * updates to the standard doclet to render Markdown comments in HTML
Jonathan Gibbons has updated the pull request incrementally with one additional
commit since the last revisi
On Wed, 15 Nov 2023 00:58:51 GMT, Jonathan Gibbons wrote:
>> test/langtools/jdk/javadoc/doclet/testMarkdown/TestMarkdown.java line 613:
>>
>>> 611: /// Lorem ipsum.
>>> 612: ///
>>> 613:
On Mon, 11 Dec 2023 16:36:09 GMT, Hannes Wallnöfer wrote:
> This is a rather big change to update the structural navigation in API
> documentation generated by JavaDoc. It adds a table of contents for the
> current page to module, package, and class documentation, and replaces the
> old sub-na
the `commonmark-java`
> library
> * updates to `DocCommentParser` to treat `///` comments as Markdown
> * updates to the standard doclet to render Markdown comments in HTML
Jonathan Gibbons has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old sub
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old sub
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old sub
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old sub
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old sub
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old sub
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old sub
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old sub
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old sub
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old sub
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old sub
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old sub
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old sub
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old sub
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old sub
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old sub
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old sub
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old sub
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old sub
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old sub
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old sub
On Thu, 11 Jan 2024 14:46:10 GMT, Hannes Wallnöfer wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/script.js.template
>> line 1:
>>
>>> 1: /*
>>
>> I note that at least in part this is a rename of `script.js` (and rightly
>> so) that Git has failed
On Fri, 12 Jan 2024 18:52:46 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old su
On Fri, 12 Jan 2024 18:52:46 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old su
On Fri, 12 Jan 2024 18:52:46 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old su
On Fri, 12 Jan 2024 18:52:46 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old su
On Thu, 11 Jan 2024 15:35:13 GMT, Pavel Rappo wrote:
>> Update:
>> Markdown in tags defined by the user on the command-line works pretty much
>> as expected: not great, but not bad.
>>
>> Headings in user-defined tags work, but are semantically questionable, since
>> the tags are generated in
On Fri, 12 Jan 2024 15:55:43 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Thu, 18 Jan 2024 16:25:49 GMT, Hannes Wallnöfer wrote:
>> This is a rather big change to update the structural navigation in API
>> documentation generated by JavaDoc. It adds a table of contents for the
>> current page to module, package, and class documentation, and replaces the
>> old su
the `commonmark-java`
> library
> * updates to `DocCommentParser` to treat `///` comments as Markdown
> * updates to the standard doclet to render Markdown comments in HTML
Jonathan Gibbons has updated the pull request with a new target base due to a
merge or a rebase. The pull request now con
Please review an almost trivial change to move the position of an HTML end tag
to avoid nested use of the tag.
There is no change to the visual presentation, because the macro
`$(DRAFT_MARKER_STR)` itself uses `` (that was the cause of the nested
tags).
-
Commit messages:
- JDK-8
On Fri, 19 Jan 2024 22:47:59 GMT, Jonathan Gibbons wrote:
> Please review an almost trivial change to move the position of an HTML end
> tag to avoid nested use of the tag.
>
> There is no change to the visual presentation, because the macro
> `$(DRAFT_MARKER_STR)` itself us
the `commonmark-java`
> library
> * updates to `DocCommentParser` to treat `///` comments as Markdown
> * updates to the standard doclet to render Markdown comments in HTML
Jonathan Gibbons has updated the pull request with a new target base due to a
merge or a rebase. The pull request now c
the `commonmark-java`
> library
> * updates to `DocCommentParser` to treat `///` comments as Markdown
> * updates to the standard doclet to render Markdown comments in HTML
Jonathan Gibbons has updated the pull request with a new target base due to a
merge or a rebase. The pull request now
On Wed, 17 Jan 2024 00:13:40 GMT, Jonathan Gibbons wrote:
>> Understood. FWIW, here are a few examples of headings in user-defined tags
>> in JDK:
>>
>> https://github.com/openjdk/jdk/blob/a6785e4d633908596ddb6de6d2eeab1c9ebdf2c3/src/java.base/share/classes/java/math/B
On Fri, 12 Jan 2024 12:08:19 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Fri, 12 Jan 2024 14:28:45 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Fri, 12 Jan 2024 15:20:56 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Wed, 17 Jan 2024 00:24:01 GMT, Jonathan Gibbons wrote:
>> src/jdk.compiler/share/classes/com/sun/source/doctree/RawTextTree.java line
>> 40:
>>
>>> 38: * @apiNote
>>> 39: * This class may be used to represent tree nodes containing
>>> 40:
On Fri, 12 Jan 2024 16:02:12 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Fri, 12 Jan 2024 16:49:31 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Mon, 15 Jan 2024 12:30:09 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Wed, 17 Jan 2024 00:25:37 GMT, Jonathan Gibbons wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java
>> line 89:
>>
>>> 87: POSTAMBLE,
>>> 88: /** The rich-text content of an inline docum
On Mon, 15 Jan 2024 16:13:38 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Wed, 22 Nov 2023 09:37:04 GMT, Andrey Turbanov wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> src/jdk.compiler/share/classes/com/sun/tools/java
On Mon, 15 Jan 2024 18:08:54 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Mon, 15 Jan 2024 17:35:00 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Fri, 19 Jan 2024 11:38:56 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Fri, 19 Jan 2024 16:59:04 GMT, Pavel Rappo wrote:
> Musing on this more.
>
> Can/should we, without introducing probably unwelcome `Kind.MD` to
> `javax.tools.JavaFileObject.Kind`, teach javac to recognise `package.md`
> similarly to how it recognises legacy `package.html`? If we are aiming
the `commonmark-java`
> library
> * updates to `DocCommentParser` to treat `///` comments as Markdown
> * updates to the standard doclet to render Markdown comments in HTML
Jonathan Gibbons has updated the pull request incrementally with two additional
commits since the last revision:
- fi
On Mon, 22 Jan 2024 15:35:41 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upst
On Tue, 23 Jan 2024 12:01:38 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upst
On Thu, 25 Jan 2024 12:41:02 GMT, Pavel Rappo wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java
>> line 1388:
>>
>>> 1386: * @see >> href="https://spec.commonmark.org/0.30/#thematic-breaks";>Thematic Break
>>> 1387: */
>>> 1388:
On Tue, 23 Jan 2024 12:50:45 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upst
On Tue, 23 Jan 2024 15:07:15 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upst
On Mon, 22 Jan 2024 16:57:16 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upst
On Tue, 23 Jan 2024 15:17:14 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upst
On Wed, 24 Jan 2024 12:17:19 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upst
On Wed, 24 Jan 2024 16:24:25 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - fix @since tags
>> - fix copyright year
>
> src/jdk.compiler/sh
On Wed, 24 Jan 2024 16:30:50 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upst
On Wed, 24 Jan 2024 19:43:51 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upst
On Wed, 24 Jan 2024 22:38:58 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upst
the `commonmark-java`
> library
> * updates to `DocCommentParser` to treat `///` comments as Markdown
> * updates to the standard doclet to render Markdown comments in HTML
Jonathan Gibbons has updated the pull request incrementally with one additional
commit since the last revisi
Please review a small change, at least as a "proof of concept", to allow
customized options to be given to `pandoc` based on the module and filename for
a spec.
The goal is to allow a Markdown spec file to have an auto-generated
table-of-contents, by including the `--toc` option when running pa
On Wed, 31 Jan 2024 10:24:44 GMT, Magnus Ihse Bursie wrote:
> Yeah, right, make sure you have the following block in your md file:
>
> ```
> ---
> # Copyright (c) 1993, 2023, Oracle and/or its affiliates. All rights reserved.
> ...
> _pandoc-options_: --toc
> ---
> ```
Wow; will try that!
> ma
On Wed, 31 Jan 2024 17:19:21 GMT, Jonathan Gibbons wrote:
> > Yeah, right, make sure you have the following block in your md file:
> > ```
> > ---
> > # Copyright (c) 1993, 2023, Oracle and/or its affiliates. All rights
> > reserved.
> > ...
> > _pando
On Wed, 31 Jan 2024 00:49:09 GMT, Jonathan Gibbons wrote:
> Please review a small change, at least as a "proof of concept", to allow
> customized options to be given to `pandoc` based on the module and filename
> for a spec.
>
> The goal is to allow a Markdown
the `commonmark-java`
> library
> * updates to `DocCommentParser` to treat `///` comments as Markdown
> * updates to the standard doclet to render Markdown comments in HTML
Jonathan Gibbons has updated the pull request with a new target base due to a
merge or a rebase. The pull request now conta
On Tue, 30 Jan 2024 22:55:27 GMT, Jonathan Gibbons wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/tree/DocTreeMaker.java
>> line 238:
>>
>>> 236: && postamble.isEmpty()
>>> 237:
the `commonmark-java`
> library
> * updates to `DocCommentParser` to treat `///` comments as Markdown
> * updates to the standard doclet to render Markdown comments in HTML
Jonathan Gibbons has updated the pull request incrementally with one additional
commit since the last revision:
chang
On Wed, 24 Jan 2024 22:35:31 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upst
On Tue, 30 Jan 2024 23:42:40 GMT, Jonathan Gibbons wrote:
>> src/jdk.internal.md/share/classes/jdk/internal/markdown/MarkdownTransformer.java
>> line 487:
>>
>>> 485: }
>>> 486:
>>> 487: private static final String AUTOREF_PREFIX = "
On Wed, 31 Jan 2024 22:10:03 GMT, Jonathan Gibbons wrote:
>> src/jdk.internal.md/share/classes/jdk/internal/markdown/MarkdownTransformer.java
>> line 543:
>>
>>> 541: @Override
>>> 542: public LinkReferenceDefinition
>>
On Wed, 31 Jan 2024 23:09:22 GMT, Jonathan Gibbons wrote:
>> My recollection is that you have to escape square brackets in a reference
>> label. I will investigate, and if necessary, add a test case.
>
> Yes, you need to escape `[` and `]` within the label of any Markdown
&g
1 - 100 of 280 matches
Mail list logo
