Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v2]

2023-10-16 Thread Joe Wang
On Mon, 16 Oct 2023 23:37:51 GMT, Naoto Sato wrote: >> CLDR provides very few short names for time zones, such as PST/PDT. This >> will typically end up substituting names from the COMPAT provider. Once the >> COMPAT is removed, they will be displayed in the GMT format, i.e., >> GMT+XX:YY. Alt

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v3]

2023-10-17 Thread Joe Wang
On Tue, 17 Oct 2023 16:52:12 GMT, Naoto Sato wrote: >> CLDR provides very few short names for time zones, such as PST/PDT. This >> will typically end up substituting names from the COMPAT provider. Once the >> COMPAT is removed, they will be displayed in the GMT format, i.e., >> GMT+XX:YY. Alt

RFR: 8306055: Add a built-in Catalog to JDK XML module

2023-11-17 Thread Joe Wang
Implement the built-in Catalog. - Commit messages: - fix whitespace error - 8306055: Add a built-in Catalog to JDK XML module Changes: https://git.openjdk.org/jdk/pull/16719/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16719&range=00 Issue: https://bugs.openjdk.org/bro

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v2]

2023-11-19 Thread Joe Wang
> Implement the built-in Catalog. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: remove J2SE directory; add note explaining how DTDs are resolved - Changes: - all: https://git.openjdk.org/jdk/pull/16719/files -

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v2]

2023-11-19 Thread Joe Wang
On Sun, 19 Nov 2023 08:45:29 GMT, Alan Bateman wrote: >> src/java.xml/share/classes/jdk/xml/internal/jdkcatalog/JDKCatalog.xml line >> 34: >> >>> 32: >>> 33: http://java.sun.com/dtd/preferences.dtd"; >>> uri="J2SE/preferences.dtd"/> >>> 34: http://java.sun.com/dtd/properti

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v2]

2023-11-19 Thread Joe Wang
On Sun, 19 Nov 2023 08:46:30 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove J2SE directory; add note explaining how DTDs are resolved > > src/java.xml/share/cla

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v2]

2023-11-19 Thread Joe Wang
On Sun, 19 Nov 2023 23:36:16 GMT, Joe Wang wrote: >> Implement the built-in Catalog. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > remove J2SE directory; add note explaining how DTDs are resolved Te

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v3]

2023-11-20 Thread Joe Wang
> Implement the built-in Catalog. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: add a note; fix alignment - Changes: - all: https://git.openjdk.org/jdk/pull/16719/files - new: https://git.openjdk.org/jdk/pull/16

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v2]

2023-11-20 Thread Joe Wang
On Mon, 20 Nov 2023 16:38:54 GMT, Magnus Ihse Bursie wrote: > Build change trivially okay Thanks Magnus! - PR Comment: https://git.openjdk.org/jdk/pull/16719#issuecomment-1819529895

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v2]

2023-11-20 Thread Joe Wang
On Mon, 20 Nov 2023 16:48:51 GMT, Lance Andersen wrote: > Hi Joe, > > Thank you for all of your hard work and perseverance to drive this project as > I realize it was a lot of work and iterations based on feedback from the team. > > Overall looks good. A couple of minor comments below Thanks

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v3]

2023-11-22 Thread Joe Wang
On Wed, 22 Nov 2023 08:08:39 GMT, Andrey Turbanov wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add a note; fix alignment > > test/jaxp/javax/xml/jaxp/unittest/common/catalog/Ca

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v4]

2023-11-22 Thread Joe Wang
> Implement the built-in Catalog. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: fix whitespace - Changes: - all: https://git.openjdk.org/jdk/pull/16719/files - new: https://git.openjdk.org/jdk/pull/16719/fi

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v3]

2023-11-22 Thread Joe Wang
On Wed, 22 Nov 2023 08:58:41 GMT, Alan Bateman wrote: > I'm happy with the addition of the JDK built-in catalog, the inclusion of the > DTD defined by Java SE, and the docs updates. Thanks again, Alan, I really appreciate it! Finally got all pieces together, a nice foundation for the next. --

Integrated: 8306055: Add a built-in Catalog to JDK XML module

2023-11-22 Thread Joe Wang
On Fri, 17 Nov 2023 20:22:40 GMT, Joe Wang wrote: > Implement the built-in Catalog. This pull request has now been integrated. Changeset: 93bdc2a6 Author: Joe Wang URL: https://git.openjdk.org/jdk/commit/93bdc2a6db91a95d6ee52ec92080e586c694dad5 Stats: 1647 lines in 50 fi

Re: [jdk22] RFR: 8322647: Short name for the `Europe/Lisbon` time zone is incorrect

2024-01-04 Thread Joe Wang
On Thu, 4 Jan 2024 17:26:37 GMT, Naoto Sato wrote: > 8322647: Short name for the `Europe/Lisbon` time zone is incorrect Marked as reviewed by joehw (Reviewer). - PR Review: https://git.openjdk.org/jdk22/pull/30#pullrequestreview-1804685583

Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base

2024-02-06 Thread Joe Wang
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote: > After the "this-escape" lint warning was added to javac (JDK-8015831), the > base module was not updated to be able to compile with this warning enabled. > This PR makes the necessary changes to allow the base module to build with > the warni

Re: RFR: 8325558: Add jcheck whitespace checking for properties files

2024-02-12 Thread Joe Wang
On Fri, 9 Feb 2024 13:46:06 GMT, Magnus Ihse Bursie wrote: >> This is an attempt to finally implement the idea brought forward in >> JDK-8295729: Properties files is essentially source code. It should have >> the same whitespace checks as all other source code, so we don't get >> spurious tra

Re: RFR: 8325558: Add jcheck whitespace checking for properties files

2024-02-12 Thread Joe Wang
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote: > This is an attempt to finally implement the idea brought forward in > JDK-8295729: Properties files is essentially source code. It should have the > same whitespace checks as all other source code, so we don't get spurious > trailin

Re: RFR: 8174269: Remove COMPAT locale data provider from JDK [v6]

2024-03-04 Thread Joe Wang
On Mon, 4 Mar 2024 19:07:44 GMT, Naoto Sato wrote: >> This PR intends to remove the legacy `COMPAT` locale data from the JDK. The >> `COMPAT` locale data was introduced for applications' migratory purposes >> transitioning to `CLDR`. It is becoming a technical debt and now is the time >> to re

Re: RFR: 8174269: Remove COMPAT locale data provider from JDK [v7]

2024-03-05 Thread Joe Wang
On Tue, 5 Mar 2024 17:50:09 GMT, Naoto Sato wrote: >> This PR intends to remove the legacy `COMPAT` locale data from the JDK. The >> `COMPAT` locale data was introduced for applications' migratory purposes >> transitioning to `CLDR`. It is becoming a technical debt and now is the time >> to re

Re: RFR: 8330542: Add jaxp-strict.properties in preparation for a secure by default configuration [v9]

2024-05-17 Thread Joe Wang
tion than previous versions such as JDK 22 > > Updated 5/16/2024 > > Design change: > The design is changed to include in the JDK two configuration files that are > the default jaxp.properties and jaxp-strict.properties, instead of three, > dropping jaxp-compat.pr

Re: RFR: 8330542: Add jaxp-strict.properties in preparation for a secure by default configuration [v8]

2024-05-17 Thread Joe Wang
On Thu, 16 May 2024 22:20:39 GMT, Joe Wang wrote: >> Add two sample configuration files: >> >> jaxp-strict.properties: used to set strict configuration, stricter than >> jaxp.properties in previous versions such as JDK 22 >> >>> jaxp-compat.proper

Re: RFR: 8330542: Add jaxp-strict.properties in preparation for a secure by default configuration [v10]

2024-05-18 Thread Joe Wang
tion than previous versions such as JDK 22 > > Updated 5/16/2024 > > Design change: > The design is changed to include in the JDK two configuration files that are > the default jaxp.properties and jaxp-strict.properties, instead of three, > dropping jaxp-compat.pr

Re: RFR: 8330542: Add jaxp-strict.properties in preparation for a secure by default configuration [v11]

2024-05-20 Thread Joe Wang
perties. > > Updated on 5/18/2024 > > Withdraw changes to jaxp.properties. The original idea was to match > jaxp-strict.properties with regard to the properties. However, that change > impact the configuration process, resulting in tests that verify the process > to fail. Jo

Re: RFR: 8330542: Add jaxp-strict.properties in preparation for a secure by default configuration [v10]

2024-05-20 Thread Joe Wang
On Mon, 20 May 2024 07:13:02 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> withdraw changes to jaxp.properties. The configuration process has not >> changed, chan

Re: RFR: 8330542: Add jaxp-strict.properties in preparation for a secure by default configuration [v10]

2024-05-20 Thread Joe Wang
On Mon, 20 May 2024 13:03:36 GMT, Sean Mullan wrote: >> In XML parlance, a "processor" is an aggregation of parsers, serializers, >> and other things that contribute to the processing. So I think it could be >> either here, but you have a point and if it stays as "processor" then it >> should

Re: RFR: 8330542: Add jaxp-strict.properties in preparation for a stricter default configuration [v12]

2024-05-21 Thread Joe Wang
perties. > > Updated on 5/18/2024 > > Withdraw changes to jaxp.properties. The original idea was to match > jaxp-strict.properties with regard to the properties. However, that change > impact the configuration process, resulting in tests that verify the process > to fail. Jo

Re: RFR: 8330542: Template for Creating Strict JAXP Configuration File [v13]

2024-05-23 Thread Joe Wang
perties. > > Updated on 5/18/2024 > > Withdraw changes to jaxp.properties. The original idea was to match > jaxp-strict.properties with regard to the properties. However, that change > impact the configuration process, resulting in tests that verify the process > to fail. Jo

Re: RFR: 8330542: Template for Creating Strict JAXP Configuration File [v13]

2024-05-23 Thread Joe Wang
On Fri, 24 May 2024 05:26:40 GMT, Joe Wang wrote: >> Add two sample configuration files: >> >> jaxp-strict.properties: used to set strict configuration, stricter than >> jaxp.properties in previous versions such as JDK 22 >> >>> jaxp-compat.proper

Re: RFR: 8330542: Template for Creating Strict JAXP Configuration File [v12]

2024-05-23 Thread Joe Wang
On Wed, 22 May 2024 08:52:42 GMT, Magnus Ihse Bursie wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add a note to module-info > > make/modules/java.xml/Copy.gmk line 35: > &g

Re: RFR: 8330542: Template for Creating Strict JAXP Configuration File [v14]

2024-05-24 Thread Joe Wang
t; > Updated on 5/23/2024 > > Provide a template `jaxp-strict.template` instead of a properties file. This > template can be used to create custom configuration files. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: rename the

Re: RFR: 8330542: Template for Creating Strict JAXP Configuration File [v14]

2024-05-24 Thread Joe Wang
On Fri, 24 May 2024 16:36:32 GMT, Joe Wang wrote: >> Add two sample configuration files: >> >> jaxp-strict.properties: used to set strict configuration, stricter than >> jaxp.properties in previous versions such as JDK 22 >> >>> jaxp-compat.proper

Re: RFR: 8330542: Template for Creating Strict JAXP Configuration File [v15]

2024-05-28 Thread Joe Wang
t; > Updated on 5/23/2024 > > Provide a template `jaxp-strict.template` instead of a properties file. This > template can be used to create custom configuration files. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: u

Re: RFR: 8330542: Template for Creating Strict JAXP Configuration File [v14]

2024-05-28 Thread Joe Wang
On Fri, 24 May 2024 16:36:32 GMT, Joe Wang wrote: >> Add two sample configuration files: >> >> jaxp-strict.properties: used to set strict configuration, stricter than >> jaxp.properties in previous versions such as JDK 22 >> >>> jaxp-compat.proper

Integrated: 8330542: Template for Creating Strict JAXP Configuration File

2024-05-28 Thread Joe Wang
On Wed, 17 Apr 2024 23:24:06 GMT, Joe Wang wrote: > Add two sample configuration files: > > jaxp-strict.properties: used to set strict configuration, stricter than > jaxp.properties in previous versions such as JDK 22 > >> jaxp-compat.properties: used to regain compat

Re: RFR: 8294317: Insufficient build rules for tzdb.dat

2022-09-23 Thread Joe Wang
On Fri, 23 Sep 2022 22:10:03 GMT, Naoto Sato wrote: > The current makefile for `tzdb.dat` won't recompile if some dependent files > (e.g. `VERSION`) are updated. Adding all files under the tzdb directory to > the dependency will fix this issue. Marked as reviewed by joehw (Reviewer).

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v4]

2022-09-30 Thread Joe Wang
On Fri, 30 Sep 2022 01:11:45 GMT, Joe Darcy wrote: >> With the domain change from openjdk.java.net to openjdk.org, references to >> URLs in the sources should be updated. >> >> Updates were made using a shell script. I"ll run a copyright updater before >> any push. > > Joe Darcy has updated th

Re: RFR: 8284840: Update CLDR to Version 42.0

2022-10-21 Thread Joe Wang
On Fri, 21 Oct 2022 16:55:28 GMT, Naoto Sato wrote: > This is to update the CLDR data from version 41 to version 42. The vast > majority of the changes are basically replacing the CLDR data, along with > tools/testcase alignments to those upstream changes: > > https://unicode-org.atlassian.net

Re: RFR: 8284840: Update CLDR to Version 42.0

2022-10-21 Thread Joe Wang
On Fri, 21 Oct 2022 16:55:28 GMT, Naoto Sato wrote: > This is to update the CLDR data from version 41 to version 42. The vast > majority of the changes are basically replacing the CLDR data, along with > tools/testcase alignments to those upstream changes: > > https://unicode-org.atlassian.net

Re: RFR: 8298808: Check `script` code on detecting the base locales [v2]

2022-12-15 Thread Joe Wang
On Wed, 14 Dec 2022 23:47:43 GMT, Naoto Sato wrote: >> Fixing `CLDRConverter` build tool to not regard [new >> locales](https://github.com/unicode-org/cldr/pull/2508/files#diff-94cbefde02914335da884f768063a06a84ad651ee4e56cdb1cb90625d7776731) >> introduced in CLDR 43 as one of the base locales.

Re: RFR: 8303039: Utilize `coverageLevels.txt` [v2]

2023-03-02 Thread Joe Wang
On Thu, 2 Mar 2023 01:03:20 GMT, Naoto Sato wrote: >> This is a pre-requisite for supporting CLDR v43, where they combine `seeds` >> locales with `common` locales >> (https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aqdv767e). In order >> to have the same coverage level of locales, CLDRC

Re: RFR: 8296246: Update Unicode Data Files to Version 15.1.0 [v3]

2023-09-19 Thread Joe Wang
On Mon, 18 Sep 2023 18:33:20 GMT, Naoto Sato wrote: >> This PR is to incorporate the latest Unicode 15.1, which was released >> yesterday. Besides the usual character data update, an upgraded >> implementation of RegEx which reflects the Indic Conjunct Break specified in >> the latest [Unicode

Re: RFR: 8296246: Update Unicode Data Files to Version 15.1.0 [v5]

2023-09-19 Thread Joe Wang
On Tue, 19 Sep 2023 18:55:28 GMT, Naoto Sato wrote: >> This PR is to incorporate the latest Unicode 15.1, which was released >> yesterday. Besides the usual character data update, an upgraded >> implementation of RegEx which reflects the Indic Conjunct Break specified in >> the latest [Unicode

Re: RFR: 8296246: Update Unicode Data Files to Version 15.1.0 [v5]

2023-09-19 Thread Joe Wang
On Tue, 19 Sep 2023 18:55:28 GMT, Naoto Sato wrote: >> This PR is to incorporate the latest Unicode 15.1, which was released >> yesterday. Besides the usual character data update, an upgraded >> implementation of RegEx which reflects the Indic Conjunct Break specified in >> the latest [Unicode

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager

2024-10-16 Thread Joe Wang
On Mon, 14 Oct 2024 13:52:24 GMT, Sean Mullan wrote: > This is the implementation of JEP 486: Permanently Disable the Security > Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The > [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the > main change

RFR: 8344800: Add W3C DTDs and XSDs to the JDK built-in Catalog

2024-11-30 Thread Joe Wang
Add DTDs and XSDs from the W3C specifications to the JDK built-in Catalog. - Commit messages: - fix whitespace - 8344800: Add W3C DTDs and XSDs to the JDK built-in Catalog Changes: https://git.openjdk.org/jdk/pull/22465/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22465

Re: RFR: 8344800: Add W3C DTDs and XSDs to the JDK built-in Catalog [v2]

2024-11-30 Thread Joe Wang
On Sat, 30 Nov 2024 14:59:08 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> list files vertically > > src/java.xml/share/classes/module-info.java line 484: > >&

Re: RFR: 8344800: Add W3C DTDs and XSDs to the JDK built-in Catalog [v2]

2024-11-30 Thread Joe Wang
> Add DTDs and XSDs from the W3C specifications to the JDK built-in Catalog. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: list files vertically - Changes: - all: https://git.openjdk.org/jdk/pull/22465/files -

Re: RFR: 8361950: Update to use jtreg 8

2025-07-11 Thread Joe Wang
On Fri, 11 Jul 2025 09:05:40 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 8. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the requiredVersion h