Add support for curl in createJMHBundle.sh

2023-01-24 Thread Eirik Bjørsnøs
Hi, The following PR adds support for running createJMHBundle.sh on MacOS, where wget is not installed by default: https://github.com/openjdk/jdk/pull/12164 I would appreciate help in creating a JBS issue for this PR, since I'm not an Author. Thanks, Eirik.

build-test-lib target seems broken

2023-03-05 Thread Eirik Bjørsnøs
Hi, The 'build-test-lib' target seems to be broken: - make/test/BuildTestLib.gmk references the directory $(TEST_LIB_SOURCE_DIR)/sun which does not seem to exist. This can be fixed by removing the reference. - Some test-lib sources use preview-features which is not enabled by make/test/BuildTestL

Re: build-test-lib target seems broken

2023-03-09 Thread Eirik Bjørsnøs
tests. If you post a PR with this, I will review it. > > /Erik > > On 3/5/23 09:36, Eirik Bjørsnøs wrote: > > Hi, > > > > The 'build-test-lib' target seems to be broken: > > > > - make/test/BuildTestLib.gmk references the > > directory

Re: RFR: 8344056: Use markdown format for man pages [v4]

2024-11-19 Thread Eirik Bjørsnøs
On Fri, 15 Nov 2024 14:50:21 GMT, Magnus Ihse Bursie wrote: >> Currently, the man pages are stored as troff (a text format) in the open >> repo, and a content-wise identical copy is stored as markdown (another text >> format) in the closed repo. >> >> Since markdown is preferred to troff in te

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2025-04-10 Thread Eirik Bjørsnøs
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote: >> JDK .properties files still use ISO-8859-1 encoding with escape sequences. >> It would improve readability to see the native characters instead of escape >> sequences (especially for the L10n process). The majority of files changed >> are l

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v6]

2025-04-10 Thread Eirik Bjørsnøs
On Thu, 10 Apr 2025 07:32:18 GMT, Magnus Ihse Bursie wrote: >> You don't have to do that, I'm working on an omnibus UTF-8 fixing PR right >> now, where I will include a fix for this as well. > > If anything, I might be a bit worried that there are more incorrect > conversions stemming from this

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Eirik Bjørsnøs
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote: > I have checked the entire code base for incorrect encodings, but luckily > enough these were the only remaining problems I found. > > BOM (byte-order mark) is a method used for distinguishing big and little > endian UTF-16 encoding

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Eirik Bjørsnøs
On Thu, 10 Apr 2025 17:23:37 GMT, Raffaello Giulietti wrote: > If this is a French name, it's e acute: é. Supported by this Wikipedia page listing S.L as an LCMS developer: https://en.wikipedia.org/wiki/Little_CMS - PR Review Comment: https://git.openjdk.org/jdk/pull/24566#discus

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Eirik Bjørsnøs
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote: > I have checked the entire code base for incorrect encodings, but luckily > enough these were the only remaining problems I found. > > BOM (byte-order mark) is a method used for distinguishing big and little > endian UTF-16 encoding

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-11 Thread Eirik Bjørsnøs
On Fri, 11 Apr 2025 10:21:32 GMT, Magnus Ihse Bursie wrote: >> src/demo/share/java2d/J2DBench/resources/textdata/arabic.ut8.txt line 11: >> >>> 9: تخصص الشفرة الموحدة "يونِكود" رقما وحيدا لكل محرف في جميع اللغات >>> العالمية، وذلك بغض النظر عن نوع الحاسوب أو البرامج المستخدمة. وقد تـم تبني >>>

Re: RFR: 8351399: AIX: Better solution than JDK8348663

2025-03-08 Thread Eirik Bjørsnøs
On Fri, 7 Mar 2025 09:28:15 GMT, Joachim Kern wrote: > With > [JDK-8348663](https://bugs.openjdk.org/browse/JDK-8348663) [AIX] clang > pollutes the burned-in library search paths of the generated executables > an ugly workaround was introduced to get rid of the unwanted list of search > librari

Re: RFR: 8345169: Implement JEP 503: Remove the 32-bit x86 Port [v2]

2025-03-11 Thread Eirik Bjørsnøs
On Mon, 10 Mar 2025 09:49:44 GMT, Aleksey Shipilev wrote: >> This PR implements JEP 503: Remove the 32-bit x86 Port. >> >> The JEP is proposed to target 25, we would not integrate until JEP is ready. >> Reviews are appreciated meanwhile. >> >> This is only the removal of obvious 32-bit x86 par