Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v3]

2025-07-16 Thread David Beaumont
On Wed, 16 Jul 2025 06:03:28 GMT, Alan Bateman wrote: >> Debatable. It's obviously going to scale any results somewhat based on the >> size of the resources and number of classes. It's kind nice to see "this >> change removes at least N micro/milli seconds of time spent" since that's a >> mini

Integrated: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes

2025-07-16 Thread David Beaumont
On Mon, 30 Jun 2025 12:27:40 GMT, David Beaumont wrote: > Initial benchmark to capture at least some comparative measures of > ImageReader performance. > > Current results on my laptop: > > Benchmark Mode Cnt Score

RFR: 8361013: JMH does not export sufficient modules to benchmark ImageReader

2025-06-29 Thread David Beaumont
Added jimage and jrtfs exports. - Commit messages: - Hacking build file for benchmark Changes: https://git.openjdk.org/jdk/pull/26035/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26035&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8361013 Stats: 2 lines in 1 fi

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v3]

2025-07-01 Thread David Beaumont
On Tue, 1 Jul 2025 07:25:35 GMT, Alan Bateman wrote: >> David Beaumont has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Some tidying up relating to the state objects. > > test/micro/org/op

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v4]

2025-07-01 Thread David Beaumont
3.752 ± 6.873 > ms/op > > The upcoming changes to ImageReader should show significant improvements to > these results. David Beaumont has updated the pull request incrementally with one additional commit since the last revision: Adding comment about maintainability. ---

Withdrawn: 8361013: JMH does not export sufficient modules to benchmark ImageReader

2025-06-30 Thread David Beaumont
On Sun, 29 Jun 2025 22:19:18 GMT, David Beaumont wrote: > Added jimage and jrtfs exports. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/26035

Re: RFR: 8361013: JMH does not export sufficient modules to benchmark ImageReader

2025-06-30 Thread David Beaumont
On Sun, 29 Jun 2025 22:19:18 GMT, David Beaumont wrote: > Added jimage and jrtfs exports. Will add with the benchmark. - PR Comment: https://git.openjdk.org/jdk/pull/26035#issuecomment-3018765679

RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes

2025-06-30 Thread David Beaumont
Initial benchmark to capture at least some comparative measures of ImageReader performance. Current results on my laptop: Benchmark Mode Cnt ScoreError Units NewImageBenchmark.warmCache_CountAllNodes avgt5 0.785 ± 0.140 ms/op NewI

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes

2025-06-30 Thread David Beaumont
On Mon, 30 Jun 2025 12:27:40 GMT, David Beaumont wrote: > Initial benchmark to capture at least some comparative measures of > ImageReader performance. > > Current results on my laptop: > > Benchmark Mode Cnt Score

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes

2025-06-30 Thread David Beaumont
On Mon, 30 Jun 2025 12:27:40 GMT, David Beaumont wrote: > Initial benchmark to capture at least some comparative measures of > ImageReader performance. > > Current results on my laptop: > > Benchmark Mode Cnt Score

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v2]

2025-06-30 Thread David Beaumont
3.752 ± 6.873 > ms/op > > The upcoming changes to ImageReader should show significant improvements to > these results. David Beaumont has updated the pull request incrementally with one additional commit since the last revision: Renaming class. - Changes: - all

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v2]

2025-06-30 Thread David Beaumont
On Mon, 30 Jun 2025 13:18:19 GMT, David Beaumont wrote: >> Initial benchmark to capture at least some comparative measures of >> ImageReader performance. >> >> Current results on my laptop: >> >> Benchmark M

RFR: 8360037: Refactor ImageReader in preparation for Valhalla support

2025-07-01 Thread David Beaumont
Refactoring `ImageReader` to make it easy to add preview mode functionality for Valhalla. This PR is a large change to `ImageReader` (effectively a rewrite) but reduces the surface area of the API significantly, reduces code complexity and increases performance/memory efficiency. The need for t

Re: RFR: 8360037: Refactor ImageReader in preparation for Valhalla support

2025-07-01 Thread David Beaumont
On Mon, 30 Jun 2025 23:27:49 GMT, David Beaumont wrote: > Refactoring `ImageReader` to make it easy to add preview mode functionality > for Valhalla. > > This PR is a large change to `ImageReader` (effectively a rewrite) but > reduces the surface area of the API significantl

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v3]

2025-06-30 Thread David Beaumont
3.752 ± 6.873 > ms/op > > The upcoming changes to ImageReader should show significant improvements to > these results. David Beaumont has updated the pull request incrementally with one additional commit since the last revision: Some tidying up relating to the state objects. --

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v4]

2025-07-15 Thread David Beaumont
On Tue, 1 Jul 2025 17:02:27 GMT, David Beaumont wrote: >> Initial benchmark to capture at least some comparative measures of >> ImageReader performance. >> >> Current results on my laptop: >> >> Benchmark M

Re: RFR: 8361013: JMH does not export sufficient modules to benchmark ImageReader

2025-06-30 Thread David Beaumont
On Sun, 29 Jun 2025 22:19:18 GMT, David Beaumont wrote: > Added jimage and jrtfs exports. Doing it on its own means not having to find someone who can approve both the makefile change and the benchmark at the same time. People say that things should be split up into independent things, s