> These changes should prevent entire binary files from being loaded into
> memory for build/AbsPathsInImage.java test. I chose a default buffer size of
> 8KB since BufferedInputStream uses that, but open to alternative solutions.
> GHA passes and test passes on linux x64.
D
These changes should prevent entire binary files from being loaded into memory
for build/AbsPathsInImage.java test. I chose a default buffer size of 8KB since
BufferedInputStream uses that, but open to alternative solutions. GHA passes
and test passes on linux x64.
-
Commit message
> These changes should prevent entire binary files from being loaded into
> memory for build/AbsPathsInImage.java test. I chose a default buffer size of
> 8KB since BufferedInputStream uses that, but open to alternative solutions.
> GHA passes and test passes on linux x64.
D
On Tue, 8 Jul 2025 21:03:40 GMT, Mikael Vidstedt wrote:
> Sorry for the potentially stupid question but: what happens if the pattern
> spans a chunk?
Thanks for catching that! I should've been more careful. Rewrote the byte
matching completely to accommodate, but now test takes twice as long..
> These changes should prevent entire binary files from being loaded into
> memory for build/AbsPathsInImage.java test. I chose a default buffer size of
> 8KB since BufferedInputStream uses that, but open to alternative solutions.
> GHA passes and test passes on linux x64.
D
