RFR: 8283707: Support version format on Windows

2022-07-16 Thread Alexey Semenyuk
8283707: Support version format on Windows - Commit messages: - Create separate tests for the new feature. - Trailing whitespaces fixed - Better test coverage - Bugfixes after manual testing - 8283707: Support version format on Windows Changes: https://git.openjdk.org/jdk/pull

Re: RFR: 8283707: Support version format on Windows [v2]

2022-07-16 Thread Alexey Semenyuk
> 8283707: Support version format on Windows Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision: Comments fixed and better naming in the code. - Changes: - all: https://git.openjdk.org/jdk/pull/9507/files -

Integrated: 8283707: Support version format on Windows

2022-07-19 Thread Alexey Semenyuk
On Fri, 15 Jul 2022 04:37:58 GMT, Alexey Semenyuk wrote: > 8283707: Support version format on Windows This pull request has now been integrated. Changeset: 977e0948 Author: Alexey Semenyuk URL: https://git.openjdk.org/jdk/commit/977e09489dd1f49d8f373ef7b8c5e47fedb82793 St

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v8]

2024-05-21 Thread Alexey Semenyuk
On Fri, 17 May 2024 13:38:25 GMT, Maurizio Cimadamore wrote: >> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting >> the use of JNI in the following ways: >> >> * `System::load` and `System::loadLibrary` are now restricted methods >> * `Runtime::load` and `Runtime::loa

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v8]

2024-05-21 Thread Alexey Semenyuk
On Tue, 21 May 2024 08:44:47 GMT, Maurizio Cimadamore wrote: > These are all good suggestions. I have not looked into jpackage, but yes, I > would expect that the jpackage user would need to provide extra options when > packaging the application. It would be good to document how jpackage user

Re: RFR: 8319457: Update jpackage to support WiX Toolset 4 on Windows

2024-06-03 Thread Alexey Semenyuk
On Tue, 4 Jun 2024 01:24:15 GMT, Alexander Matveev wrote: > Is there plan to add support for WiX 5? This patch supports WiX5 as well. There is not much difference between WiX4 and WiX5 from jpackage perspective. I'll update the description - PR Comment: https://git.openjdk.org/jdk

Re: RFR: 8295231: Move all linking of native libraries to make [v6]

2022-10-17 Thread Alexey Semenyuk
On Mon, 17 Oct 2022 14:41:06 GMT, Julian Waters wrote: >> Some external libraries required by native code are linked via linker >> comments embedded in pragmas. Searching for which libraries are linked can >> then become frustrating and confusing since they may be included in an >> obscure pla

Re: RFR: 8295231: Move all linking of native libraries to make [v6]

2022-10-17 Thread Alexey Semenyuk
On Mon, 17 Oct 2022 17:37:11 GMT, Erik Joelsson wrote: > I believe this is part of the effort for > https://bugs.openjdk.org/browse/JDK-8288293. Agree. I'd prefer to have a different description of the bug though to make it clear that this is necessary for decoupling a compiler and an OS. ---

Re: RFR: 8300111: Add rpath for common lib locations for jpackageapplauncher

2023-01-13 Thread Alexey Semenyuk
On Tue, 10 Jan 2023 09:57:19 GMT, David wrote: > This patch adds the `-headerpad_max_install_names` linker argument to the > build of the `jpackageapplauncher` binary (osx only) > > Adding this argument allows the user to use the `install_name_tool` to add > search paths for the dynamic linker

Re: RFR: 8344191: Build code should not have classpath exception [v2]

2024-12-18 Thread Alexey Semenyuk
On Wed, 18 Dec 2024 17:06:02 GMT, Magnus Ihse Bursie wrote: >> In several (most? all?) of the build system files, the copyright header >> includes the classpath exception. This makes no sense, and should be >> removed. >> >> I have removed the classpath exception from makefiles, autoconf, she

Re: RFR: 8355249: Remove the use of WMIC from the entire source code [v2]

2025-05-06 Thread Alexey Semenyuk
On Tue, 22 Apr 2025 07:41:43 GMT, Daishi Tabata wrote: >> After searching the entire JDK source code, I found that WMIC is only used >> in four files. These WMIC calls can be replaced with PowerShell for WMI. >> >> The primary challenge in this replacement is to make it work the same as >> bef