Re: RFR: 8288396: Always create reproducible builds [v5]

2022-06-15 Thread Alex Menkov
On Wed, 15 Jun 2022 15:18:04 GMT, Magnus Ihse Bursie wrote: >> When we started introducing some possibly more intrusive compiler flags and >> functionality for reproducible builds, we also introduced a flag to turn >> this off out of an abundance of caution. But we have been been using this >

RFR: 8332096: hotspot-ide-project fails with this-escape

2024-05-10 Thread Alex Menkov
The change fixes `make hotspot-ide-project` which fails with \open\make\ide\visualstudio\hotspot\src\classes\build\tools\projectcreator\FileTreeCreator.java:54: warning: [this-escape] possible 'this' escape before subclass is fully initialized attributes.push(new DirAttributes());

Integrated: 8332096: hotspot-ide-project fails with this-escape

2024-05-22 Thread Alex Menkov
On Fri, 10 May 2024 23:54:11 GMT, Alex Menkov wrote: > The change fixes `make hotspot-ide-project` which fails with > > \open\make\ide\visualstudio\hotspot\src\classes\build\tools\projectcreator\FileTreeCreator.java:54: > warning: [this-escape] possible 'this' escape be

Re: RFR: JDK-8303166: Disable RTTI for Hotspot when building with MSVC [v3]

2023-02-24 Thread Alex Menkov
On Fri, 24 Feb 2023 19:56:39 GMT, Justin King wrote: >> Disable RTTI `-GR-` for Hotspot when building with MSVC. This drops the size >> of `jvm.dll` by roughly 1 MB. Hotspot does not rely on RTTI and it is >> disabled for both GCC/Clang and Open XL C/C++ already. This change disables >> it for

Re: RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v30]

2024-11-05 Thread Alex Menkov
On Wed, 6 Nov 2024 00:58:10 GMT, David Holmes wrote: > I think you may be throwing the baby out with the bath water when it comes to > `__stdcall`. It may be that 32-bit requires `__stdcall` but I don't see > anything that states `__stdcall` is ONLY for 32-bit! https://learn.microsoft.com/en-u

Re: RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v31]

2024-11-07 Thread Alex Menkov
On Fri, 8 Nov 2024 02:13:09 GMT, David Holmes wrote: > Can someone confirm that use of `__stdcall` has no affect on name > decorations, as there is no mention here about anything being ignored: > > https://learn.microsoft.com/en-us/cpp/build/reference/decorated-names?view=msvc-170 > > I would

Re: RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v31]

2024-11-08 Thread Alex Menkov
On Fri, 8 Nov 2024 05:29:05 GMT, David Holmes wrote: > > In the page you mentioned: > > @alexmenkov that is for C functions, not C++. And also for `extern "C"` (AFAIU we export all C++ functions as extern "C") - PR Comment: https://git.openjdk.org/jdk/pull/21744#issuecomment-24642