Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v3]

2025-07-15 Thread Alan Bateman
On Tue, 1 Jul 2025 16:50:09 GMT, David Beaumont wrote: >> test/micro/org/openjdk/bench/jdk/internal/jrtfs/ImageReaderBenchmark.java >> line 230: >> >>> 228: // Created by running "java -verbose:class", throwing away >>> anonymous inner >>> 229: // classes and anything without a reliabl

RFR: 8362244: Devkit's Oracle Linux base OS keyword is incorrectly documented

2025-07-15 Thread Volkan Yazici
`open/doc/building.md` uses the incorrect `OEL6` keyword to denote the Oracle Enterprise Linux base OS distribution for Devkit – replaced it with the correct one instead, i.e., `OL`. - Commit messages: - Fix OL-related base OS keywords in Devkit docs Changes: https://git.openjdk.o

Re: RFR: 8360459: UNICODE_CASE and character class with non-ASCII range does not match ASCII char [v5]

2025-07-15 Thread Xueming Shen
> Regex class should conform to **_Level 1_** of [Unicode Technical Standard > #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/), plus > RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters. > > This PR primarily addresses conformance with RL1.5: Simple Loose Ma

Re: RFR: 8360459: UNICODE_CASE and character class with non-ASCII range does not match ASCII char [v5]

2025-07-15 Thread Xueming Shen
On Mon, 14 Jul 2025 07:28:09 GMT, Xueming Shen wrote: >> src/java.base/share/classes/jdk/internal/util/regex/CaseFolding.java.template >> line 99: >> >>> 97: */ >>> 98: public static int[] getClassRangeClosingCharacters(int start, int >>> end) { >>> 99: int[] expanded = new in

Re: RFR: 8360459: UNICODE_CASE and character class with non-ASCII range does not match ASCII char [v6]

2025-07-15 Thread Naoto Sato
On Tue, 15 Jul 2025 17:44:00 GMT, Xueming Shen wrote: >> Regex class should conform to **_Level 1_** of [Unicode Technical Standard >> #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/), >> plus RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters. >> >> This P

Re: RFR: 8360459: UNICODE_CASE and character class with non-ASCII range does not match ASCII char [v6]

2025-07-15 Thread Xueming Shen
> Regex class should conform to **_Level 1_** of [Unicode Technical Standard > #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/), plus > RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters. > > This PR primarily addresses conformance with RL1.5: Simple Loose Ma

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v4]

2025-07-15 Thread David Beaumont
On Tue, 1 Jul 2025 17:02:27 GMT, David Beaumont wrote: >> Initial benchmark to capture at least some comparative measures of >> ImageReader performance. >> >> Current results on my laptop: >> >> Benchmark Mode Cnt ScoreError >> Units >> NewImage

Re: RFR: 8362244: Devkit's Oracle Linux base OS keyword is incorrectly documented

2025-07-15 Thread Mikael Vidstedt
On Tue, 15 Jul 2025 09:58:02 GMT, Volkan Yazici wrote: > `open/doc/building.md` uses the incorrect `OEL6` keyword to denote the Oracle > Enterprise Linux base OS distribution for Devkit – replaced it with the > correct one instead, i.e., `OL`. You also need to regenerate the corresponding buil

Re: RFR: 8360459: UNICODE_CASE and character class with non-ASCII range does not match ASCII char [v5]

2025-07-15 Thread Xueming Shen
On Tue, 15 Jul 2025 15:11:07 GMT, Xueming Shen wrote: >> Regex class should conform to **_Level 1_** of [Unicode Technical Standard >> #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/), >> plus RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters. >> >> This P

Re: RFR: 8362244: Devkit's Oracle Linux base OS keyword is incorrectly documented [v2]

2025-07-15 Thread Volkan Yazici
On Tue, 15 Jul 2025 16:46:24 GMT, Mikael Vidstedt wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Apply review feedback > > doc/building.md line 1289: > >> 1287: >> 1288: `BASE_OS` must be one of `OL` for Oracle

Re: RFR: 8362244: Devkit's Oracle Linux base OS keyword is incorrectly documented [v2]

2025-07-15 Thread Volkan Yazici
> `open/doc/building.md` uses the incorrect `OEL6` keyword to denote the Oracle > Enterprise Linux base OS distribution for Devkit – replaced it with the > correct one instead, i.e., `OL`. Volkan Yazici has updated the pull request incrementally with one additional commit since the last revisio

Integrated: 8360459: UNICODE_CASE and character class with non-ASCII range does not match ASCII char

2025-07-15 Thread Xueming Shen
On Mon, 14 Jul 2025 04:53:13 GMT, Xueming Shen wrote: > Regex class should conform to **_Level 1_** of [Unicode Technical Standard > #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/), plus > RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters. > > This PR pri

Re: RFR: 8360459: UNICODE_CASE and character class with non-ASCII range does not match ASCII char [v6]

2025-07-15 Thread Xueming Shen
On Tue, 15 Jul 2025 17:47:29 GMT, Xueming Shen wrote: >> Regex class should conform to **_Level 1_** of [Unicode Technical Standard >> #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/), >> plus RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters. >> >> This P

Re: RFR: 8362244: Devkit's Oracle Linux base OS keyword is incorrectly documented [v2]

2025-07-15 Thread Volkan Yazici
On Tue, 15 Jul 2025 16:46:44 GMT, Mikael Vidstedt wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Apply review feedback > > doc/building.md line 1291: > >> 1289: not specified `OL` will be the default). If the ba

RE: malloc/calloc return value NULL check

2025-07-15 Thread Baesken, Matthias
Regarding calloc – checking , jdk.incubator.vector/unix/native/libsleef seems to have quite a lot of callocs without a NULL check afterwards , but afaik it is 3rd party coding so we will probably not touch it. For sunFont.c I see no direct handling after calloc in the C code : java.des

Re: RFR: 8360459: UNICODE_CASE and character class with non-ASCII range does not match ASCII char [v5]

2025-07-15 Thread Naoto Sato
On Tue, 15 Jul 2025 15:11:07 GMT, Xueming Shen wrote: >> Regex class should conform to **_Level 1_** of [Unicode Technical Standard >> #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/), >> plus RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters. >> >> This P