Re: RFR: 8360459: UNICODE_CASE and character class with non-ASCII range does not match ASCII char [v3]

2025-07-14 Thread Xueming Shen
> Regex class should conform to **_Level 1_** of [Unicode Technical Standard > #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/), plus > RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters. > > This PR primarily addresses conformance with RL1.5: Simple Loose Ma

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v4]

2025-07-14 Thread Roger Riggs
On Tue, 1 Jul 2025 17:02:27 GMT, David Beaumont wrote: >> Initial benchmark to capture at least some comparative measures of >> ImageReader performance. >> >> Current results on my laptop: >> >> Benchmark Mode Cnt ScoreError >> Units >> NewImage

Re: RFR: 8360459: UNICODE_CASE and character class with non-ASCII range does not match ASCII char

2025-07-14 Thread Xueming Shen
On Mon, 14 Jul 2025 05:01:17 GMT, Chen Liang wrote: >> Regex class should conform to **_Level 1_** of [Unicode Technical Standard >> #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/), >> plus RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters. >> >> This PR

Re: RFR: 8360459: UNICODE_CASE and character class with non-ASCII range does not match ASCII char [v2]

2025-07-14 Thread Xueming Shen
> Regex class should conform to **_Level 1_** of [Unicode Technical Standard > #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/), plus > RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters. > > This PR primarily addresses conformance with RL1.5: Simple Loose Ma

Re: RFR: 8360459: UNICODE_CASE and character class with non-ASCII range does not match ASCII char [v2]

2025-07-14 Thread Xueming Shen
On Mon, 14 Jul 2025 05:08:58 GMT, Chen Liang wrote: >> Xueming Shen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update to address the review comments > > make/jdk/src/classes/build/tools/generatecharacter/CaseFolding.java line 45: >

Re: RFR: 8360459: UNICODE_CASE and character class with non-ASCII range does not match ASCII char [v2]

2025-07-14 Thread Naoto Sato
On Mon, 14 Jul 2025 07:54:31 GMT, Xueming Shen wrote: >> Regex class should conform to **_Level 1_** of [Unicode Technical Standard >> #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/), >> plus RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters. >> >> This P

Re: RFR: 8360459: UNICODE_CASE and character class with non-ASCII range does not match ASCII char [v2]

2025-07-14 Thread Xueming Shen
On Mon, 14 Jul 2025 18:10:53 GMT, Naoto Sato wrote: > Looks good. Thanks for adding case folding support which is long overdue 🙂 > Since this is adding a new support for casefolding for character class > ranges, I think CSR and a release note should be considered. Thanks for the review. Arguab

Re: RFR: 8360459: UNICODE_CASE and character class with non-ASCII range does not match ASCII char [v3]

2025-07-14 Thread Naoto Sato
On Mon, 14 Jul 2025 20:13:06 GMT, Xueming Shen wrote: >> Regex class should conform to **_Level 1_** of [Unicode Technical Standard >> #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/), >> plus RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters. >> >> This P

Re: RFR: 8360459: UNICODE_CASE and character class with non-ASCII range does not match ASCII char [v4]

2025-07-14 Thread Xueming Shen
> Regex class should conform to **_Level 1_** of [Unicode Technical Standard > #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/), plus > RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters. > > This PR primarily addresses conformance with RL1.5: Simple Loose Ma