RFR: 8343546: GHA: Cache required dependencies in master-branch workflow

2025-07-04 Thread Aleksey Shipilev
In our current GHA workflows, we only run workflows in branches in personal forks. GHA isolation rules say that workflow caches from the parent branches can be used by descendant branches. For our branches, the usual parent is `master`. Since we do not run workflows on `master`, this means every

Re: RFR: 8361288: Fix build of JTReg: wget exited with exit code 4 [v2]

2025-07-04 Thread Aleksey Shipilev
On Thu, 3 Jul 2025 11:00:28 GMT, Jan Kratochvil wrote: >> https://github.com/jankratochvil/jdk21u-dev/actions/runs/16026488095/job/45215623689 >> [build.sh][INFO] Downloading >> https://archive.apache.org/dist/ant/binaries/apache-ant-1.10.8-bin.zip to >> /home/runner/work/jdk21u-dev/jdk21u-dev/

Re: RFR: 8343546: GHA: Cache required dependencies in master-branch workflow

2025-07-04 Thread Severin Gehwolf
On Fri, 4 Jul 2025 15:23:04 GMT, Aleksey Shipilev wrote: > We should probably write it down somewhere, but I don't quite see where... Maybe a heads-up to jdk-dev list would do and we have it in the list archives once this is in. - PR Comment: https://git.openjdk.org/jdk/pull/26134

Re: RFR: 8343546: GHA: Cache required dependencies in master-branch workflow

2025-07-04 Thread Severin Gehwolf
On Fri, 4 Jul 2025 14:32:44 GMT, Magnus Ihse Bursie wrote: > That seems like a reasonable interpretation, yes. At least if you want to > utilize this optimization. Otoh, Github makes it really easy nowadays with a > simple "sync with upstream" button (or whatever it's called). Thanks. It's not

Re: RFR: 8343546: GHA: Cache required dependencies in master-branch workflow

2025-07-04 Thread Magnus Ihse Bursie
On Fri, 4 Jul 2025 13:21:40 GMT, Aleksey Shipilev wrote: > In our current GHA workflows, we only run workflows in branches in personal > forks. GHA isolation rules say that workflow caches from the parent branches > can be used by descendant branches. For our branches, the usual parent is > `m

Re: RFR: 8343546: GHA: Cache required dependencies in master-branch workflow

2025-07-04 Thread Severin Gehwolf
On Fri, 4 Jul 2025 13:21:40 GMT, Aleksey Shipilev wrote: > GHA isolation rules say that workflow caches from the parent branches can be > used by descendant branches. Is a corollary of that that one ought to keep one's fork `master` branch in sync with the main repo's (`openjdk/jdk`) `master`

Re: RFR: 8343546: GHA: Cache required dependencies in master-branch workflow

2025-07-04 Thread Magnus Ihse Bursie
On Fri, 4 Jul 2025 13:21:40 GMT, Aleksey Shipilev wrote: > In our current GHA workflows, we only run workflows in branches in personal > forks. GHA isolation rules say that workflow caches from the parent branches > can be used by descendant branches. For our branches, the usual parent is > `m

Re: RFR: 8343546: GHA: Cache required dependencies in master-branch workflow [v2]

2025-07-04 Thread Aleksey Shipilev
> In our current GHA workflows, we only run workflows in branches in personal > forks. GHA isolation rules say that workflow caches from the parent branches > can be used by descendant branches. For our branches, the usual parent is > `master`. Since we do not run workflows on `master`, this mea

Re: RFR: 8343546: GHA: Cache required dependencies in master-branch workflow

2025-07-04 Thread Aleksey Shipilev
On Fri, 4 Jul 2025 14:24:00 GMT, Severin Gehwolf wrote: > > GHA isolation rules say that workflow caches from the parent branches can > > be used by descendant branches. > > Is a corollary of that that one ought to keep one's fork `master` branch in > sync with the main repo's (`openjdk/jdk`)

Re: RFR: 8343546: GHA: Cache required dependencies in master-branch workflow [v2]

2025-07-04 Thread Magnus Ihse Bursie
On Fri, 4 Jul 2025 15:30:56 GMT, Aleksey Shipilev wrote: >> In our current GHA workflows, we only run workflows in branches in personal >> forks. GHA isolation rules say that workflow caches from the parent branches >> can be used by descendant branches. For our branches, the usual parent is >

Integrated: 8361306: jdk.compiler-gendata needs to depend on java.base-launchers

2025-07-04 Thread Magnus Ihse Bursie
On Thu, 3 Jul 2025 10:55:50 GMT, Magnus Ihse Bursie wrote: > A recent run in the Oracle CI produced the following: > > Creating ct.sym classes > /bin/bash: $WS/build/linux-aarch64-open/jdk/bin/java: No such file or > directory > modules/jdk.compiler/Gendata.gmk:72: recipe for target > '$WS/bui