On Fri, 27 Jun 2025 20:45:14 GMT, Naoto Sato wrote:
> The ICU4J component currently stores binary data files directly in the
> repository. This change replaces them with base64-encoded text files and
> converts them to binary during the build process
I don't see any benefit of checking in base
Added jimage and jrtfs exports.
-
Commit messages:
- Hacking build file for benchmark
Changes: https://git.openjdk.org/jdk/pull/26035/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26035&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8361013
Stats: 2 lines in 1 fi
On Sun, 29 Jun 2025 22:19:18 GMT, David Beaumont wrote:
> Added jimage and jrtfs exports.
Is there a reason to do this on its own? Usually the exports are expanded as
benchmarks are added that use internal APIs.
-
PR Comment: https://git.openjdk.org/jdk/pull/26035#issuecomment-301
On Sun, 29 Jun 2025 22:19:18 GMT, David Beaumont wrote:
> Added jimage and jrtfs exports.
Looks reasonable.
-
Marked as reviewed by liach (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26035#pullrequestreview-2969934108
