Re: RFR: 8358626: Emit UTF-8 CLDR resources

2025-06-04 Thread Volkan Yazici
On Wed, 4 Jun 2025 21:54:15 GMT, Naoto Sato wrote: > The resource files in `java.base` are supposed to be US English only, but > they also need to use UTF-8 as some of the names are non-ASCII (e.g., Türkiye) @naotoj, shall we add this note as a comment to places where `-utf8` is added? ---

Re: RFR: 8358543: Remove CommentChecker.java and DirDiff.java

2025-06-04 Thread Volkan Yazici
On Tue, 3 Jun 2025 20:11:27 GMT, Magnus Ihse Bursie wrote: > These two tools were moved to src/utils/src/build/tools/ during the > build-infra project. It was not part of the build, but two standalone tools > that nobody knew who created or who used them. > > I think we can safely delete them

Re: RFR: 8358543: Remove CommentChecker.java and DirDiff.java

2025-06-04 Thread Magnus Ihse Bursie
On Tue, 3 Jun 2025 20:11:27 GMT, Magnus Ihse Bursie wrote: > These two tools were moved to src/utils/src/build/tools/ during the > build-infra project. It was not part of the build, but two standalone tools > that nobody knew who created or who used them. > > I think we can safely delete them

Re: RFR: 8358538: Update GHA Windows runner to 2025

2025-06-04 Thread Aleksey Shipilev
On Tue, 3 Jun 2025 19:56:37 GMT, Magnus Ihse Bursie wrote: > GitHub is retiring the windows-2019 runner, starting with brownouts now, and > complete removal in about a month. We need to upgrade to Windows 2022 or > possible Windows 2025. .github/workflows/main.yml line 313: > 311: with: >

Re: RFR: 8358538: Update GHA Windows runner to 2025

2025-06-04 Thread Andrew John Hughes
On Tue, 3 Jun 2025 19:56:37 GMT, Magnus Ihse Bursie wrote: > GitHub is retiring the windows-2019 runner, starting with brownouts now, and > complete removal in about a month. We need to upgrade to Windows 2022 or > possible Windows 2025. There's another case of WIndows 2019 in `main.xml` for `

Re: RFR: 8358543: Remove CommentChecker.java and DirDiff.java

2025-06-04 Thread Erik Joelsson
On Tue, 3 Jun 2025 20:11:27 GMT, Magnus Ihse Bursie wrote: > These two tools were moved to src/utils/src/build/tools/ during the > build-infra project. It was not part of the build, but two standalone tools > that nobody knew who created or who used them. > > I think we can safely delete them

Re: Questions about the Hermetic Java project

2025-06-04 Thread Jiangli Zhou
Ok, still thanks for the thoughts, David. To summarize, here is what we can do for the current step: - Allow JNI_OnLoad_L and etc for JDK internal native libraries with the dynamic linking case. - JNI spec already allows JNI_OnLoad_L and etc for dynamically linked native libraries. No spec change

Re: RFR: 8358538: Update GHA Windows runner to 2025

2025-06-04 Thread Magnus Ihse Bursie
On Wed, 4 Jun 2025 13:06:07 GMT, Andrew John Hughes wrote: > There's another case of WIndows 2019 in `main.xml` for `test-windows-x64` not > fixed here, which is why the testing is stalled. Oh bummer, I did not see that. Fingers crossed that it's enough to just bump that number. -

Re: RFR: 8358538: Update GHA Windows runner to 2025 [v2]

2025-06-04 Thread Magnus Ihse Bursie
On Wed, 4 Jun 2025 11:24:45 GMT, Aleksey Shipilev wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update windows version for testing > > .github/workflows/main.yml line 313: > >> 311: with: >> 312:

Re: RFR: 8358538: Update GHA Windows runner to 2025 [v2]

2025-06-04 Thread Magnus Ihse Bursie
> GitHub is retiring the windows-2019 runner, starting with brownouts now, and > complete removal in about a month. We need to upgrade to Windows 2022 or > possible Windows 2025. Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8358538: Update GHA Windows runner to 2025 [v2]

2025-06-04 Thread Aleksey Shipilev
On Wed, 4 Jun 2025 16:55:12 GMT, Magnus Ihse Bursie wrote: >> .github/workflows/main.yml line 313: >> >>> 311: with: >>> 312: platform: windows-x64 >>> 313: msvc-toolset-version: '14.43' >> >> I wish I understood why `14.43`, since I don't see any reference to it in >> current

Re: RFR: 8358538: Update GHA Windows runner to 2025

2025-06-04 Thread Aleksey Shipilev
On Tue, 3 Jun 2025 19:56:37 GMT, Magnus Ihse Bursie wrote: > GitHub is retiring the windows-2019 runner, starting with brownouts now, and > complete removal in about a month. We need to upgrade to Windows 2022 or > possible Windows 2025. Pretty sure it will just work (tm). I'll hang around for

Re: RFR: 8358538: Update GHA Windows runner to 2025 [v2]

2025-06-04 Thread Aleksey Shipilev
On Wed, 4 Jun 2025 17:03:07 GMT, Magnus Ihse Bursie wrote: >> GitHub is retiring the windows-2019 runner, starting with brownouts now, and >> complete removal in about a month. We need to upgrade to Windows 2022 or >> possible Windows 2025. > > Magnus Ihse Bursie has updated the pull request in

Integrated: 8357000: Write overview documentation for start of release changes

2025-06-04 Thread Joe Darcy
On Tue, 20 May 2025 04:30:57 GMT, Joe Darcy wrote: > First attempt to populate "supplementary docs" with a discussion of the start > of release changes. For reference on the idea of supplementary docs, see the > thread > > "Where to put supplementary docs?" > https://mail.openjdk.org/pipermail

Re: RFR: 8355746: Start of release updates for JDK 26 [v7]

2025-06-04 Thread Joe Darcy
On Tue, 3 Jun 2025 11:14:36 GMT, Nizar Benalla wrote: >> Get JDK 26 underway. > > Nizar Benalla has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 20 commits: > > - Merge branch 'master' into jdk.8355746 > - Problemlist JavaBaseChec

Re: RFR: 8355746: Start of release updates for JDK 26 [v6]

2025-06-04 Thread Kevin Rushforth
On Tue, 3 Jun 2025 11:10:30 GMT, Nizar Benalla wrote: > I have problemlisted > `tools/sincechecker/modules/java.base/JavaBaseCheckSince.java` as it is > failing due to the symbol information lagging behind. What is your plan for addressing this? In its current state, that problem list entry w

Re: RFR: 8355746: Start of release updates for JDK 26 [v7]

2025-06-04 Thread Kevin Rushforth
On Tue, 3 Jun 2025 11:14:36 GMT, Nizar Benalla wrote: >> Get JDK 26 underway. > > Nizar Benalla has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 20 commits: > > - Merge branch 'master' into jdk.8355746 > - Problemlist JavaBaseChec

Re: RFR: 8355746: Start of release updates for JDK 26 [v7]

2025-06-04 Thread Iris Clark
On Tue, 3 Jun 2025 11:14:36 GMT, Nizar Benalla wrote: >> Get JDK 26 underway. > > Nizar Benalla has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 20 commits: > > - Merge branch 'master' into jdk.8355746 > - Problemlist JavaBaseChec

Re: RFR: 8355746: Start of release updates for JDK 26 [v7]

2025-06-04 Thread Nizar Benalla
On Wed, 4 Jun 2025 20:44:12 GMT, Kevin Rushforth wrote: >> Nizar Benalla has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 20 commits: >> >> - Merge branch 'master' into jdk.8355746 >> - Problemlist JavaBaseCheckSince >> - Revert

Re: RFR: 8355746: Start of release updates for JDK 26 [v7]

2025-06-04 Thread Kevin Rushforth
On Tue, 3 Jun 2025 11:14:36 GMT, Nizar Benalla wrote: >> Get JDK 26 underway. > > Nizar Benalla has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 20 commits: > > - Merge branch 'master' into jdk.8355746 > - Problemlist JavaBaseChec

Re: RFR: 8355746: Start of release updates for JDK 26 [v8]

2025-06-04 Thread Nizar Benalla
> Get JDK 26 underway. Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 22 commits: - use a different bug ID to problemlist `kevinrushforth ` - Merge branch 'master' into jdk.8355746 - Merge branch 'master' into jdk.83

Re: RFR: 8355746: Start of release updates for JDK 26 [v9]

2025-06-04 Thread Nizar Benalla
> Get JDK 26 underway. Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision: fix typo - Changes: - all: https://git.openjdk.org/jdk/pull/25008/files - new: https://git.openjdk.org/jdk/pull/25008/files/09df3b66..9929da7b

Integrated: 8358538: Update GHA Windows runner to 2025

2025-06-04 Thread Magnus Ihse Bursie
On Tue, 3 Jun 2025 19:56:37 GMT, Magnus Ihse Bursie wrote: > GitHub is retiring the windows-2019 runner, starting with brownouts now, and > complete removal in about a month. We need to upgrade to Windows 2022 or > possible Windows 2025. This pull request has now been integrated. Changeset: b

Re: RFR: 8355746: Start of release updates for JDK 26 [v9]

2025-06-04 Thread Iris Clark
On Wed, 4 Jun 2025 23:09:08 GMT, Nizar Benalla wrote: >> Get JDK 26 underway. > > Nizar Benalla has updated the pull request incrementally with one additional > commit since the last revision: > > fix typo Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.

Re: RFR: 8358626: Emit UTF-8 CLDR resources

2025-06-04 Thread Naoto Sato
On Wed, 4 Jun 2025 21:54:15 GMT, Naoto Sato wrote: > Changes to generate CLDR resource bundles in UTF-8 encoding. The resource > files in `java.base` are supposed to be US English only, but they also need > to use UTF-8 as some of the names are non-ASCII (e.g., Türkiye) Looks like this PR did