Re: RFR: JDK-8354316 : clang/linux build fails with -Wunused-result warning at XToolkit.c:695:9 [v2]

2025-05-23 Thread Erik Joelsson
On Wed, 14 May 2025 21:28:37 GMT, Harshitha Onkar wrote: >> The following line results in unused-result warning on linux/clang. >> >> >> /java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c:695:9: error: ignoring >> return value of function >> declared with 'warn_unused_result' attribute [-W

Re: RFR: JDK-8354316 : clang/linux build fails with -Wunused-result warning at XToolkit.c:695:9 [v2]

2025-05-23 Thread Erik Joelsson
On Tue, 13 May 2025 18:33:40 GMT, Alexey Ivanov wrote: >> make/modules/java.desktop/lib/AwtLibraries.gmk line 281: >> >>> 279: DISABLED_WARNINGS_gcc_XlibWrapper.c := type-limits >>> pointer-to-int-cast, \ >>> 280: DISABLED_WARNINGS_gcc_XRBackendNative.c := maybe-uninitialized, \ >>>

Re: RFR: 8355798: Implement JEP 514: Ahead-of-Time Command Line Ergonomics [v12]

2025-05-23 Thread Erik Joelsson
On Fri, 23 May 2025 04:31:39 GMT, Ioi Lam wrote: >> This is the implementation of the draft [JEP: Ahead-of-time Command Line >> Ergonomics](https://bugs.openjdk.org/browse/JDK-8350022) >> >> - Implemented new flag `AOTCacheOutput`, which can be used to create an AOT >> cache using the "one-com

Re: RFR: JDK-8354316 : clang/linux build fails with -Wunused-result warning at XToolkit.c:695:9 [v3]

2025-05-23 Thread Alexey Ivanov
On Fri, 23 May 2025 16:36:23 GMT, Harshitha Onkar wrote: >> The following line results in unused-result warning on linux/clang. >> >> >> /java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c:695:9: error: ignoring >> return value of function >> declared with 'warn_unused_result' attribute [-W

Re: RFR: 8357000: Write overview documentation for start of release changes [v2]

2025-05-23 Thread Magnus Ihse Bursie
On Wed, 21 May 2025 17:58:30 GMT, Mark Reinhold wrote: > Writing this up is good, but I think it belongs in `doc` rather than > `doc/ref`. I agree. It does not feel substantially different from the other "process" documents we already have in `doc`. (That would also take care of generation of

Re: RFR: JDK-8354316 : clang/linux build fails with -Wunused-result warning at XToolkit.c:695:9 [v3]

2025-05-23 Thread Harshitha Onkar
> The following line results in unused-result warning on linux/clang. > > > /java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c:695:9: error: ignoring > return value of function > declared with 'warn_unused_result' attribute [-Werror,-Wunused-result] > 695 | write ( AWT_WRITEPIPE, &wakeUp_ch

Integrated: JDK-8354316 : clang/linux build fails with -Wunused-result warning at XToolkit.c:695:9

2025-05-23 Thread Harshitha Onkar
On Tue, 13 May 2025 18:19:37 GMT, Harshitha Onkar wrote: > The following line results in unused-result warning on linux/clang. > > > /java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c:695:9: error: ignoring > return value of function > declared with 'warn_unused_result' attribute [-Werror,

Re: RFR: JDK-8354316 : clang/linux build fails with -Wunused-result warning at XToolkit.c:695:9 [v3]

2025-05-23 Thread Magnus Ihse Bursie
On Fri, 23 May 2025 16:36:23 GMT, Harshitha Onkar wrote: >> The following line results in unused-result warning on linux/clang. >> >> >> /java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c:695:9: error: ignoring >> return value of function >> declared with 'warn_unused_result' attribute [-W

Re: RFR: 8357141: Update to use jtreg 7.5.2

2025-05-23 Thread Magnus Ihse Bursie
On Fri, 16 May 2025 09:51:56 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.5.2. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVers

Re: RFR: 8357000: Write overview documentation for start of release changes [v2]

2025-05-23 Thread Joe Darcy
On Wed, 21 May 2025 21:14:12 GMT, Iris Clark wrote: > Some of these changes require a CSR. Should that be mentioned somewhere? I think "and all the usual review processes need to be followed" is implicit. My main intention is to both summarize the concept of what is in the start-of-release cha

Re: RFR: 8357000: Write overview documentation for start of release changes [v2]

2025-05-23 Thread Joe Darcy
On Wed, 21 May 2025 17:58:30 GMT, Mark Reinhold wrote: > Writing this up is good, but I think it belongs in `doc` rather than > `doc/ref`. In discussion, the latter morphed into `doc/internals`, and this > isn’t about JDK internals. Also, this fits well alongside the `building.md` > and `testi

Re: RFR: 8357141: Update to use jtreg 7.5.2

2025-05-23 Thread Iris Clark
On Fri, 16 May 2025 09:51:56 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.5.2. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVers