On Tue, 11 Feb 2025 15:56:39 GMT, Matthias Baesken wrote:
> The libjdwp is currently built with LOW optimization level, it could be built
> with SIZE optimization to lower the lib size by ~ 10 % on UNIX.
> On Windows LOW and SIZE currently translate to the same O1 optimization flag
> so no diff
On Tue, 20 May 2025 13:28:22 GMT, Magnus Ihse Bursie wrote:
> In `SetJtregValue` and `SetMicroValue`, if a default or user-supplied value
> was given, the corresponding "local" variable was assigned using :=, which
> will force future eager evaluation of the variable, most notably `+=`.
> Howe
On Sun, 18 May 2025 23:44:13 GMT, Sergey Bylokhov wrote:
> This patch suppresses compiler warning C5287 triggered in debugInit.c when
> building with Visual Studio 2022 version 17.14 (released a few days ago).
>
> I’m simply disabling the warning to unblock the broken build. This change is
> i
Please review a trivial change to disable syntax highlighting in JDK API docs.
-
Commit messages:
- 8357376: Disable syntax highlighting for JDK API docs
Changes: https://git.openjdk.org/jdk/pull/25348/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25348&range=00
Issue:
There are several locations in the JDK source where `System.in` and
`FileDescriptor.in` is read with `InputStreamReader` and `Scanner` using the
default charset. As recommended by the recently merged
[JDK-8356420](https://bugs.openjdk.org/browse/JDK-8356420), this PR replaces
the default charse
On Wed, 21 May 2025 23:17:26 GMT, Mikael Vidstedt wrote:
> Backing out JDK-8357048 which broke testing.
>
> Testing: tier5 (in progress)
LGTM. Thanks for doing the backout.
-
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25374#pullrequestre
On Wed, 21 May 2025 23:17:26 GMT, Mikael Vidstedt wrote:
> Backing out JDK-8357048 which broke testing.
>
> Testing: tier5 (in progress)
Marked as reviewed by erikj (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/25374#pullrequestreview-2859375418
Backing out JDK-8357048 which broke testing.
Testing: tier5 (in progress)
-
Commit messages:
- 8357511: [BACKOUT] 8357048: RunTest variables should always be assigned
Changes: https://git.openjdk.org/jdk/pull/25374/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25374&rang
On Tue, 20 May 2025 17:14:38 GMT, Joe Darcy wrote:
>> First attempt to populate "supplementary docs" with a discussion of the
>> start of release changes. For reference on the idea of supplementary docs,
>> see the thread
>>
>> "Where to put supplementary docs?"
>> https://mail.openjdk.org/pip
On Wed, 21 May 2025 23:17:26 GMT, Mikael Vidstedt wrote:
> Backing out JDK-8357048 which broke testing.
>
> Testing: tier5 (in progress)
This pull request has now been integrated.
Changeset: b685ea54
Author:Mikael Vidstedt
URL:
https://git.openjdk.org/jdk/commit/b685ea54081fcf54a65
On Wed, 21 May 2025 23:17:26 GMT, Mikael Vidstedt wrote:
> Backing out JDK-8357048 which broke testing.
>
> Testing: tier5 (in progress)
Thank you for the quick reviews!
-
PR Comment: https://git.openjdk.org/jdk/pull/25374#issuecomment-2899584725
On Tue, 20 May 2025 17:14:38 GMT, Joe Darcy wrote:
>> First attempt to populate "supplementary docs" with a discussion of the
>> start of release changes. For reference on the idea of supplementary docs,
>> see the thread
>>
>> "Where to put supplementary docs?"
>> https://mail.openjdk.org/pip
On Wed, 21 May 2025 06:19:36 GMT, Jan Lahoda wrote:
>> This patch builds on top of https://github.com/openjdk/jdk/pull/24746, and
>> adds support for `@RequiresIdentity` to `--release`.
>>
>> Important parts of the patch:
>> - `CreateSymbols` now keeps
>> `RuntimeInvisibleTypeAnnotationsAttrib
On Wed, 21 May 2025 20:56:31 GMT, Volkan Yazici wrote:
> There are several locations in the JDK source where `System.in` and
> `FileDescriptor.in` is read with `InputStreamReader` and `Scanner` using the
> default charset. As recommended by the recently merged
> [JDK-8356420](https://bugs.open
On Wed, 14 May 2025 21:28:37 GMT, Harshitha Onkar wrote:
>> The following line results in unused-result warning on linux/clang.
>>
>>
>> /java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c:695:9: error: ignoring
>> return value of function
>> declared with 'warn_unused_result' attribute [-W
On Wed, 21 May 2025 20:56:31 GMT, Volkan Yazici wrote:
> There are several locations in the JDK source where `System.in` and
> `FileDescriptor.in` is read with `InputStreamReader` and `Scanner` using the
> default charset. As recommended by the recently merged
> [JDK-8356420](https://bugs.open
> Please review this PR that adds a `test-linux-x64-static` job, which runs
> tier1 tests on the static-jdk 'release' binary created from the
> `linux-x64-static` build job in GHA. Following are the details on the changes:
>
> .github/actions/get-bundles/action.yml.
> - Add `static-suffix` param
> Please review this PR that adds a `test-linux-x64-static` job, which runs
> tier1 tests on the static-jdk 'release' binary created from the
> `linux-x64-static` build job in GHA. Following are the details on the changes:
>
> .github/actions/get-bundles/action.yml.
> - Add `static-suffix` param
On Wed, 21 May 2025 22:09:15 GMT, Jiangli Zhou wrote:
>> Please review this PR that adds a `test-linux-x64-static` job, which runs
>> tier1 tests on the static-jdk 'release' binary created from the
>> `linux-x64-static` build job in GHA. Following are the details on the
>> changes:
>>
>> .git
On Wed, 21 May 2025 16:50:42 GMT, Erik Joelsson wrote:
> > @erikj79 , do you know the build target that would generate the HTML from
> > the new Mardown file? Thanks.
>
> ```
> make update-build-docs
> ```
>
> I'm not sure if it will search recursively through subdirectories or not.
It did no
On Wed, 21 May 2025 10:36:58 GMT, Hannes Wallnöfer wrote:
> Please review a trivial change to disable syntax highlighting in JDK API docs.
This pull request has now been integrated.
Changeset: a07150af
Author:Hannes Wallnöfer
URL:
https://git.openjdk.org/jdk/commit/a07150af1139b2625
On Tue, 20 May 2025 20:06:28 GMT, Erik Joelsson wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> Marked as reviewed by erikj (Reviewer).
> @erikj79 , do you know the build target that w
On Tue, 20 May 2025 17:14:38 GMT, Joe Darcy wrote:
>> First attempt to populate "supplementary docs" with a discussion of the
>> start of release changes. For reference on the idea of supplementary docs,
>> see the thread
>>
>> "Where to put supplementary docs?"
>> https://mail.openjdk.org/pip
On Tue, 20 May 2025 20:06:28 GMT, Erik Joelsson wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> Marked as reviewed by erikj (Reviewer).
@erikj79 , do you know the build target that wou
On Wed, 21 May 2025 10:36:58 GMT, Hannes Wallnöfer wrote:
> Please review a trivial change to disable syntax highlighting in JDK API docs.
Marked as reviewed by erikj (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/25348#pullrequestreview-2857648558
25 matches
Mail list logo
