Re: RFR: 8355570: [s390x] Update -march to z13 generation [v2]

2025-05-16 Thread Lutz Schmidt
On Thu, 15 May 2025 16:03:51 GMT, Amit Kumar wrote: >> updated march level from z10 to z13. >> >> Testing: tier1 (fastdebug-vm) > > Amit Kumar has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by

Re: RFR: 8355570: [s390x] Update -march to z13 generation [v2]

2025-05-16 Thread Amit Kumar
On Fri, 16 May 2025 09:52:28 GMT, Lutz Schmidt wrote: > This change enables new gcc optimizations which fully kick in only in the > release build. locally both fastdebug + release builds are totally fine, I did build + tier1 test run and didn't see any issue. > do you see any performance ga

Withdrawn: 8351842: Windows specific issues in combination of JEP 493 and --with-external-symbols-in-bundles=public

2025-05-16 Thread duke
On Fri, 14 Mar 2025 12:29:22 GMT, Christoph Langer wrote: > Alternative approach to #24012 > > This keeps the current handling of *.pdb vs *.stripped.pdb which allows > debugging at the cost of a little hack in jlink. Maybe the code in jlink can > be improved, e.g. make it more conditional. >

Re: RFR: 8355452: GHA: Test jtreg tier1 on linux-x64 static-jdk [v10]

2025-05-16 Thread Magnus Ihse Bursie
On Thu, 15 May 2025 19:44:39 GMT, Jiangli Zhou wrote: >> Please review this PR that adds a `test-linux-x64-static` job, which runs >> tier1 tests on the static-jdk 'release' binary created from the >> `linux-x64-static` build job in GHA. Following are the details on the >> changes: >> >> .git

Re: RFR: 8355452: GHA: Test jtreg tier1 on linux-x64 static-jdk [v10]

2025-05-16 Thread Magnus Ihse Bursie
On Thu, 15 May 2025 19:44:39 GMT, Jiangli Zhou wrote: >> Please review this PR that adds a `test-linux-x64-static` job, which runs >> tier1 tests on the static-jdk 'release' binary created from the >> `linux-x64-static` build job in GHA. Following are the details on the >> changes: >> >> .git

Re: RFR: 8349638: Build libjdwp with SIZE optimization

2025-05-16 Thread Magnus Ihse Bursie
On Tue, 11 Feb 2025 15:56:39 GMT, Matthias Baesken wrote: > The libjdwp is currently built with LOW optimization level, it could be built > with SIZE optimization to lower the lib size by ~ 10 % on UNIX. > On Windows LOW and SIZE currently translate to the same O1 optimization flag > so no diff

Re: RFR: 8355452: GHA: Test jtreg tier1 on linux-x64 static-jdk [v10]

2025-05-16 Thread Jiangli Zhou
On Fri, 16 May 2025 20:23:00 GMT, Magnus Ihse Bursie wrote: > I approved this but then I noticed that there were failures in the last GHA > run for the new static run. You need to fix or problemlist them before > integrating. Right, I'll hold off integrating this PR, until the static testing g

Re: RFR: 8354257: xctracenorm profiler not working with JDK JMH benchmarks

2025-05-16 Thread Galder ZamarreƱo
On Wed, 30 Apr 2025 08:43:19 GMT, Galder ZamarreƱo wrote: > > > I do think it's a bug that JMH is bundling its checkstyle and findbugs > > > configurations in its distribution jar, so perhaps we can suggest to a > > > JMH maintainer to stop doing that. :) > > > > > > I think that makes sense