Re: RFR: 8355003: Implement JEP 515: Ahead-of-Time Method Profiling [v18]

2025-05-13 Thread Igor Veresov
> Improve warm-up time by making profile data from a previous run of an > application instantly available, when the HotSpot Java Virtual Machine > starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) > to store method execution profiles from training runs, reducing profili

Re: RFR: 8355003: Implement JEP 515: Ahead-of-Time Method Profiling [v19]

2025-05-13 Thread Igor Veresov
> Improve warm-up time by making profile data from a previous run of an > application instantly available, when the HotSpot Java Virtual Machine > starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) > to store method execution profiles from training runs, reducing profili

Re: RFR: 8355003: Implement JEP 515: Ahead-of-Time Method Profiling [v14]

2025-05-13 Thread Igor Veresov
On Tue, 13 May 2025 07:42:33 GMT, Ioi Lam wrote: >> Do you want me to leave the existing `log_info` alone? Or should I fix >> everything in `FileMapHeader::validate()` ? > > You can leave the existing code and just fix the new code you added. Done. And changed the test. Please take a look. ---

Re: RFR: 8355003: Implement JEP 515: Ahead-of-Time Method Profiling [v19]

2025-05-13 Thread Ioi Lam
On Tue, 13 May 2025 22:40:42 GMT, Igor Veresov wrote: >> Improve warm-up time by making profile data from a previous run of an >> application instantly available, when the HotSpot Java Virtual Machine >> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) >> to store me

Re: RFR: 8355003: Implement JEP 515: Ahead-of-Time Method Profiling [v19]

2025-05-13 Thread Igor Veresov
On Tue, 13 May 2025 23:10:53 GMT, Ioi Lam wrote: >> Igor Veresov has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 82 commits: >> >> - Merge branch 'master' into pp2 >> - Address Ioi's comments >> - 8356885: Don't emit C1 profili

Re: RFR: 8355798: Implement JEP 514: Ahead-of-Time Command Line Ergonomics [v7]

2025-05-13 Thread Dan Heidinga
On Tue, 13 May 2025 03:06:44 GMT, Ioi Lam wrote: >> This is the implementation of the draft [JEP: Ahead-of-time Command Line >> Ergonomics](https://bugs.openjdk.org/browse/JDK-8350022) >> >> - Implemented new flag `AOTCacheOutput`, which can be used to create an AOT >> cache using the "one-com

Re: RFR: 8356820: fixpath should allow + in paths on Windows

2025-05-13 Thread Erik Joelsson
On Tue, 13 May 2025 01:17:25 GMT, Chihiro Ito wrote: > When we run configure on Windows, fixpath is used, but this causes an error > if the path contains +. > > For example, when we unzip Temurin 24, the directory name created is > jdk-24+36. When we specify this as the boot JDK, the following

Re: RFR: 8327466: ct.sym zip not reproducible across build environment timezones

2025-05-13 Thread Erik Joelsson
On Tue, 13 May 2025 12:00:15 GMT, Jaikiran Pai wrote: > Can I please get a review of this change in the JDK build tool class > `CreateSymbols` which addresses an issue related to the reproducibility of > the generated `ct.sym` file? This addresses > https://bugs.openjdk.org/browse/JDK-8327466.

Re: RFR: 8355003: Implement JEP 515: Ahead-of-Time Method Profiling [v14]

2025-05-13 Thread Ioi Lam
On Tue, 13 May 2025 03:32:13 GMT, Igor Veresov wrote: >> src/hotspot/share/cds/filemap.cpp line 1955: >> >>> 1953: " does not equal the current >>> SpecTrapLimitExtraEntries setting (%d).", file_type, >>> 1954: _spec_trap_limit_extra_entries, >>> SpecTra

RFR: 8327466: ct.sym zip not reproducible across build environment timezones

2025-05-13 Thread Jaikiran Pai
Can I please get a review of this change in the JDK build tool class `CreateSymbols` which addresses an issue related to the reproducibility of the generated `ct.sym` file? This addresses https://bugs.openjdk.org/browse/JDK-8327466. Even before this change, in order to support reproducibility o

Re: RFR: 8327466: ct.sym zip not reproducible across build environment timezones

2025-05-13 Thread Jan Lahoda
On Tue, 13 May 2025 12:00:15 GMT, Jaikiran Pai wrote: > Can I please get a review of this change in the JDK build tool class > `CreateSymbols` which addresses an issue related to the reproducibility of > the generated `ct.sym` file? This addresses > https://bugs.openjdk.org/browse/JDK-8327466.

RFR: JDK-8354316 : clang/linux build fails with -Wunused-result warning at XToolkit.c:695:9

2025-05-13 Thread Harshitha Onkar
The following line results in unused-result warning on linux/clang. /java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c:695:9: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result] 695 | write ( AWT_WRITEPIPE, &wakeUp_char, 1 ); Th

Re: RFR: JDK-8354316 : clang/linux build fails with -Wunused-result warning at XToolkit.c:695:9

2025-05-13 Thread Harshitha Onkar
On Tue, 13 May 2025 18:19:37 GMT, Harshitha Onkar wrote: > The following line results in unused-result warning on linux/clang. > > > /java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c:695:9: error: ignoring > return value of function > declared with 'warn_unused_result' attribute [-Werror,

Re: RFR: JDK-8354316 : clang/linux build fails with -Wunused-result warning at XToolkit.c:695:9

2025-05-13 Thread Alexey Ivanov
On Tue, 13 May 2025 18:30:01 GMT, Harshitha Onkar wrote: >> The following line results in unused-result warning on linux/clang. >> >> >> /java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c:695:9: error: ignoring >> return value of function >> declared with 'warn_unused_result' attribute [-W

Re: RFR: JDK-8354316 : clang/linux build fails with -Wunused-result warning at XToolkit.c:695:9

2025-05-13 Thread Alexey Ivanov
On Tue, 13 May 2025 18:19:37 GMT, Harshitha Onkar wrote: > The following line results in unused-result warning on linux/clang. > > > /java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c:695:9: error: ignoring > return value of function > declared with 'warn_unused_result' attribute [-Werror,

Re: RFR: 8355003: Implement JEP 515: Ahead-of-Time Method Profiling [v20]

2025-05-13 Thread Ioi Lam
On Tue, 13 May 2025 23:43:01 GMT, Igor Veresov wrote: >> Improve warm-up time by making profile data from a previous run of an >> application instantly available, when the HotSpot Java Virtual Machine >> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) >> to store me

Re: RFR: 8355003: Implement JEP 515: Ahead-of-Time Method Profiling [v19]

2025-05-13 Thread Igor Veresov
On Tue, 13 May 2025 23:13:42 GMT, Igor Veresov wrote: >> test/hotspot/jtreg/runtime/cds/appcds/aotProfile/AOTProfileFlags.java line >> 115: >> >>> 113: >>> 114: out = CDSTestUtils.executeAndLog(pb, "production_failure"); >>> 115: out.shouldContain("does not equal"); >> >> Sinc

Re: RFR: 8355003: Implement JEP 515: Ahead-of-Time Method Profiling [v20]

2025-05-13 Thread Igor Veresov
> Improve warm-up time by making profile data from a previous run of an > application instantly available, when the HotSpot Java Virtual Machine > starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) > to store method execution profiles from training runs, reducing profili

Integrated: 8356820: fixpath should allow + in paths on Windows

2025-05-13 Thread Chihiro Ito
On Tue, 13 May 2025 01:17:25 GMT, Chihiro Ito wrote: > When we run configure on Windows, fixpath is used, but this causes an error > if the path contains +. > > For example, when we unzip Temurin 24, the directory name created is > jdk-24+36. When we specify this as the boot JDK, the following

Integrated: 8356686: doc/building.html is not up to date after JDK-8301971

2025-05-13 Thread Kim Barrett
On Sat, 10 May 2025 22:45:54 GMT, Kim Barrett wrote: > Please review this change to doc/building.html. The change is the result of > using `make update-build-docs` to regenerate it from the current building.md > file. This pull request has now been integrated. Changeset: 530d14a1 Author:Ki

Re: RFR: 8356686: doc/building.html is not up to date after JDK-8301971

2025-05-13 Thread Kim Barrett
On Sat, 10 May 2025 22:45:54 GMT, Kim Barrett wrote: > Please review this change to doc/building.html. The change is the result of > using `make update-build-docs` to regenerate it from the current building.md > file. Thanks for reviews. - PR Comment: https://git.openjdk.org/jdk/p

Re: RFR: JDK-8354316 : clang/linux build fails with -Wunused-result warning at XToolkit.c:695:9

2025-05-13 Thread Sergey Bylokhov
On Tue, 13 May 2025 18:36:18 GMT, Alexey Ivanov wrote: >> The following line results in unused-result warning on linux/clang. >> >> >> /java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c:695:9: error: ignoring >> return value of function >> declared with 'warn_unused_result' attribute [-Wer

Re: RFR: 8355452: GHA: Test jtreg tier1 on linux-x64 static-jdk [v5]

2025-05-13 Thread Magnus Ihse Bursie
On Mon, 12 May 2025 22:28:29 GMT, Jiangli Zhou wrote: >> Please review this PR that adds a `test-linux-x64-static` job, which runs >> tier1 tests on the static-jdk 'release' binary created from the >> `linux-x64-static` build job in GHA. Following are the details on the >> changes: >> >> .git

Re: RFR: 8355452: GHA: Test jtreg tier1 on linux-x64 static-jdk [v5]

2025-05-13 Thread Magnus Ihse Bursie
On Tue, 6 May 2025 15:50:01 GMT, Magnus Ihse Bursie wrote: >>> Do we really need to duplicate all this code? From what I can see, this is >>> just to be able to send in the JDK_FOR_COMPILE argument, right? >> >> Yaml syntax is new to me. I went with that as it worked. :-) The static case >> se

Re: RFR: 8355798: Implement JEP 514: Ahead-of-Time Command Line Ergonomics [v8]

2025-05-13 Thread Ioi Lam
> This is the implementation of the draft [JEP: Ahead-of-time Command Line > Ergonomics](https://bugs.openjdk.org/browse/JDK-8350022) > > - Implemented new flag `AOTCacheOutput`, which can be used to create an AOT > cache using the "one-command workflow" > - Added processing of the `JAVA_AOT_OPT