Re: RFR: 8301971: Make JDK source code UTF-8 [v6]

2025-05-08 Thread Magnus Ihse Bursie
> Most of the JDK code base has been transitioned to UTF-8, but not all. This > has recently become an acute problem, since our mixing of iso-8859-1 and > utf-8 in properties files confused the version of `sed` that is shipped with > the new macOS 15.4. > > The fix is basically simple, and incl

Re: RFR: 8355746: Start of release updates for JDK 26 [v2]

2025-05-08 Thread Nizar Benalla
On Fri, 2 May 2025 16:42:04 GMT, Joe Darcy wrote: >> test/langtools/tools/javac/options/HelpOutputColumnWidthTest.java line 50: >> >>> 48: public class HelpOutputColumnWidthTest extends TestRunner { >>> 49: >>> 50: public static final int MAX_COLUMNS = 84; >> >> What is this for? > > It is

Integrated: 8354278: Revert use of non-POSIX echo -n introduced in JDK-8301197

2025-05-08 Thread Magnus Ihse Bursie
On Wed, 7 May 2025 21:25:39 GMT, Magnus Ihse Bursie wrote: > `echo -n` is not part of the required POSIX standard, and built in shell > versions of echo might not support it. Restore the previous use of `printf` > instead. This pull request has now been integrated. Changeset: 57297e60 Author:

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-08 Thread Daniel Fuchs
On Thu, 8 May 2025 14:51:24 GMT, Leo Korinth wrote: > This change tries to add timeout to individual testcases so that I am able to > run them with a timeout factor of 1 in the future (JDK-8260555). > > The first commit changes the timeout factor to 0.7, so that I can run tests > and test the

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-08 Thread Leo Korinth
On Thu, 8 May 2025 14:51:24 GMT, Leo Korinth wrote: > This change tries to add timeout to individual testcases so that I am able to > run them with a timeout factor of 1 in the future (JDK-8260555). > > The first commit changes the timeout factor to 0.7, so that I can run tests > and test the

Re: RFR: 8351029: IncludeCustomExtension does not work on cygwin with source code below /home [v2]

2025-05-08 Thread Erik Joelsson
On Wed, 7 May 2025 22:50:52 GMT, Magnus Ihse Bursie wrote: >> If you check out your source code in Cygwin, somewhere under /home/... (as >> opposed to /cygpath/...), IncludeCustomExtension does not work. >> >> The problem is that TOPDIR gets a different lexical value from the spec.gmk >> file

Re: RFR: 8301971: Make JDK source code UTF-8 [v6]

2025-05-08 Thread Erik Joelsson
On Thu, 8 May 2025 10:19:31 GMT, Magnus Ihse Bursie wrote: >> Most of the JDK code base has been transitioned to UTF-8, but not all. This >> has recently become an acute problem, since our mixing of iso-8859-1 and >> utf-8 in properties files confused the version of `sed` that is shipped with

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-08 Thread Leo Korinth
On Thu, 8 May 2025 16:04:53 GMT, Stefan Karlsson wrote: >> This change tries to add timeout to individual testcases so that I am able >> to run them with a timeout factor of 1 in the future (JDK-8260555). >> >> The first commit changes the timeout factor to 0.7, so that I can run tests >> and

Re: RFR: 8334391: JDK build should exclude *-files directories for Java source [v2]

2025-05-08 Thread Erik Joelsson
On Wed, 7 May 2025 22:52:09 GMT, Magnus Ihse Bursie wrote: >> make/common/JavaCompilation.gmk line 342: >> >>> 340: $1_SRCS_WITHOUT_ROOTS := $$($1_SRCS) >>> 341: $$(foreach i, $$($1_SRC), $$(eval $1_SRCS_WITHOUT_ROOTS := >>> $$(patsubst \ >>> 342: $$i/%,%, $$($1_SRCS_WITHOUT_ROO

Re: RFR: 8349638: Build libjdwp with SIZE optimization

2025-05-08 Thread Matthias Baesken
On Wed, 9 Apr 2025 12:33:26 GMT, Magnus Ihse Bursie wrote: >> The libjdwp is currently built with LOW optimization level, it could be >> built with SIZE optimization to lower the lib size by ~ 10 % on UNIX. >> On Windows LOW and SIZE currently translate to the same O1 optimization flag >> so no

RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-08 Thread Leo Korinth
This change tries to add timeout to individual testcases so that I am able to run them with a timeout factor of 1 in the future (JDK-8260555). The first commit changes the timeout factor to 0.7, so that I can run tests and test the change (it will finally be changed to 1.0 in JDK-8260555). The n

Re: RFR: 8355746: Start of release updates for JDK 26 [v2]

2025-05-08 Thread Nizar Benalla
> Get JDK 26 underway. Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits: - Update release date - Update --release 25 symbol information for JDK 25 build 21 The macOS/AArch64 build 21 was taken from http

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-08 Thread Stefan Karlsson
On Thu, 8 May 2025 14:51:24 GMT, Leo Korinth wrote: > This change tries to add timeout to individual testcases so that I am able to > run them with a timeout factor of 1 in the future (JDK-8260555). > > The first commit changes the timeout factor to 0.7, so that I can run tests > and test the

Re: RFR: 8301971: Make JDK source code UTF-8 [v6]

2025-05-08 Thread Naoto Sato
On Thu, 8 May 2025 10:19:31 GMT, Magnus Ihse Bursie wrote: >> Most of the JDK code base has been transitioned to UTF-8, but not all. This >> has recently become an acute problem, since our mixing of iso-8859-1 and >> utf-8 in properties files confused the version of `sed` that is shipped with

Re: RFR: 8334391: JDK build should exclude *-files directories for Java source [v2]

2025-05-08 Thread Erik Joelsson
On Wed, 7 May 2025 22:59:04 GMT, Magnus Ihse Bursie wrote: >> We should always exclude `doc-files` and `snippet-files` when compiling java >> code. To generalize this, exclude all `*-files` directories. >> >> (The usage of EXCLUDES and EXCLUDE_FILES is a bit weird. In essence, >> EXCLUDE_FILES

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-08 Thread David Holmes
On Thu, 8 May 2025 14:51:24 GMT, Leo Korinth wrote: > This change tries to add timeout to individual testcases so that I am able to > run them with a timeout factor of 1 in the future (JDK-8260555). > > The first commit changes the timeout factor to 0.7, so that I can run tests > and test the

Re: RFR: 8356571: Re-enable -Wtype-limits for GCC in LCMS

2025-05-08 Thread Julian Waters
On Thu, 8 May 2025 18:30:11 GMT, Sergey Bylokhov wrote: > The -Wtype-limits warning was previously disabled in the OpenJDK build for > LCMS 2.14+ due to upstream issues: https://github.com/openjdk/jdk/pull/11217 > The issue was reported to the LCMS project: > https://github.com/mm2/Little-CMS/i

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-08 Thread Phil Race
On Thu, 8 May 2025 14:51:24 GMT, Leo Korinth wrote: > This change tries to add timeout to individual testcases so that I am able to > run them with a timeout factor of 1 in the future (JDK-8260555). > > The first commit changes the timeout factor to 0.7, so that I can run tests > and test the

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-08 Thread Daniel Fuchs
On Thu, 8 May 2025 14:51:24 GMT, Leo Korinth wrote: > This change tries to add timeout to individual testcases so that I am able to > run them with a timeout factor of 1 in the future (JDK-8260555). > > The first commit changes the timeout factor to 0.7, so that I can run tests > and test the

RFR: 8356571: Re-enable -Wtype-limits for GCC in LCMS

2025-05-08 Thread Sergey Bylokhov
The -Wtype-limits warning was previously disabled in the OpenJDK build for LCMS 2.14+ due to upstream issues: https://github.com/openjdk/jdk/pull/11217 The issue was reported to the LCMS project: https://github.com/mm2/Little-CMS/issues/458 It has since been fixed in LCMS 2.17 and integrated into

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-08 Thread Leonid Mesnik
On Thu, 8 May 2025 16:43:10 GMT, Leo Korinth wrote: >> This change tries to add timeout to individual testcases so that I am able >> to run them with a timeout factor of 1 in the future (JDK-8260555). >> >> The first commit changes the timeout factor to 0.7, so that I can run tests >> and test

Re: RFR: 8356571: Re-enable -Wtype-limits for GCC in LCMS

2025-05-08 Thread Phil Race
On Thu, 8 May 2025 18:30:11 GMT, Sergey Bylokhov wrote: > The -Wtype-limits warning was previously disabled in the OpenJDK build for > LCMS 2.14+ due to upstream issues: https://github.com/openjdk/jdk/pull/11217 > The issue was reported to the LCMS project: > https://github.com/mm2/Little-CMS/i

Re: RFR: 8355746: Start of release updates for JDK 26 [v2]

2025-05-08 Thread David Holmes
On Thu, 8 May 2025 13:18:07 GMT, Nizar Benalla wrote: >> Get JDK 26 underway. > > Nizar Benalla has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains seven commits: > > - Update release date > - Update --release 25 symbol information f

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-08 Thread Leonid Mesnik
On Thu, 8 May 2025 17:03:03 GMT, Leo Korinth wrote: >> doc/testing.md line 385: >> >>> 383: (`-timeoutFactor`). Also, some test cases that programmatically wait a >>> 384: certain amount of time will apply this factor. If we run in >>> 385: interpreted mode (`-Xcomp`), [RunTest.gmk](../make/RunT

Integrated: 8356571: Re-enable -Wtype-limits for GCC in LCMS

2025-05-08 Thread Sergey Bylokhov
On Thu, 8 May 2025 18:30:11 GMT, Sergey Bylokhov wrote: > The -Wtype-limits warning was previously disabled in the OpenJDK build for > LCMS 2.14+ due to upstream issues: https://github.com/openjdk/jdk/pull/11217 > The issue was reported to the LCMS project: > https://github.com/mm2/Little-CMS/i