Re: RFR: 8350209: Preserve adapters in AOT cache [v12]

2025-04-29 Thread Ioi Lam
On Wed, 30 Apr 2025 02:05:41 GMT, Vladimir Kozlov wrote: >> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class >> information in AOT cache which helps Java startup performance. >> >> We should also preserve adapters (i2c, c2i) to further improve performance >> of class link

Re: RFR: 8355570: [s390x] Update -march to z13 generation

2025-04-29 Thread Amit Kumar
On Mon, 28 Apr 2025 19:35:46 GMT, Magnus Ihse Bursie wrote: > This is a failure when building the gtest framework. > > Could this different arch flag be sensitive to different gcc versions? When > you say you tested locally, what gcc version did you use? This is the config: gcc version 11.4.0

Re: RFR: 8355003: Implement Ahead-of-Time Method Profiling [v5]

2025-04-29 Thread Igor Veresov
> Improve warm-up time by making profile data from a previous run of an > application instantly available, when the HotSpot Java Virtual Machine > starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) > to store method execution profiles from training runs, reducing profili

Re: RFR: 8355003: Implement Ahead-of-Time Method Profiling [v5]

2025-04-29 Thread Igor Veresov
On Sun, 27 Apr 2025 01:15:54 GMT, Vladimir Kozlov wrote: >> You mean you want these checks to be done only if `TrainingData::have_data() >> == true` ? > > Yes, if it is related. Otherwise you may change default behavior when Leyden > code is not used. I simplified it and factored out the new s

Re: RFR: 8350209: Preserve adapters in AOT cache [v11]

2025-04-29 Thread Ioi Lam
On Tue, 29 Apr 2025 15:29:08 GMT, Vladimir Kozlov wrote: >> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class >> information in AOT cache which helps Java startup performance. >> >> We should also preserve adapters (i2c, c2i) to further improve performance >> of class link

Re: RFR: 8355080: java.base/jdk.internal.foreign.SystemLookup.find() doesn't work on static JDK [v3]

2025-04-29 Thread Jiangli Zhou
On Tue, 29 Apr 2025 06:43:59 GMT, Magnus Ihse Bursie wrote: >> Jiangli Zhou has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Merge branch 'JDK-8355080' of ssh://github.com/jianglizhou/jdk into >> JDK-8355080 >> - Address henryjen@ com

Re: RFR: 8350209: Preserve adapters in AOT cache [v12]

2025-04-29 Thread Vladimir Kozlov
> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class > information in AOT cache which helps Java startup performance. > > We should also preserve adapters (i2c, c2i) to further improve performance of > class linking where adapters are generated. > > Short running Java applic

Re: RFR: 8350209: Preserve adapters in AOT cache [v11]

2025-04-29 Thread Vladimir Kozlov
On Wed, 30 Apr 2025 01:15:21 GMT, Ioi Lam wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove unused method > > LGTM. Some small nits. Thank you, @iklam, for review. I pushed your suggestions. -

RE: clang Memory sanitizer (msan) and OpenJDK

2025-04-29 Thread Baesken, Matthias
* I thought I recognized this issue, and started searching the mail archive. Seems the same question was asked last year by ... you. :-) Yeah I looked into msan some time ago and wanted to look into it again now . * I don't understand how the msan internal functions are supposed to work

Re: RFR: 8355594: Warnings occur when building with clang and enabling ubsan [v2]

2025-04-29 Thread Erik Joelsson
On Tue, 29 Apr 2025 09:05:07 GMT, Matthias Baesken wrote: >> When building ubsan-enabled binaries with the clang toolchain (e.g. on AIX >> or Linux), we get the following warnings : >> >> >> warning: unknown warning option '-Wno-stringop-truncation'; did you mean >> '-Wno-string-concatenation

Re: RFR: 8355594: Warnings occur when building with clang and enabling ubsan [v2]

2025-04-29 Thread Matthias Baesken
On Tue, 29 Apr 2025 09:05:07 GMT, Matthias Baesken wrote: >> When building ubsan-enabled binaries with the clang toolchain (e.g. on AIX >> or Linux), we get the following warnings : >> >> >> warning: unknown warning option '-Wno-stringop-truncation'; did you mean >> '-Wno-string-concatenation

Integrated: 8355594: Warnings occur when building with clang and enabling ubsan

2025-04-29 Thread Matthias Baesken
On Mon, 28 Apr 2025 15:22:50 GMT, Matthias Baesken wrote: > When building ubsan-enabled binaries with the clang toolchain (e.g. on AIX or > Linux), we get the following warnings : > > > warning: unknown warning option '-Wno-stringop-truncation'; did you mean > '-Wno-string-concatenation'? [-W

RE: clang Memory sanitizer (msan) and OpenJDK

2025-04-29 Thread Baesken, Matthias
>>Maybe you can try patching out -fvisibility=hidden from the compile command >>line to see if that makes any difference. >Sounds like a good idea to start with, I will try this! Seems the visibility >stuff plays a role here. I removed the -fvisibility=hidden from make/autoconf/flags-cflag

Re: RFR: 8355080: java.base/jdk.internal.foreign.SystemLookup.find() doesn't work on static JDK [v3]

2025-04-29 Thread Alan Bateman
On Tue, 29 Apr 2025 06:43:59 GMT, Magnus Ihse Bursie wrote: > Do we have native libraries in the JDK that are not loaded by the boot > loader? There are few, e.g. java.security.jgss, jdk.security.auth and jdk.crypto.cryptoki are mapped to the platform class loader, and jdk.attach mapped to t

Re: RFR: 8355697: Create windows devkit on wsl and msys2 [v3]

2025-04-29 Thread duke
On Tue, 29 Apr 2025 03:38:33 GMT, kuaiwei wrote: >> The patch fix error when creating devkit on wsl/msys2 . >> * Msys2 can be supported like cygwin >> * In wsl, it can not test path name in windows format, like `if [ -d >> "d:/VisualStuio"]` . The path must be converted as linux style before >>

Re: RFR: 8355697: Create windows devkit on wsl and msys2 [v2]

2025-04-29 Thread kuaiwei
On Mon, 28 Apr 2025 13:47:47 GMT, Erik Joelsson wrote: >> kuaiwei has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Get SDK_INSTALL_DIR from enviroment variable > > Verified that it still works in Cygwin on my machine. Looks good. @erikj7

Integrated: 8355697: Create windows devkit on wsl and msys2

2025-04-29 Thread kuaiwei
On Mon, 28 Apr 2025 11:03:16 GMT, kuaiwei wrote: > The patch fix error when creating devkit on wsl/msys2 . > * Msys2 can be supported like cygwin > * In wsl, it can not test path name in windows format, like `if [ -d > "d:/VisualStuio"]` . The path must be converted as linux style before testing

Re: RFR: 8355594: Warnings occur when building with clang and enabling ubsan [v2]

2025-04-29 Thread Matthias Baesken
On Mon, 28 Apr 2025 19:25:55 GMT, Magnus Ihse Bursie wrote: >> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Sort flags > > make/autoconf/jdk-options.m4 line 525: > >> 523: UBSAN_CFLAGS="$UBSAN_CHECKS -Wno-array-bou

Re: RFR: 8355594: Warnings occur when building with clang and enabling ubsan [v2]

2025-04-29 Thread Matthias Baesken
> When building ubsan-enabled binaries with the clang toolchain (e.g. on AIX or > Linux), we get the following warnings : > > > warning: unknown warning option '-Wno-stringop-truncation'; did you mean > '-Wno-string-concatenation'? [-Wunknown-warning-option] > warning: unknown warning option '-

Re: RFR: 8350209: Preserve adapters in AOT cache [v11]

2025-04-29 Thread Vladimir Kozlov
> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class > information in AOT cache which helps Java startup performance. > > We should also preserve adapters (i2c, c2i) to further improve performance of > class linking where adapters are generated. > > Short running Java applic

Re: RFR: 8350209: Preserve adapters in AOT cache [v8]

2025-04-29 Thread Vladimir Kozlov
On Tue, 29 Apr 2025 14:42:42 GMT, Ashutosh Mehra wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Downgraded UL as asked. Added synchronization to C strings caching. > > src/hotspot/share/code/aotCodeCache.hpp li

Re: RFR: 8350209: Preserve adapters in AOT cache [v11]

2025-04-29 Thread Ashutosh Mehra
On Tue, 29 Apr 2025 15:29:08 GMT, Vladimir Kozlov wrote: >> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class >> information in AOT cache which helps Java startup performance. >> >> We should also preserve adapters (i2c, c2i) to further improve performance >> of class link

Re: RFR: 8354919: Move HotSpot .editorconfig into the global .editorconfig

2025-04-29 Thread Julian Waters
On Thu, 17 Apr 2025 07:28:03 GMT, Julian Waters wrote: > The src/hotspot directory should ideally only be used for HotSpot source > files, and we should avoid polluting it with an .editorconfig. A cleaner > solution exists since we can just specify the desired code formatting for > HotSpot as

Integrated: 8354919: Move HotSpot .editorconfig into the global .editorconfig

2025-04-29 Thread Julian Waters
On Thu, 17 Apr 2025 07:28:03 GMT, Julian Waters wrote: > The src/hotspot directory should ideally only be used for HotSpot source > files, and we should avoid polluting it with an .editorconfig. A cleaner > solution exists since we can just specify the desired code formatting for > HotSpot as

RE: clang Memory sanitizer (msan) and OpenJDK

2025-04-29 Thread Baesken, Matthias
I checked the link call for javac . /usr/bin/clang -fuse-ld=lld -fuse-ld=lld -Wl,--exclude-libs,ALL -Wl,-z,noexecstack -m64 -fsanitize=memory Could it be that the -Wl,--exclude-libs,ALL“hides” the msan symbols like __msan_param_tlsfrom exporting ? But I guess we set thi

Re: RFR: 8350209: Preserve adapters in AOT cache [v10]

2025-04-29 Thread Ashutosh Mehra
On Tue, 29 Apr 2025 06:27:41 GMT, Vladimir Kozlov wrote: >> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class >> information in AOT cache which helps Java startup performance. >> >> We should also preserve adapters (i2c, c2i) to further improve performance >> of class link

Re: RFR: 8350209: Preserve adapters in AOT cache [v10]

2025-04-29 Thread Vladimir Kozlov
On Tue, 29 Apr 2025 14:47:42 GMT, Ashutosh Mehra wrote: >> Vladimir Kozlov has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 11 commits: >> >> - Fix C strings caching >> - Merge branch 'master' into JDK-8350209 >> - Merge branch

RE: clang Memory sanitizer (msan) and OpenJDK

2025-04-29 Thread Baesken, Matthias
>Could it be that the -Wl,--exclude-libs,ALL“hides” the msan symbols >like __msan_param_tlsfrom exporting ? >But I guess we set this for a reason so removing it might cause other trouble ? Seems the -Wl,--exclude-libs,ALL is the setting that caused the msan build issue, when I r

Re: RFR: 8350209: Preserve adapters in AOT cache [v8]

2025-04-29 Thread Ashutosh Mehra
On Sun, 27 Apr 2025 21:52:43 GMT, Vladimir Kozlov wrote: >> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class >> information in AOT cache which helps Java startup performance. >> >> We should also preserve adapters (i2c, c2i) to further improve performance >> of class link