On Sun, 27 Apr 2025 01:37:33 GMT, Igor Veresov wrote:
>> I thought if we can not use AOT cache we issue warning and continue
>> execution without it.
>> Unless you are checking for damaged AOT cache which may affect execution
>> without it.
>>
>> @iklam what do you think?
>
> But this runs on
On Sun, 27 Apr 2025 02:00:48 GMT, Vladimir Kozlov wrote:
>> @vnkozlov Are you ok with Ioi's code change proposal?
>
> Yes, I am ok. I assume you will change accordingly all other similar empty
> constructors in your code: `MethodCounters()` and `*TrainingData()`.
Yes, will do.
-
P
On Sun, 27 Apr 2025 01:11:39 GMT, Vladimir Kozlov wrote:
>> I think it's OK to test without these two additional flags. This will make
>> sure that the two diagnostic flags don't have any bad side effect even if
>> AOT class linking is disabled (due to flags like -XX:+UseZGC).
>
> I see them in
I have just compiled in the master branch. As a result, I am struggling with
the following compilation errors.
Configuration summary:
* Name: macosx-aarch64-server-release
* Debug level:release
* HS debug level: product
* JVM variants: server
-n * JVM features:
-n server: 'cds
On Sun, 27 Apr 2025 01:20:45 GMT, Vladimir Kozlov wrote:
>> But this is a verification code. That seems to be the usual strategy, is it
>> not?
>
> I thought if we can not use AOT cache we issue warning and continue execution
> without it.
> Unless you are checking for damaged AOT cache which m
On Sun, 27 Apr 2025 01:49:20 GMT, Igor Veresov wrote:
>> src/hotspot/share/oops/methodData.cpp line 1296:
>>
>>> 1294:
>>> 1295: MethodData::MethodData() {
>>> 1296: assert(CDSConfig::is_dumping_static_archive() || UseSharedSpaces,
>>> "only for CDS");
>>
>> 1. Should its code be guarded by
On Sat, 26 Apr 2025 21:30:25 GMT, Vladimir Kozlov wrote:
>> Improve warm-up time by making profile data from a previous run of an
>> application instantly available, when the HotSpot Java Virtual Machine
>> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483)
>> to store
On Fri, 25 Apr 2025 20:18:41 GMT, Igor Veresov wrote:
> Improve warm-up time by making profile data from a previous run of an
> application instantly available, when the HotSpot Java Virtual Machine
> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483)
> to store method
On Sat, 26 Apr 2025 21:07:04 GMT, Vladimir Kozlov wrote:
>> Improve warm-up time by making profile data from a previous run of an
>> application instantly available, when the HotSpot Java Virtual Machine
>> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483)
>> to store
On Sat, 26 Apr 2025 21:28:12 GMT, Vladimir Kozlov wrote:
>> Improve warm-up time by making profile data from a previous run of an
>> application instantly available, when the HotSpot Java Virtual Machine
>> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483)
>> to store
On Sat, 26 Apr 2025 22:09:24 GMT, Vladimir Kozlov wrote:
>> Improve warm-up time by making profile data from a previous run of an
>> application instantly available, when the HotSpot Java Virtual Machine
>> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483)
>> to store
On Sat, 26 Apr 2025 22:15:27 GMT, Vladimir Kozlov wrote:
>> Improve warm-up time by making profile data from a previous run of an
>> application instantly available, when the HotSpot Java Virtual Machine
>> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483)
>> to store
On Sat, 26 Apr 2025 22:42:02 GMT, Vladimir Kozlov wrote:
>> Improve warm-up time by making profile data from a previous run of an
>> application instantly available, when the HotSpot Java Virtual Machine
>> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483)
>> to store
On Sat, 26 Apr 2025 21:30:25 GMT, Vladimir Kozlov wrote:
>> Improve warm-up time by making profile data from a previous run of an
>> application instantly available, when the HotSpot Java Virtual Machine
>> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483)
>> to store
On Sat, 26 Apr 2025 22:32:00 GMT, Vladimir Kozlov wrote:
>> Improve warm-up time by making profile data from a previous run of an
>> application instantly available, when the HotSpot Java Virtual Machine
>> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483)
>> to store
On Sat, 26 Apr 2025 22:11:58 GMT, Vladimir Kozlov wrote:
>> Improve warm-up time by making profile data from a previous run of an
>> application instantly available, when the HotSpot Java Virtual Machine
>> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483)
>> to store
On Sat, 26 Apr 2025 23:35:01 GMT, Igor Veresov wrote:
>> test/hotspot/jtreg/runtime/cds/appcds/aotProfile/AOTProfileFlags.java line
>> 30:
>>
>>> 28: * @requires vm.cds
>>> 29: * @comment work around JDK-8345635
>>> 30: * @requires !vm.jvmci.enabled
>>
>> Consider adding:
>>
>> * @require
On Sun, 27 Apr 2025 00:52:37 GMT, Ioi Lam wrote:
>> Could you please explain why? @iklam, what do you think?
>
> I think it's OK to test without these two additional flags. This will make
> sure that the two diagnostic flags don't have any bad side effect even if AOT
> class linking is disabled
On Sun, 27 Apr 2025 00:02:41 GMT, Igor Veresov wrote:
>> src/hotspot/share/cds/dumpAllocStats.hpp line 151:
>>
>>> 149: }
>>> 150:
>>> 151: void record_dynamic_proxy_class() {
>>
>> This is not called. This code seems not related.
>
> True. @iklam, this came with a change you wanted me to
On Sun, 27 Apr 2025 00:24:31 GMT, Igor Veresov wrote:
>> src/hotspot/share/ci/ciInstanceKlass.hpp line 47:
>>
>>> 45: friend class ciField;
>>> 46: friend class ciReplay;
>>> 47: friend class CompileTrainingData;
>>
>> Not referenced here
>
> It allows `CompileTrainingData` to peek into t
On Sat, 26 Apr 2025 23:58:04 GMT, Igor Veresov wrote:
>> src/hotspot/share/oops/trainingData.cpp line 76:
>>
>>> 74:
>>> 75: static void verify_archived_entry(TrainingData* td, const
>>> TrainingData::Key* k) {
>>> 76: guarantee(TrainingData::Key::can_compute_cds_hash(k), "");
>>
>> Should
21 matches
Mail list logo
