Re: RFR: 8348282: Add option for syntax highlighting in javadoc snippets [v4]

2025-04-24 Thread Nizar Benalla
On Wed, 9 Apr 2025 04:15:20 GMT, Hannes Wallnöfer wrote: >> Please review a change to add a `javadoc` option to enable syntax >> highlighting for code fragments in snippets and `` tags. The new >> `--syntax-highlight` option uses the [highlight.js] JavaScript library and >> supports Java, Pro

Re: RFR: 8355080: java.base/jdk.internal.foreign.SystemLookup.find() doesn't work on static JDK [v3]

2025-04-24 Thread Jiangli Zhou
On Tue, 22 Apr 2025 21:32:48 GMT, Chen Liang wrote: >> Jiangli Zhou has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Merge branch 'JDK-8355080' of ssh://github.com/jianglizhou/jdk into >> JDK-8355080 >> - Address henryjen@ comment: >>

Re: RFR: 8350209: Preserve adapters in AOT cache [v7]

2025-04-24 Thread Vladimir Kozlov
On Thu, 24 Apr 2025 02:18:27 GMT, Ioi Lam wrote: >> src/hotspot/share/cds/aotCacheAccess.hpp line 38: >> >>> 36: // AOT Cache API for AOT compiler >>> 37: >>> 38: class AOTCacheAccess : AllStatic { >> >> It looks related to `AOTCodeCache`? Maybe `AOTCodeCacheAccess` then? > > This file is call

Re: RFR: 8354686: [AIX] now ubsan is possible [v2]

2025-04-24 Thread Matthias Baesken
On Thu, 17 Apr 2025 15:42:09 GMT, Joachim Kern wrote: >> With the introduction of the open XL 17.1.2.13 Compiler and the runtime >> 17.1.3 as minimum requirement ubsan is supported for AIX now. >> Unfortunately there has to be some adoptions. >> - Currently the test for vptr does not work and pr

Re: RFR: 8355400: Better git detection in update_copyright_year.sh

2025-04-24 Thread duke
On Wed, 23 Apr 2025 13:19:19 GMT, Manuel Hässig wrote: > The script `make/scripts/update_copyright.sh` relies on the path to the > script for git detection, which is fragile or does not work at all or git > worktrees. This PR uses git itself to detect whether the script is running in > a git r

Re: RFR: 8355400: Better git detection in update_copyright_year.sh

2025-04-24 Thread Christian Hagedorn
On Wed, 23 Apr 2025 13:19:19 GMT, Manuel Hässig wrote: > The script `make/scripts/update_copyright.sh` relies on the path to the > script for git detection, which is fragile or does not work at all or git > worktrees. This PR uses git itself to detect whether the script is running in > a git r

Integrated: 8355400: Better git detection in update_copyright_year.sh

2025-04-24 Thread Manuel Hässig
On Wed, 23 Apr 2025 13:19:19 GMT, Manuel Hässig wrote: > The script `make/scripts/update_copyright.sh` relies on the path to the > script for git detection, which is fragile or does not work at all or git > worktrees. This PR uses git itself to detect whether the script is running in > a git r

Re: RFR: 8355080: java.base/jdk.internal.foreign.SystemLookup.find() doesn't work on static JDK [v3]

2025-04-24 Thread Jiangli Zhou
On Thu, 24 Apr 2025 15:14:27 GMT, Henry Jen wrote: >> Jiangli Zhou has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Merge branch 'JDK-8355080' of ssh://github.com/jianglizhou/jdk into >> JDK-8355080 >> - Address henryjen@ comment: >>

Re: RFR: 8355080: java.base/jdk.internal.foreign.SystemLookup.find() doesn't work on static JDK [v3]

2025-04-24 Thread Chen Liang
On Thu, 24 Apr 2025 17:33:19 GMT, Jiangli Zhou wrote: >> src/java.base/share/classes/jdk/internal/foreign/SystemLookup.java line 135: >> >>> 133: @SuppressWarnings("restricted") >>> 134: private static SymbolLookup sysLookup() { >>> 135: NativeLibraries libs = NativeLibraries.new

Re: RFR: 8355080: java.base/jdk.internal.foreign.SystemLookup.find() doesn't work on static JDK [v3]

2025-04-24 Thread Henry Jen
On Wed, 23 Apr 2025 00:56:18 GMT, Jiangli Zhou wrote: >> Please review this PR that changes to use `NativeLibraries.loadLibrary()` >> for loading the `libsyslookup` in `jdk.internal.foreign.SystemLookup` class. >> >> `NativeLibraries.loadLibrary()` handles both the shared library and (static)

RFR: 8355446: Change to Xcode 15.4 for building on macOS at Oracle

2025-04-24 Thread Mikael Vidstedt
Oracle is updating the version of Xcode for building the JDK on macOS to Xcode 15.4. Testing: tier1-5 - Commit messages: - Update doc/building.md to reflect updated macOS/Xcode versions - 8355446: Change to Xcode 15.4 for building on macOS at Oracle Changes: https://git.openjdk.o

RFR: 8355570: [s390x] Update -march to z13 generation

2025-04-24 Thread Amit Kumar
updated march level from z10 to z13. Testing: tier1 (fastdebug-vm) - Commit messages: - z10 -> z15 Changes: https://git.openjdk.org/jdk/pull/24869/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24869&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8355570 Stats: 1

Re: RFR: 8350209: Preserve adapters in AOT cache [v7]

2025-04-24 Thread Vladimir Kozlov
On Thu, 24 Apr 2025 00:49:23 GMT, Vladimir Ivanov wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix message > > src/hotspot/share/cds/aotCacheAccess.hpp line 40: > >> 38: class AOTCacheAccess : AllStatic { >>

Re: RFR: 8350209: Preserve adapters in AOT cache [v7]

2025-04-24 Thread Vladimir Kozlov
On Thu, 24 Apr 2025 01:37:12 GMT, Vladimir Ivanov wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix message > > src/hotspot/share/code/aotCodeCache.cpp line 645: > >> 643: return false; >> 644: } >> 645

Re: RFR: 8350209: Preserve adapters in AOT cache [v7]

2025-04-24 Thread Vladimir Kozlov
On Thu, 24 Apr 2025 01:51:40 GMT, Vladimir Ivanov wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix message > > src/hotspot/share/code/aotCodeCache.cpp line 62: > >> 60: } >> 61: >> 62: static void exit_vm_o

Re: RFR: 8350209: Preserve adapters in AOT cache [v7]

2025-04-24 Thread Vladimir Kozlov
On Fri, 25 Apr 2025 00:44:46 GMT, Vladimir Kozlov wrote: >> src/hotspot/share/code/aotCodeCache.cpp line 62: >> >>> 60: } >>> 61: >>> 62: static void exit_vm_on_store_failure() { >> >> It's a bit confusing to see `exit_vm_on_load_failure()` and >> `exit_vm_on_store_failure()` to silently proc

Re: RFR: 8350209: Preserve adapters in AOT cache [v7]

2025-04-24 Thread Vladimir Kozlov
On Fri, 25 Apr 2025 00:48:43 GMT, Vladimir Kozlov wrote: >> We check failure state of AOT code cache when query about using adapters >> caching: >> >> bool for_use() const { return _for_use && !_failed; } >> bool for_dump() const { return _for_dump && !_failed; } >> static bool is_on()

Re: RFR: 8355235: Clean out old versions from Tools.gmk

2025-04-24 Thread Mikael Vidstedt
On Mon, 21 Apr 2025 22:51:33 GMT, Mikael Vidstedt wrote: > Traditionally, when upgrading the versions of the components (gcc, binutils, > etc.) in Tools.gmk, the old versions/definitions have been preserved. The > list is now starting to be on the long side, it's unlikely that anybody would >

Integrated: 8355235: Clean out old versions from Tools.gmk

2025-04-24 Thread Mikael Vidstedt
On Mon, 21 Apr 2025 22:51:33 GMT, Mikael Vidstedt wrote: > Traditionally, when upgrading the versions of the components (gcc, binutils, > etc.) in Tools.gmk, the old versions/definitions have been preserved. The > list is now starting to be on the long side, it's unlikely that anybody would >

Re: RFR: 8350209: Preserve adapters in AOT cache [v7]

2025-04-24 Thread Ashutosh Mehra
On Thu, 24 Apr 2025 01:39:33 GMT, Vladimir Ivanov wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix message > > src/hotspot/share/runtime/sharedRuntime.cpp line 2966: > >> 2964: adapter_blob = >> Adapter