RFR: 8355400: Better git detection in update_copyright_year.sh

2025-04-23 Thread Manuel Hässig
The script `make/scripts/update_copyright.sh` relies on the path to the script for git detection, which is fragile or does not work at all or git worktrees. This PR uses git itself to detect whether the script is running in a git repository. This has the added benefit that the script can be exec

Re: RFR: 8350209: Preserve adapters in AOT cache [v7]

2025-04-23 Thread Vladimir Kozlov
On Wed, 23 Apr 2025 14:24:20 GMT, Erik Joelsson wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix message > > Build change looks trivially good. Thank you, @erikj79 - PR Comment: https://git.ope

Re: RFR: 8348282: Add option for syntax highlighting in javadoc snippets [v4]

2025-04-23 Thread Nizar Benalla
On Wed, 9 Apr 2025 04:15:20 GMT, Hannes Wallnöfer wrote: >> Please review a change to add a `javadoc` option to enable syntax >> highlighting for code fragments in snippets and `` tags. The new >> `--syntax-highlight` option uses the [highlight.js] JavaScript library and >> supports Java, Pro

Re: RFR: 8348282: Add option for syntax highlighting in javadoc snippets [v4]

2025-04-23 Thread Chen Liang
On Wed, 9 Apr 2025 04:15:20 GMT, Hannes Wallnöfer wrote: >> Please review a change to add a `javadoc` option to enable syntax >> highlighting for code fragments in snippets and `` tags. The new >> `--syntax-highlight` option uses the [highlight.js] JavaScript library and >> supports Java, Pro

Re: RFR: 8355235: Clean out old versions from Tools.gmk

2025-04-23 Thread Erik Joelsson
On Mon, 21 Apr 2025 22:51:33 GMT, Mikael Vidstedt wrote: > Traditionally, when upgrading the versions of the components (gcc, binutils, > etc.) in Tools.gmk, the old versions/definitions have been preserved. The > list is now starting to be on the long side, it's unlikely that anybody would >

Re: RFR: 8350209: Preserve adapters in AOT cache [v7]

2025-04-23 Thread Erik Joelsson
On Tue, 22 Apr 2025 23:05:13 GMT, Vladimir Kozlov wrote: >> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class >> information in AOT cache which helps Java startup performance. >> >> We should also preserve adapters (i2c, c2i) to further improve performance >> of class link

Re: RFR: 8355400: Better git detection in update_copyright_year.sh

2025-04-23 Thread Erik Joelsson
On Wed, 23 Apr 2025 13:19:19 GMT, Manuel Hässig wrote: > The script `make/scripts/update_copyright.sh` relies on the path to the > script for git detection, which is fragile or does not work at all or git > worktrees. This PR uses git itself to detect whether the script is running in > a git r

Integrated: 8353214: Add testing with --enable-preview

2025-04-23 Thread Leonid Mesnik
On Thu, 17 Apr 2025 00:24:50 GMT, Leonid Mesnik wrote: > Added problemlists and and requires for execution tests with --enable-preview. > > The --enable-preview features might significantly change VM/JDK behavior and > sometimes it is useful to run tests with preview features enabled. Eventuall

Re: RFR: 8355249: Remove the use of WMIC from the entire source code [v2]

2025-04-23 Thread Erik Joelsson
On Tue, 22 Apr 2025 07:41:43 GMT, Daishi Tabata wrote: >> After searching the entire JDK source code, I found that WMIC is only used >> in four files. These WMIC calls can be replaced with PowerShell for WMI. >> >> The primary challenge in this replacement is to make it work the same as >> bef

Re: RFR: 8350209: Preserve adapters in AOT cache [v7]

2025-04-23 Thread Ioi Lam
On Thu, 24 Apr 2025 00:51:31 GMT, Vladimir Ivanov wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix message > > src/hotspot/share/cds/aotCacheAccess.hpp line 38: > >> 36: // AOT Cache API for AOT compiler >>

Re: RFR: 8350209: Preserve adapters in AOT cache [v7]

2025-04-23 Thread Vladimir Ivanov
On Tue, 22 Apr 2025 23:05:13 GMT, Vladimir Kozlov wrote: >> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class >> information in AOT cache which helps Java startup performance. >> >> We should also preserve adapters (i2c, c2i) to further improve performance >> of class link