RFR: 8354902: Change to Visual Studio 17.13.2 for building on Windows at Oracle

2025-04-17 Thread Mikael Vidstedt
Oracle is updating the version of Visual Studio for building the JDK on Windows to Visual Studio 2022 17.13.2. Testing: tier1-5 - Commit messages: - 8354902: Change to Visual Studio 17.13.2 for building on Windows at Oracle Changes: https://git.openjdk.org/jdk/pull/24707/files W

Integrated: 8353009: Improve documentation for Windows AArch64 builds

2025-04-17 Thread Saint Wesonga
On Wed, 26 Mar 2025 22:38:40 GMT, Saint Wesonga wrote: > The target selection configuration flag for Windows AArch64 should be added > to the build documentation for improved discoverability and completeness. This pull request has now been integrated. Changeset: 86f3eafa Author:Saint Weson

Re: RFR: 8354919: Move HotSpot .editorconfig into the global .editorconfig

2025-04-17 Thread Erik Joelsson
On Thu, 17 Apr 2025 07:28:03 GMT, Julian Waters wrote: > The src/hotspot directory should ideally only be used for HotSpot source > files, and we should avoid polluting it with an .editorconfig. A cleaner > solution exists since we can just specify the desired code formatting for > HotSpot as

Re: RFR: 8353214: Add testing with --enable-preview

2025-04-17 Thread Roger Riggs
On Thu, 17 Apr 2025 05:06:24 GMT, Chen Liang wrote: > Just curious, which tiers have you run with forced `--enable-preview` and > discovered such incompatible tests? I've run tiers 1-3 and have not found any incompatible tests (by that means). - PR Comment: https://git.openjdk.org

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-17 Thread Matthias Baesken
On Mon, 14 Apr 2025 12:53:35 GMT, Magnus Ihse Bursie wrote: >> Most of the JDK code base has been transitioned to UTF-8, but not all. This >> has recently become an acute problem, since our mixing of iso-8859-1 and >> utf-8 in properties files confused the version of `sed` that is shipped with

Re: RFR: 8353214: Add testing with --enable-preview

2025-04-17 Thread Leonid Mesnik
On Thu, 17 Apr 2025 00:24:50 GMT, Leonid Mesnik wrote: > Added problemlists and and requires for execution tests with --enable-preview. > > The --enable-preview features might significantly change VM/JDK behavior and > sometimes it is useful to run tests with preview features enabled. Eventuall

Re: RFR: 8350209: Preserve adapters in AOT cache

2025-04-17 Thread Ashutosh Mehra
On Thu, 17 Apr 2025 19:11:47 GMT, Vladimir Kozlov wrote: > [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class > information in AOT cache which helps Java startup performance. > > We should also preserve adapters (i2c, c2i) to further improve performance of > class linking w

Re: RFR: 8354996: Reduce dynamic code generation for a single downcall

2025-04-17 Thread Chen Liang
On Thu, 17 Apr 2025 19:44:07 GMT, Chen Liang wrote: > Perf numbers for simple main: > Linking of `Class::forName0` down from ~152 to ~83 > > For calling little color management system > https://bugs.openjdk.org/browse/JDK-8313344: > JNI: ~45 > baseline panama: ~164 > patch: ~103 > > Also see #

RFR: 8354996: Reduce dynamic code generation for a single downcall

2025-04-17 Thread Chen Liang
Perf numbers for simple main: Linking of `Class::forName0` down from ~152 to ~83 For calling little color management system https://bugs.openjdk.org/browse/JDK-8313344: JNI: ~45 baseline panama: ~164 patch: ~103 Also see #24705. - Commit messages: - Merge branch 'master' of https:

Re: RFR: 8354686: [AIX] now ubsan is possible [v2]

2025-04-17 Thread Joachim Kern
> With the introduction of the open XL 17.1.2.13 Compiler and the runtime > 17.1.3 as minimum requirement ubsan is supported for AIX now. > Unfortunately there has to be some adoptions. > - Currently the test for vptr does not work and produces crashes when active, > so we have to deactivate it.

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-17 Thread Naoto Sato
On Thu, 17 Apr 2025 14:01:07 GMT, Magnus Ihse Bursie wrote: > Is there some specific problem you are worried about on Windows that you were > thinking about? I would have tested on non-English (preferrably Chinese/Japanese) Windows where users set it to English. I believe we had issues from co

RFR: 8350209: Preserve adapters in AOT cache

2025-04-17 Thread Vladimir Kozlov
[JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class information in AOT cache which helps Java startup performance. We should also preserve adapters (i2c, c2i) to further improve performance of class linking where adapters are generated. Short running Java application can see

Re: RFR: 8354919: Move HotSpot .editorconfig into the global .editorconfig

2025-04-17 Thread Julian Waters
On Thu, 17 Apr 2025 07:28:03 GMT, Julian Waters wrote: > The src/hotspot directory should ideally only be used for HotSpot source > files, and we should avoid polluting it with an .editorconfig. A cleaner > solution exists since we can just specify the desired code formatting for > HotSpot as

Re: RFR: 8354686: [AIX] now ubsan is possible

2025-04-17 Thread Joachim Kern
On Thu, 17 Apr 2025 09:05:14 GMT, Matthias Baesken wrote: >> Can you please give me an example to try? > > If the tool is (in case it is available) always at THIS position then it is > not needed to add more logic. On the other hand, what happens if it is not > there ? Would we get just less c

Re: RFR: 8354686: [AIX] now ubsan is possible

2025-04-17 Thread Matthias Baesken
On Thu, 17 Apr 2025 10:51:25 GMT, Joachim Kern wrote: >> okay thanks. >> So back to my first question - is the tool always at this position ? > > For the 17.1.2 Compiler it is always at the same position relative to the > compiler executable itself. Of course you can install the 17.1.2 Compiler

Re: RFR: 8354686: [AIX] now ubsan is possible

2025-04-17 Thread Matthias Baesken
On Thu, 17 Apr 2025 09:20:23 GMT, Joachim Kern wrote: >> If the tool is (in case it is available) always at THIS position then it is >> not needed to add more logic. On the other hand, what happens if it is not >> there ? Would we get just less complete stacks in case of ubsan issues? > > We w

Re: RFR: 8354686: [AIX] now ubsan is possible

2025-04-17 Thread Joachim Kern
On Thu, 17 Apr 2025 10:29:14 GMT, Matthias Baesken wrote: >> We would just get a stack without symbol resolution (not very helpful) and >> the ubsan message that the symbolizer could not be found. > > okay thanks. > So back to my first question - is the tool always at this position ? For the 17

Re: RFR: 8353214: Add testing with --enable-preview

2025-04-17 Thread Erik Joelsson
On Thu, 17 Apr 2025 00:24:50 GMT, Leonid Mesnik wrote: > Added problemlists and and requires for execution tests with --enable-preview. > > The --enable-preview features might significantly change VM/JDK behavior and > sometimes it is useful to run tests with preview features enabled. Eventuall

Re: RFR: 8354686: [AIX] now ubsan is possible

2025-04-17 Thread Matthias Baesken
On Tue, 15 Apr 2025 18:40:57 GMT, Joachim Kern wrote: > With the introduction of the open XL 17.1.2.13 Compiler and the runtime > 17.1.3 as minimum requirement ubsan is supported for AIX now. > Unfortunately there has to be some adoptions. > - Currently the test for vptr does not work and produc

Re: RFR: 8354686: [AIX] now ubsan is possible

2025-04-17 Thread Matthias Baesken
On Wed, 16 Apr 2025 10:40:49 GMT, Joachim Kern wrote: >> make/autoconf/jdk-options.m4 line 526: >> >>> 524: UBSAN_LDFLAGS="$UBSAN_CHECKS" >>> 525: if test "x$TOOLCHAIN_TYPE" = "xclang" && test "x$OPENJDK_TARGET_OS" >>> = "xaix"; then >>> 526: UBSAN_CFLAGS="$UBSAN_CFLAGS -fno-sanitize=

Re: RFR: 8352044: Add --with-import-jvms to configure

2025-04-17 Thread Magnus Ihse Bursie
On Fri, 14 Mar 2025 15:49:44 GMT, Magnus Ihse Bursie wrote: > We should allow pre-built JVMs to be included in a build, so they are just > copied into place, and the jvm.cfg file properly updated. `KEEPALIVE` - PR Comment: https://git.openjdk.org/jdk/pull/24063#issuecomment-281301

Re: RFR: 8353009: Improve documentation for Windows AArch64 builds [v6]

2025-04-17 Thread Magnus Ihse Bursie
On Wed, 16 Apr 2025 14:50:57 GMT, Saint Wesonga wrote: >> The target selection configuration flag for Windows AArch64 should be added >> to the build documentation for improved discoverability and completeness. > > Saint Wesonga has updated the pull request incrementally with two additional > c

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-17 Thread Magnus Ihse Bursie
On Wed, 16 Apr 2025 16:14:39 GMT, Naoto Sato wrote: > We will probably need to make sure things are ok on Windows as well (they are > the other confusing environment) Windows is much more painful to work with, since there is no correspondence of `LC_ALL`; you must set the user's locale. There