Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console() [v4]

2025-04-16 Thread Jan Lahoda
> The `java.io.Console` has several backends: a simple on in `java.base`, a > more convenient one in `jdk.internal.le` (with line-reading based on JLine) > and one for JShell. > > The backend based on JLine is proving to be a somewhat problematic - JLine is > very powerful, possibly too powerfu

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-16 Thread Martin Doerr
On Mon, 14 Apr 2025 12:53:35 GMT, Magnus Ihse Bursie wrote: >> Most of the JDK code base has been transitioned to UTF-8, but not all. This >> has recently become an acute problem, since our mixing of iso-8859-1 and >> utf-8 in properties files confused the version of `sed` that is shipped with

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-16 Thread Magnus Ihse Bursie
On Wed, 16 Apr 2025 07:54:13 GMT, Martin Doerr wrote: > We get the following problem on AIX: > > ``` > checking for locale to use... no UTF-8 locale found > configure: error: No UTF-8 locale found. This is required for building > successfully. > configure exiting with result code 1 > ``` This

RFR: 8353214: Add testing with --enable-preview

2025-04-16 Thread Leonid Mesnik
Added problemlists and and requires for execution tests with --enable-preview. The --enable-preview features might significantly change VM/JDK behavior and sometimes it is useful to run tests with preview features enabled. Eventually preview features should be made default and it is expected tha

Re: RFR: 8353009: Improve documentation for Windows AArch64 builds [v6]

2025-04-16 Thread Saint Wesonga
> The target selection configuration flag for Windows AArch64 should be added > to the build documentation for improved discoverability and completeness. Saint Wesonga has updated the pull request incrementally with two additional commits since the last revision: - Remove trailing whitespace

Re: RFR: 8353009: Improve documentation for Windows AArch64 builds [v6]

2025-04-16 Thread Erik Joelsson
On Wed, 16 Apr 2025 14:50:57 GMT, Saint Wesonga wrote: >> The target selection configuration flag for Windows AArch64 should be added >> to the build documentation for improved discoverability and completeness. > > Saint Wesonga has updated the pull request incrementally with two additional > c

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-16 Thread Magnus Ihse Bursie
On Wed, 16 Apr 2025 10:35:02 GMT, Matthias Baesken wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Also document UTF-8 requirements (solves JDK-8338973) >> - Let configure only accept utf-8 locales >> -

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-16 Thread Naoto Sato
On Mon, 14 Apr 2025 12:53:35 GMT, Magnus Ihse Bursie wrote: >> Most of the JDK code base has been transitioned to UTF-8, but not all. This >> has recently become an acute problem, since our mixing of iso-8859-1 and >> utf-8 in properties files confused the version of `sed` that is shipped with

Integrated: 8351603: Change to GCC 14.2.0 for building on Linux at Oracle

2025-04-16 Thread Mikael Vidstedt
On Mon, 10 Mar 2025 22:42:47 GMT, Mikael Vidstedt wrote: > Background: > > Oracle is updating the version of GCC for building the JDK on Linux to 14.2.0. > > This change updates the versions of the components used for the (Linux) > devkit. Newer versions of ccache use cmake for the build, so s

Re: RFR: 8351603: Change to GCC 14.2.0 for building on Linux at Oracle [v3]

2025-04-16 Thread Mikael Vidstedt
On Tue, 15 Apr 2025 16:04:28 GMT, Mikael Vidstedt wrote: >> Background: >> >> Oracle is updating the version of GCC for building the JDK on Linux to >> 14.2.0. >> >> This change updates the versions of the components used for the (Linux) >> devkit. Newer versions of ccache use cmake for the b

Re: RFR: 8353009: Document target selection flag for Windows AArch64 builds [v5]

2025-04-16 Thread Saint Wesonga
> The target selection configuration flag for Windows AArch64 should be added > to the build documentation for improved discoverability and completeness. Saint Wesonga has updated the pull request incrementally with one additional commit since the last revision: Simplify documentation Co

Re: RFR: 8353214: Add testing with --enable-preview

2025-04-16 Thread Chen Liang
On Thu, 17 Apr 2025 00:24:50 GMT, Leonid Mesnik wrote: > Added problemlists and and requires for execution tests with --enable-preview. > > The --enable-preview features might significantly change VM/JDK behavior and > sometimes it is useful to run tests with preview features enabled. Eventuall

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-16 Thread Matthias Baesken
On Mon, 14 Apr 2025 12:53:35 GMT, Magnus Ihse Bursie wrote: >> Most of the JDK code base has been transitioned to UTF-8, but not all. This >> has recently become an acute problem, since our mixing of iso-8859-1 and >> utf-8 in properties files confused the version of `sed` that is shipped with

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-16 Thread Magnus Ihse Bursie
On Tue, 15 Apr 2025 23:20:45 GMT, Sergey Bylokhov wrote: > can we also force this rule by the jcheck? Well, yes and no. First, we can verify that we do not have invalid UTF-8. That might be a signal that the encoding is wrong. But then this check needs to be able to distinguish between pure bi

Re: RFR: 8354686: [AIX] now ubsan is possible

2025-04-16 Thread Joachim Kern
On Tue, 15 Apr 2025 19:42:40 GMT, Erik Joelsson wrote: >> With the introduction of the open XL 17.1.2.13 Compiler and the runtime >> 17.1.3 as minimum requirement ubsan is supported for AIX now. >> Unfortunately there has to be some adoptions. >> - Currently the test for vptr does not work and p

Re: RFR: 8353009: Document target selection flag for Windows AArch64 builds [v4]

2025-04-16 Thread Magnus Ihse Bursie
On Tue, 15 Apr 2025 19:35:24 GMT, Saint Wesonga wrote: >> The target selection configuration flag for Windows AArch64 should be added >> to the build documentation for improved discoverability and completeness. > > Saint Wesonga has updated the pull request incrementally with two additional > c

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-16 Thread Magnus Ihse Bursie
On Mon, 14 Apr 2025 12:53:35 GMT, Magnus Ihse Bursie wrote: >> Most of the JDK code base has been transitioned to UTF-8, but not all. This >> has recently become an acute problem, since our mixing of iso-8859-1 and >> utf-8 in properties files confused the version of `sed` that is shipped with

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-16 Thread Martin Doerr
On Wed, 16 Apr 2025 09:51:49 GMT, Magnus Ihse Bursie wrote: > `locale -a` C POSIX en_US.8859-15 en_US.IBM-858 en_US.ISO8859-1 en_US I don't know if UTF-8 can be installed. If so, we should also document that as requirement for AIX build machines. - PR Comment: https://git.openj

Re: RFR: 8353009: Improve documentation for Windows AArch64 builds [v6]

2025-04-16 Thread duke
On Wed, 16 Apr 2025 14:50:57 GMT, Saint Wesonga wrote: >> The target selection configuration flag for Windows AArch64 should be added >> to the build documentation for improved discoverability and completeness. > > Saint Wesonga has updated the pull request incrementally with two additional > c

Re: RFR: 8351842: Windows specific issues in combination of JEP 493 and --with-external-symbols-in-bundles=public [v4]

2025-04-16 Thread Christoph Langer
> Alternative approach to #24012 > > This keeps the current handling of *.pdb vs *.stripped.pdb which allows > debugging at the cost of a little hack in jlink. Maybe the code in jlink can > be improved, e.g. make it more conditional. > > I'm running this through our testing still to see whether