Integrated: 8354254: Remove the linux ppc64 -minsert-sched-nops=regroup_exact compile flag

2025-04-14 Thread Matthias Baesken
On Thu, 10 Apr 2025 08:19:19 GMT, Matthias Baesken wrote: > On linux ppc64 / gcc , we build with the compile flag > -minsert-sched-nops=regroup_exact ; this is most likely outdated, maybe it > was still useful for old Power6 machines. > > See > https://gcc.gnu.org/onlinedocs/gcc-11.1.0/gcc/RS

Re: RFR: 8354254: Remove the linux ppc64 -minsert-sched-nops=regroup_exact compile flag

2025-04-14 Thread Martin Doerr
On Thu, 10 Apr 2025 08:19:19 GMT, Matthias Baesken wrote: > On linux ppc64 / gcc , we build with the compile flag > -minsert-sched-nops=regroup_exact ; this is most likely outdated, maybe it > was still useful for old Power6 machines. > > See > https://gcc.gnu.org/onlinedocs/gcc-11.1.0/gcc/RS

Re: RFR: 8354510: Skipped gtest cause test failure

2025-04-14 Thread Robbin Ehn
On Mon, 14 Apr 2025 13:25:20 GMT, Axel Boldt-Christmas wrote: > `GTEST_SKIPPED` tests count is accounted in gtests run. But when we calculate > the number of GTEST errors we take `ERROR = RUN - PASSED - FAILED`. We need > parse and account for the skipped as well. Currently we only account for

Re: RFR: 8354510: Skipped gtest cause test failure

2025-04-14 Thread Erik Joelsson
On Mon, 14 Apr 2025 13:25:20 GMT, Axel Boldt-Christmas wrote: > `GTEST_SKIPPED` tests count is accounted in gtests run. But when we calculate > the number of GTEST errors we take `ERROR = RUN - PASSED - FAILED`. We need > parse and account for the skipped as well. Currently we only account for

Re: RFR: 8354254: Remove the linux ppc64 -minsert-sched-nops=regroup_exact compile flag

2025-04-14 Thread Matthias Baesken
On Thu, 10 Apr 2025 08:19:19 GMT, Matthias Baesken wrote: > On linux ppc64 / gcc , we build with the compile flag > -minsert-sched-nops=regroup_exact ; this is most likely outdated, maybe it > was still useful for old Power6 machines. > > See > https://gcc.gnu.org/onlinedocs/gcc-11.1.0/gcc/RS

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-14 Thread Kim Barrett
On Mon, 14 Apr 2025 12:53:35 GMT, Magnus Ihse Bursie wrote: >> Most of the JDK code base has been transitioned to UTF-8, but not all. This >> has recently become an acute problem, since our mixing of iso-8859-1 and >> utf-8 in properties files confused the version of `sed` that is shipped with

Re: RFR: 8301971: Make JDK source code UTF-8 [v2]

2025-04-14 Thread Magnus Ihse Bursie
On Sun, 13 Apr 2025 23:14:41 GMT, Magnus Ihse Bursie wrote: >> Most of the JDK code base has been transitioned to UTF-8, but not all. This >> has recently become an acute problem, since our mixing of iso-8859-1 and >> utf-8 in properties files confused the version of `sed` that is shipped with

Re: RFR: 8301971: Make JDK source code UTF-8 [v2]

2025-04-14 Thread Kim Barrett
On Sun, 13 Apr 2025 23:14:41 GMT, Magnus Ihse Bursie wrote: >> Most of the JDK code base has been transitioned to UTF-8, but not all. This >> has recently become an acute problem, since our mixing of iso-8859-1 and >> utf-8 in properties files confused the version of `sed` that is shipped with

RFR: 8354510: Skipped gtest cause test failure

2025-04-14 Thread Axel Boldt-Christmas
`GTEST_SKIPPED` tests count is accounted in gtests run. But when we calculate the number of GTEST errors we take `ERROR = RUN - PASSED - FAILED`. We need parse and account for the skipped as well. Currently we only account for `DISABLED` gtests (which are not counted as run tests). This patch

Re: RFR: 8354510: Skipped gtest cause test failure

2025-04-14 Thread Axel Boldt-Christmas
On Mon, 14 Apr 2025 13:25:20 GMT, Axel Boldt-Christmas wrote: > `GTEST_SKIPPED` tests count is accounted in gtests run. But when we calculate > the number of GTEST errors we take `ERROR = RUN - PASSED - FAILED`. We need > parse and account for the skipped as well. Currently we only account for

RFR: 8354565: jtreg failure handler GatherProcessInfoTimeoutHandler has a leftover call to System.loadLibrary

2025-04-14 Thread Jaikiran Pai
Can I please get a review of this cleanup in the jtreg timeout handler `GatherProcessInfoTimeoutHandler`? As noted in https://bugs.openjdk.org/browse/JDK-8354565, this is a leftover after the change done in https://bugs.openjdk.java.net/browse/JDK-8268626. The `timeoutHandler` native test libra

Re: RFR: 8354565: jtreg failure handler GatherProcessInfoTimeoutHandler has a leftover call to System.loadLibrary

2025-04-14 Thread Kim Barrett
On Tue, 15 Apr 2025 05:50:03 GMT, Jaikiran Pai wrote: > Can I please get a review of this cleanup in the jtreg timeout handler > `GatherProcessInfoTimeoutHandler`? > > As noted in https://bugs.openjdk.org/browse/JDK-8354565, this is a leftover > after the change done in https://bugs.openjdk.ja

Re: RFR: 8354565: jtreg failure handler GatherProcessInfoTimeoutHandler has a leftover call to System.loadLibrary

2025-04-14 Thread Alan Bateman
On Tue, 15 Apr 2025 05:50:03 GMT, Jaikiran Pai wrote: > Can I please get a review of this cleanup in the jtreg timeout handler > `GatherProcessInfoTimeoutHandler`? > > As noted in https://bugs.openjdk.org/browse/JDK-8354565, this is a leftover > after the change done in https://bugs.openjdk.ja