On Wed, 9 Apr 2025 20:26:13 GMT, Chris Plummer wrote:
> > Making hotspot `-Os` would certainly never make any sense, for example.)
>
> When the minimalVM was first created, there was a quite of bit of
> benchmarking done to decide which hotspot files to build with -Os and which
> to build with
On Wed, 9 Apr 2025 18:35:12 GMT, Mikael Vidstedt wrote:
> [JDK-8342984](https://bugs.openjdk.org/browse/JDK-8342984) bumped the minimum
> boot jdk to JDK 24, and update the boot JDKs used in GHA in the process.
> Unfortunately the boot jdk for alpine-linux-x64 was incorrectly changed to
> use
On Thu, 10 Apr 2025 07:31:37 GMT, Magnus Ihse Bursie wrote:
>> Right, that `å` looks to have been incorrectly converted during the
>> ISO-8859-1 to UTF-8 conversion. (I can't find the script used for conversion
>> as this change is from some time ago.)
>>
>> Since the change occurs in a commen
On Wed, 9 Apr 2025 21:26:15 GMT, Justin Lu wrote:
>> src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/Encodings.properties
>> line 22:
>>
>>> 20: # Peter Smolik
>>> 21: Cp1250 WINDOWS-1250 0x00FF
>>> 22: # Patch attributed to hava...@underdusken.no (H�vard Wigtil)
>>
>> Th
On Wed, 9 Apr 2025 04:15:20 GMT, Hannes Wallnöfer wrote:
>> Please review a change to add a `javadoc` option to enable syntax
>> highlighting for code fragments in snippets and `` tags. The new
>> `--syntax-highlight` option uses the [highlight.js] JavaScript library and
>> supports Java, Pro
On Wed, 9 Apr 2025 18:35:12 GMT, Mikael Vidstedt wrote:
> [JDK-8342984](https://bugs.openjdk.org/browse/JDK-8342984) bumped the minimum
> boot jdk to JDK 24, and update the boot JDKs used in GHA in the process.
> Unfortunately the boot jdk for alpine-linux-x64 was incorrectly changed to
> use
On Fri, 31 Jan 2025 16:19:17 GMT, Hannes Wallnöfer wrote:
> Please review a patch to add a JavaDoc Taglet to the JDK build system that
> allows to add preview-related notes to non-preview API elements, as well as a
> hidden javadoc option to add elements with preview notes to the preview
> sum
On Thu, 10 Apr 2025 08:08:02 GMT, Eirik Bjørsnøs wrote:
>> If anything, I might be a bit worried that there are more incorrect
>> conversions stemming from this PR, that my automated tools and manual
>> scanning has not revealed.
>
> Some observations:
>
> 1: This PR seems to have been abondo
On Thu, 10 Apr 2025 08:19:19 GMT, Matthias Baesken wrote:
> On linux ppc64 / gcc , we build with the compile flag
> -minsert-sched-nops=regroup_exact ; this is most likely outdated, maybe it
> was still useful for old Power6 machines.
>
> See
> https://gcc.gnu.org/onlinedocs/gcc-11.1.0/gcc/RS
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote:
> I have checked the entire code base for incorrect encodings, but luckily
> enough these were the only remaining problems I found.
>
> BOM (byte-order mark) is a method used for distinguishing big and little
> endian UTF-16 encoding
On Thu, 10 Apr 2025 10:14:40 GMT, Magnus Ihse Bursie wrote:
>> I have checked the entire code base for incorrect encodings, but luckily
>> enough these were the only remaining problems I found.
>>
>> BOM (byte-order mark) is a method used for distinguishing big and little
>> endian UTF-16 enc
On Wed, 9 Apr 2025 17:55:26 GMT, Roger Riggs wrote:
> It would, IMHO, look better if it was a BOLD prefix of the first sentence.
I partly agree, but I also think the stamp-like nature serves a purpose. Note
that deprecated members and restricted methods use the same format, sometimes
adding a
On Tue, 8 Apr 2025 13:31:10 GMT, Severin Gehwolf wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/LinkableRuntimeImage.java
>> line 71:
>>
>>> 69: private static InputStream getDiffInputStream(String module) throws
>>> IOException {
>>> 70: String resourceName = Strin
On Thu, 10 Apr 2025 09:03:36 GMT, Alan Bateman wrote:
>> It's very odd, but when I attempt this then the resource is not found. It
>> seems to fail on the module name verification. For example: `jlink --help |
>> tail -n2` shows as `disabled` for an enabled linkable runtime image.
>
> Without r
On Sat, 5 Apr 2025 04:49:03 GMT, Christoph Langer wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> c
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote:
>> JDK .properties files still use ISO-8859-1 encoding with escape sequences.
>> It would improve readability to see the native characters instead of escape
>> sequences (especially for the L10n process). The majority of files changed
>> are l
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote:
>> JDK .properties files still use ISO-8859-1 encoding with escape sequences.
>> It would improve readability to see the native characters instead of escape
>> sequences (especially for the L10n process). The majority of files changed
>> are l
On Wed, 9 Apr 2025 16:10:20 GMT, Severin Gehwolf wrote:
>> For JEP 493-enabled builds there are no JMODs. Certain files come from the
>> installed JDK image when a user creates a custom run-time from it. This is
>> problematic for example for files that often come from a different package
>> (
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote:
> I have checked the entire code base for incorrect encodings, but luckily
> enough these were the only remaining problems I found.
>
> BOM (byte-order mark) is a method used for distinguishing big and little
> endian UTF-16 encoding
I have checked the entire code base for incorrect encodings, but luckily enough
these were the only remaining problems I found.
BOM (byte-order mark) is a method used for distinguishing big and little endian
UTF-16 encodings. There is a special UTF-8 BOM, but it is discouraged. In the
words of
Avoid filtering out xml files at the root of the JMH folder, in order to get
the `default.instruments.template.xml` file bundled in the JMH core jar to
support xtrace profiler.
-
Commit messages:
- 8354257: xctracenorm profiler not working with JDK JMH benchmarks
Changes: https://
On Thu, 10 Apr 2025 07:32:18 GMT, Magnus Ihse Bursie wrote:
>> You don't have to do that, I'm working on an omnibus UTF-8 fixing PR right
>> now, where I will include a fix for this as well.
>
> If anything, I might be a bit worried that there are more incorrect
> conversions stemming from this
On Fri, 4 Apr 2025 07:55:20 GMT, Alan Bateman wrote:
>>> Part of me is concerned that the hidden option is a bit of an attractive
>>> nuisance. What would you think about just having a fixed list in a
>>> properties file in the repo, thus a resource in the jlink module. This
>>> would avoid th
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote:
>> JDK .properties files still use ISO-8859-1 encoding with escape sequences.
>> It would improve readability to see the native characters instead of escape
>> sequences (especially for the L10n process). The majority of files changed
>> are l
On Mon, 3 Feb 2025 10:41:17 GMT, Hannes Wallnöfer wrote:
>> make/jdk/src/classes/build/tools/taglet/PreviewNote.java line 94:
>>
>>> 92: if (tag.getKind() == UNKNOWN_INLINE_TAG) {
>>> 93: UnknownInlineTagTree inlineTag = (UnknownInlineTagTree)
>>> tag;
>>> 94:
On Tue, 8 Apr 2025 14:36:14 GMT, Magnus Ihse Bursie wrote:
> When building the JDK on GHA, we should use `make -k` to continue building as
> much as possible in case of failure, to avoid having developers resubmitting
> one fix after another.
>
> The additional cost of continuing to build even
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote:
> I have checked the entire code base for incorrect encodings, but luckily
> enough these were the only remaining problems I found.
>
> BOM (byte-order mark) is a method used for distinguishing big and little
> endian UTF-16 encoding
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote:
> I have checked the entire code base for incorrect encodings, but luckily
> enough these were the only remaining problems I found.
>
> BOM (byte-order mark) is a method used for distinguishing big and little
> endian UTF-16 encoding
On Mon, 7 Apr 2025 11:11:08 GMT, Magnus Ihse Bursie wrote:
> Analogous with how native warnings can be treated as errors or not using the
> `--disable-warnings-as-errors` configure flag, this patch introduces a
> `--disable-javac-warnings-as-errors` flag.
>
> The reason that this is not made p
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote:
> I have checked the entire code base for incorrect encodings, but luckily
> enough these were the only remaining problems I found.
>
> BOM (byte-order mark) is a method used for distinguishing big and little
> endian UTF-16 encoding
On Fri, 4 Apr 2025 14:28:00 GMT, Magnus Ihse Bursie wrote:
> It might still make sense to document that to cross-compile to aarch64, the
> flag `--openjdk-target=aarch64-unknown-cygwin` should be used -- that is in
> no way obvious or trivial to figure out.
ok, I'll leave the cross-compilation
On Wed, 19 Feb 2025 12:27:58 GMT, David Linus Briemann wrote:
> Add an .editorconfig to define indentation, trim trailing whitespace and open
> curly brace position for C++ and Java.
> This allows various editors to easily infer basics of the coding style.
This pull request has been closed with
On Thu, 10 Apr 2025 12:02:45 GMT, Galder Zamarreño wrote:
> Avoid filtering out xml files at the root of the JMH folder, in order to get
> the `default.instruments.template.xml` file bundled in the JMH core jar to
> support xtrace profiler.
The jmh-core jar file published in Maven central
(ht
On Thu, 10 Apr 2025 17:09:27 GMT, Naoto Sato wrote:
>> I have checked the entire code base for incorrect encodings, but luckily
>> enough these were the only remaining problems I found.
>>
>> BOM (byte-order mark) is a method used for distinguishing big and little
>> endian UTF-16 encodings.
On Thu, 3 Apr 2025 08:04:50 GMT, snake66 wrote:
> The configure script is not able to pick up the giflib installed via system
> packages if it's not located in the system include and lib directories. Since
> giflib does not provide a pkgconfig, arguments to specify the location of the
> includ
On Fri, 31 Jan 2025 16:19:17 GMT, Hannes Wallnöfer wrote:
> Please review a patch to add a JavaDoc Taglet to the JDK build system that
> allows to add preview-related notes to non-preview API elements, as well as a
> hidden javadoc option to add elements with preview notes to the preview
> sum
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote:
> I have checked the entire code base for incorrect encodings, but luckily
> enough these were the only remaining problems I found.
>
> BOM (byte-order mark) is a method used for distinguishing big and little
> endian UTF-16 encoding
On Thu, 10 Apr 2025 12:02:45 GMT, Galder Zamarreño wrote:
> Avoid filtering out xml files at the root of the JMH folder, in order to get
> the `default.instruments.template.xml` file bundled in the JMH core jar to
> support xtrace profiler.
`xtraceasm` was not released yet in any JMH version,
On Thu, 10 Apr 2025 17:23:37 GMT, Raffaello Giulietti
wrote:
> If this is a French name, it's e acute: é.
Supported by this Wikipedia page listing S.L as an LCMS developer:
https://en.wikipedia.org/wiki/Little_CMS
-
PR Review Comment: https://git.openjdk.org/jdk/pull/24566#discus
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote:
> I have checked the entire code base for incorrect encodings, but luckily
> enough these were the only remaining problems I found.
>
> BOM (byte-order mark) is a method used for distinguishing big and little
> endian UTF-16 encoding
On Thu, 10 Apr 2025 08:44:28 GMT, Eirik Bjørsnøs wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Replace InputStreamReader with BufferedReader
>
> FWIW, I checked out the revision of the commit previous to this change
On Fri, 31 Jan 2025 16:58:08 GMT, Chen Liang wrote:
>> Please review a patch to add a JavaDoc Taglet to the JDK build system that
>> allows to add preview-related notes to non-preview API elements, as well as
>> a hidden javadoc option to add elements with preview notes to the preview
>> summa
On Wed, 9 Apr 2025 18:35:12 GMT, Mikael Vidstedt wrote:
> [JDK-8342984](https://bugs.openjdk.org/browse/JDK-8342984) bumped the minimum
> boot jdk to JDK 24, and update the boot JDKs used in GHA in the process.
> Unfortunately the boot jdk for alpine-linux-x64 was incorrectly changed to
> use
On Wed, 9 Apr 2025 18:35:12 GMT, Mikael Vidstedt wrote:
> [JDK-8342984](https://bugs.openjdk.org/browse/JDK-8342984) bumped the minimum
> boot jdk to JDK 24, and update the boot JDKs used in GHA in the process.
> Unfortunately the boot jdk for alpine-linux-x64 was incorrectly changed to
> use
On Fri, 31 Jan 2025 16:19:17 GMT, Hannes Wallnöfer wrote:
> Please review a patch to add a JavaDoc Taglet to the JDK build system that
> allows to add preview-related notes to non-preview API elements, as well as a
> hidden javadoc option to add elements with preview notes to the preview
> sum
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote:
> I have checked the entire code base for incorrect encodings, but luckily
> enough these were the only remaining problems I found.
>
> BOM (byte-order mark) is a method used for distinguishing big and little
> endian UTF-16 encoding
On Thu, 3 Apr 2025 13:36:16 GMT, Magnus Ihse Bursie wrote:
> We have been sloppy in our use of `printf` in make code. Most of the time, we
> should really use `echo` instead. If we do need to use `printf`, we should
> never inline make or shell variables into the formatting string, since they
On Thu, 10 Apr 2025 11:46:45 GMT, Raffaello Giulietti
wrote:
> I guess the difference at L.1 in the various files is just the BOM?
Yes.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/24566#discussion_r2037357899
On Tue, 8 Apr 2025 20:34:09 GMT, Chen Liang wrote:
> With all dependencies of com.sun.tools.classfile in the JDK converted to the
> ClassFile API, we can remove this legacy library for release 25 like how we
> removed ASM.
>
> Testing: built locally, running tier 1-3 tests
>
> Don't know why,
On linux ppc64 / gcc , we build with the compile flag
-minsert-sched-nops=regroup_exact ; this is most likely outdated, maybe it was
still useful for old Power6 machines.
See
https://gcc.gnu.org/onlinedocs/gcc-11.1.0/gcc/RS_002f6000-and-PowerPC-Options.html
-minsert-sched-nops=scheme : This opt
On Tue, 11 Feb 2025 15:56:39 GMT, Matthias Baesken wrote:
> The libjdwp is currently built with LOW optimization level, it could be built
> with SIZE optimization to lower the lib size by ~ 10 % on UNIX.
> On Windows LOW and SIZE currently translate to the same O1 optimization flag
> so no diff
On Wed, 9 Apr 2025 00:54:25 GMT, David Holmes wrote:
> https://github.com/dholmes-ora/jdk/pull/new/8354088-backout
>
> This reverts commit bd73a0641615d743663ef652bc1f27305af1517b.
>
> It causes problems with paths to ProblemList files no longer being correct.
>
> Re-tested tier3
Marked as re
On Thu, 3 Apr 2025 07:59:26 GMT, snake66 wrote:
> The autoconf scrips fail to find libjpeg on systems where it's not installed
> in the default system include and library directories. It should check for
> the pkgconfig in these cases.
>
> This work is sponsored by The FreeBSD Foundation
Anyb
On Thu, 3 Apr 2025 08:04:50 GMT, snake66 wrote:
> The configure script is not able to pick up the giflib installed via system
> packages if it's not located in the system include and lib directories. Since
> giflib does not provide a pkgconfig, arguments to specify the location of the
> includ
On Mon, 7 Apr 2025 08:45:13 GMT, Magnus Ihse Bursie wrote:
> Allow the user to set "--with-jcov-modules=java.desktop", instead of
> "--with-jcov-filters=--include-modules java.desktop", since this is one of
> the common use cases for the filtering.
Marked as reviewed by erikj (Reviewer).
make
On Mon, 7 Apr 2025 15:46:12 GMT, David Linus Briemann wrote:
> I thought you had an issue with the indentation.
I had an issue with indentation in the original PR, where you wanted to apply
it to all files and not just Hotspot, but not the current version.
-
PR Comment: https://gi
On Mon, 7 Apr 2025 11:11:08 GMT, Magnus Ihse Bursie wrote:
> Analogous with how native warnings can be treated as errors or not using the
> `--disable-warnings-as-errors` configure flag, this patch introduces a
> `--disable-javac-warnings-as-errors` flag.
>
> The reason that this is not made p
On Wed, 9 Apr 2025 10:29:55 GMT, Magnus Ihse Bursie wrote:
>> Analogous with how native warnings can be treated as errors or not using the
>> `--disable-warnings-as-errors` configure flag, this patch introduces a
>> `--disable-javac-warnings-as-errors` flag.
>>
>> The reason that this is not m
On Fri, 4 Apr 2025 13:58:08 GMT, Magnus Ihse Bursie wrote:
> Alternative to https://github.com/openjdk/jdk/pull/23693 for implementing
> JDK-8311227.
>
> This `.editorconfig` file is a 1-to-1 conversion of the checks done by jcheck
> into .editorconfig format. I believe that is a better way to
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote:
> I have checked the entire code base for incorrect encodings, but luckily
> enough these were the only remaining problems I found.
>
> BOM (byte-order mark) is a method used for distinguishing big and little
> endian UTF-16 encoding
On Thu, 10 Apr 2025 19:06:35 GMT, Eirik Bjørsnøs wrote:
> (BTW, I enjoyed seeing separate commits for the encoding and BOM changes,
> makes it easier to verify each!)
Thanks! I do very much like myself to review PRs that has separate logical
commits, so I try to produce such myself. I'm glad t
On Thu, 10 Apr 2025 18:30:22 GMT, Eirik Bjørsnøs wrote:
>> If this is a French name, it's e acute: é.
>
>> If this is a French name, it's e acute: é.
>
> Supported by this Wikipedia page listing S.L as an LCMS developer:
>
> https://en.wikipedia.org/wiki/Little_CMS
It's not a mistake in capita
62 matches
Mail list logo
