On Wed, 9 Apr 2025 17:22:04 GMT, Naoto Sato wrote:
> never expected zero-width space, or Cyrillic "C" in place for ascii "C" in
> the code!
Yes, these got some extra bonus points. :-) I'm also curious what the
almost-comma is supposed to be, but never bothered to look it up. :)
-
On Wed, 9 Apr 2025 15:17:50 GMT, Magnus Ihse Bursie wrote:
> I believe the source code of the JDK should be in US-ASCII if possible, and
> only employ extended characters if that is strictly necessary for the code to
> work.
>
> In my attempt to figure out which non-ascii files are another enc
On Wed, 9 Apr 2025 16:10:20 GMT, Severin Gehwolf wrote:
>> For JEP 493-enabled builds there are no JMODs. Certain files come from the
>> installed JDK image when a user creates a custom run-time from it. This is
>> problematic for example for files that often come from a different package
>> (
On Wed, 9 Apr 2025 11:42:31 GMT, Magnus Ihse Bursie wrote:
>> Sure. It's not really a properties file (which assumes `key=value`). How
>> about `upgrade_files_.conf`? Then the pattern could be
>> `upgrade_files_*.conf`. Thoughts?
>
> Yeah, my comment was meant more like "maybe you should turn i
On Wed, 9 Apr 2025 18:35:12 GMT, Mikael Vidstedt wrote:
> [JDK-8342984](https://bugs.openjdk.org/browse/JDK-8342984) bumped the minimum
> boot jdk to JDK 24, and update the boot JDKs used in GHA in the process.
> Unfortunately the boot jdk for alpine-linux-x64 was incorrectly changed to
> use
On Wed, 9 Apr 2025 15:06:32 GMT, Magnus Ihse Bursie wrote:
>> Justin Lu has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains 16 commits:
>>
>> - Convert the merged master changes to UTF-8
>> - Merge master and fix conflicts
>> - Clo
On Tue, 25 Mar 2025 00:39:17 GMT, Chen Liang wrote:
> Migrates the CreateSymbols tool to use the ClassFile API, away from
> com.sun.tools.classfile.
>
> Need the boot jdk `--with-boot-jdk=` to be 24; thus a draft for now; but this
> is open to reviews.
>
> Together with #24206, the old com.su
On Wed, 9 Apr 2025 15:04:24 GMT, Chen Liang wrote:
>> With all dependencies of com.sun.tools.classfile in the JDK converted to the
>> ClassFile API, we can remove this legacy library for release 25 like how we
>> removed ASM.
>>
>> Testing: built locally, running tier 1-3 tests
>>
>> Don't kn
On Tue, 8 Apr 2025 20:34:09 GMT, Chen Liang wrote:
> With all dependencies of com.sun.tools.classfile in the JDK converted to the
> ClassFile API, we can remove this legacy library for release 25 like how we
> removed ASM.
>
> Testing: built locally, running tier 1-3 tests
>
> Don't know why,
On Wed, 9 Apr 2025 10:41:34 GMT, Matthias Baesken wrote:
> Wait, `LOW` is `-O2`? 👀 I thought it was like no optimization at all. I'm
> sooo confused with these levels. So maybe going from `LOW` to `SIZE` will
> actually lose more optimization than I thought. _sigh_
-Os is the same as -O2 minus
On Wed, 9 Apr 2025 14:17:25 GMT, Matthias Baesken wrote:
> Making hotspot `-Os` would certainly never make any sense, for example.)
When the minimalVM was first created, there was a quite of bit of benchmarking
done to decide which hotspot files to build with -Os and which to build with
-O3. I
[JDK-8342984](https://bugs.openjdk.org/browse/JDK-8342984) bumped the minimum
boot jdk to JDK 24, and update the boot JDKs used in GHA in the process.
Unfortunately the boot jdk for alpine-linux-x64 was incorrectly changed to use
the linux-*aarch64* version.
Testing: GHA, incl. explicitly trigg
On Wed, 9 Apr 2025 15:53:51 GMT, Magnus Ihse Bursie wrote:
>> I believe the source code of the JDK should be in US-ASCII if possible, and
>> only employ extended characters if that is strictly necessary for the code
>> to work.
>>
>> In my attempt to figure out which non-ascii files are anothe
On Wed, 9 Apr 2025 15:53:51 GMT, Magnus Ihse Bursie wrote:
>> I believe the source code of the JDK should be in US-ASCII if possible, and
>> only employ extended characters if that is strictly necessary for the code
>> to work.
>>
>> In my attempt to figure out which non-ascii files are anothe
On Fri, 31 Jan 2025 16:19:17 GMT, Hannes Wallnöfer wrote:
> Please review a patch to add a JavaDoc Taglet to the JDK build system that
> allows to add preview-related notes to non-preview API elements, as well as a
> hidden javadoc option to add elements with preview notes to the preview
> sum
On Wed, 9 Apr 2025 18:35:12 GMT, Mikael Vidstedt wrote:
> [JDK-8342984](https://bugs.openjdk.org/browse/JDK-8342984) bumped the minimum
> boot jdk to JDK 24, and update the boot JDKs used in GHA in the process.
> Unfortunately the boot jdk for alpine-linux-x64 was incorrectly changed to
> use
On Wed, 9 Apr 2025 12:33:26 GMT, Magnus Ihse Bursie wrote:
> Making hotspot -Os would certainly never make any sense, for example
We even have this (jvm feature opt-size)
https://github.com/openjdk/jdk/blob/master/make/hotspot/lib/JvmFeatures.gmk#L197
but it is not widely used afaik.
I think in
> I believe the source code of the JDK should be in US-ASCII if possible, and
> only employ extended characters if that is strictly necessary for the code to
> work.
>
> In my attempt to figure out which non-ascii files are another encoding than
> utf-8 (see [JDK-8301971](https://bugs.openjdk.o
On Fri, 31 Jan 2025 16:19:17 GMT, Hannes Wallnöfer wrote:
> Please review a patch to add a JavaDoc Taglet to the JDK build system that
> allows to add preview-related notes to non-preview API elements, as well as a
> hidden javadoc option to add elements with preview notes to the preview
> sum
> For JEP 493-enabled builds there are no JMODs. Certain files come from the
> installed JDK image when a user creates a custom run-time from it. This is
> problematic for example for files that often come from a different package
> (e.g. `cacerts` file for Linux distro builds of OpenJDK package
On Tue, 11 Feb 2025 15:56:39 GMT, Matthias Baesken wrote:
> The libjdwp is currently built with LOW optimization level, it could be built
> with SIZE optimization to lower the lib size by ~ 10 % on UNIX.
> On Windows LOW and SIZE currently translate to the same O1 optimization flag
> so no diff
> I believe the source code of the JDK should be in US-ASCII if possible, and
> only employ extended characters if that is strictly necessary for the code to
> work.
>
> In my attempt to figure out which non-ascii files are another encoding than
> utf-8 (see [JDK-8301971](https://bugs.openjdk.o
On Thu, 11 May 2023 20:21:57 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is adjusted to support reading in t
On Wed, 9 Apr 2025 15:04:24 GMT, Chen Liang wrote:
>> With all dependencies of com.sun.tools.classfile in the JDK converted to the
>> ClassFile API, we can remove this legacy library for release 25 like how we
>> removed ASM.
>>
>> Testing: built locally, running tier 1-3 tests
>>
>> Don't kn
I believe the source code of the JDK should be in US-ASCII if possible, and
only employ extended characters if that is strictly necessary for the code to
work.
In my attempt to figure out which non-ascii files are another encoding than
utf-8 (see [JDK-8301971](https://bugs.openjdk.org/browse/JD
On Wed, 9 Apr 2025 15:04:24 GMT, Chen Liang wrote:
>> With all dependencies of com.sun.tools.classfile in the JDK converted to the
>> ClassFile API, we can remove this legacy library for release 25 like how we
>> removed ASM.
>>
>> Testing: built locally, running tier 1-3 tests
>>
>> Don't kn
On Tue, 8 Apr 2025 20:33:33 GMT, Chen Liang wrote:
>> Migrates the CreateSymbols tool to use the ClassFile API, away from
>> com.sun.tools.classfile.
>>
>> Need the boot jdk `--with-boot-jdk=` to be 24; thus a draft for now; but
>> this is open to reviews.
>>
>> Together with #24206, the old
On Tue, 8 Apr 2025 20:33:33 GMT, Chen Liang wrote:
>> Migrates the CreateSymbols tool to use the ClassFile API, away from
>> com.sun.tools.classfile.
>>
>> Need the boot jdk `--with-boot-jdk=` to be 24; thus a draft for now; but
>> this is open to reviews.
>>
>> Together with #24206, the old
On Tue, 25 Mar 2025 00:39:17 GMT, Chen Liang wrote:
> Migrates the CreateSymbols tool to use the ClassFile API, away from
> com.sun.tools.classfile.
>
> Need the boot jdk `--with-boot-jdk=` to be 24; thus a draft for now; but this
> is open to reviews.
>
> Together with #24206, the old com.su
> With all dependencies of com.sun.tools.classfile in the JDK converted to the
> ClassFile API, we can remove this legacy library for release 25 like how we
> removed ASM.
>
> Testing: built locally, running tier 1-3 tests
>
> Don't know why, but GitHub is redundantly displaying changes that ar
On Tue, 11 Feb 2025 15:56:39 GMT, Matthias Baesken wrote:
> The libjdwp is currently built with LOW optimization level, it could be built
> with SIZE optimization to lower the lib size by ~ 10 % on UNIX.
> On Windows LOW and SIZE currently translate to the same O1 optimization flag
> so no diff
On Wed, 9 Apr 2025 10:24:24 GMT, Magnus Ihse Bursie wrote:
>> make/Coverage.gmk line 42:
>>
>>> 40: JCOV_TEMP := $(JCOV_SUPPORT_DIR)/temp
>>> 41:
>>> 42: ifneq ($(JCOV_MODULES), )
>>
>> Is this redundant conditional done on purpose?
>
> You mean as in a foreach on an empty variable will yield
On Wed, 9 Apr 2025 15:53:51 GMT, Magnus Ihse Bursie wrote:
>> I believe the source code of the JDK should be in US-ASCII if possible, and
>> only employ extended characters if that is strictly necessary for the code
>> to work.
>>
>> In my attempt to figure out which non-ascii files are anothe
On Tue, 11 Feb 2025 15:56:39 GMT, Matthias Baesken wrote:
> The libjdwp is currently built with LOW optimization level, it could be built
> with SIZE optimization to lower the lib size by ~ 10 % on UNIX.
> On Windows LOW and SIZE currently translate to the same O1 optimization flag
> so no diff
On Wed, 9 Apr 2025 15:45:41 GMT, Roger Riggs wrote:
> For methods that have "@PreviewFeature(feature =
> PreviewFeature.Feature.VALUE_OBJECTS, reflective=true)" annotations the first
> (summary) line in the list of methods is "Preview." without any decoration.
> Is that intended?
Yes, that's
> If there is something wrong with the build, the user can run "make doctor".
> That is hard to do in a CI setting. Instead, if the build environment is
> detected to be a CI, we should run the doctor automatically in case of a
> failed build.
Magnus Ihse Bursie has updated the pull request wit
On Tue, 8 Apr 2025 20:33:33 GMT, Chen Liang wrote:
>> Migrates the CreateSymbols tool to use the ClassFile API, away from
>> com.sun.tools.classfile.
>>
>> Need the boot jdk `--with-boot-jdk=` to be 24; thus a draft for now; but
>> this is open to reviews.
>>
>> Together with #24206, the old
On Mon, 7 Apr 2025 11:11:08 GMT, Magnus Ihse Bursie wrote:
> Analogous with how native warnings can be treated as errors or not using the
> `--disable-warnings-as-errors` configure flag, this patch introduces a
> `--disable-javac-warnings-as-errors` flag.
>
> The reason that this is not made p
On Tue, 8 Apr 2025 20:34:09 GMT, Chen Liang wrote:
> With all dependencies of com.sun.tools.classfile in the JDK converted to the
> ClassFile API, we can remove this legacy library for release 25 like how we
> removed ASM.
>
> Testing: built locally, running tier 1-3 tests
>
> Don't know why,
On Tue, 8 Apr 2025 19:38:52 GMT, Erik Joelsson wrote:
>> Allow the user to set "--with-jcov-modules=java.desktop", instead of
>> "--with-jcov-filters=--include-modules java.desktop", since this is one of
>> the common use cases for the filtering.
>
> make/Coverage.gmk line 42:
>
>> 40: JCOV_TE
On Fri, 31 Jan 2025 16:19:17 GMT, Hannes Wallnöfer wrote:
> Please review a patch to add a JavaDoc Taglet to the JDK build system that
> allows to add preview-related notes to non-preview API elements, as well as a
> hidden javadoc option to add elements with preview notes to the preview
> sum
On Tue, 11 Feb 2025 15:56:39 GMT, Matthias Baesken wrote:
> The libjdwp is currently built with LOW optimization level, it could be built
> with SIZE optimization to lower the lib size by ~ 10 % on UNIX.
> On Windows LOW and SIZE currently translate to the same O1 optimization flag
> so no diff
On Mon, 7 Apr 2025 11:11:08 GMT, Magnus Ihse Bursie wrote:
> Analogous with how native warnings can be treated as errors or not using the
> `--disable-warnings-as-errors` configure flag, this patch introduces a
> `--disable-javac-warnings-as-errors` flag.
>
> The reason that this is not made p
> Analogous with how native warnings can be treated as errors or not using the
> `--disable-warnings-as-errors` configure flag, this patch introduces a
> `--disable-javac-warnings-as-errors` flag.
>
> The reason that this is not made part of `--disable-warnings-as-errors` is
> discussed in the
On Mon, 7 Apr 2025 13:35:57 GMT, Severin Gehwolf wrote:
>> For JEP 493-enabled builds there are no JMODs. Certain files come from the
>> installed JDK image when a user creates a custom run-time from it. This is
>> problematic for example for files that often come from a different package
>> (
> Please review a change to add a `javadoc` option to enable syntax
> highlighting for code fragments in snippets and `` tags. The new
> `--syntax-highlight` option uses the [highlight.js] JavaScript library and
> supports Java, Properties, XML, HTML and JSON. The option is enabled in the
> JD
On Wed, 9 Apr 2025 10:36:03 GMT, Magnus Ihse Bursie wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review v2
>
> make/modules/jdk.jlink/Java.gmk line 28:
>
>> 26:
>> ##
On Wed, 9 Apr 2025 11:38:25 GMT, Severin Gehwolf wrote:
>> make/modules/jdk.jlink/Java.gmk line 28:
>>
>>> 26:
>>>
>>> 27:
>>> 28: COPY += upgrade_files_java.base
>>
>> Any chance you can give this file a differe
48 matches
Mail list logo
